[{"id":3680108,"web_url":"http://patchwork.ozlabs.org/comment/3680108/","msgid":"","list_archive_url":null,"date":"2026-04-21T22:48:13","subject":"Re: [PATCH v2 8/8] env: ubi: add support to create environment volume\n if it does not exist","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Weijie,\n\nOn 2026-04-21T08:35:39, Weijie Gao wrote:\n> env: ubi: add support to create environment volume if it does not exist\n>\n> Add an option to allow environment volume being auto created if not\n> exist.\n>\n> Signed-off-by: Weijie Gao \n>\n> env/Kconfig | 11 +++++++++++\n> env/ubi.c | 30 ++++++++++++++++++++++++++++++\n> 2 files changed, 41 insertions(+)\n\n> diff --git a/env/ubi.c b/env/ubi.c\n> @@ -105,6 +105,23 @@ static int env_ubi_save(void)\n> +static int env_ubi_volume_create(const char *volume)\n> +{\n> + struct ubi_volume *vol;\n> + int ret;\n> +\n> + vol = ubi_find_volume(volume);\n> + if (vol)\n> + return 0;\n\nYou might need __maybe_unused for this function?\n\n> diff --git a/env/ubi.c b/env/ubi.c\n> @@ -134,6 +151,14 @@ static int env_ubi_load(void)\n> + if (IS_ENABLED(CONFIG_ENV_UBI_VOLUME_CREATE)) {\n> + read1_fail = env_ubi_volume_create(CONFIG_ENV_UBI_VOLUME);\n> + read2_fail = env_ubi_volume_create(CONFIG_ENV_UBI_VOLUME_REDUND);\n> +\n> + if (read1_fail && read2_fail)\n> + return -ENODEV;\n> + }\n\nRe-using read1_fail and read2_fail for volume creation is confusing.\nPlease can you use separate variables (e.g. create1_fail).\n\nAlso, when both volumes fail to create, you return -ENODEV without\ncalling env_set_default(), but the other error paths in this function\nall call env_set_default() before returning.\n\n> diff --git a/env/ubi.c b/env/ubi.c\n> @@ -171,6 +196,11 @@ static int env_ubi_load(void)\n> + if (IS_ENABLED(CONFIG_ENV_UBI_VOLUME_CREATE)) {\n> + if (env_ubi_volume_create(CONFIG_ENV_UBI_VOLUME))\n> + return -ENODEV;\n> + }\n\nsame here, env_set_default() should be called before returning -ENODEV\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=cVdRQu2q;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"cVdRQu2q\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0cw259vdz1yHB\n\tfor ; Wed, 22 Apr 2026 08:48:34 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 868B083AC5;\n\tWed, 22 Apr 2026 00:48:32 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id BEFE083E76; Wed, 22 Apr 2026 00:48:30 +0200 (CEST)","from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com\n [IPv6:2a00:1450:4864:20::62d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A4E3F83936\n for ; Wed, 22 Apr 2026 00:48:26 +0200 (CEST)","by mail-ej1-x62d.google.com with SMTP id\n a640c23a62f3a-baa8c78ac7fso93234266b.0\n for ; Tue, 21 Apr 2026 15:48:26 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776811706; cv=none;\n d=google.com; s=arc-20240605;\n b=altrUGguHs/rwKSRKzn9sZak3ZXwe9u2vKcUv0JxKrTf7V2v1oIGDKjiXtOZpgbHg8\n OoQvaBe3LNQ6m7EkP9v4Ysb/FBAHPOo8w0LgAeGgCrjcL39ZIsjQpH0hN5wK/BQzYn/N\n V0j1gW4TkltxA3Ge0pw2rooT4LvXbjoLe7CDdTZleGY6kiAhirBrYure4cjw26v0cVmL\n 8wh63ArotYkTNQo5Ksc0jV64Xo1bjKkOxDTqxDnU7APZj1iWVpMnBjnwMgWIEiejXeXK\n tCLAKt3z+atVPh9NUjrpzIjAUPdert4EAhqJO7V6VXiMjgovCzML3EH0t83bp/xi0ecL\n /Y1A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=fNM6j+QCnDsfwSmr+RyxDxJ3DxuzKoUuZ6g3ztiV3/I=;\n fh=fJAGB8LvxCJalDRE+ziaXIW21+gD5jSCb0B1QEwHsvE=;\n b=ZOnva88umxfgaFaTsNNuFzl97mPGnwcnaoPRH2HB0BnEp/46a/tJhHP8HZDrHi8UeW\n 2ndB5ILi9NNW90jSQ/Y4oDygRfIcQp7hW1c5858JuIq30kdwJkF7i2RT9P9k32xxw0DC\n y3g5YLbHtyHqqBrtPYe/O+WAHiz92LzC82Oh0JbXne6A5c7U64fy5LEph7QmiKkQvXZ3\n MVhjfdEIHEp7kVJQxORqp046m7hSMbs+dOlDz0EthXQUmnhes+OVMgGqHBBu1T2qEaLJ\n kD/mV6E0nBDVNfvbAcHznUHdN6pGtUwxRIO73TArX0U1qsro5KhB3DHNa82xXbfIrUGN\n +eGw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776811706; x=1777416506; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=fNM6j+QCnDsfwSmr+RyxDxJ3DxuzKoUuZ6g3ztiV3/I=;\n b=cVdRQu2qUNWpWoy8DRnxu6iZnDFpr2P7FuOZ/hMaLAYAt300wSyCVtMlI7RgOQk2oT\n 6d//9BC7K7ol0Utdz9CcLDL1ycxIKJwXD3AL8etJF8jjDTXxsAOaleUGAVjJw0ct1cRT\n z+Cf0a3MsTbRVAcTORycvvpiNLqqkJLJGPBrI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776811706; x=1777416506;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fNM6j+QCnDsfwSmr+RyxDxJ3DxuzKoUuZ6g3ztiV3/I=;\n b=lIU0AksV2i/wBR/vo94I4ho6rs8O8thIhVR57uqq6kLbiKwDLCoOLg1YENBIVpU7Nt\n TSsbPDkk5pCLDkQB4zeuwBAeSZLz1bu58hCHTmp1/qu4PJeFUkuILnuvNlfgEfsFqEs0\n 1BXq6BJylvAmJ4a4xzo5GUhdJBj0CI3i90iDlPipS2oNeuKT1KsG5Wig3Rmh1uZqTx0C\n jE1aXTXA7JE7wLHb9/IccTbEw447U3I7NRQ6pGSGRUYNCiWNsoaEHx3xTUsXIWu33H1f\n 87+Hedl9IGvxpDcw7s2H4Fcp7KE0zrk1DkmsON2z2cbOZLe5zNEJPkONZt781RkbJIJp\n vV2A==","X-Gm-Message-State":"AOJu0YyLkjs89jPUvR3yqDxfCYnHd29inrExnQHxQPaRSH6641y1BQ7x\n vK5J0F0P/lLD0QUqQHEVVvfz8TrYwQcTzELz9AJ/cFo//c7TV6WROT+MZrE1jRxUUkZJmQS2+wA\n GViqd8ORvFz0LV0A5H9OViSnMc5Uo9RiZMSw66xRZJ3dhuKTLJKvk7A==","X-Gm-Gg":"AeBDieuRV1zrlkH2Lm9yTrRelxaz41VH5ML+mHBMQWK7ADpxd4OqNgAfn7AHnX0fsKU\n a89uNp5Aw7+CCpikClQXq4EzSYebYKeItbzQrebvQxqH+PnMBGL0bByzNyZcgTeUNvWbOfh8E9k\n AK1I4eLoOP1+dqvUCN34EqY27VmJEM5F5yNq0fvTatnPW4PdTEebMITUM6aSqWT2rxiILRroSbH\n DZpYwBr3fIRPazREXhpDDsP0Q5r4AFhzPFIAo+c39zN6eKnWT+dYbTrhVcaPTMliGRe0uloN1/v\n dVHtCCAPe0+mc9Hs9gxl","X-Received":"by 2002:a17:907:9609:b0:ba7:d65f:3b4b with SMTP id\n a640c23a62f3a-ba7d65f49b6mr503885966b.2.1776811706085; Tue, 21 Apr 2026\n 15:48:26 -0700 (PDT)","MIME-Version":"1.0","References":"\n <7532f71af6fd58644c2cb7dff07df54ddd854fa1.1776759754.git.weijie.gao@mediatek.com>","In-Reply-To":"\n <7532f71af6fd58644c2cb7dff07df54ddd854fa1.1776759754.git.weijie.gao@mediatek.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 10:48:13 +1200","X-Gm-Features":"AQROBzBlVmJXQZP0S4MSYXHLo_5PnJXyjLv4mQDNb0DC-5yQ6Ljg9QNUaKfjnDE","Message-ID":"\n ","Subject":"Re: [PATCH v2 8/8] env: ubi: add support to create environment volume\n if it does not exist","To":"weijie.gao@mediatek.com","Cc":"u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]