[{"id":3680106,"web_url":"http://patchwork.ozlabs.org/comment/3680106/","msgid":"","list_archive_url":null,"date":"2026-04-21T22:46:58","subject":"Re: [PATCH v2 6/8] cmd: ubi: expose more APIs to public","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Weijie,\n\nOn 2026-04-21T08:35:39, Weijie Gao wrote:\n> cmd: ubi: expose more APIs to public\n>\n> Export ubi_detach/ubi_create_vol/ubi_find_volume/ubi_remove_vol to\n> public for better ubi manipulation used by other modules.\n>\n> Signed-off-by: Weijie Gao \n>\n> cmd/ubi.c | 10 +++++-----\n> include/ubi_uboot.h | 5 +++++\n> 2 files changed, 10 insertions(+), 5 deletions(-)\n\n> diff --git a/include/ubi_uboot.h b/include/ubi_uboot.h\n> @@ -47,10 +47,15 @@\n> +int ubi_detach(void);\n> +int ubi_create_vol(const char *volume, int64_t size, int dynamic, int vol_id,\n> + bool skipcheck);\n> +struct ubi_volume *ubi_find_volume(const char *volume);\n> +int ubi_remove_vol(const char *volume);\n\nLooking at patch 8, only ubi_find_volume() and ubi_create_vol() are\nused by the env code. Please can you either only export the functions\nactually needed, or mention why they are exported in the commit\nmessage.\n\nAlso, the dynamic parameter is declared as int but used as a boolean,\nso could become a bool ?\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=lux8Ll4I;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"lux8Ll4I\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0ctY5DYXz1yHB\n\tfor ; Wed, 22 Apr 2026 08:47:17 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A1D7A83E76;\n\tWed, 22 Apr 2026 00:47:15 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 4E1BF83AC5; Wed, 22 Apr 2026 00:47:14 +0200 (CEST)","from mail-ej1-x636.google.com (mail-ej1-x636.google.com\n [IPv6:2a00:1450:4864:20::636])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 59EB783E76\n for ; Wed, 22 Apr 2026 00:47:12 +0200 (CEST)","by mail-ej1-x636.google.com with SMTP id\n a640c23a62f3a-ba388bc0a9dso845111166b.1\n for ; Tue, 21 Apr 2026 15:47:12 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776811632; cv=none;\n d=google.com; s=arc-20240605;\n b=FjhnQGvRG+d0KX6T2FUuRJVqu8wGKGrL7FaCScqM0thIToWQdasBjOH2n0WxFfeA9O\n 3ubAJ9LIystSGWvd4LSxMcoUgzRPLTNW03Qi2eozSsqiLupmsXSoWk2gFWgkcg3UhaKY\n +8b8EckCCtmdvX7BByQtf7VYuKN/ukEdo7XSjWX1Lm2CE79E6+dff0ONM2STAIzxLiLr\n 5TXnUxXirkeaDRrFpoHb7FdsWqgKqstlLPi+tTh/lrcGPZpzW9u0VX2QfyhgZRPHkRFa\n FxeQYiXCLuw0wO6niMRXZchIEoAFOZd1L3LkIxA8LCzfaexdqAZ9GLImQx3Xv9WwscTs\n 9Tqw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=zwXBu3DpRSlVe0DWL05QmF1vC5TQ4KnCUbuj1DBTLms=;\n fh=fJAGB8LvxCJalDRE+ziaXIW21+gD5jSCb0B1QEwHsvE=;\n b=MNUyPpAjjzEnOhNnSUULiw1JobRBoud/SYa0gV3I6xuuPDqXhzZVf+O1O/KZNZGgLK\n blRkK+mpo7tUPmtBYLivy4JT/D6Pn2atXleUoSMpBrtXQtgO8AjSoMP4rpHn5HnS9IN6\n OR6x9mY8SNbqEyB9AXAkNw+k3xH9zQGYu4bTIME+pLg7J9Fm8xIJ6SJzbp/y6dS9Oz3E\n MOyxc0V2RVDDH3Rvpp2E89uSYoKPbOCKTe8nka/3rnpw7rRoZEe80Cj+EtoUVCpx/xMc\n hQL8xeT5VLJ58nXhJc2Ok8BuOmLOwH7BD0MqerjTT85q/ir1ucGok6pj24iy5SrV2kgW\n ZjxQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776811632; x=1777416432; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=zwXBu3DpRSlVe0DWL05QmF1vC5TQ4KnCUbuj1DBTLms=;\n b=lux8Ll4Ins7Mim9/2IIgdCVGu7gE0rUfVWdhN9Fn4nUCLKQNy/dE5B8wumgLb25g6n\n ItuwYIXXDbvZgsz54f51QsxGliGcNaF/FUTb46NNM2j20sdZvEcAm48pq/a5q0K4wELm\n OLHIYR7sBYg8JZu3AXgyBgBTjVzFUH5gxwH9w=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776811632; x=1777416432;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zwXBu3DpRSlVe0DWL05QmF1vC5TQ4KnCUbuj1DBTLms=;\n b=fmVJvxBe7b+ESe5gRmF+4wchTCRb3F5P2Q+Ixz4tL5Oj6bLxORVABhSTtLVoFbbKw3\n FNkdtVt+kqskYleAQBLldmJJACnOqRvYrylxG7srVNimkS0U52VSrk14dZnsgVEM6dNG\n nUvaLDER99TmXTc+fBJC8N3bgd2Mz9V2DwwexA6sFcSGsmdU8CV2fDHNhd+3eMI+RnOn\n XVdRl4CH1co5ACdOa6MqtRqa/kqUV2/8WH+weQnQ/9ad6gmOF8gtCZTxfEkD+V4w9I/y\n kPpfXw00YvEQPnJT4oyyzpq0HGcQXXoehsEbQUKIGy2xZRIJsQhKHKuN586T28JaXDWm\n r57Q==","X-Gm-Message-State":"AOJu0YxdQGHMq+inUsH36/43O5dxax/E6Z6AVO/NPexczbQ8UyuIN7P3\n 0XO0t+g9f08wqC56yMjHAz4xkEwjk0nyS7PWdVvVLQGToQhhH2hZG8Y8asHVDRLOIoGXkh9yhY8\n 4vDdP/u1O8bPybGRE8VxBEqgxBN8Jqd3Nu4OVaMr+fbEZd6Hrn8MmZQ==","X-Gm-Gg":"AeBDietbjAb1/9u+FFsHSItiZEFBpTvt5+PxkZ4mrKXtKdAalrrGln7V8KUTyYD031u\n UwnAPTeT7wgIQnJhP1/qVpPjczp88/e6OJ2J1M62JjyH5gqRBt2GnbUDe4KxZKBKymaNlkRq81K\n bnYI+O8djdx+VSU3amprTR7cPx+87/KWkhJKUA42x4sALjMzLJCIBTdemvWd2ANJxi9yAQvPBSo\n 474scION9YSk5eVbL23eAKgGMc40tiMrdCpjZnA6KRjW/IPn8caQSajWcNLFlzt1K9s4GT3Qizr\n e3PUnRqFS3a83rZWX2lu","X-Received":"by 2002:a17:907:748:b0:ba3:e99e:18dd with SMTP id\n a640c23a62f3a-ba41aef07c6mr945277366b.35.1776811631754; Tue, 21 Apr 2026\n 15:47:11 -0700 (PDT)","MIME-Version":"1.0","References":"\n ","In-Reply-To":"\n ","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 10:46:58 +1200","X-Gm-Features":"AQROBzCpZP_hUybhXnk32AZlv2S4h4g11niYwnIE0vXgt7Cv9pd1rP4AFxdR1_E","Message-ID":"\n ","Subject":"Re: [PATCH v2 6/8] cmd: ubi: expose more APIs to public","To":"weijie.gao@mediatek.com","Cc":"u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]