[{"id":3680103,"web_url":"http://patchwork.ozlabs.org/comment/3680103/","msgid":"","list_archive_url":null,"date":"2026-04-21T22:43:45","subject":"Re: [PATCH v2 4/8] cmd: ubifs: mark string parameters with const","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-21T08:35:39, Weijie Gao wrote:\n> cmd: ubifs: mark string parameters with const\n>\n> File name and volume name should be const as they will not be modified in\n> these functions.\n>\n> Signed-off-by: Weijie Gao \n>\n> cmd/ubifs.c | 2 +-\n> fs/ubifs/super.c | 2 +-\n> fs/ubifs/ubifs.c | 2 +-\n> include/ubi_uboot.h | 2 +-\n> include/ubifs_uboot.h | 4 ++--\n> 5 files changed, 6 insertions(+), 6 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=bKZ9mVCW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"bKZ9mVCW\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0cq1256Sz1yGs\n\tfor ; Wed, 22 Apr 2026 08:44:13 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4D5578429E;\n\tWed, 22 Apr 2026 00:44:09 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 93E238429E; Wed, 22 Apr 2026 00:44:08 +0200 (CEST)","from mail-ej1-x635.google.com (mail-ej1-x635.google.com\n [IPv6:2a00:1450:4864:20::635])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 554BC8412A\n for ; Wed, 22 Apr 2026 00:44:05 +0200 (CEST)","by mail-ej1-x635.google.com with SMTP id\n a640c23a62f3a-ba3115fe0d5so967218566b.1\n for ; Tue, 21 Apr 2026 15:44:05 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776811445; cv=none;\n d=google.com; s=arc-20240605;\n b=Jmo9I9cRMxze9wNzZfMIRvSQsZ2CzTHfQh0LxAw/6CJFS9cMiMCD/Wg2NdsyLq611K\n 6VUt09BIpG4eu/KXoQLuNiqS78QwBB75AH6Mxp6eGdC+gDdy782K1cJ9zILMtBTbtElM\n 8EdfEyeqzs8oFUBgOhYBSLn+BlJORngo61sr88lwK61tyj7Gf2MVYUCJ0jhDHimZl6M8\n ckRflywScdq1mVBiT2iia8UsLEZJAPOFhgwHSt+XoVWAyVnb17OdTfMvN3AKHOZeCwip\n AIHc7BCK2uSIjeFqIo3Tto5iZ9yx+O6Nb8aH03zf2EKCvW2pG02+EyVwmGGrXFMtBvI+\n MzFQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=ByCSWChsEh+5lX7F4nC3oFEu6ZaIU4RBLvXUsY4UezU=;\n fh=fJAGB8LvxCJalDRE+ziaXIW21+gD5jSCb0B1QEwHsvE=;\n b=NanG/UPN52VzSnLhZ1EUVgS33KC4xDSrOgfYN9Sy30ou6z0ssP/xGs6JOU/oLVGeBG\n DejGV8Q5U26VD5CNRNuZ7jllPUSrdJkbLrN2HLswfbuJqrB3OtbyFwET9um/O9Brg0Z6\n HvFsk4YpFhVF3hABx86WU4oMkmgh1rZH7LevBG+wDhj8kF9sDsPpAQQ0V4bXkG1ACmfF\n XM/2VsK4QYNT0tEhO+Bl1TLnzqI9MvPj8PhlLyS7QKTEk3zBawqMyGSoYrh9M3obU9BR\n IBsZYZeQaxZW39EyaJGgTlG4rZN5NcOlZuEJ8Vz+a515l6dD+CSB7AcwRpoBqE/Gp6Qu\n 728w==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776811445; x=1777416245; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=ByCSWChsEh+5lX7F4nC3oFEu6ZaIU4RBLvXUsY4UezU=;\n b=bKZ9mVCWjBsvjhnmdDQOMdt1ZGSzutrUTksW3YIjqnSBRUAbhco3Jpq0kZp63hCgRw\n gozZuKf21Rdrldyd9cjhBYu8tqvckoHp4LePqaqaA0DXz36RbqF5JUVw67oICQlbPOUq\n t5YSVzgwXdHzm3Sl1BiHY2g0QjsgjsZO2NREI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776811445; x=1777416245;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ByCSWChsEh+5lX7F4nC3oFEu6ZaIU4RBLvXUsY4UezU=;\n b=Zwj4ckMcSDlLwvq8hDtFY7cAfFba95YkDwE6nZakxCgf+CQj0Z/22qJi/AXac7uh13\n okLBSdlu/u8tZ7Scr51P6gRVUOhjWhZd0jxg6qriuBLHULDInKN9YA9+LsKUMVDdE7CI\n YaNwF1RfEC/Knk0pwyhDVUFW4dBT5CtaXvj02QwHMx+7jrXmHOrYSdhyP6wT4gASCqCG\n midZ422piXHz07mHMgzQV01jywt31BVpVu9QrZm0k30YmbfXBZJzdfHXUbNp1fGpf7Pp\n 7LteC0foP7ww/1r+/aEMXpq5HqqAsGdJGSZj/6esRpNY2zX+GH33+wUetjg0M/BRaji0\n MG+A==","X-Gm-Message-State":"AOJu0YygR3AHVwa6KTkIZFuyRnK3+OJIYGxdmrJY5eJ0XTM1s/bUULYh\n Nhz3sT+oEaEfqJKIRqoinHaFZqkJ1nZUvhtXN5Lwl5RrFxxpSehWZS1ALrJS4gX1ERptQ1/acMd\n LslS9hloJECUVngvhQhBrJ4U4tJPTrbo8THfnOtVE8QmLy+8Y386sqA==","X-Gm-Gg":"AeBDieuSUe03+jSirttMZZ9lcRBKwVd0M+s6m8eqaazZMK5QbKCPuAw+vR8Bw4xzGMk\n hCrrgk+yLN/53aNUMmwmmQi7fDEVQpe6hBunWXuOChmsJ4PyALOKS3RpSHiws4Jd+zkCmpbvrYW\n 1JQMjf83rkh+c+0+U6IaDDaJlDwLXDkVBs4mgt0xiLVRVUw3AWdc5NrpaqWzEeTBWdsTVa9TxSy\n 8BRvNfNtOSipaCiInJl7KNFntLNA3ao9QGuNVgqLPswiQxfvu3z/W+xUSj1nEKfbWAc3OKDQ/3x\n q0kELHWbC3IQDFHi8qAp","X-Received":"by 2002:a17:907:2d0f:b0:ba6:a05c:ac2f with SMTP id\n a640c23a62f3a-ba6a05cb512mr489803566b.22.1776811444807; Tue, 21 Apr 2026\n 15:44:04 -0700 (PDT)","MIME-Version":"1.0","References":"\n <730a6370bd11b6897ef881e560a8687b893b7bdf.1776759754.git.weijie.gao@mediatek.com>","In-Reply-To":"\n <730a6370bd11b6897ef881e560a8687b893b7bdf.1776759754.git.weijie.gao@mediatek.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 10:43:45 +1200","X-Gm-Features":"AQROBzBFvWSFoRtTAc9G7dG-s5yYeGD_WKo0IU2hCZaBzam80JjUb9rGv3jrvbU","Message-ID":"\n ","Subject":"Re: [PATCH v2 4/8] cmd: ubifs: mark string parameters with const","To":"weijie.gao@mediatek.com","Cc":"u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]