[{"id":3680101,"web_url":"http://patchwork.ozlabs.org/comment/3680101/","msgid":"","list_archive_url":null,"date":"2026-04-21T22:43:39","subject":"Re: [PATCH v2 2/8] cmd: ubi: mark read-only function parameters with\n const","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On Tue, 21 Apr 2026 at 20:36, Weijie Gao wrote:\n>\n> Parameters like part/volume name and buffer for writing are not being\n> modified by the callee functions and should be marked const.\n>\n> Signed-off-by: Weijie Gao \n> ---\n> v2: new\n> ---\n> cmd/ubi.c | 41 ++++++++++++++++++++++-------------------\n> include/ubi_uboot.h | 7 ++++---\n> 2 files changed, 26 insertions(+), 22 deletions(-)\n>\n\nReviewed-by: Simon Glass \n\n> diff --git a/include/ubi_uboot.h b/include/ubi_uboot.h\n> index 05fb9634d81..a949d1b80dd 100644\n> --- a/include/ubi_uboot.h\n> +++ b/include/ubi_uboot.h\n> @@ -47,9 +47,10 @@\n> int ubi_mtd_param_parse(const char *val, struct kernel_param *kp);\n> int ubi_init(void);\n> void ubi_exit(void);\n> -int ubi_part(char *part_name, const char *vid_header_offset);\n> -int ubi_volume_write(char *volume, void *buf, loff_t offset, size_t size);\n> -int ubi_volume_read(char *volume, char *buf, loff_t offset, size_t size);\n> +int ubi_part(const char *part_name, const char *vid_header_offset);\n> +int ubi_volume_write(const char *volume, const void *buf, loff_t offset,\n> + size_t size);\n> +int ubi_volume_read(const char *volume, char *buf, loff_t offset, size_t size);\n>\n> extern struct ubi_device *ubi_devices[];\n> int cmd_ubifs_mount(char *vol_name);\n> --\n> 2.45.2\n>\n\nIt would be nice to have proper comments for these functions.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=VuWRqWEb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"VuWRqWEb\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0cpm4yMDz1yGs\n\tfor ; Wed, 22 Apr 2026 08:44:00 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4BCEB83E76;\n\tWed, 22 Apr 2026 00:43:57 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 0790C83FFA; Wed, 22 Apr 2026 00:43:56 +0200 (CEST)","from mail-ej1-x635.google.com (mail-ej1-x635.google.com\n [IPv6:2a00:1450:4864:20::635])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 16992839D5\n for ; Wed, 22 Apr 2026 00:43:54 +0200 (CEST)","by mail-ej1-x635.google.com with SMTP id\n a640c23a62f3a-b9382e59c0eso755138166b.0\n for ; Tue, 21 Apr 2026 15:43:54 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776811433; cv=none;\n d=google.com; s=arc-20240605;\n b=CEdH6TokjVJZmgy4bw4eLZvWNrQXbCxkHzYc8/v3X86gVntjGiRKHBZ0/zEoTjVLxp\n 1rCjvrqAmCAFOAjMug9BBw10bqWWFmmfz4Bof83QaAd1wGJkV3Yw+SMZ/UWoa1/sfmGi\n 76kaydwR71hg4x8yK8xcPSZwHEPEsCptUnwF7wZO9toidE5bHLvLQgRRn9bdRk1jdgCO\n Q9qCeZd4PyiGRYByDzb4REouWWAupvbCBWN52k9MER9XtDueWSFbpDkr1MWh2SyfVprp\n GQFaL6mMV4Pn2jiby/iMhTRi9HH/0TMO6UzaI9ILbkJRWtFLE8KLlhrPzVckYpa+O2NN\n VecA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=sERvdl/fx9UQAfIj581HEBcDF8fCkBcpMoN1EH9bpYQ=;\n fh=b/b+yr9z4XxaI5A5qEQnsMBRDFDpyiCKmVLWUAngCcA=;\n b=PqlN/YrxNQhsnywlXosplxpkcb9CqNAE/Zh+21cjqpkSrvV9zmo2yjIFjCigDZCGk3\n rQ95dLndivCTYDFwR3K7Ehw/Zu945jUitSGUCusxpaeun4z0YCRR48MwXBt9+AsGl8jT\n /aqEqfjWEI4elPBLHbAHntcizv7/tW/+OrOU1v5ZdM7XkAyoVsDFHLdP4Ub8Y5/9zosM\n UCaFQDo4mE1m8ue+Hh4YsEeW2PdIAjLlPerwy+YnOZjsNaTwb78SE3CSv+fjEApi/21e\n 81EyYKEzdYUEqkr2vGUZDWOiiz+OwzvVjteuhQ6NU/q0GJb/T18l6+lLXYzEIvO6qkzJ\n OBtg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776811433; x=1777416233; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=sERvdl/fx9UQAfIj581HEBcDF8fCkBcpMoN1EH9bpYQ=;\n b=VuWRqWEbOnD1eaPD6IWXy43mJ6SUvXOAs5x97FNGpvlVKYmqFZx3YFjOOItncGTko6\n nQB6xoNEhB2ThdTSOeGbdqyVZ+CbGp09NgtLA0k+biq/VZLNwxHM6Ik+WjGLtxYdxxb3\n 39KHC5dztUaF2dzXAVid3Im0SW7PdL0ivyvrY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776811433; x=1777416233;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=sERvdl/fx9UQAfIj581HEBcDF8fCkBcpMoN1EH9bpYQ=;\n b=FHnyEdK6YiANncJOdFkyOZijeb6mhBTDivFDOanUApQk0KZDCD7wSgbpSV+gvZrxFQ\n aGz5uoI7x3kS4t1KRgV/uwbEmmYAhdFSBJONysesyYjgQfgAPCorzT60LmwJNVCS2TjZ\n PYgJauymm7ldDFwNu4T/YFapdmiAT7zrwDTbtkeQCihSJ5REEq/Lh1MufJgSkOhGjGas\n Jn7bupv1wgkCfnaHrxndk9dNWeH20dhfbs2U7tPFdXkBrG8c0ojjXLyYAAZ5AieMefZ2\n T3PkeKNwbdzcpTOoq3wlgP1dD9YiIQ5y6b2pAELq4nfc445ha6c5U7E735yOd12BWYEn\n J9YA==","X-Gm-Message-State":"AOJu0Yyqw4qRunNLkuApcUhtEYI+jjl+RM8m6xdAPg6oO8aBmnKjaaOh\n PQ3QBlu0HFqrHlANbUqGl1BPNilk0yy9dBIrUidv3gSwOrhJ603JJLDPZt4q3OZw4aOBr9sN1u1\n 8oC9a73id3FyhAbOiihghDTJQnI7CzmawtiOe+QVj","X-Gm-Gg":"AeBDiespsW+JLD+x3Y3SmvIibH8BaN7CNvznpaE5vFzInnAoW39TgPSWtKl4h0Rt1m8\n pkOyOF3y9OgSTKAQNoqBz5k/jquGeScjnspm8V7ZSSToo/UyMTg9Wn6YGHxSofP7BaPoy8sPWCu\n b5yD+wADvpB1Y5yiJmsyw30eTbp54NBPFeF9JilfQ6jTNrbsg1m7WppDhLCiphb5V7+DmfpFHkR\n te+PASMxGN5/P0Qs+d3QevNL3emhSZqz9aJrRGzSGX2O7/dtsb+kUwiG2fGBUUwMKqASuAoIGsa\n 8nXCVFPdJJyAqHkuZRPdmKaqu/jcJzg=","X-Received":"by 2002:a17:907:70b:b0:ba4:b8d6:c336 with SMTP id\n a640c23a62f3a-ba4b8d6d9c2mr987322666b.43.1776811433502; Tue, 21 Apr 2026\n 15:43:53 -0700 (PDT)","MIME-Version":"1.0","References":"\n ","In-Reply-To":"\n ","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 10:43:39 +1200","X-Gm-Features":"AQROBzAjSnaYg-27W-eYGcAjj8TUleNGA4Y3ri2UNw6n5VrVXZCrl-xvE2F-k_M","Message-ID":"\n ","Subject":"Re: [PATCH v2 2/8] cmd: ubi: mark read-only function parameters with\n const","To":"Weijie Gao ","Cc":"u-boot@lists.denx.de,\n GSS_MTK_Uboot_upstream ,\n Tom Rini ,\n Marek Vasut ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]