[{"id":3680099,"web_url":"http://patchwork.ozlabs.org/comment/3680099/","msgid":"","list_archive_url":null,"date":"2026-04-21T22:42:45","subject":"Re: [PATCH v2 1/8] ubi: remove unnecessary extern directive from\n function prototypes","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-21T08:35:39, Weijie Gao wrote:\n> ubi: remove unnecessary extern directive from function prototypes\n>\n> The extern directive is unnecessary for function declaration and should be\n> removed.\n>\n> Signed-off-by: Weijie Gao \n>\n> include/ubi_uboot.h | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=mQF3vskd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"mQF3vskd\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0cnp4sVtz1yGs\n\tfor ; Wed, 22 Apr 2026 08:43:10 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id F27D583E76;\n\tWed, 22 Apr 2026 00:43:07 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 8EC2683FED; Wed, 22 Apr 2026 00:43:06 +0200 (CEST)","from mail-ed1-x535.google.com (mail-ed1-x535.google.com\n [IPv6:2a00:1450:4864:20::535])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 0A579839D5\n for ; Wed, 22 Apr 2026 00:43:03 +0200 (CEST)","by mail-ed1-x535.google.com with SMTP id\n 4fb4d7f45d1cf-671c24f23b1so6951805a12.0\n for ; Tue, 21 Apr 2026 15:43:03 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776811382; cv=none;\n d=google.com; s=arc-20240605;\n b=ezdJyU6lyoKYHbgiCi9L3MUEh+T4TTc/7RneUq0LmSDD2QFzWHEW2ppOSZUFNPO7L2\n vOyPgy3UB284wa4U4y5moXzr5NOUL7iGWlHVf2hThLE3Ms4YQfLu5R3cdKN5ZzFTJcs9\n R5xyLfnUcrHMz83q5fsn8ZkWwWHx+DjzMWwBVj6CnIIPBewbajfZNI3gSKAS830RhQYJ\n vYjfDjEy4eb6V3l0U9gemIA/Khi8Qfh8cBlODOZZbHyMw0zsbYT03BXBos7gSJS1dkT8\n Tgc49kI08fOollRRI5iCyhMZ8DK8Rh7NAKyy7S5OT6C+HmZ5+gi4bnTmt/5ZtdbkZrvC\n KYFw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=AMMqsY4FjTwa1Yb4cYgQ8bLTkIk2A62p67Gk0erdy8Q=;\n fh=fJAGB8LvxCJalDRE+ziaXIW21+gD5jSCb0B1QEwHsvE=;\n b=ZYdisaNZeSQMiPvyB+Pi9hyFXJKtxOb6kkizv6F9NDwyAM4XdZTUZHzgFvmm+wzU7s\n UjDpz2vYL+aIp1BX34Cb/3kLJOQh/6h1mX5Pcb1QQKdyOjglwntWMWGRE+iJ7ak/PB3f\n RGurXVwom5/wIcTsBxjnz0Z/0+kxxCEf0dQ7R/fK/jL+VRX/c14qZCHA1UDak0nRPeTX\n 7tMjoCnUzOn19AbHYSgGucFfGiWteZqLGu3ztFv5Gyq5CjGDBKkp7Sj3V52x64fu3biH\n vbAOp38IwPzAhpTc2M/0wAbOJ0EDtmFo2lSRflRsfDa3ssl2jv29dGu8lLsbbkdIxS6r\n Qppw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776811382; x=1777416182; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=AMMqsY4FjTwa1Yb4cYgQ8bLTkIk2A62p67Gk0erdy8Q=;\n b=mQF3vskdJz8955UJe+g51ef00vji/gOzbJ6Ng7TAUMz1pC0vrbf3ckATg08ONRF/y/\n GVgOkteBzacS5Hjoo/xcKbq5kc9BpN9RZU1bBg+NrMZZUZB6SLzp+qWHKWm7G01fQUwp\n VNnupMF+Pw/dBD78+eKY4IV4JW4MKlzlwMghg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776811382; x=1777416182;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=AMMqsY4FjTwa1Yb4cYgQ8bLTkIk2A62p67Gk0erdy8Q=;\n b=TXFK0VIOaQ+9PvcFdqvCDfGoYCSPfpfizP3zV+w/wZp3BxEwMdvd7xdsNotCtSVJ/5\n yvP4du4kEfMhtaI7jzy/MrcH0rP6nucjDkVRwx2qyNwYHgkjafcrS546tcH/AhKwfdS/\n pH8XXTMqc3pGxC5lhkGSGBhN9PQ+Kidawa0ZKc9qHbEoBgZku7Pz4ykQ+hHZSlEgcRA8\n KCe2B3zOMGJx1YbbDePZ8dY6crjoBXaVytevloxaTjp+yjnYTbtNPbP/qqTpi3L2+kkT\n 1eJwz7m0vetgSnjAV4ltyeIThY55LzH6AcG102m0UqL8SlQTH4FwM0otX0/btu5Pq6OT\n 91/w==","X-Gm-Message-State":"AOJu0YwxXx/tOSW5AwQA05ls2xT/R5ttraEEr5AXyWkZVZaX4EsKzP8F\n NQEVm4do3ESqP8koY0zol+c+3XCfB9Ln1046ceIJgf9q/lQvB0jd1dPhADFW+jKomI/+sO5QT60\n WCkisWv6+o8gKX4VAsylraR7yuDgXeEGm9NyddTtNGMfgzIfF1CHvhw==","X-Gm-Gg":"AeBDievr/i2dwseXLjHKNyMtsWrI/lNklUbrtHyGuDWL09lOhuztcJQxhshh6cqv4Ir\n qngSoTHYdrIk4exos/UQ66Xzv/idCC7tpYHc+t7TiZDmrYiH8tRGcVKhaVQNKpd6KEyHSqg5HOm\n PYFtPyTg5iMlxE2FN3x3pLwRF70F5Bat/lLfrAOIarPztyN7CPKbt9pTtkRP4ycvm2b++4NdeLH\n XGPSdk3rsKnNU5qmbMkMkf4nPLf/Znu7E1Rl/dke/vtjgNNKQ8W0/MMe0HA10blFsj3TGQ9l937\n w2t5WgOELx2bwzCktQvM","X-Received":"by 2002:a17:907:1588:b0:ba9:3162:182 with SMTP id\n a640c23a62f3a-ba9316201a6mr228279866b.19.1776811382419; Tue, 21 Apr 2026\n 15:43:02 -0700 (PDT)","MIME-Version":"1.0","References":"\n ","In-Reply-To":"\n ","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 10:42:45 +1200","X-Gm-Features":"AQROBzDrUz5wKgXfvMuqKEnjoVLzgArvY835ogTWj0yjnyAbEiEYXALs46AgaiE","Message-ID":"\n ","Subject":"Re: [PATCH v2 1/8] ubi: remove unnecessary extern directive from\n function prototypes","To":"weijie.gao@mediatek.com","Cc":"u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]