[{"id":3679746,"web_url":"http://patchwork.ozlabs.org/comment/3679746/","msgid":"","list_archive_url":null,"date":"2026-04-21T08:41:54","subject":"Re: [PATCH] hw/misc: Fix the valid access size to the avr-power\n device","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Tue, 21 Apr 2026 at 09:29, Thomas Huth wrote:\n>\n> From: Thomas Huth \n>\n> Accessing the device with in non-single byte mode currently causes\n> QEMU to abort:\n>\n> $ echo \"writew 0x800064 0x4142\" | \\\n> ./qemu-system-avr -M mega2560 -display none -qtest stdio -accel qtest\n> [I 0.000000] OPENED\n> [R +0.001784] writew 0x800064 0x4142\n> qemu-system-avr: ../../devel/qemu/hw/misc/avr_power.c:58: avr_mask_write:\n> Assertion `offset == 0' failed.\n> Aborted (core dumped)\n>\n> Set the valid max access size to 1 to fix the problem.\n>\n> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3393\n> Signed-off-by: Thomas Huth \n> ---\n> hw/misc/avr_power.c | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/hw/misc/avr_power.c b/hw/misc/avr_power.c\n> index f42cf4fd906..42be2656911 100644\n> --- a/hw/misc/avr_power.c\n> +++ b/hw/misc/avr_power.c\n> @@ -73,6 +73,9 @@ static const MemoryRegionOps avr_mask_ops = {\n> .impl = {\n> .max_access_size = 1,\n> },\n> + .valid = {\n> + .max_access_size = 1,\n> + },\n> };\n\nReviewed-by: Peter Maydell \n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=rLlgR/DP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0G8162qmz1yGs\n\tfor ; Tue, 21 Apr 2026 18:42:41 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wF6gM-0006Ii-Cu; Tue, 21 Apr 2026 04:42:10 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wF6gK-0006Hz-Gr\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 04:42:08 -0400","from mail-yx1-xb129.google.com ([2607:f8b0:4864:20::b129])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wF6gI-00038Y-O1\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 04:42:08 -0400","by mail-yx1-xb129.google.com with SMTP id\n 956f58d0204a3-64eaf8aa893so3166562d50.3\n for ; Tue, 21 Apr 2026 01:42:06 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1776760925; cv=none;\n d=google.com; s=arc-20240605;\n b=LzxgkbI9gjlIGUAnLlwMwnSW+hm7dTHh5VKwpoRmVkxSwDKNJl2YYWdzAW/ektBbVB\n zc/+bw4JNwpHbPdzSlDnhnL17j5NG3TZWvTwxkO/gomJoeXJvj4Biq/GWSzLWqaYH+Rr\n E3Km2WLIWeu5EOId06SAZ2Tq5nvXB4nd5A2CPhPtM1YOnkSXqkpVl3QWHlnJRxcc0b5O\n d13bol5EWG4INtA9OR8R5FFP3Tc2FwxrOP9XmpyL0wnuj00iZOIpHMuCAE+rcZr50uvG\n ZX9QlByhMK6ZZJgUw3kPu9iRHyVBWxWF9T2V+8VNbE9pCML10bhOic07g4BnVoa5tXfU\n RpSg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=pkN1JBmanUEOKiq6af58ThegBRjT5yctGC3q3GS1kYU=;\n fh=EgP5TNajs02ZcZMtU/5Ht6otQ0qQU/YZQZO4GwaWWG4=;\n b=E8/vioc/Lyd1R+TBquD5pUgs3ulmKQ4nN5zprmvEEpoeVIQnVDP00Ezlg06kzsl2Q6\n YdbmkqQn/fsjyXEL/+8x1h/3mMTHpNMGsOPs0TJLUFiAkugJaralCd97e8VidFVh4Hf3\n TquzOJEoiz7G9w7NKgXR4c5N2dqKHJMEtqyPHm2wHXt/WHMxp0SdFAOtP/qftf5bXjPn\n OuwCH7WinKC158w5KNqlYGre7A+gCN+CIQNEPOnc2j+cPzC32OyITjmy9LlbEdfwbmSD\n miPyuNmqnnL22fqDlm/ZIh6wCHRTsid/Kx8gNOpifrkLRSTizobaWhc0OgIxXUoQ1FJW\n leMQ==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776760925; x=1777365725; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=pkN1JBmanUEOKiq6af58ThegBRjT5yctGC3q3GS1kYU=;\n b=rLlgR/DP4+Dpsnb1k3AXajrWpRNTHSZWpFe/QhLsdZAPcIkkaYk9DswaasRcuBBMnK\n TZLmniPUNco0OBiPyOArPyXbs/576x8fA/SSQa/NuNeL2+rbAA3f0OwVbNVkbaN1A5ub\n fhnURtcEPV/ds1yS96Rn2gl/pWMTJywoNZzv/1onCNPASST1qXkuLVawab3DaTNPL9V9\n TolTH63QVXZ1Vkstj9q/ZAs+jtvX3C+Rhoob76q01wvxN2DvVBXpGzKFc2uw02c3Jk9m\n z4YFfEzRM0TRrrzUZdt7aF79Yj8RKQ3h2wJ3afUzI9Z32lS5EfYjj2AtmZ3mmigLcRl7\n 2++g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776760925; x=1777365725;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=pkN1JBmanUEOKiq6af58ThegBRjT5yctGC3q3GS1kYU=;\n b=R8TpvDIxZkjwXj8fur5H9zKNZhUAKIVB1jVmGHJZVcHD/QbmZ73LGE4pFWQYrk+NLL\n IvsxI3uQqiBJUzNqgtiPSEm4NNmls4o5BvCdD2PxxpCzyyy1KYkUTJVBdjzhOLGHuOXC\n Su7AqvSnTS+Cw07lgy9dJ2OvnlNofHsp268Rmqhy4VfEZc9zc3Zsp6+s76TfVWzX+JxO\n xSqe+U8g4Ggp0+y5p49Ae4OAI18htmSS8PurNckh7EQGimXIOJLOMu/NKtfUi0twyNzF\n ELroWs9+PJ3O19gjv5zHEjkcczfo1YttbTGe1Y4k1X51phx80VjFRn82mButiHmszx8F\n RNyQ==","X-Gm-Message-State":"AOJu0YzThmMzCTQmEhrbhWSW1Ii4rSNbpanVZuVeyvItN6ZI6QnJ5H0S\n jT0bqpCIWkHLzZd0ZN09ojXXiv8xO3YUJ3B+b+MJttmw+tyHQz6yz2zjXfd+ZqRAgIDu+oL8tlH\n GM6WCrEkK7nuX70XoRB89eDeFnMlUwt1Rfd6zon9b7Q==","X-Gm-Gg":"AeBDiev8yYKjIi1Ee7F5yDZl99wnINIR4dxI/8l66k7FfrjAvdIqkeCsLeq1QENmlTn\n EkLPWwkvoPxYJmvw/aan0lo9Cp088vbQxt6i8TeJt1b7tWjsH10/0Nt+xwOhM73+WzhLWMKYylW\n XVnNYVLnoMGWZRVRRRxlTPoHB4U6olcfDpwpwa7mEhLlLITvYMAng0i7xWY/ofKWwJYv2az6z6S\n Pl6UDd+vvggenf8MY+pDGscli/OhbuthUpEjYGB8zjl2b2aPkgTzREtwusr9LebDhk8VfNwPJVK\n 44Sm8BAKkVWSGgc8RQMFCmICGU9GQMoQIsZYJBfOE7KH0taDZC1LmMwWVUXm13OTkm5OhJ08EsC\n 6zQ==","X-Received":"by 2002:a05:690e:130e:b0:651:bc3b:75c7 with SMTP id\n 956f58d0204a3-65310804a7bmr16086869d50.11.1776760925553; Tue, 21 Apr 2026\n 01:42:05 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421082935.85995-1-thuth@redhat.com>","In-Reply-To":"<20260421082935.85995-1-thuth@redhat.com>","From":"Peter Maydell ","Date":"Tue, 21 Apr 2026 09:41:54 +0100","X-Gm-Features":"AQROBzBjzkjg82Uxm_550fvWhUsgz7_cl9OzZbdv5DNaq_GFpL9-x8n_64U9vOM","Message-ID":"\n ","Subject":"Re: [PATCH] hw/misc: Fix the valid access size to the avr-power\n device","To":"Thomas Huth ","Cc":"qemu-devel@nongnu.org, Michael Rolnik ,\n qemu-trivial@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Received-SPF":"pass client-ip=2607:f8b0:4864:20::b129;\n envelope-from=peter.maydell@linaro.org; helo=mail-yx1-xb129.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3679753,"web_url":"http://patchwork.ozlabs.org/comment/3679753/","msgid":"<1a5a1371-421b-409f-bda2-63f1f29a3966@linaro.org>","list_archive_url":null,"date":"2026-04-21T09:01:28","subject":"Re: [PATCH] hw/misc: Fix the valid access size to the avr-power\n device","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 21/4/26 10:29, Thomas Huth wrote:\n> From: Thomas Huth \n> \n> Accessing the device with in non-single byte mode currently causes\n> QEMU to abort:\n> \n> $ echo \"writew 0x800064 0x4142\" | \\\n> ./qemu-system-avr -M mega2560 -display none -qtest stdio -accel qtest\n> [I 0.000000] OPENED\n> [R +0.001784] writew 0x800064 0x4142\n> qemu-system-avr: ../../devel/qemu/hw/misc/avr_power.c:58: avr_mask_write:\n> Assertion `offset == 0' failed.\n> Aborted (core dumped)\n> \n> Set the valid max access size to 1 to fix the problem.\n> \n> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3393\n> Signed-off-by: Thomas Huth \n> ---\n> hw/misc/avr_power.c | 3 +++\n> 1 file changed, 3 insertions(+)\n\nReviewed-by: Philippe Mathieu-Daudé \n\nand queued, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=TmboJgqG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0GZh71Fpz1yGt\n\tfor ; Tue, 21 Apr 2026 19:02:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wF6z9-00018L-8s; Tue, 21 Apr 2026 05:01:35 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wF6z7-00017c-QI\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 05:01:34 -0400","from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wF6z6-0007Jf-7E\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 05:01:33 -0400","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-4852b81c73aso33836815e9.3\n for ; Tue, 21 Apr 2026 02:01:31 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4891c08faffsm269481385e9.1.2026.04.21.02.01.29\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 21 Apr 2026 02:01:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776762090; x=1777366890; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=nXQ2IHDXTbEKPoc80gqzdwc+ZOiq9E9sWXaw5VmnG+I=;\n b=TmboJgqGnoyhV9EhhjBBpVuYLip3hJjmq/hQdl1i36ctj5Jbq6Omxj3hz0WIJIrx2Z\n 5Xesr9ZjvCv1pAzKzprhGZ2vxqUeAzE+OAEdDP9c8xzZyznIwVPcRXThjr3/w9m+Sq3r\n 1dJt+OShoAmv1izd1faY8KaOikuvQHrDKIkJRMZFa3KaX/WZQlodQDzQ9WtAxX+oQ68+\n oMdnzQfCMGdC0fQ9hMp+8oZNMGDi2PokTIzw/SDwKks5u/E2DIrD8hyX7qAz/Akyob+4\n f4MzgFaMafernqrzB8ZpmWaQGKFGXo9CdL3gRPH5pqockMmGTSjErIhI2mO81cgvYM6U\n uL4A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776762090; x=1777366890;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=nXQ2IHDXTbEKPoc80gqzdwc+ZOiq9E9sWXaw5VmnG+I=;\n b=S+NdlxNPSfOzvA6voLW+aM2gCTPVsldiOX1W1OpZEVB/PuwA0fYri2CGJdVxRw9s0L\n UQAywP6puHgonmOl9dgbAbDX8mczlLoVVctSrNRzaTVMUPdkpp+letW46mcgb/JXc7Bk\n dico5Vqwdd2ROO6/5i8M1Owv6OA3RS4r8OPKPOp+wWOpXQjc5ebbwR/YQ2AfazLds2P3\n c+2uXs3Dd07t0dVWiu+RTQmDiq6mpakApJkzYkDLVNaGlaXoy7Jstj4Ucs7pC+o+4Uyz\n ihni8ITFCclteM3sjvn69zUmVkTRqg/w24Arm0NRj5oM1wqI+LP+BU8Ia8smnxVM05EF\n OU0A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+upkiq7E2H9P3KjBSERIas4Chxw+xxcC48D/kmDzYSVOcHam/+VsDgPWic2rZ62crnJ7Od6d8AZQ+0@nongnu.org","X-Gm-Message-State":"AOJu0YzGMbJtnz6L3Iz5YqkHEe8IfCcXePNUs5gVfD8/lJQP8n1PbBCA\n MgW8xndURumcYPXgESCygPTRp09cQPRlLpSwOiEtWBdOoEHcw3aUOgk0obLjReE40Ss=","X-Gm-Gg":"AeBDieuuk3RLBFLtqpb2nXUumQheY2Aj9GdhWPU759XnZTCe8gMdZbx039ahNjsFIKS\n G5wer+hX3kjRLoNl1V29j4uuZuOUyYulOKbHwiLaHcdfopWJmH+T7hp4z859mwCydvgVarbDu94\n DELHClejupjxrBxjq62ky5AiSTR9ewEJWmZkwI821Z4pN20bNRmNC0hvnjBI9A2B4rZ3pEBMqrW\n Mfj6fVfRSby6bEO/Urcr7bhvGaEDTBtBThabDHIeNV53otlEeKasK4ftoFWHCKZA9gxlFVVvhn6\n ElgYlFU1qPOWqHDHQvkAe+7715bLNsqFhA519+YoH7OCMWeCvdysmpsudvPVmr5J1ji2SdrxfmM\n TpddqYYOXnbEQOaynWcYwewvxFg26h3xd4IsoFG/lgEHpkrvII8I5IEXv1mvZqvEHH4cUlwdjYt\n J+P3B0xz6aT8KUcaxJcyeNw2AuiZ/jDUj2hH71hCarVE0YaoTHYLWCNuER+4z0CXuU814hjc7Y5\n Y/h","X-Received":"by 2002:a05:600c:33a6:b0:489:1c1f:35f9 with SMTP id\n 5b1f17b1804b1-4891c1f38b6mr64277975e9.9.1776762089935;\n Tue, 21 Apr 2026 02:01:29 -0700 (PDT)","Message-ID":"<1a5a1371-421b-409f-bda2-63f1f29a3966@linaro.org>","Date":"Tue, 21 Apr 2026 11:01:28 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] hw/misc: Fix the valid access size to the avr-power\n device","Content-Language":"en-US","To":"Thomas Huth , qemu-devel@nongnu.org,\n Michael Rolnik ","Cc":"Peter Maydell , qemu-trivial@nongnu.org","References":"<20260421082935.85995-1-thuth@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260421082935.85995-1-thuth@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::336;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]