[{"id":3679751,"web_url":"http://patchwork.ozlabs.org/comment/3679751/","msgid":"","list_archive_url":null,"date":"2026-04-21T08:58:12","subject":"Re: [PATCH v2 3/5] gpu: nova-core: do not import firmware commands\n into GSP command module","submitter":{"id":93201,"url":"http://patchwork.ozlabs.org/api/people/93201/","name":"Eliot Courtney","email":"ecourtney@nvidia.com"},"content":"On Tue Apr 21, 2026 at 3:16 PM JST, Alexandre Courbot wrote:\n> Importing all the firmware commands like we did is a bit confusing, as\n> the layer of a command type (fw or GSP) cannot be inferred from looking\n> at its name alone. Furthermore it makes it impossible to create commands\n> that have the same name as their firmware command.\n>\n> Thus, stop importing all commands and refer to them from the `fw` module\n> instead.\n>\n> Signed-off-by: Alexandre Courbot \n> ---\n\nReviewed-by: Eliot Courtney ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=NA38O3VR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-52830-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"NA38O3VR\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.56.13","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0GVJ4JvGz1yGs\n\tfor ; Tue, 21 Apr 2026 18:58:32 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id B0D4430093BF\n\tfor ; Tue, 21 Apr 2026 08:58:25 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4C4F93A168C;\n\tTue, 21 Apr 2026 08:58:24 +0000 (UTC)","from BN1PR04CU002.outbound.protection.outlook.com\n (mail-eastus2azon11010013.outbound.protection.outlook.com [52.101.56.13])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 01E6739F181;\n\tTue, 21 Apr 2026 08:58:22 +0000 (UTC)","from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31)\n by SN7PR12MB8059.namprd12.prod.outlook.com (2603:10b6:806:32b::7) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.16; Tue, 21 Apr\n 2026 08:58:16 +0000","from BL0PR12MB2353.namprd12.prod.outlook.com\n ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com\n ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9846.016; Tue, 21 Apr 2026\n 08:58:16 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776761904; cv=fail;\n b=KGkPZzBVmISGDTHei8i1HdDrUweDQ6cVSvqoi3IjDar4Hpyz5m69oQYy0sLwGlDuSlo+gbYlC16hXstt/ckI5zot+9+VaXMo2C9X5YFGvzi3ZqD75Q9Sw/DwFSHctJ/lByPKRhnW3gE2z0G7BiVSTduizLxnqVopkDmDu6d9zNk=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=czvuJrSDJKKkX9BttEQruWF3pvseVgcYw+eDOqW0QRKyi5NY3EYgpRje9OeM4VIhU9dk+GxxG4GFwaknoNm1dYR3z8U/oujKg6ClX0Z206w16tbvUcLmNMjRCNCVBNqHOg7URIJKCuZyd040pnXSXsVlycHza0Q6NVfUeejc7OJKc+bf2h93o/Mz3VX18LvcLKACt1F36t1ZJ4PUJj6HApEwoU3qt6HYEiYQvTrMf2pKAS/u7on8Ex56tQ4FjZKp1/N26cP4jG3gdzWrLndqbd4M6mvyoQqTqayW5tOVXybnHgDJYP68cuzQ8hDVOe51QXNNYiJasQAQBlBV7vjuSA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776761904; c=relaxed/simple;\n\tbh=WxUg95YEhw8xbBafM9mY9hVSCPdJPZB/GKY/muNtSSI=;\n\th=Content-Type:Date:Message-Id:Cc:Subject:From:To:References:\n\t In-Reply-To:MIME-Version;\n b=qtwcXhpFiIAlW+UP8/nUR/045wEgtSWtRUTTBX6SBaBxTvQQ3ihhMBlYVuD9qPyvXgGejiXDewUQREHwVEe0W/yFBtdVv1EInbDHrZvhEvJ+J+3tXtPt1ST5NSzewbcwOU9Gpw2OJ3eAVKduPkwJeUxtalPsxzLwSDDQdEgAfaA=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=WxUg95YEhw8xbBafM9mY9hVSCPdJPZB/GKY/muNtSSI=;\n b=LWRC9ycSMu4FayRRFBKwsJna8Ax1vfMeeW86+z/t1le9liO5pGmuxVw2E6PVoTktImD0+VxckK6yQSDko6A+9De5xI3/ep9MkbgKIKPJim+YYjnFd/Q8QsW5LnP4zOd6P4nH3Cn9Hn3Ke8q5in0EfrMgFNQ56CWqoYKyNsftKw7L4oLsR3OYSj4HknDIKctN+uAFEei+KLjTba72p3l86pkd2WoXudkwxQmw3+OlMqLBZL39KO1FVcbyPQwBsauDb3YgtRoHKbw0pzYgqk5VTIwdKlNVc6wGBY4WPPO0RjCzTraBh8nNF4S/rZWoXIz5SvDYzEMGBQgNw1FWTLBerQ=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=NA38O3VR; arc=fail smtp.client-ip=52.101.56.13","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=WxUg95YEhw8xbBafM9mY9hVSCPdJPZB/GKY/muNtSSI=;\n b=NA38O3VRYu8Q+H/MF5XOlLpZs1/EdpbnX1NbSmzvoIqN8rK62s0A+rZY9IT+sHgIg0LM2f8vbApiXbqWAa69l8oBFaAmcD7IdzvQz8W8z6K9s3wQSb5ejO1kFQocP9u7l8fttNyzOLPFj6lqLqtrBCYfK9mh90753u8+uDyIfbjcsFrt3ZHondNpdDOwEXJTdz/wP9ir16QsZFlTfmLvWFv36MHKaszfAEbvWS8DAho/vgWo5ABNJO5BGrtAO/KU+YwI5rSPaxphdgMHCkcIUd22/VqZueNUhTm+K9cyMOvQZsTNCzCSSqJQ/bdhfIfOL0dAWMKs3PU5hZO6i8N6qw==","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=UTF-8","Date":"Tue, 21 Apr 2026 17:58:12 +0900","Message-Id":"","Cc":"\"John Hubbard\" , \"Alistair Popple\"\n , \"Joel Fernandes\" , \"Timur\n Tabi\" , \"Eliot Courtney\" ,\n , ,\n , ,\n ","Subject":"Re: [PATCH v2 3/5] gpu: nova-core: do not import firmware commands\n into GSP command module","From":"\"Eliot Courtney\" ","To":"\"Alexandre Courbot\" ,\n \"Danilo Krummrich\" , \"Alice Ryhl\" ,\n \"David Airlie\" , \"Simona Vetter\" ,\n \"Bjorn Helgaas\" ,\n =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ,\n \"Miguel Ojeda\" , \"Gary Guo\" ,\n\t=?utf-8?q?Bj=C3=B6rn_Roy_Baron?= ,\n \"Benno Lossin\" ,\n \"Andreas Hindborg\" ,\n \"Trevor Gross\" , \"Boqun Feng\" ","X-Mailer":"aerc 0.21.0-0-g5549850facc2","References":"<20260421-nova-unload-v2-0-2fe54963af8b@nvidia.com>\n <20260421-nova-unload-v2-3-2fe54963af8b@nvidia.com>","In-Reply-To":"<20260421-nova-unload-v2-3-2fe54963af8b@nvidia.com>","X-ClientProxiedBy":"TY4P286CA0049.JPNP286.PROD.OUTLOOK.COM\n (2603:1096:405:36e::6) To BL0PR12MB2353.namprd12.prod.outlook.com\n (2603:10b6:207:4c::31)","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"BL0PR12MB2353:EE_|SN7PR12MB8059:EE_","X-MS-Office365-Filtering-Correlation-Id":"4bcfa981-86a1-4a25-b94d-08de9f84203b","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|1800799024|10070799003|366016|7416014|376014|18002099003|22082099003|921020|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\t8zO/sWtI41nUR97QjPkbAIuz0TAigxRafAQKhqIoVaRkQb9Bh49K6oIr5jCJG/pxwDLE4Cfv8WJtcKPmce+nZ8yblCAzm9Ggq1xkDIY1KR58nlYUx593NrRSllcWqocKZzVW+Rm/AFVs/g6xdZZXl7zfvx5uQYskrvaiZ1CoE5Nev8GxZhNz99aV+69Yo4Y70VaBT+dahosB813CxRBaXJFV28VP80zwXfkOyzbVqKq4iz8otfC8C5RwLFJjqbburreP82nXWCV/jj5PCEC5p7bTjPcWRK/t/dqXGOlnq1j6XLBkohSQ4+6JVuJfbR/YBpnb5qBASBsx92BeBsrRbEiXHrziqoujV3LZGYtcoIgnkGiztqmBFVbLDCOiMgX+uNF5v9mpBeDkE7OxKixqRYMo+wk5XYu/GTGGH03yl8wQqVjdYyL/AzKRrVta9vaPgXDtlEuYQCtsZkQVKrcxORb46ut0wvsovfLuPaMhDtJPDYT2X6kFXL7spN2VX41cvP0qnmfTNfYjK0YQWWGde7jIWNBpjeIsFKG25715CIHQ56Yt+bhJ/hqTVkkG6YFgNu77R09PWXle+mmBEZzyrSENeNnReMjHLDBeALBW8fc5UXy+gLie99awgdkqLI6cZgB2ZcU4cs9WDVt3Rr/byylvQXSdPU9dXR8Apl5HHJxvWlzMwPzfPVT887OlUzExO/8eNzDap2lBKW03S9CM6DAFWWln+kjB51tOPqpyXnp444A9q2C7Ikj6u7jOIq4DOBZMkcyycfCo3EkqV43OTA==","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(10070799003)(366016)(7416014)(376014)(18002099003)(22082099003)(921020)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"2","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?Hz5sn3HLP92GhXpDMxfy0QmJasGy?=\n\t=?utf-8?q?GbUANUNlu7r8OKmnaKBLNjeUG5LMcAGo5MjbdfQCieqA877jAHGY3Mh+LEt4KsoKK?=\n\t=?utf-8?q?lCAzhakAXTJCevFzDTJ21nl5vAMhxKPqeT0h6UTdOL0KPFIA55WKRgYt8oCBRlNOf?=\n\t=?utf-8?q?S4zQVoGfcqDvmCwkgNc2UbZ0HPOp4Tm+YVJ5HjL4ONplzBYebAvThFfgeFd2PJsBm?=\n\t=?utf-8?q?vZ76XFCAbw5lcBaY7eL26LNKZVHL5/crdmjYdkjP2egr3ER3o9oapuOXQB7TkGHW9?=\n\t=?utf-8?q?vr3l1tUGoPTAnKJl4veQktCWjpmi71uOi7HyXvsoecim61UFWegnH84bWG9IMZ6RP?=\n\t=?utf-8?q?6rSMulb5uC79bDpJuHKmU+WpkrZwFg9KQ40NXSB3cOapunN8cfIPihjEG7qlk1KgT?=\n\t=?utf-8?q?O+0sIR8smifOR/qotIL7u07uh/YIMuRbxNNgRWH7tnGCl87MQ5T0RHyyRiR73Sp0E?=\n\t=?utf-8?q?m3FkKrcinMMYITApD9a0L8OOi+YP9oP8Oiz1iDiTQB+YZks22xI4qhNUS4dTPLpci?=\n\t=?utf-8?q?jQW4eHgLLUM8VuImA1hOBshGEQta9fhUg8//JnF9+nnxrgjgw2ZCdcn+ex7DEAJBb?=\n\t=?utf-8?q?R4ZHI/T3IJrsrRwLAFa36SsN+sSOoqAezgishHm0lHUmZR++cFu9Umgj3ZLx7T8h8?=\n\t=?utf-8?q?BL0gg5AYYOt0rjEw+Lx8fIHm4n1I48VRADjkJNFBmBfuVlyVvCp5AOSN4myl0k/YN?=\n\t=?utf-8?q?U8wIyBU0qcqJukQL9h8qffsTRr0f8c8R6oX0sqyHr4I4O67wPsQ24mT5QnU7oKiz+?=\n\t=?utf-8?q?r5+KIzJbhTe72w8pFpPXMTD2hapWN8ICE7clrc4Tw9TXsO/i4A9E2gyD730QUzc/c?=\n\t=?utf-8?q?EmydIbBqSmyiAJfhFKcn9BwDDiPKjTsTifgCJZeWnDhsRxChiKBhMNKYQ1ZdWYLpa?=\n\t=?utf-8?q?x6WYG+aLUO4ZQ77M2CvAxLeJFjWmUed7GDCkcTZ/7i+V0wQUem9wd+pibcYOlT13o?=\n\t=?utf-8?q?hnsmiRGF+OVsI5VYtpWS8+MaMyOoOUHvmjHM4yIeRt1KCguupndiFieacUspPpZRw?=\n\t=?utf-8?q?/AYHP9GXKx2H8Ns3tFQL1Gb2xffLeKxW3LaxtqB8+BiODdVjjv+99vCzjHmn+tItL?=\n\t=?utf-8?q?GGCCs2WoseGVWVBJwwdb5bfIcdYZPD+vDabY8yV/yHragECz9IFIQ626W+kPrO6aW?=\n\t=?utf-8?q?dRWvhbqbR04IytQVUo6khOwiz3FvqQ16apugB2P8U5T6Q7R5UsbY3YHGJZyjginN/?=\n\t=?utf-8?q?rwsZhiUedBEtkd9ONYyRK0w4ubQXRb/cSq4jSZX70e3hZmOaG7m19PYkt0JNv+5pv?=\n\t=?utf-8?q?VQIqGsAGydVCaRIPv1ss7t7zQ7cXEF8G4pLIds2XLYBNW4HqwhNXzpaQwMH2N5a8h?=\n\t=?utf-8?q?Ybm6zF72/5oDDM6VoC/EDJZYAKtaRnbwpIYgdAO5sBA1U0pM7ZtRU6Ps9yRNrXvZv?=\n\t=?utf-8?q?U65PJ4/8M+3Vbjdsz5WVcA0YP911QnxognsvpeCCdKJOorDVDihMjE+FPgbhxg5qY?=\n\t=?utf-8?q?SMfClvCUl7mGodGkTNBNK0LA9mwwctMYqOSGqWk9E3NuJAecy/73Q/m10RXLvWg9t?=\n\t=?utf-8?q?21xatbQ3bCAfh14b08GPoB4Z9FsnFVwi8/42vKZDsHO0JfiiW6r39qE7+soAnh08w?=\n\t=?utf-8?q?uj+lschc5Kp9+0UunP1aat0tpNVNu9Df7KQJZPkd179dH7Sfvy+UvHHo6GgfyD/ml?=\n\t=?utf-8?q?fSWXKeaPPQ05MVHGgwxGirHx3dWCcAWIb6W8EByq0v0B/d5XOMZDRq1k8shwQzd65?=\n\t=?utf-8?q?hCNV/gRVEIYzXhbqM?=","X-MS-Exchange-AntiSpam-MessageData-1":"hkEHAwqj2o7Yuw==","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 4bcfa981-86a1-4a25-b94d-08de9f84203b","X-MS-Exchange-CrossTenant-AuthSource":"BL0PR12MB2353.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"21 Apr 2026 08:58:15.9917\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n ktx9RbqoYuw68ba8/ggd6D6Q9Sj8M1pPQx7DZMCqwju01S+19yybF4giUErp1Qow7ncQ/Pj8JE/4AnRq4UDCkA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SN7PR12MB8059"}}]