[{"id":3679699,"web_url":"http://patchwork.ozlabs.org/comment/3679699/","msgid":"","list_archive_url":null,"date":"2026-04-21T07:09:17","subject":"Re: [PATCH v2 2/5] gpu: nova-core: use warn_on_err macro","submitter":{"id":93201,"url":"http://patchwork.ozlabs.org/api/people/93201/","name":"Eliot Courtney","email":"ecourtney@nvidia.com"},"content":"On Tue Apr 21, 2026 at 3:16 PM JST, Alexandre Courbot wrote:\n> Use the warn_on_err macro in the unbind sequence, and refactor it to\n> early-exit on the failure path as we will need to use the bar for other\n> purposes.\n>\n> Signed-off-by: Alexandre Courbot \n> ---\n\nReviewed-by: Eliot Courtney ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=kfRZpILV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-52819-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"kfRZpILV\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.62.66","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0D4p1gGdz1yGs\n\tfor ; Tue, 21 Apr 2026 17:09:46 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 73530300A25B\n\tfor ; Tue, 21 Apr 2026 07:09:32 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 44762387373;\n\tTue, 21 Apr 2026 07:09:26 +0000 (UTC)","from DM5PR21CU001.outbound.protection.outlook.com\n (mail-centralusazon11011066.outbound.protection.outlook.com [52.101.62.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id F2D3A37F8A1;\n\tTue, 21 Apr 2026 07:09:24 +0000 (UTC)","from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31)\n by PH8PR12MB6772.namprd12.prod.outlook.com (2603:10b6:510:1c7::7) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.16; Tue, 21 Apr\n 2026 07:09:20 +0000","from BL0PR12MB2353.namprd12.prod.outlook.com\n ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com\n ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9846.016; Tue, 21 Apr 2026\n 07:09:20 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776755366; cv=fail;\n b=dHuBVpsS7y+0xsk0HlExDCD4Aoa1c9ZaMWAYVHkLStPaAollsrfyG6RIPFREwGpEaskou08zgkFcuJPNfso6W7bBdFF8xKpHQTDI9b2TdbhWpEY1UTyV/EHVevZp1esnwcE1Men8TRZpJ6A+2Bhq6wsc1WeaHdsKoFh+At0u48Q=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=JoKs2YqtvcEXXdPDAmDbmCrwW8TbrIORw+Av3fa1qh5XSuqmZ7D3v7fJBSvBGsoq0DWEieR14xAYSzhyMvk/WUbWqtEwErslDURdohjbTGJgWvE03xQVmLM+UvSs7qV0IIoNMxyD0FoT2ALCMXr28DESKxHS5SNPS5PeiBQPj5nOkqUdnnS2reqTj8kVzvtT8foU0P6iFGbMOmWks+qk/B9TFwmC5LdzzkEppzrvzeJZZntAnfAnuGxuEvvaap4WZ4EvnUXyzRxLZS1nmW9sWf0RvRWLY5BwMAuf3SPrMFuWscfw/vKxr4DY7VgMGtNu6cv3r79alKvduEhZ20BiQw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776755366; c=relaxed/simple;\n\tbh=uIoJtRLrxX5tEDL2I0z7cJLH6JZn4XzWQ/42/UC6JaQ=;\n\th=Content-Type:Date:Message-Id:Cc:Subject:From:To:References:\n\t In-Reply-To:MIME-Version;\n b=tv44hO6aCZ5exBW6kjMV6xYHLF8U4EsCzrG9J2uqBNjUQ/rFgMqI2dvN3Xy53lgJMexYSaET8pl6rghPLGC7VSh4/fqyXtv339zLPV6HaDoy6Upwh2156YiwZkz+lnO4JkE54xyZg7BV3FAMbr1WITyXW5v91nglHhifmhjqSME=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=uIoJtRLrxX5tEDL2I0z7cJLH6JZn4XzWQ/42/UC6JaQ=;\n b=jshF5P4eLylDgRDq4gai7qlRc23oub3MSRu4s0Qcw4VZyyMOZgVChvJh7jUZZVc2CUtrhUEW3lql9tMBBtpnj6p4GYX0zkxBLELK0XVE7cGXL6AoRWVKGsRA5xoQ5jfG0taHvOcqbb0iCjGRvn+RhZqDU0Jvdao6bEk3uR2okvE0HGJjuwPu5eOUbfQqvpjF0TnVJmKpmo1Ok++FR+WivJQpz/ypg8oLn4hzWYQ3c3Qr9pkADBbO8zRzgsN316zIWmhHsf4Btwc4zZJuLbNEv4OSoj1/6xLjx8GCje9NOewACrYRkS6air+P8TVLIR2CRuAI9DvU+5jTP7O+bOaobA=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=kfRZpILV; arc=fail smtp.client-ip=52.101.62.66","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=uIoJtRLrxX5tEDL2I0z7cJLH6JZn4XzWQ/42/UC6JaQ=;\n b=kfRZpILV/9uvaAOexT/tF2knZOmuIabuzeqJTSuCmgrYd4mA9qLcSoMd0+DerSStql/6uW4eB2hpqTE8P1l6mfAOwPELJYFJ8Oo/ROt7D4P2Q3HREo6MFJjywLdIA+Fx488B8AHiU3ff19J0JDCwuhwCVdX265fIlAjWj0aGSm9EdEuvMoDYpqlXCh5HNp78bEU89TEW+XTsWcZL4JtzfmasAnrwmo96z6Y9dTQB8+H6I2XZe1Fh1gmgo3EV0K/c/cs0Ii4ZK7qLxzm0S+Ux52r5ZHRTA8x+uzzDV9dpzunTX/R9xY93/Rs0tv+UvGPY4ei2eQ+va5F1MEVzIr4DCw==","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=UTF-8","Date":"Tue, 21 Apr 2026 16:09:17 +0900","Message-Id":"","Cc":"\"John Hubbard\" , \"Alistair Popple\"\n , \"Joel Fernandes\" , \"Timur\n Tabi\" , \"Eliot Courtney\" ,\n , ,\n , ,\n ","Subject":"Re: [PATCH v2 2/5] gpu: nova-core: use warn_on_err macro","From":"\"Eliot Courtney\" ","To":"\"Alexandre Courbot\" ,\n \"Danilo Krummrich\" , \"Alice Ryhl\" ,\n \"David Airlie\" , \"Simona Vetter\" ,\n \"Bjorn Helgaas\" ,\n =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ,\n \"Miguel Ojeda\" , \"Gary Guo\" ,\n\t=?utf-8?q?Bj=C3=B6rn_Roy_Baron?= ,\n \"Benno Lossin\" ,\n \"Andreas Hindborg\" ,\n \"Trevor Gross\" , \"Boqun Feng\" ","X-Mailer":"aerc 0.21.0-0-g5549850facc2","References":"<20260421-nova-unload-v2-0-2fe54963af8b@nvidia.com>\n <20260421-nova-unload-v2-2-2fe54963af8b@nvidia.com>","In-Reply-To":"<20260421-nova-unload-v2-2-2fe54963af8b@nvidia.com>","X-ClientProxiedBy":"TY4P301CA0052.JPNP301.PROD.OUTLOOK.COM\n (2603:1096:405:36b::15) To BL0PR12MB2353.namprd12.prod.outlook.com\n (2603:10b6:207:4c::31)","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"BL0PR12MB2353:EE_|PH8PR12MB6772:EE_","X-MS-Office365-Filtering-Correlation-Id":"9fdf71cd-0f2f-4fb7-684a-08de9f74e8e8","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|1800799024|376014|366016|10070799003|7416014|921020|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\t6MHgLnYnDCh6CBBPJBQ3+aJiSM5oU7+uXqVPrH+BZKexgouZV4g+qGIjTWj3+gd0WKOjcfgNPLRdnD9gEbrMvsV32SHXBr4k6f7n4MWXbGdqccvdOoeJ2nClmVxqSfSDrDFOz9Ej/ky27IkCPJEUHnmLNYmiYwjMJv1/73ICC4IenZvZVp1f7l8a2u9SKZapatCJfLPC+kTliG0lCEWQijZt9wYI3HpMtK98DcQ20bKNbMOrFj5thp9HF1uGhOtW9qTWx2rgpJTr2Dd4/lEOl5nAtZcfQs00q8wcTmIsaAycc3BxinkTedOAQQSqEgq0dv+wKUYnS0kCLPxJShr9LpL3O3xEeRg5DZCh/TD1suTbX4eelmxJcgetVTQR9+cZevzzDO8j5+78wkJQCbGJ7KX4babCey5Xa1f7t12BG/V0twJf07LzJtgT9P+kK9mZJNZ7GR+hKOZZoQzglHNKaEYzHmv8asEVo6C6xY+CtbaFtaCuj6x8lVL43nqmQEzJUgj5xiZdG+4ocRG+zTz9/n3uE7M6GoITGGXEMhgKTI/O21EYbNCybLHo8I3VDKejdS/e/IQk4CLAbM4qKUPnsf3pw7e3S8imKJDgEl032OgyoLS3np4V6oE87bXdrjdCcaltEaIs3rHZSFBcleeDtGdhef0G6tztuySweA408DmePbGZFEZWXmdqM6xW6eg6Uw8V74sBXq6CgquDS2Vl/UO/VUdhM1W806P21EY4CR4KKs1BvXyVhLEyGTpoXJPrs7mJqA92QoQBf9twE607gg==","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(10070799003)(7416014)(921020)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"2","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?2qvwo7+BRxiBIiLzw7vlNSgfgYmo?=\n\t=?utf-8?q?cq3wE5FX/NvIaanAYX+8GeQJ9PWhPQHn8/FjQrsKPe69Y48aU2c3v5xPEjinP4Dh0?=\n\t=?utf-8?q?aceXOvUOr6oCP2GWtUWb+vS/qoP4lxnkxSnId2+UFkfQSvKG9DcsFiC2TuS9xjehX?=\n\t=?utf-8?q?kw0AGzsD5//V7pt4b9AUw3DjFnxylkfNQm8dv10ir1HOAiNL5naUysCxBKLN1vi3v?=\n\t=?utf-8?q?67Lx1Il4udp/8E8aUooi2ISLynzBbHPgARw7mGIHP6Bw7xZGVYtB6WYEu83/1rK12?=\n\t=?utf-8?q?eo0lqKhpgGGm+6d7S/zbmJu8tNb1elRLnKbajqdxURYhYYbkNE6jmKr6IIZhuvSFs?=\n\t=?utf-8?q?AFRqOn+3peIsP3zAhac/PKqkKRRTrft+WEaA/nqbZtKrLYhRqP81Br3f8lqK3hGS7?=\n\t=?utf-8?q?aYqsTi+BeAIL6203/qFgiIcP0wp0HcBUYKWT+KvJrGrNL2trMZrzEinGgraZjAzDg?=\n\t=?utf-8?q?RjNtTKLMLoQyIEWrkWsDSNqSw3p7bAn62XiqfDjdWTrEniV59IJ2xanqQIAoF33jg?=\n\t=?utf-8?q?VVLfxTsKlTBJApJd43rBX8DllTY+UWeg2JKwx85OZz0pUBKVpJISV32RnxCp9vQIR?=\n\t=?utf-8?q?dUX57V6cb6xxpkpCKcI88ccf92kVIGO0Qwzy/6x/LN9bxcrql6bcTFtlCCixt/1AT?=\n\t=?utf-8?q?djEfLIhxAC4fzMsI30eh5W4AZU2Oc/q3mo0jaQaWy+4TvAurkMy4Z6DGp1FUCPMh5?=\n\t=?utf-8?q?NgXoa9TekaOOhEzzZClEjDPc0rbmL2K7g9Hh+M5ojr8/q7d5k9tqr6K4G9WgRGr2o?=\n\t=?utf-8?q?yir2KmNpkprUZQ3lK+8VlG89EUES857W/0Em8Bqp3ctysXXFwQwJyij0shzJzHSVV?=\n\t=?utf-8?q?lZ9TFXHRXjXUmCk9ew35R5Zgc0U9uud4U7HvX3uKWMbxmfoUrH8YvrhES9IvX8GvS?=\n\t=?utf-8?q?Y4GXUyfQ8GvghAtt7Mt/HLmNYcnSnhSOs+EMew6RK70rCSQcXGYuvyTQJbqYcotxv?=\n\t=?utf-8?q?acxaqfmJlSczgxjxRIM+CK0qsTCwsf0zov0P0Gi3AvF8JxEWW1aVywlHpRtmZqdw5?=\n\t=?utf-8?q?wCauuuT8NxtMIoNWkL7Xo2Dcg86mIuHLCD4sPE8JBQBgSJ0tBV/0WAQd+2ovGrNfW?=\n\t=?utf-8?q?JWY/1FrDR1JvK8kvpjnhVOmKMbmJMD5unYGsGObsP6p5EPExJ2UjM3dTVzWuZEwUF?=\n\t=?utf-8?q?DaI96FVPCaDXYNYPEwxQCJUwP3vxRK+RsxWFV7m/JSg8hTAOzraub5475ebAFe86q?=\n\t=?utf-8?q?EyBOKaK03P+V7rAlbEqiwb279fV0xoW9ub9KS51+Hz00NjcvBfFkDpgK/RfpwPOhW?=\n\t=?utf-8?q?vrW9qVZxFwyW37Lzt5GIsQPNUDFsV3CwNwc4iE9Bqn0QvkapatfPlovXIlZldmFod?=\n\t=?utf-8?q?RuWbWQGfuorOzBHpxKe9SXpyVUzZGKXjr6Mcdqce/FrKXvWQOlaqYn8am5DMRS4pb?=\n\t=?utf-8?q?ZzD3O+VDW/lKRrOSI2ATbiZ4sLJccp4ECv62oI4009+3Ivlq9/+9at6H758GfYRMB?=\n\t=?utf-8?q?EoV3wWwY5v2/6ny8/5iBbn86IOpoIdOw5ohkYfPYehKHnnnB7V40XkqzDN577/TTA?=\n\t=?utf-8?q?gw7guMj5/b3kzYgTWEAm3c69bS+uZFX/LwJzFKgXTropI5lNM22rZZQI19RS5FCOg?=\n\t=?utf-8?q?KYkhKhW5Ww6MleuoyIOfn9NZBhp3jmxmU60clU1I08UWWM3Z1pmr7ZQEq40YQoaAz?=\n\t=?utf-8?q?cEb97ceIU9Crd1x/HWLgNDTHx8hN47vEn7y1YYaURp+OEkUn/6FNeNmND0hqCLhFI?=\n\t=?utf-8?q?6p6zeYYzTBPK9dpXQ?=","X-MS-Exchange-AntiSpam-MessageData-1":"XMJgEjdKF4onpQ==","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 9fdf71cd-0f2f-4fb7-684a-08de9f74e8e8","X-MS-Exchange-CrossTenant-AuthSource":"BL0PR12MB2353.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"21 Apr 2026 07:09:20.6982\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n KRxUTgNo81n1ETdEYob1bNwv2RBTV8B9qZwfqgzViwVTprKqzJjo5H7kUmqefVYYTA4MBURcp08WY8rXxC0cCA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH8PR12MB6772"}}]