[{"id":3679700,"web_url":"http://patchwork.ozlabs.org/comment/3679700/","msgid":"<DHYN6DTR4KE4.1WN4EVEZ26WB2@nvidia.com>","list_archive_url":null,"date":"2026-04-21T07:07:47","subject":"Re: [PATCH v2 1/5] rust: add warn_on_err macro","submitter":{"id":93201,"url":"http://patchwork.ozlabs.org/api/people/93201/","name":"Eliot Courtney","email":"ecourtney@nvidia.com"},"content":"On Tue Apr 21, 2026 at 3:16 PM JST, Alexandre Courbot wrote:\n> While we already have the `warn_on` macro, a common usage pattern in\n> Rust is to check whether a `Result` is an error. Add a helper macro that\n> allows this.\n>\n> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>\n> ---\n>  rust/kernel/bug.rs | 10 ++++++++++\n>  1 file changed, 10 insertions(+)\n>\n> diff --git a/rust/kernel/bug.rs b/rust/kernel/bug.rs\n> index ed943960f851..2fefc0aeef81 100644\n> --- a/rust/kernel/bug.rs\n> +++ b/rust/kernel/bug.rs\n> @@ -130,3 +130,13 @@ macro_rules! warn_on {\n>          cond\n>      }};\n>  }\n> +\n> +/// Report a warning if `res` is an error and return it unmodified.\n\nnit: \"it\" -> \"the [`Result`] `res`\" since it somewhat reads like it's\nreturning the error\n\nReviewed-by: Eliot Courtney <ecourtney@nvidia.com>\n\n\n> +#[macro_export]\n> +macro_rules! warn_on_err {\n> +    ($res:expr) => {{\n> +        let res = $res;\n> +        let _ = $crate::warn_on!(res.is_err());\n> +        res\n> +    }};\n> +}","headers":{"Return-Path":"\n <linux-pci+bounces-52818-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=C7ZURTBM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52818-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"C7ZURTBM\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=40.107.201.4","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0D4q41q5z1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 17:09:47 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 83BC5302D0A5\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 07:08:01 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 24648311C36;\n\tTue, 21 Apr 2026 07:08:00 +0000 (UTC)","from CH4PR04CU002.outbound.protection.outlook.com\n (mail-northcentralusazon11013004.outbound.protection.outlook.com\n [40.107.201.4])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C45F5284690;\n\tTue, 21 Apr 2026 07:07:58 +0000 (UTC)","from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31)\n by PH8PR12MB6772.namprd12.prod.outlook.com (2603:10b6:510:1c7::7) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.16; Tue, 21 Apr\n 2026 07:07:54 +0000","from BL0PR12MB2353.namprd12.prod.outlook.com\n ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com\n ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9846.016; Tue, 21 Apr 2026\n 07:07:53 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776755280; cv=fail;\n b=jWkkFB8+xjs/fbHjBjB/TTCYN7EuQp3+MBhTy+vfmG9INHy5rQnXx5fsS5ztHOSPkzVLxc/90V1m+HxkhPigqKZMi8I0ge+LXDQaprJXRZ3ou/Jc4n3I/WwxlpnmBX+Bk9nt20dAPau6R4xSigWepVavy4UO3Kd0II1s6Pcj0lA=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=kTZ+lRdXpDgtawHLNqlz/sfVEhTMM75mkUyDND4WYep8/uclfplYaDHjE4UqH4/RFxPKz+t3UC+oW2XKS89dQR9EgItCYkC9sQHL1c//tLUc43FJbxmeZOSEaHNiLrjTOOZNm17Mw6ZEQBf5aXx+gmWMsmHDVzBsRRkHvzYKKQpemzaOTxyaZSNOfRoSYCJIJnFJxVfdT2bdYZRE98J3WsnI92Z0v2/5Dlxtorc923xrGWK1VmdNPxlVgi4vBxllhVAatqjIRXA39pilv6lTipEjx9qSPZhtDpDFHRHMBgvSUK+37MIcVtv+TburfHL2BJSqUlJ/jSc1rvfzSk2FUA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776755280; c=relaxed/simple;\n\tbh=WIZYzeH6tGCXJMmeU+u+9hZuqscQIC3tYutkUZLs6gU=;\n\th=Content-Type:Date:Message-Id:Subject:From:To:Cc:References:\n\t In-Reply-To:MIME-Version;\n b=psmwlf86YIcbjOne28jNbPypjMzOzygxMyXXtT1Bo46x/uuT+k2aFbQROwDbf0G/VQbkbr//olB9irmHQN93oG4LQo0ATJ+1FhxfUiYqonpEXtXRAj3rJXcKziomzx9JFAX1Fnqfb+8Md4Dw68aM//STEU3Y2MK6YCazyQzCIis=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ek+vlvo0xuKoimHR5KbPJcTEB++ViUciv8U1hCvCUYo=;\n b=ih0fVgCFfzKgTHeiL2/A8Yw1lVC+k70qyRZDPaNjx2RZKVO+E/FmQf8hYx9hiD82OnoGsHV+joVjMLcOSIJ7rsyZcVy+sbFsOQNIZCgA5K3doYSyZhcT2QudF56LsqfnQ3TX84fuXJRxCrcM+t2hc9SeHGyKBIFbAyZey+7QE+JIkrBpbVjGNaFznQvr60/Zc2HGnKgEq+wzqKp78J/6k9OcuPwbB9z4U3s6LOWKPcQBXzpc7LQ2IbLmTrasc6Gzcob7YmzUQEs2wa04FlAzdiFIBTIhCxk07TovwcVCa+Mp6k/i1h5fbGANf/eBSl5OS8u5E1nI+jyc704uB00NuQ=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=C7ZURTBM; arc=fail smtp.client-ip=40.107.201.4","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ek+vlvo0xuKoimHR5KbPJcTEB++ViUciv8U1hCvCUYo=;\n b=C7ZURTBMS9E4ElBBMwZSy0XdUPyDfMDxQYgqu26JzqPqO6VdSEnar3y4IUSnGLfvtDxD5HMbrPrTIPJhNViKUrjD/O9FuHM1IPWcv+9cGjy8rwxp7Ddzq/Qge2+FiQcQPo5uwVidkESQErOnzRsIBCId+K25eEofmv0GiKsIV+OSBUCHj6zI857y22m04Ry00Ixpo3CmjtfkITStPoT9vjH/1M4AAG5dz9FwkMKFnmt5UydLZTuM252NegJ3C3BqjPZW0zYRd833ZAqYXgvdZFXj8UsaFQKC+vDj6Jwtg/Gl61SKEL4P+g59NuTKljxchfbkS35GQU2qdL8x0R9pYQ==","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=UTF-8","Date":"Tue, 21 Apr 2026 16:07:47 +0900","Message-Id":"<DHYN6DTR4KE4.1WN4EVEZ26WB2@nvidia.com>","Subject":"Re: [PATCH v2 1/5] rust: add warn_on_err macro","From":"\"Eliot Courtney\" <ecourtney@nvidia.com>","To":"\"Alexandre Courbot\" <acourbot@nvidia.com>,\n \"Danilo Krummrich\" <dakr@kernel.org>, \"Alice Ryhl\" <aliceryhl@google.com>,\n \"David Airlie\" <airlied@gmail.com>, \"Simona Vetter\" <simona@ffwll.ch>,\n \"Bjorn Helgaas\" <bhelgaas@google.com>,\n =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>,\n \"Miguel Ojeda\" <ojeda@kernel.org>, \"Gary Guo\" <gary@garyguo.net>,\n\t=?utf-8?q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,\n \"Benno Lossin\" <lossin@kernel.org>,\n \"Andreas Hindborg\" <a.hindborg@kernel.org>,\n \"Trevor Gross\" <tmgross@umich.edu>, \"Boqun Feng\" <boqun@kernel.org>","Cc":"\"John Hubbard\" <jhubbard@nvidia.com>, \"Alistair Popple\"\n <apopple@nvidia.com>, \"Joel Fernandes\" <joelagnelf@nvidia.com>, \"Timur\n Tabi\" <ttabi@nvidia.com>, \"Eliot Courtney\" <ecourtney@nvidia.com>,\n <nouveau@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>,\n <linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,\n <rust-for-linux@vger.kernel.org>","X-Mailer":"aerc 0.21.0-0-g5549850facc2","References":"<20260421-nova-unload-v2-0-2fe54963af8b@nvidia.com>\n <20260421-nova-unload-v2-1-2fe54963af8b@nvidia.com>","In-Reply-To":"<20260421-nova-unload-v2-1-2fe54963af8b@nvidia.com>","X-ClientProxiedBy":"DUZPR01CA0180.eurprd01.prod.exchangelabs.com\n (2603:10a6:10:4b3::14) To BL0PR12MB2353.namprd12.prod.outlook.com\n (2603:10b6:207:4c::31)","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"BL0PR12MB2353:EE_|PH8PR12MB6772:EE_","X-MS-Office365-Filtering-Correlation-Id":"2a9510ab-37a3-40b5-a942-08de9f74b4fe","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|1800799024|376014|366016|10070799003|7416014|921020|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\t5VqQ5/ISk2lz6P4A388i+pAqikJtv1QrvjbB8aS1IF2K/lXoDcJ8NrQOcpBnRfo2HRNkDKJHIxkJpbVA52bTvPBr1LSiiVDcqKoWI+WnLAXPuJ8G+gB7frP95UQgULP79BjGKYj0OXLXVbJMPLk3/VgZlH4SU8eyV2dSrm+N3srA6ujqfYOTLyApG5oUR7d2YtwpRIZy+BEb4mAFBpBewbK9n6yisvkmFPhQy494V+XhwCgQH0owoheKIQX09KVmgxKBtxreBq1V5CzOTAej8V8ZfS7uVb7S3fwmzFGEr0PSgn7M3CMs/mLN3PGfbxK6Opw9yDe83ZIILU/4TSI18rZBDjQhUs9rU4V+RijcqTehvMAxOBFi0L3ijnqNzhgEyfDadfHgPJ3km/cGJ4h3ywTcC8KiAKlRoeiCJPVcjud9vQasJDO2KDC3pjL+ByeWtoMop50o29MtETjzVe6l/5prqP0zIJkivxReibmv7zKUc5sYCi/kiz7wqmpPZTsaQFoRwEdinuvnB9oDJr4+ZudZDH2AVUqTBu873+aShpErxot0l9TaZcpeBlpraERVL1HEaKAThM0fJKDihpzKCmRRiNYaQXRqgXq4lr3V1rdAY/OicP2Bi18HLyxOTfdI1R8H9yxa4KMZ9Cpt8VDkd824ileSWlmfo7yZgfBYFDKyYeCjSC/RkXLLy8TQVZJYdY4gBHTLRhJxuMZQq77pKdGrnZdi3UMqSsHruB5bU1cOkzNv7tgSwygM82hTwL7dxuN8nNoOGn1v1wpTZPKtPQ==","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(10070799003)(7416014)(921020)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"2","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?VIQ7e3ESdsF2ZPEPdFUTUQVkoWrb?=\n\t=?utf-8?q?5DSPG/j5rD/ASRDKaWfYPXR5MQLcVBUsHbmSRMi3txVncQA/6W8IpZucl5C0Gyue/?=\n\t=?utf-8?q?yDWyiVREsCGG0wRVUoIX1jeX1TmvOCEeTAXwDieh4OcdDoRDUN//YXrnuKdtQgJMo?=\n\t=?utf-8?q?WLCH40m/hu460m2lrg3kjqhqZvaTHvBBwmBhbOK0YIpJyoR1+ku1XK8XibdJvAoGn?=\n\t=?utf-8?q?+i7ccgE3UBVtb9QpIOLQIjQWAb8tNESL0i/d/20OQdV+eG6XOFnEtwXXlrzrGgmrT?=\n\t=?utf-8?q?e1pqY08yhJVMdW4AWk4SS/s02dAapBL/lxhx4eyzsYepYlbvLzcBnjPizpfHRW/KQ?=\n\t=?utf-8?q?mPTqTiqNrsJ2RiU3z5okjDprgXqrLIiH+9upIfh+nQ3rrBXQdopoaks7UZ2IZUmqa?=\n\t=?utf-8?q?JFgBXfwZX6hvcBi0lVmmcoF3RPRphg1QyHEh7owbZCg8P5k4f+jiLme9xVg63vxXA?=\n\t=?utf-8?q?lWfApF0fqQT6lxBy+76H/7gyzVl4h6x0vlcps1F8t918WIsL2j9TJXpIQOTDJT2US?=\n\t=?utf-8?q?8edEsHLeUNalM4jhM1Xu/X52aUXvleyGuU/vrYqLBNYIXs1fy2tzdRw4Uizd9hqtN?=\n\t=?utf-8?q?A2TbYz0ciCQp4i0gKcnnPQy4ph0RCU89KLbckDYTBkOEUbUQBXeHQ4DdaPRyl1iZM?=\n\t=?utf-8?q?AT1TYUYEdPCriaMMI43i7lrPIB6y9n5gsYlbqvi47yk2Ll6rzxy0pUnACm4DXID6R?=\n\t=?utf-8?q?g35YPMYzy58V5OcUQG2hYW+IINA0Jw5aYvlKjliPi0ZmDZBqW1lZqNRyuTePG5zE8?=\n\t=?utf-8?q?cz/gFQDUSTvV/a3sO0Zma4uA7i53N6sHLoSjJfLc3h0IILLTmhM54s8EVGyCY/77F?=\n\t=?utf-8?q?5MMsuvvN9UFycY7RzsgTxawf/1Aj+Jpdw5HUjwBnKbgII58ZKVv/+vZWilugQepym?=\n\t=?utf-8?q?+qtTVbEcRfYIJN6w5VuqBQEKJhCdpHOuy/FewRkQQ9J719YioqKvBRkuRSEhqnrQr?=\n\t=?utf-8?q?7qKnFhMuHcymcevct4Zi7kyFmVNlcU8H4Umfb5AaNnN5UckDjEkRqYC46RyHHSENt?=\n\t=?utf-8?q?SOzrz7mCp58s2rxpgXyOOAxDHLgSS64f2QZwRQgJrNbSppSgXSbD1V0MOEqhmBXy9?=\n\t=?utf-8?q?kdgStiVbUuTWpIudOMKfHy9KP09pmOSkiDYQxuMYNip9yECHfTGXM0oQNm+AaNyin?=\n\t=?utf-8?q?ej4DgrE/rQl3uvPMj8kLV+7njSSvPeYPCZYo0wul1wuf7JFHUugcZHm3IyfwT2vvW?=\n\t=?utf-8?q?duC5xCJbYNcwolrg//ba+vDmqZGpH0p8vPpwn/gZ0/mD4QQIw+WGJXLR4LgWwMWTt?=\n\t=?utf-8?q?Lak/c449JNC98EbnH6dLVz7HjP1tmv4JvFGISxoaBM7d7B/e98w3dl4pSPSwI4/oG?=\n\t=?utf-8?q?VC036WkXDp8I8ku1xneyjTI7MB+QZMQNBiJDV1czgl653BytQDa3QAY7+0qGQYY5Y?=\n\t=?utf-8?q?EQaZyArE/7wEjAL818BTb4v7sdKH4jP6OZheZIZFyQJlYlP1UslBq/pkgHD3n6sGD?=\n\t=?utf-8?q?JRkCUUi43I6bEE4/qW71lCM/teV4gMhdHxHba5DQ3bxQZzx2pWU57IbbcE1WyILL/?=\n\t=?utf-8?q?bGSZneiCpLN6FtJvCenL3j3zDzSceM2UMuSHogm75EANIjKjAMObNCLyXTfV7uCEV?=\n\t=?utf-8?q?sYD68E35iHaWBOiSbciqC3jjZmGzYAUQSf1wrFjdthEtiSEN+FhVLl+OSBvA/t5Lk?=\n\t=?utf-8?q?rO48J6P2yHhf/Nvlkxfyo4DK02cKoOy2wSGo5M1ZWrRI5sQO0+hH9lASxqs3nPi6x?=\n\t=?utf-8?q?LrukpEjlA3qy4Tbig?=","X-MS-Exchange-AntiSpam-MessageData-1":"G9Z0Y2LnAaBCtQ==","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 2a9510ab-37a3-40b5-a942-08de9f74b4fe","X-MS-Exchange-CrossTenant-AuthSource":"BL0PR12MB2353.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"21 Apr 2026 07:07:53.6042\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n yeKs/dd3bgqL7JA0eXX6+M9l3WB/x6i3MsmLrtWIprDrHB6vZ3ugh3PzTIFWSK0pjQD5a/VgRgRU3mh08vJrlg==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH8PR12MB6772"}},{"id":3681387,"web_url":"http://patchwork.ozlabs.org/comment/3681387/","msgid":"<DI0I3TH8B8ZZ.2118S8MDUHG@garyguo.net>","list_archive_url":null,"date":"2026-04-23T11:34:41","subject":"Re: [PATCH v2 1/5] rust: add warn_on_err macro","submitter":{"id":76823,"url":"http://patchwork.ozlabs.org/api/people/76823/","name":"Gary Guo","email":"gary@garyguo.net"},"content":"On Tue Apr 21, 2026 at 7:16 AM BST, Alexandre Courbot wrote:\n> While we already have the `warn_on` macro, a common usage pattern in\n> Rust is to check whether a `Result` is an error. Add a helper macro that\n> allows this.\n>\n> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>\n> ---\n>  rust/kernel/bug.rs | 10 ++++++++++\n>  1 file changed, 10 insertions(+)\n>\n> diff --git a/rust/kernel/bug.rs b/rust/kernel/bug.rs\n> index ed943960f851..2fefc0aeef81 100644\n> --- a/rust/kernel/bug.rs\n> +++ b/rust/kernel/bug.rs\n> @@ -130,3 +130,13 @@ macro_rules! warn_on {\n>          cond\n>      }};\n>  }\n> +\n> +/// Report a warning if `res` is an error and return it unmodified.\n> +#[macro_export]\n> +macro_rules! warn_on_err {\n> +    ($res:expr) => {{\n> +        let res = $res;\n> +        let _ = $crate::warn_on!(res.is_err());\n> +        res\n> +    }};\n> +}\n\n\nI think `warn_on_err` could just be expressed as\n\n    res.inspect_err(|_| warn_on!(true))\n\nBest,\nGary","headers":{"Return-Path":"\n <linux-pci+bounces-53041-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=garyguo.net header.i=@garyguo.net header.a=rsa-sha256\n header.s=selector1 header.b=tTFsGxiv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-53041-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=garyguo.net header.i=@garyguo.net\n header.b=\"tTFsGxiv\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.195.79","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=garyguo.net","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=garyguo.net","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=garyguo.net;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1Ysr1ThVz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 21:34:56 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 67FC53018AC5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 11:34:47 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C5D533E92AA;\n\tThu, 23 Apr 2026 11:34:46 +0000 (UTC)","from CWXP265CU008.outbound.protection.outlook.com\n (mail-ukwestazon11020079.outbound.protection.outlook.com [52.101.195.79])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CF091FC8;\n\tThu, 23 Apr 2026 11:34:45 +0000 (UTC)","from CW1P265MB8877.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:27c::13)\n by CWXP265MB5180.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:193::7) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.21; Thu, 23 Apr\n 2026 11:34:41 +0000","from CW1P265MB8877.GBRP265.PROD.OUTLOOK.COM\n ([fe80::6c9e:93c8:10db:e995]) by CW1P265MB8877.GBRP265.PROD.OUTLOOK.COM\n ([fe80::6c9e:93c8:10db:e995%6]) with mapi id 15.20.9846.016; Thu, 23 Apr 2026\n 11:34:41 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776944086; cv=fail;\n b=k6p3Q78s4iOJGm9SBtOg0of1pZ99X6Q7Cw+bYjbdavCMIeTIhjlE/slQtwvSIUGqod45vEfemXAYOpngcDJ+HQKb4iR0nHFNzRoUwsjNBzHrLk9Boi6IFNHAbp+PSVTIur/2PI/SYk2KSPArtrekepQptpuxkI99C6qyttk96R0=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=d8HC/UMaKQIaiYAK9ehiBlBSVYRmXqspVhFEIHgsiiC8T9GxXuKdSo7EdB5uy94AW7WnEpMyOP1jnf+SNm+6PGxc0kv7+nEUxJE+/6hUwNEZ/39wNV9eLXgz6W5n0sXhVl+wQWmInHRRxUduEysLji6IWZd5qgq1D8WC9VFXi+8ccL+OO30MKqGnNR8Yd2ruaVHnTFaQ3zStPh6dSdeT/QJPO9apbIuVKhUrPx/uxzLEBwsUYaQM9i5v9YjqZeAGVhXZ7yAVNofYRTLvVDDiEgkc8bVPEBMY4urUBf8HL+dulqa60a1WMdUUMEVzK72BKl2I8gyUZMi8VQPbuOFxtw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776944086; c=relaxed/simple;\n\tbh=lMDNDe5CGVrtCAo+Pqv0CHn2z/EIBB0kThPUnNgO9Ws=;\n\th=Content-Type:Date:Message-Id:Cc:Subject:From:To:References:\n\t In-Reply-To:MIME-Version;\n b=nNJzSZbJ7Vf3+XKgFRcdW1DUQ8V8cVYcIC3T4tuNkBL8BOoCIfUrhXLH6umkuDdvCMIe3HpzKA3yyP3PYrLb66XTgvrly/1A4AuES92GBk2Dv261vFVUQrlTv4o+Pu4o4mzGFbwHX6VZUyy/F8cn1DIh5ODFydxVJG3srnpsQCg=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=c7DplJiGF3GFUHZwQB9/ZjsSCLIFOsIFt5Q424beC5U=;\n b=jX2o6Y6RdYdwLFhI+3ZRD90aySDqmsZaFXp+vTRhmZhGxOcBrw/oQVcGNN5v+ctwDIWcG5apvIpjlaDiCZVsnQQmPrS3la5vHD+8/C7Lx8HqTr4c6HXpNNl4L7EEpP+Twp/CqeR+f3PH+vS3PiwOQ9mTT5TrPcJKkXmpu1deqKI33oZYfvpuEVzP6Daw6Pp2M+sfvgktVEJYQJcIJYajDqmBGyMmR9f1znuHFYiBJ2wM/0y33qgxcU4mWkn6eR1PN2d8OzKOD/yxBBMMQq+mXrgZgdmG6u/M8MB+bu7DKa+tPyNl5yAZiFhe+VM9zFy4k30kTL+OEWLJXYdLNBDyCA=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=garyguo.net;\n spf=pass smtp.mailfrom=garyguo.net;\n dkim=pass (1024-bit key) header.d=garyguo.net header.i=@garyguo.net\n header.b=tTFsGxiv; arc=fail smtp.client-ip=52.101.195.79","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=garyguo.net; dmarc=pass action=none header.from=garyguo.net;\n dkim=pass header.d=garyguo.net; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=garyguo.net;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=c7DplJiGF3GFUHZwQB9/ZjsSCLIFOsIFt5Q424beC5U=;\n b=tTFsGxivf5dWYm2kIha8869MgP3HgkRQDcAQzA2Je8AvcH/vTkLiMy/OXdxVmqe1/C8J5hoqoONLNjKaTr+2M++e0AQXUQkUkEWYiCaEy5vvWWuPrFJPuFqZwYwm2zZDetyvSSnV0EPKhDYX7O5A6F65RGqvGgc+8JaP2HctSmE=","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=UTF-8","Date":"Thu, 23 Apr 2026 12:34:41 +0100","Message-Id":"<DI0I3TH8B8ZZ.2118S8MDUHG@garyguo.net>","Cc":"\"John Hubbard\" <jhubbard@nvidia.com>, \"Alistair Popple\"\n <apopple@nvidia.com>, \"Joel Fernandes\" <joelagnelf@nvidia.com>, \"Timur\n Tabi\" <ttabi@nvidia.com>, \"Eliot Courtney\" <ecourtney@nvidia.com>,\n <nouveau@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>,\n <linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,\n <rust-for-linux@vger.kernel.org>","Subject":"Re: [PATCH v2 1/5] rust: add warn_on_err macro","From":"\"Gary Guo\" <gary@garyguo.net>","To":"\"Alexandre Courbot\" <acourbot@nvidia.com>,\n \"Danilo Krummrich\" <dakr@kernel.org>, \"Alice Ryhl\" <aliceryhl@google.com>,\n \"David Airlie\" <airlied@gmail.com>, \"Simona Vetter\" <simona@ffwll.ch>,\n \"Bjorn Helgaas\" <bhelgaas@google.com>,\n =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>,\n \"Miguel Ojeda\" <ojeda@kernel.org>, \"Gary Guo\" <gary@garyguo.net>,\n\t=?utf-8?q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,\n \"Benno Lossin\" <lossin@kernel.org>,\n \"Andreas Hindborg\" <a.hindborg@kernel.org>,\n \"Trevor Gross\" <tmgross@umich.edu>, \"Boqun Feng\" <boqun@kernel.org>","X-Mailer":"aerc 0.21.0","References":"<20260421-nova-unload-v2-0-2fe54963af8b@nvidia.com>\n <20260421-nova-unload-v2-1-2fe54963af8b@nvidia.com>","In-Reply-To":"<20260421-nova-unload-v2-1-2fe54963af8b@nvidia.com>","X-ClientProxiedBy":"LO3P265CA0002.GBRP265.PROD.OUTLOOK.COM\n (2603:10a6:600:bb::7) To CW1P265MB8877.GBRP265.PROD.OUTLOOK.COM\n (2603:10a6:400:27c::13)","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"CW1P265MB8877:EE_|CWXP265MB5180:EE_","X-MS-Office365-Filtering-Correlation-Id":"0c8d6c5f-370b-4857-ed36-08dea12c4f7a","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|7416014|376014|10070799003|366016|1800799024|18002099003|921020|56012099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n\tdmnucVv3RvQrvaiFg1A12ABJC5zaKu7Olgf56p6jOVIAUBb3p5yFwzohBIrHWBDv30MaZBSEuCoWCnmurdaWmhQh75sCgV/5LELw2mEmvBxggBB4Xss9h0k3Dgb+G2x6WekhWnLmHkguFQ39cUSxpgx8pL3BfdLcGqEjzM654qBwgPlHs0H7ijcIP3bXVp1TD2W4cl5XdDIRW3a5x+QmzLoUH7LiyQzrHziw71ch3ypR5V5hHAKWzgR3wxGdkCZ15OISnE+/sbxNX2bZOi3VpMaoolrcAjFm962zExnOChxBv4UMpVkD1Q69SUHPr0jbLjdHhtgBSpmvfoR1momdOhGcfGa8+ihKIqn3BcYZyAny+2HythvrXJCox3eF3Y/HEpvX1H1ojAeQgWsKT4YRq5W3Cx2Fx4tdCi5FmV0OwqhXvwn+fgb1WJTzEGJhPzcKDaimy/SFLz1Kw7Eq/yK1ORoWhMDXSCb3A9eIzhiE1H5ZUiRnm4A6vA4W5wqbxX4pSbkl91Jv4h/K0p6UGGAtrdQ89i+tEuCz4g/ZQrUpH1LgQ1ar93bHW+VXZ8pvvqIgLakWs3gUGLnqRjcf+uLNruxWwdnb9g9lgTxdFHaYpMuCg6++BDCglH4WUhZAfxBVBJKtKti3nrOtKDNFhpKIQSVMrq+S5ASxd6+Y6rQkY/Dv4DUaYUDybEIR5t9eSB1NOUFWe02WSf362lln7nmCnMtTp6+IUzYymYMDgupG0x1qxdfECxjYXLXV4Vm19+Kccmh4zE/ol+9Z2o1J+u91Uw==","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CW1P265MB8877.GBRP265.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(10070799003)(366016)(1800799024)(18002099003)(921020)(56012099003)(22082099003);DIR:OUT;SFP:1102;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?az/M2lLb73pinVqH89kwkOdbg1cB?=\n\t=?utf-8?q?pfDPC1os5eCklYc8ppRFP9nS82611CUjVzYLq+HpyjpXW/3aB8TddCvc8EA2B1Zix?=\n\t=?utf-8?q?HPQZ/kESGlMWdHMIS3hY02llx6qzxTsI3lxCfQAoMgaupoo6u/T0P3emuoE/a+4Ne?=\n\t=?utf-8?q?lCo6irGQyMISFxVXQj0pRIiVFiB3UI+3THP2j9XdVVA0HYhJCLvfigp2nJy3hPfMW?=\n\t=?utf-8?q?9cp1tIWLRHq61tDzFf8hqn464zxlHeq5WOToAQWQe1ZypzE5pXlLsp0Ud2Z1jH026?=\n\t=?utf-8?q?pavfUAY23CIBsaEK+I6KYVwNpAYaCv31Wk3I5FgU0390Xfa4JIIflSG0++6LjBhP6?=\n\t=?utf-8?q?AnH8eTKabCsT9KErVhI36FXOoNnTRf0EsbEDWfOveetVRKYwnnl4QrR+BvJWN6N3N?=\n\t=?utf-8?q?0JitxLFX4UG+B6w5il7Z108GZNIBYJuOZ5v/gD1bRz5gtzPj/KGgJP8aI69LehUe6?=\n\t=?utf-8?q?ldNyxqFNmgqOc1jduUDUs4L2tWVPsHZYjQXCHkHe5XAv39PA+MWgAjbNotqOWToQ6?=\n\t=?utf-8?q?nfTRphDWx2QCB1PEskr87opotIF3x1rmG5inzLGucnEKI12B14pjxylp7GVgPVIyH?=\n\t=?utf-8?q?TOxXVJQN37bwOJK+RVr94USTppZPwn5493eomk9PhrTBqbyzpQD7rW633AOcGqEYZ?=\n\t=?utf-8?q?P6pkHQD4KdWCKDYhtk4H7qRSCfJlomHjiYnvaQgJEF8vbVnlC2VCTpCSruhSVM/z5?=\n\t=?utf-8?q?PQ86bWApPdAa86Lw5oCryYcsrFWnmjUZNurn6T67+mhJCONR+avbQl3lv7wcZxZkW?=\n\t=?utf-8?q?0NTS48RKdzNgD3e2Yye0uQy3K7/SeQxfdItRYO7vdnSrLzIXOaVbm3cGD+XGvN4ho?=\n\t=?utf-8?q?mLnRJ+Fr55IL2OjWDPwKR3DIgELZqi5K/JmcQ6JwLNhQQyLW5Qg1N2UmD29rZhXAJ?=\n\t=?utf-8?q?XPMgbb1MYJh0u2w3w1RZsgAU4FZN8FjJQ6V9CFfrEmnYnuO4WebCrKHyxD6kb58jx?=\n\t=?utf-8?q?6ycSbYv3hNrNabVUIw05Guh5xLRWfnINs7tIEN8vNp+nmSUIH4KHIefu7j+9pw5+0?=\n\t=?utf-8?q?Ae/aQ0vd/SzIceSpm6T4N3OSZtPb90HoW7qP0ZOIT+gaNXEUvW3S/gFDy9La7NmVm?=\n\t=?utf-8?q?cmFywNRrealUp2/ejrHsehoYxb+ajNQ8nrzwYUFIESP3nJKWSsUQ5HBt5FS6TZ8iR?=\n\t=?utf-8?q?PuK15gz/+6mRCN4HZ6/aIQd25rwLyloyplSyDDXUaJwJ7SuLMJVJ+nJO0+NA5qtf0?=\n\t=?utf-8?q?7vPR3+B98BM1BPA2v37K/g5vuIPKF6We4H44Au+4ZvAPYQkCm4O3d/5TCrBd8o0IK?=\n\t=?utf-8?q?6hl/60ucEr2Z05duDZeiRMElXejFr10pFcAalHKb81xxWvXQzZ8oxhiyNQo8x/Tj9?=\n\t=?utf-8?q?DSksf8MnzVMAOucXK9auLRYRtEoHd1AfX4wUXA3j+QMogOzKtR/QC7DZiNfdDk70u?=\n\t=?utf-8?q?gj25mspX+4EwKMwhA+ImLUZV/9ayfAr2megaV5nXi9yKaYEF35jlNUXwfgS+A+jMs?=\n\t=?utf-8?q?O5XMY1MVH9nESmgM+pyy9mOZgBvJHtdzYgLbbiQJ+cRis4l7R4Z0gEZ9wz5ZIYGZI?=\n\t=?utf-8?q?fh/INPgyFF25K2TuXgoZqYCAeoLm7Cq4swvbQK5iUAeVcA9OjxUm8wkwq5GzThm1F?=\n\t=?utf-8?q?VgTkaQ3nsXbJZ+vsOzLDdn3J4mGxYpk3JXWPfREp2KAIeG3B88RSkK3IgLR0aM7je?=\n\t=?utf-8?q?Jb91qxfxHblpF2s3qdf37/UTQouNY4oQ=3D=3D?=","X-OriginatorOrg":"garyguo.net","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 0c8d6c5f-370b-4857-ed36-08dea12c4f7a","X-MS-Exchange-CrossTenant-AuthSource":"CW1P265MB8877.GBRP265.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"23 Apr 2026 11:34:41.8296\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"bbc898ad-b10f-4e10-8552-d9377b823d45","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n us2Hgn3qe/+Fk7ICmqizx5qWCA0L++4sAN3Y0yBTfiorNm8isBkwvxsp88MukQrFwiBOCjTKwS76bFDV9ffz4Q==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CWXP265MB5180"}}]