[{"id":3679748,"web_url":"http://patchwork.ozlabs.org/comment/3679748/","msgid":"<5pr6n639-r103-q404-898s-o556n552495o@fhfr.qr>","list_archive_url":null,"date":"2026-04-21T08:50:04","subject":"Re: [PATCH] sccvn: Use build_bitint_type in another SCCVN spot\n [PR124941]","submitter":{"id":4338,"url":"http://patchwork.ozlabs.org/api/people/4338/","name":"Richard Biener","email":"rguenther@suse.de"},"content":"On Tue, 21 Apr 2026, Jakub Jelinek wrote:\n\n> Hi!\n> \n> The following testcase ICEs on riscv.\n> tree-ssa-sccvn.cc (vn_walk_cb_data::push_partial_def) already uses\n> build_bitint_type instead of build_nonstandard_integer_type for larger\n> BITINT_TYPE types:\n> /* Make sure to interpret in a type that has a range covering the whole\n> access size. */\n> if (INTEGRAL_TYPE_P (vr->type) && maxsizei != TYPE_PRECISION (vr->type))\n> {\n> if (TREE_CODE (vr->type) == BITINT_TYPE\n> && maxsizei > MAX_FIXED_MODE_SIZE)\n> type = build_bitint_type (maxsizei, TYPE_UNSIGNED (type));\n> else\n> type = build_nonstandard_integer_type (maxsizei, TYPE_UNSIGNED (type));\n> }\n> and the same change in vn_reference_lookup_3 fixes the ICE.\n> \n> Bootstrapped/regtested on x86_64-linux and i686-linux and x86_64-linux ->\n> riscv64-linux cross compiler tested on the testcase, ok for trunk?\n\nOK.\n\n> 2026-04-21 Jakub Jelinek \n> \n> \tPR tree-optimization/124941\n> \t* tree-ssa-sccvn.cc (vn_reference_lookup_3): Use build_bitint_type\n> \trather than build_nonstandard_integer_type for\n> \tmaxsizei larger than MAX_FIXED_MODE_SIZE.\n> \n> \t* gcc.dg/bitint-129.c: New test.\n> \n> --- gcc/tree-ssa-sccvn.cc.jj\t2026-03-27 10:17:21.501210523 +0100\n> +++ gcc/tree-ssa-sccvn.cc\t2026-04-20 12:40:15.175842096 +0200\n> @@ -3284,8 +3284,14 @@ vn_reference_lookup_3 (ao_ref *ref, tree\n> \t\t covering the whole access size. */\n> \t\t if (INTEGRAL_TYPE_P (vr->type)\n> \t\t && maxsizei != TYPE_PRECISION (vr->type))\n> -\t\t type = build_nonstandard_integer_type (maxsizei,\n> -\t\t\t\t\t\t\t TYPE_UNSIGNED (type));\n> +\t\t {\n> +\t\t bool uns = TYPE_UNSIGNED (type);\n> +\t\t if (TREE_CODE (vr->type) == BITINT_TYPE\n> +\t\t\t && maxsizei > MAX_FIXED_MODE_SIZE)\n> +\t\t\ttype = build_bitint_type (maxsizei, uns);\n> +\t\t else\n> +\t\t\ttype = build_nonstandard_integer_type (maxsizei, uns);\n> +\t\t }\n> \t\t if (BYTES_BIG_ENDIAN)\n> \t\t {\n> \t\t /* For big-endian native_encode_expr stored the rhs\n> --- gcc/testsuite/gcc.dg/bitint-129.c.jj\t2026-04-20 12:43:29.585546318 +0200\n> +++ gcc/testsuite/gcc.dg/bitint-129.c\t2026-04-20 12:42:46.331279596 +0200\n> @@ -0,0 +1,14 @@\n> +/* PR tree-optimization/124941 */\n> +/* { dg-do compile { target bitint } } */\n> +/* { dg-options \"-O2 -fno-strict-aliasing\" } */\n> +\n> +#if __BITINT_MAXWIDTH__ >= 1024\n> +_BitInt(257)\n> +foo ()\n> +{\n> + _BitInt(1024) b = 0;\n> + return *(_BitInt(257) *)&b;\n> +}\n> +#else\n> +int i;\n> +#endif\n> \n> \tJakub\n> \n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=CRHTAsnM;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=tsoOwxhA;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=nQGEao3X;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=nJVqp1IM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=CRHTAsnM;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=tsoOwxhA;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=nQGEao3X;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=nJVqp1IM","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","sourceware.org; spf=pass smtp.mailfrom=suse.de","server2.sourceware.org;\n arc=none smtp.remote-ip=195.135.223.130","smtp-out1.suse.de;\n\tnone"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0GK95pQ4z1yCv\n\tfor ; Tue, 21 Apr 2026 18:50:36 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 83A164BA2E3C\n\tfor ; Tue, 21 Apr 2026 08:50:34 +0000 (GMT)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n by sourceware.org (Postfix) with ESMTPS id E470A4BA2E3A\n for ; Tue, 21 Apr 2026 08:50:05 +0000 (GMT)","from murzim.nue2.suse.org (unknown [10.168.4.243])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id D6F806A82B;\n Tue, 21 Apr 2026 08:50:04 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 83A164BA2E3C","OpenDKIM Filter v2.11.0 sourceware.org E470A4BA2E3A"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org E470A4BA2E3A","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org E470A4BA2E3A","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776761406; cv=none;\n b=etqyJl/QmEl+53ZPDQ2dJQUYfc/L2Ft9uKx6YBBhz0nDB05GRWENMza6gBNPEmalt3GSnrqKHylTuG0zTbObBe8l61gbDDEaX8XoKbVf3jZnj/AFCfI0Dz7Bg3/6zXWKwB9/TZa59R9BI1M1leFDQoYZ0+TRZVrZo1xsPcNeepc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776761406; c=relaxed/simple;\n bh=vkH1Z+nnnc+Emb2HeMwOSzM7Wb2I8mxFh07YY7SrEnQ=;\n h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date:\n From:To:Subject:Message-ID:MIME-Version;\n b=uHPnqX1poWLQ0GgV+auf/pYaJSiGxRz6J3s1rpQOqxNrR/54A5lgM4ceZ59V77W9IYVfTmK+sAubcIjsvRLFWl3O5e65UwoM83tgz+vZ0hXzvQIl8R5HQ4ga8i9LSs3e75CE/BHQ3x0m/bdvDVhQtGokGTy1r7Mc2ic2Z3EYVc4=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776761405;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=iXQe4hHxCOj2z71HSH9ybJBqpdI4+a2b8fHGEJhn2CE=;\n b=CRHTAsnMaWH90i5DvnS/9KFMcyaJvJUk/IPjfdffbAM7bxT7yQvvXvdxmMJeFcE2E3uDGm\n ig8WDTdYXV0CqzgdjeeAki1biWQCcp+q0NJo/d7VSDZpu0V/ExdOdVK5AgtGNjfplC6Cyi\n ndQZ5Snxs7WdiLWnQ2OrwW4qBa699Kc=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776761405;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=iXQe4hHxCOj2z71HSH9ybJBqpdI4+a2b8fHGEJhn2CE=;\n b=tsoOwxhAmo+Q8lzjsq2KgdoqPYtYxFX3T0ksgq6FBT1+Q900VKxTicLaQNZlws8L/eleEI\n vbMziFwJ1JNH+HCw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776761404;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=iXQe4hHxCOj2z71HSH9ybJBqpdI4+a2b8fHGEJhn2CE=;\n b=nQGEao3XxByYKsEUEeS9QpmdTvEN86lbnx5t4EzpKOcp5xRwNVDqJiWgCRGZnLHJJJUdib\n IEMa0aUMQ/5ZPFJyaymPcX477/xJhzB/Ft1b8UDi+lQ9mUayZ0PZ/bS6eGBikEhqF5RTKe\n RcdQVp0Ahmv/gxBGjDgdJSfFSpHqvKk=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776761404;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=iXQe4hHxCOj2z71HSH9ybJBqpdI4+a2b8fHGEJhn2CE=;\n b=nJVqp1IM7wBXNibI7yR1e6XXp/pe6T8ME0tfO4G9i6FFKcBisAlWivW5aFcriVqcf3PWAN\n czA4nQhcF4BAElBA=="],"Date":"Tue, 21 Apr 2026 10:50:04 +0200 (CEST)","From":"Richard Biener ","To":"Jakub Jelinek ","cc":"Andrew Pinski , gcc-patches@gcc.gnu.org","Subject":"Re: [PATCH] sccvn: Use build_bitint_type in another SCCVN spot\n [PR124941]","In-Reply-To":"","Message-ID":"<5pr6n639-r103-q404-898s-o556n552495o@fhfr.qr>","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","X-Spamd-Result":"default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[];\n MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[];\n RCVD_COUNT_ZERO(0.00)[0]; RCPT_COUNT_THREE(0.00)[3];\n FROM_EQ_ENVFROM(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n TO_MATCH_ENVRCPT_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]