[{"id":3679682,"web_url":"http://patchwork.ozlabs.org/comment/3679682/","msgid":"<42263811-2d99-4d2a-aba7-a19dda3b5047@linaro.org>","list_archive_url":null,"date":"2026-04-21T06:09:07","subject":"Re: [PATCH v3 13/13] hw/riscv/atlantis: Add some i2c peripherals","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 21/4/26 07:31, Joel Stanley wrote:\n> Add an I2C RTC device and a temperature sensor. These are not present\n> on the board but help for testing.\n> \n> Signed-off-by: Joel Stanley \n> ---\n> v3: Use HWADDR_PRIX in i2c device string consistent\n> ---\n> hw/riscv/tt_atlantis.c | 18 ++++++++++++++++++\n> hw/riscv/Kconfig | 2 ++\n> 2 files changed, 20 insertions(+)\n\n\n> @@ -542,6 +555,9 @@ static void finalize_fdt(TTAtlantisState *s)\n> TT_ATL_I2C0_IRQ + i,\n> aplic_s_phandle, periph_clk_phandle);\n> }\n> +\n\nWorth mentioning /* QEMU specific */ ?\n\n> + create_fdt_i2c_device(s, 0, \"national,lm75\", 0x48);\n> + create_fdt_i2c_device(s, 0, \"dallas,ds1338\", 0x6f);\n\nMaybe use another bus to extend coverage, like #4.\n\n> }\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Qlij1u4b;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0BlM5hr6z1yGt\n\tfor ; Tue, 21 Apr 2026 16:09:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wF4IS-0001Ti-9u; Tue, 21 Apr 2026 02:09:20 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wF4IN-0001Qd-52\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 02:09:16 -0400","from mail-wm1-x333.google.com ([2a00:1450:4864:20::333])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wF4IK-00084v-ED\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 02:09:14 -0400","by mail-wm1-x333.google.com with SMTP id\n 5b1f17b1804b1-4891f625344so17892495e9.0\n for ; Mon, 20 Apr 2026 23:09:10 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a4b329542sm139338775e9.3.2026.04.20.23.09.08\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 20 Apr 2026 23:09:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776751749; x=1777356549; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=PsvOmqdR+PAMgvW8Ny63cT8kUXc//ZS402nme+dkyxY=;\n b=Qlij1u4b71rUk6xzICpzg8FIJM01IxkuUxe/u1+wP/JYo4bNM9No4hV0BBkxQ7/LS0\n +hWoqTzak4rR7xzrNenhEeWLECfubCud8L7XwWkOzAI4ePK2ZB3ggNMivpzqCFoVkT6I\n XYyIxNB00PpwD/jclM0KZMNkd8VD7j5H+6QQeLswEzfvGMpTBlBxpUswsqQcd4FT051H\n HngTfljGBFGIeIs6GfysUre7UIIUh2NxLfmNe24eS6Ayyyer2s/zQfvrvi7wIwfnH9TO\n DlJ2mt75t3RSWqv7Z1Xq4MZVsVdcOdDvshV0DcAZ8HveD4ls865UZemOy3n4SW6ERcPz\n pbZw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776751749; x=1777356549;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=PsvOmqdR+PAMgvW8Ny63cT8kUXc//ZS402nme+dkyxY=;\n b=iPBaV548Tq9C89Z5HAl+o52ySkSD+kWe9pdOvCmm/M/yG3rnGNPoC8mWXC32m7NeBh\n 2zV3xFwnn0iNyGGDlH60ZPKT6EUVgMltOZbmQkXnlPZergG1SPRkM4i8Ca6V5vGUT5ya\n dmelwufh9oOrf5Ng8eJd7qtvz0Du9Q50eQ4v6FANROmgcGwOB/3IUX2mDksm5GvIF49/\n 8sFqQYUpTiJxEeGp0rokgc/qsQWS6IoHNam2WVaTejk+acRPNxEzTj641ml3Vf0Bug0L\n xwEhzwSTtrVBWXfqNzbJRJvM+c/VHthRdRCCXlD9KWPx/qo5Y3No5ygz6CzsTx63ft/o\n U48w==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9YpcD5kTHb1RiqOlNyPIG7Iu7KgYc42R1lyVa2XD0xXK26vFSiMNCfJ6eYomY4AYz/bV0lTcc//ovu@nongnu.org","X-Gm-Message-State":"AOJu0YxsPxvE6B98BQd+C0uvPD4IrCqJ+6oPCJgVoy2yHGrLVzqJMQJn\n sU7yCOIBl4xaq7nE5W5KmPGXW/Gu1wDqBB2OP+R/pxW6NLn7afUtm42TcLIqsO+plW0=","X-Gm-Gg":"AeBDievRMJy+mjW/7ZIg+bwdKSo0MELShUm6XxPnTDxkSB2NYARvp3VovJLyb+xkibY\n LcYrT0R8kJBnZC97GPzKf7+oR9H220iQNwZp9U0EJliBJwaIHARnqicoOEZ/aYNU0XxEgUcIHgK\n qwz6mWgVBTeR18AOrymRmSjIKvtaECleSL7zF7XY11uFXqs9Hbi1sL1GQ6u2ZRaLAa5f95obFyZ\n JCdIwY3WYHgB1XKFygaezrUSMYx5t9NL5qLK8dXk33clTjyhyYt88LwobuWvq1DsyjuwBSxLeiI\n LWRzMN4yw1Wtvt/1E3me/t8ZMVzEUS7C40tjeKf8qu+y8DWY8uzzww3mxp076D3WXkTKzxIHnA1\n zU/+aFwaf6KUNF0OfsEzEpp55DfwbuDzOjLoiWRasvZLDNRJlJ4K3Ym/vfu+iGmID+xu9YwSYcf\n T+J+GHCgZtVccznQyIEBe7mw67R6lq4qSS9xD7NXcvgONxYDi/thHCkjfNQwldrkZcqE/xtyPwC\n IFU","X-Received":"by 2002:a05:600d:8447:b0:486:f893:56c6 with SMTP id\n 5b1f17b1804b1-488fb8b18d1mr164856175e9.10.1776751749469;\n Mon, 20 Apr 2026 23:09:09 -0700 (PDT)","Message-ID":"<42263811-2d99-4d2a-aba7-a19dda3b5047@linaro.org>","Date":"Tue, 21 Apr 2026 08:09:07 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 13/13] hw/riscv/atlantis: Add some i2c peripherals","Content-Language":"en-US","To":"Joel Stanley ,\n Alistair Francis ,\n Daniel Henrique Barboza ","Cc":"Michael Ellerman , Nicholas Piggin ,\n Joel Stanley ,\n Anirudh Srinivasan , qemu-riscv@nongnu.org,\n qemu-devel@nongnu.org","References":"<20260421053140.752059-1-joel@jms.id.au>\n <20260421053140.752059-14-joel@jms.id.au>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260421053140.752059-14-joel@jms.id.au>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::333;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3681243,"web_url":"http://patchwork.ozlabs.org/comment/3681243/","msgid":"","list_archive_url":null,"date":"2026-04-23T02:23:41","subject":"Re: [PATCH v3 13/13] hw/riscv/atlantis: Add some i2c peripherals","submitter":{"id":48628,"url":"http://patchwork.ozlabs.org/api/people/48628/","name":"Joel Stanley","email":"joel@jms.id.au"},"content":"On Tue, 21 Apr 2026 at 16:09, Philippe Mathieu-Daudé wrote:\n>\n> On 21/4/26 07:31, Joel Stanley wrote:\n> > Add an I2C RTC device and a temperature sensor. These are not present\n> > on the board but help for testing.\n> >\n> > Signed-off-by: Joel Stanley \n> > ---\n> > v3: Use HWADDR_PRIX in i2c device string consistent\n> > ---\n> > hw/riscv/tt_atlantis.c | 18 ++++++++++++++++++\n> > hw/riscv/Kconfig | 2 ++\n> > 2 files changed, 20 insertions(+)\n>\n>\n> > @@ -542,6 +555,9 @@ static void finalize_fdt(TTAtlantisState *s)\n> > TT_ATL_I2C0_IRQ + i,\n> > aplic_s_phandle, periph_clk_phandle);\n> > }\n> > +\n>\n> Worth mentioning /* QEMU specific */ ?\n>\n> > + create_fdt_i2c_device(s, 0, \"national,lm75\", 0x48);\n> > + create_fdt_i2c_device(s, 0, \"dallas,ds1338\", 0x6f);\n>\n> Maybe use another bus to extend coverage, like #4.\n\nBoth good ideas, thanks.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256\n header.s=google header.b=kbYWbYjk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1Kff0BRxz1y2d\n\tfor ; Thu, 23 Apr 2026 12:24:24 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFjjZ-0001ot-OB; Wed, 22 Apr 2026 22:24:05 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFjjR-0001oT-QN\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 22:23:59 -0400","from mail-yw1-x112b.google.com ([2607:f8b0:4864:20::112b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wFjjP-0000ur-AU\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 22:23:57 -0400","by mail-yw1-x112b.google.com with SMTP id\n 00721157ae682-79885f4a8ffso65446987b3.3\n for ; Wed, 22 Apr 2026 19:23:54 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1776911033; cv=none;\n d=google.com; s=arc-20240605;\n b=fwhvACtcNj9SYJzdCEB97J1wskJuFrsnreDNl1+xp6E/iK2DkaU5HqB0q3E5MI9Fy5\n 5RvB0RlfZAWLx0FKTMtyuvQ4tzXeIHrqFnUE7Mj452TiLKCUazIJkotV/+Nk6OxqMZ3P\n +MmG9l5J3F/Qf6KR5IJy2e9Lhjtc7mpOkD8Im6CR/f2QfJNkzMb/awl2lLbrxVUkPTOs\n IfeSa/ImnDHRm2EElO4KogJUXQs0zxO4N+0DogpLC3DpSd6f9QhIPQYX5QOaPtO0Lrdl\n rd99GrQilnzIoXdQJf/CD0dmSQ42qikaMoRC5A3iyBTY5myNZGGORgj6KkzVHrS517O8\n zBJg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=a7CuCakoGxzeAIS8gozKH2+RGkp8kPxcBVq3hh+6O90=;\n fh=Oi7/q8LTYXnhar7Jxtpphz6tzu2ZEVH8OxycppvdTcw=;\n b=bgywRsUVuu4C7Pp2qzangAsXNKTyxLL9O2Dv3ZUvGO4TsvGJsJOLWfbZxvAuwiHnZ0\n h9cYkEDDYm0VUaeUGLr/62njVdoDUmrPl27O9a+n4aqLffirxpuqVhEb+9xxW6h+5h8J\n w1PMuONanPD2GAk1tNW5cpRRSw9N3xMPBPw83v2zaTPl3VTMDoeRPFqv31yJ7Zhqa/MA\n fwWwmMA3o1O/EJDSJv3vzUlYQft3XEbnWkr/E9nYapOa2qC3GKkKzB06mSQFEu3U5SVL\n NUEiO4FmFf5NbosKWhQYnR/dqDqeo1Y9Cxfw+FdFH60bkwURCbsF23kuiDm4YiP6565U\n Cn8Q==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=jms.id.au; s=google; t=1776911033; x=1777515833; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=a7CuCakoGxzeAIS8gozKH2+RGkp8kPxcBVq3hh+6O90=;\n b=kbYWbYjkXCh29EpmCJ0s8+oLxCKEFU5M+nVzCiiBBBp2Ztw8oxzntKXzbLkqkUkbjw\n i/AwarNPv3H4FJoBZaBnQeJZC8HX5vWQKILZOCUyH4m6RxKsuJRWaxABb4oABoAk19qW\n d7Rk1TzxqOjtSTVtxOd8oOVnmOWPAfg57dlmc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776911033; x=1777515833;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=a7CuCakoGxzeAIS8gozKH2+RGkp8kPxcBVq3hh+6O90=;\n b=ZuFHYRwVOaG+qIcDd24S71NKcmtiHg3WgCGm5DEP/G5v3V7noAd/lxzJ1GG7cmec/R\n Hq3ishmTl1THEQAtYgNw0zpt6oZP24xJdety3o+wiCZwJiqAMHe9A85ev6dhFSg61EOb\n LdRaIJ9pcACafB5OPwerlOD6k0VliYlqf8p0FgaYKttoVCw75C2BUeGxqFD+eaZVPKzs\n 1X3hl8I416u30lYTMl1CpzpDALrMfNqjBWh9kpi+8YqGlDA3Rp4SkEz+haDkIWEAP5kE\n r9SD/KSdbZgsVsZjAoMcMN9QpAGKoFgfgXw4PScL2pyX1ehRLzxgPO3Hnsld4sTEs2d6\n 61qw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ80aXPg+rgrIQhOJN32VQmC5vTNbLs7m9/265vAtolemjgB0H3wJ15suXwEFJe7ed2K8sZc/AUQWRr9@nongnu.org","X-Gm-Message-State":"AOJu0YwXl1cxpbGpNvA0Pwf6J1BYUGNuXUa/hlTdC62tm+oOvE/9lU3V\n nCpvj1FDbZCpr2grt4LRuHFeZSbYGpGEaJO0WctXc469O0k2lw+07GyUE2vdAxBehnhCX8qdNmo\n sf0BVVVQ19rB4M6TlnjitAZUWQmSouSs=","X-Gm-Gg":"AeBDiesKc10IQBaUA/8PpVIxoS7cTklzTQXAiBhF9BmELFctNVepXHAFPclx2mhy+T6\n GvOI//UJVOoxJ3bgwPsKriFRkQwwSEsDULy3CkrLrAmyqMa1MUcL6uWctZlP0STI7NLAtTkH3SU\n XCZMfvKrcpEzCFl15+of7vpx0fbx90/7hAvJjYOFKbAcBfGjVH59rbcHvT2clCaVy4gmTqVLh5Z\n 5xZDaXCcMEksxiDzTynO0Welr0TJBiMttTag2axQhymE3lZ9GmHmqdYIRWctK4vQx3WgsoHfLhg\n odNpsxJ+TkL6Jm5iMMWD0HJAcVBHJpDNYETMqfdnNj/M5nQlRq6eeSNEUzkMYyMwhjzmvjfSfkT\n Bk4BMg6EO0hs=","X-Received":"by 2002:a05:690c:e3c5:b0:79a:4419:71bb with SMTP id\n 00721157ae682-7b9ecef09e3mr267698817b3.21.1776911033458; Wed, 22 Apr 2026\n 19:23:53 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421053140.752059-1-joel@jms.id.au>\n <20260421053140.752059-14-joel@jms.id.au>\n <42263811-2d99-4d2a-aba7-a19dda3b5047@linaro.org>","In-Reply-To":"<42263811-2d99-4d2a-aba7-a19dda3b5047@linaro.org>","From":"Joel Stanley ","Date":"Thu, 23 Apr 2026 12:23:41 +1000","X-Gm-Features":"AQROBzDr3C1c1P1c-g3yc_v4eM9yf41F6oJRcoRn8Z37FU1Ez4tGL0G5rhSzXMs","Message-ID":"\n ","Subject":"Re: [PATCH v3 13/13] hw/riscv/atlantis: Add some i2c peripherals","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Cc":"Alistair Francis ,\n Daniel Henrique Barboza ,\n Michael Ellerman ,\n Nicholas Piggin , Joel Stanley ,\n Anirudh Srinivasan , qemu-riscv@nongnu.org,\n qemu-devel@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2607:f8b0:4864:20::112b;\n envelope-from=joel.stan@gmail.com; helo=mail-yw1-x112b.google.com","X-Spam_score_int":"-16","X-Spam_score":"-1.7","X-Spam_bar":"-","X-Spam_report":"(-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001,\n FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]