[{"id":3679683,"web_url":"http://patchwork.ozlabs.org/comment/3679683/","msgid":"","list_archive_url":null,"date":"2026-04-21T06:11:49","subject":"Re: [PATCH v3 05/13] hw/riscv/virt: Move AIA initialisation to helper\n file","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 21/4/26 07:31, Joel Stanley wrote:\n> The AIA init will be used by any server class riscv machine. Separate it\n> out in order to share code with such systems.\n> \n> The virt machine keeps machine specific #defines such as\n> VIRT_IRQCHIP_NUM_MSIS, VIRT_IRQCHIP_NUM_PRIO_BITS.\n> \n> Reviewed-by: Daniel Henrique Barboza \n> Reviewed-by: Nutty Liu \n> Signed-off-by: Joel Stanley \n> ---\n> v3:\n> - Add r-b\n> - Move fewer things out of virt machine into aia common code, as they\n> are virt machine specific and not part of aia. Done as part of this\n> movement patch to avoid moving them out only put them back in the\n> next patch.\n> ---\n> hw/riscv/aia.h | 26 +++++++++++\n> include/hw/riscv/virt.h | 1 -\n> hw/riscv/aia.c | 89 ++++++++++++++++++++++++++++++++++++++\n> hw/riscv/virt-acpi-build.c | 2 +\n> hw/riscv/virt.c | 87 +++++--------------------------------\n> hw/riscv/meson.build | 2 +-\n> 6 files changed, 129 insertions(+), 78 deletions(-)\n> create mode 100644 hw/riscv/aia.h\n> create mode 100644 hw/riscv/aia.c\n\nIMHO, since used by distinct machines, AIA should have its own entry\nin MAINTAINERS.\n\nOtherwise:\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=wrM8mtna;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0BpZ6xp8z1yCv\n\tfor ; Tue, 21 Apr 2026 16:12:21 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wF4L3-0002Vy-IW; Tue, 21 Apr 2026 02:12:04 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wF4Kx-0002VT-I7\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 02:11:56 -0400","from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wF4Kv-0000Yk-Q5\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 02:11:55 -0400","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-4852b81c73aso32421745e9.3\n for ; Mon, 20 Apr 2026 23:11:53 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cb11b4sm35649605f8f.2.2026.04.20.23.11.50\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 20 Apr 2026 23:11:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776751911; x=1777356711; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=jD8WyQ5rH2Zwa84Ea9NtW6HBFWV7ZHyiCe4m6oiIFss=;\n b=wrM8mtna62QH4RSGBENa4dkB63oFVpmDUC3gOQLh2v7a0x6HZ86dwul2UinJwcXQqC\n 3zegtUnPBcyy1o0/fYWzjHGD+dqsURpiffLMyk9ihXkJmr4GHDRlpHJZQnHVboDefEfN\n oyEZAiLrzFAUluJBRJBdR5Q966cUHQCxNYHHeVcEHU1fNPeM1XRiroTIFLywYBfabfG4\n NE+N5+Db6wjOt73/3FmDXTxGiOOldfZqvIdkv/+y2T+0p6NtS7p3eaMaBUrMcvitmt1v\n +gMKPCU/H0+75PFJcyE8fjWTIfDrFB0G91pG7qa0ZRLkh4DTqxPBhMDuILMOsem6XveY\n Vasw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776751911; x=1777356711;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=jD8WyQ5rH2Zwa84Ea9NtW6HBFWV7ZHyiCe4m6oiIFss=;\n b=PAAUHhLFrm0syvQr2fjAAfroQuU9zFhysgCmcY63E4P4pW5PhnQKMwiJs1jcLmE5DI\n UD5x9QOSqR6aBoPE9bzsZJAU6vGHfgrCAzlKKylkS0B8hL0oHo4NzYZnZouVrpp+UEJw\n FT22Awb+tT03KO4gjXom8ZO1orE6EoQK1Nfx4dIMhLMdmml8qNxmGl18s23EiOO1DsGj\n y6nVPCoQiA61aGf+aobecnmA9hLPJiRguoSKh1OTLgLFIbMxGVuTxmy+TTOtw8ZkGRWO\n casL0LHfe5PkpnAfQEDGhLxV7CAYrapgJQHlWJ5Vg9Wc1IYID2dhK/9Qrk3kmHaufams\n xvKA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ89iqW/XsDJS+fkxSSBuTmSjxNWPVOWFE9E6dewMl5vS5YJIB7MJphgO1wngmoDSAgfCZuiUJCZKw2V@nongnu.org","X-Gm-Message-State":"AOJu0Yz7RiYOt/aIfCHg53cDlfp5sP9nfjAFSGZakyzYdONT9H4+4vdE\n BEF19rsuk52P6bu2RgV7gGgIR5F/2xxFHI6NptqOQIZ2b48/i+LEcBQqyKe3xwaiTfE=","X-Gm-Gg":"AeBDievlBU2KFa3FstKwMZW3RgqQiOqbZViN4r66X/qz5jvI7fTZrKXppF7zAEGKZDG\n DP3xxeHmRypQB79SW1uBS8nNV5l3St201FqT/uonm5AWdTnCq0Nrrx0UxfigLteMuCFFiko4uDW\n pP2620QKS9coG/KfRxDdbFmTNX5+n3rkMw9IrO95JhihrGZPLZPjYuHcO1HznqmZOCWT/G/8VpY\n hp94pxAhjW61Vc84BbwUSLRzWuEEiIt4dagJikvCorS1fpVUqHDV1KmcXYtWfjXUt/nYf2tTKhR\n FpFk4uyjAo6bEdL/wyqmADBCLic4eQgHRb17lvrH+26N8jQILRl7gT0OMj4tsbALRentjXRMl3D\n 2s5mUJskrULDOSZBq5Js2bkrXvCw6dE3pyJEEw7QcLKqXv9Z/mKCiFdXLJsxBq8LtDcQHITjWhI\n 2EsffoBL9I9JbeOKus3YokaHOM1RG0mdFimLSNpdUIUddNC/qKLSTW7ZXMDr3PIw8pJueqZ7L6I\n eMj","X-Received":"by 2002:a05:600c:1da1:b0:488:79a3:f04c with SMTP id\n 5b1f17b1804b1-488fb7863femr248609805e9.27.1776751911467;\n Mon, 20 Apr 2026 23:11:51 -0700 (PDT)","Message-ID":"","Date":"Tue, 21 Apr 2026 08:11:49 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 05/13] hw/riscv/virt: Move AIA initialisation to helper\n file","Content-Language":"en-US","To":"Joel Stanley ,\n Alistair Francis ,\n Daniel Henrique Barboza ","Cc":"Michael Ellerman , Nicholas Piggin ,\n Joel Stanley ,\n Anirudh Srinivasan , qemu-riscv@nongnu.org,\n qemu-devel@nongnu.org, Nutty Liu ","References":"<20260421053140.752059-1-joel@jms.id.au>\n <20260421053140.752059-6-joel@jms.id.au>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260421053140.752059-6-joel@jms.id.au>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]