[{"id":3681232,"web_url":"http://patchwork.ozlabs.org/comment/3681232/","msgid":"<8e4483bb-852d-41aa-bcff-26a460d24762@linaro.org>","list_archive_url":null,"date":"2026-04-23T01:51:17","subject":"Re: [PATCH v3 06/14] accel/mshv: add arch-specific accelerator init\n hook","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/21/26 15:21, Aastha Rawat wrote:\n> From: \"Anirudh Rayabharam (Microsoft)\" \n> \n> Introduce mshv_arch_accel_init() as an arch-specific hook called early\n> in mshv_init(), before VM creation. This allows each architecture to\n> perform platform-specific initialization at accelerator init time.\n> \n> For arm64, the hook queries the hypervisor for the supported IPA bit\n> size and validates it against the guest memory map via the machine's\n> get_physical_address_range callback, following the same pattern used by\n> HVF and WHPX. This also populates the memory map which comes in handy\n> later when retreiving the vGIC layout.\n> \n> For x86, the hook calls mshv_init_mmio_emu() which was previously called\n> directly from the common init path. Also move set_unimplemented_msr_action()\n> and mshv_arch_post_init_vm() from mshv-cpu.c to the new mshv-all.c, as\n> they are not vCPU-specific.\n> \n> Signed-off-by: Anirudh Rayabharam (Microsoft) \n> ---\n> accel/mshv/mshv-all.c | 5 ++-\n> include/system/mshv_int.h | 1 +\n> target/arm/mshv/mshv-all.c | 25 ++++++++++----\n> target/i386/mshv/meson.build | 1 +\n> target/i386/mshv/mshv-all.c | 80 ++++++++++++++++++++++++++++++++++++++++++++\n> target/i386/mshv/mshv-cpu.c | 40 ----------------------\n> 6 files changed, 105 insertions(+), 47 deletions(-)\n> \n> diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c\n> index 44f35a1463..6940ad9989 100644\n> --- a/accel/mshv/mshv-all.c\n> +++ b/accel/mshv/mshv-all.c\n> @@ -434,7 +434,10 @@ static int mshv_init(AccelState *as, MachineState *ms)\n> return -1;\n> }\n> \n> - mshv_init_mmio_emu();\n> + ret = mshv_arch_accel_init(as, ms, mshv_fd);\n> + if (ret < 0) {\n> + return -1;\n> + }\n> \n> mshv_init_msicontrol();\n> \n> diff --git a/include/system/mshv_int.h b/include/system/mshv_int.h\n> index ff3ab957b5..c72c91cd23 100644\n> --- a/include/system/mshv_int.h\n> +++ b/include/system/mshv_int.h\n> @@ -96,6 +96,7 @@ void mshv_arch_init_vcpu(CPUState *cpu);\n> void mshv_arch_destroy_vcpu(CPUState *cpu);\n> void mshv_arch_amend_proc_features(\n> union hv_partition_synthetic_processor_features *features);\n> +int mshv_arch_accel_init(AccelState *as, MachineState *ms, int mshv_fd);\n> int mshv_arch_post_init_vm(int vm_fd);\n> void mshv_setup_hvcall_args(AccelCPUState *state);\n> \n> diff --git a/target/arm/mshv/mshv-all.c b/target/arm/mshv/mshv-all.c\n> index db1174b444..8d16971c0d 100644\n> --- a/target/arm/mshv/mshv-all.c\n> +++ b/target/arm/mshv/mshv-all.c\n> @@ -9,12 +9,13 @@\n> * SPDX-License-Identifier: GPL-2.0-or-later\n> */\n> \n> -\n> #include \"qemu/osdep.h\"\n> #include \n> \n> #include \"qemu/error-report.h\"\n> #include \"qemu/memalign.h\"\n> +#include \"hw/arm/bsa.h\"\n> +#include \"hw/arm/virt.h\"\n> \n> #include \"system/cpus.h\"\n> #include \"target/arm/cpu.h\"\n> @@ -188,11 +189,6 @@ void mshv_arch_destroy_vcpu(CPUState *cpu)\n> state->hvcall_args = (MshvHvCallArgs){0};\n> }\n> \n> -void mshv_init_mmio_emu(void)\n> -{\n> -\n> -}\n\nIt would be nice to introduce the mshv_arch_accel_init hook earlier in the series, so that \nyou don't have to add and then remove this function.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=fhg62kn3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1Jwv3D87z1y2d\n\tfor ; Thu, 23 Apr 2026 11:51:43 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFjE1-0002ZM-6v; Wed, 22 Apr 2026 21:51:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFjDz-0002Z3-06\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 21:51:27 -0400","from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wFjDx-0005bQ-53\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 21:51:26 -0400","by mail-qk1-x736.google.com with SMTP id\n af79cd13be357-8d7e7f48499so685418685a.1\n for ; Wed, 22 Apr 2026 18:51:24 -0700 (PDT)","from [10.72.56.227] ([172.59.184.224])\n by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8e7d94d3f99sm1502036985a.40.2026.04.22.18.51.21\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 22 Apr 2026 18:51:23 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776909083; x=1777513883; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=mvODFvouzFtekDxFTRCuLNEOo39dtr+XK18QT7+L97s=;\n b=fhg62kn3al5CFr5onRRn0VjeiEzH9QWK4YGeUSs8O9AIeRRp83wSl+cXhBo1y9ieWZ\n GpEjcJ0z54KLyrp5Nu//qqcqkJa+0TNhnfQIMjS2tfRj9j9k0KjndH4N6BIrjeMyJtuz\n qOdPuoKEYc/B1daBPb9wOACFi+jXCKUkJcIaS/iAHrzmbils09hnRF+rTzmc7gW/WMVx\n 7gleL8UdXZtuFtkiD23uevaMnZZlb0O7VVBm658wx9ERw0ScoyvOT0DRUwW9nvKcU/tf\n 0LzvWXq2Nz/f8bLzauU6UplHzefWyeTjNdYSJUd9n0hmTGD6QG5nAWLehX6nDx9danqY\n h7tg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776909083; x=1777513883;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=mvODFvouzFtekDxFTRCuLNEOo39dtr+XK18QT7+L97s=;\n b=o7z4WPgdC8NaoptN07sRMdLmLkGejvQEU5MWhH+l/mNhPkDRrUdbY5p5Pp2Ra2evpo\n k1K9xjN4is5PyLnIL7ThbBEjp/oiSr9E+h07mDjeX4geDsaRBRIrCljLFbNB04UkGLHw\n UmMWyHYykZdzQov6mz37heznDJ9sA2QS2mGt0SmA+47FgY6yQ9MXLboxyeWahjehH8IJ\n WnR8FipmH4QglL/IZ2uA0u5QM0e9iy6qA+zEsNFqHLSlmZF4c+Gwmkvf8tosz3Njd1ao\n nuV+QF49G9wUp0YyJoRcHtrE4fWx4yrw8i7PVDGHJhJf8W+FLivNIdjEqA/yAXeELtM0\n leZQ==","X-Gm-Message-State":"AOJu0YzMu1CGKhzcDvAqmYQt5QHfVgZUbHNnk9uiOsg608hT3DZ1rqTL\n zEtu2xXacC8W2oOtYfZ1P/vaTYeT8BmaMPVDBIcugyCuPxiKyQQxPTNDe41fHfTu8VQDFPe5uK+\n vUs6A9ng=","X-Gm-Gg":"AeBDieuUJWRV++294kyDfGyTxKtigvaIXgbaAdT7NzltK6w8nfzLgnvFkTLdyZJVWf5\n VbmnCgO9dgz5Q1x34aYtiAwRsOFiXbzMarO/+Gl06LU2MZ+aH9NxdRdcJUE5L/tc9HttjuV0Gup\n BZ6EwGXVZVk+kOtvFI7gue4XoubxPM8XWheZtY45k4Vc4sCdwgJ+76fxwyZMNQ1dDPb25vMzASI\n ykni2hEOcm+HRmUhJFk64FBLQJrfVvAbMEcP3I26W5Pru3GSYBm0381eglHs2Yy0L1L8BygG5Dl\n bN0MgjYsvt32MowNjmIlbTMZOTVK1aDrsiiKYdMba87nm1oz4w5zIBbyPtiUSqFupDKGhMt+Ltv\n SpybszIa9wJ+5purBUPWzkG6ZLQj7VaKozFx6on+JS6BEiMa036DtKxmSGqssOrp0ozfAm9V8E5\n 0NA4mzyVE4njEUeJzTR8VnP5ht49W7vszO0qF+5VUPuqI9e/nVeCtDvBglyTAKRr3Fyq4q74UPj\n SDWXi2vMevTCyoe3R5bBEhVtkGL","X-Received":"by 2002:a05:620a:4093:b0:8ca:fe5c:ea6d with SMTP id\n af79cd13be357-8e792a59afamr3535737585a.59.1776909083478;\n Wed, 22 Apr 2026 18:51:23 -0700 (PDT)","Message-ID":"<8e4483bb-852d-41aa-bcff-26a460d24762@linaro.org>","Date":"Thu, 23 Apr 2026 11:51:17 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 06/14] accel/mshv: add arch-specific accelerator init\n hook","To":"qemu-devel@nongnu.org","References":"\n <20260421-mshv_accel_arm64_supp-v3-0-469f544778ba@linux.microsoft.com>\n <20260421-mshv_accel_arm64_supp-v3-6-469f544778ba@linux.microsoft.com>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"\n <20260421-mshv_accel_arm64_supp-v3-6-469f544778ba@linux.microsoft.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::736;\n envelope-from=richard.henderson@linaro.org; helo=mail-qk1-x736.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]