[{"id":3681233,"web_url":"http://patchwork.ozlabs.org/comment/3681233/","msgid":"<66ebbc64-7509-47bc-b7cf-27c0b5fd0eee@linaro.org>","list_archive_url":null,"date":"2026-04-23T01:55:43","subject":"Re: [PATCH v3 09/14] accel/mshv: implement cpu_thread_is_idle() hook","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/21/26 15:21, Aastha Rawat wrote:\n> From: Magnus Kulke \n> \n> In MSHV the hypervisor APIC is always used, so we to implement this hook\n> to make sure the AP's vcpu thread is not blocked waiting for an INIT SIPI\n> by the BSP. Without this change soft reboots with -smp cpus>=2 will\n> hang.\n> \n> Signed-off-by: Magnus Kulke \n> Reviewed-by: Mohamed Mediouni \n> ---\n> accel/mshv/mshv-all.c | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n> \n> diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c\n> index 5ce76e86db..6c0ddbf3ca 100644\n> --- a/accel/mshv/mshv-all.c\n> +++ b/accel/mshv/mshv-all.c\n> @@ -704,11 +704,23 @@ static const TypeInfo mshv_accel_type = {\n> .instance_size = sizeof(MshvState),\n> };\n> \n> +/*\n> + * MSHV manages the LAPIC in the hypervisor. SIPI for APs are handled\n> + * internally. Halted vCPUs must still enter mshv_cpu_exec() so that\n> + * MSHV_RUN_VP is called and the hypervisor will deliver SIPI to wake APs.\n> + */\n> +\n> +static bool mshv_vcpu_thread_is_idle(CPUState *cpu)\n> +{\n> + return false;\n> +}\n\nThe comment, at least, is x86 specific.\n\n\nr~\n\n> +\n> static void mshv_accel_ops_class_init(ObjectClass *oc, const void *data)\n> {\n> AccelOpsClass *ops = ACCEL_OPS_CLASS(oc);\n> \n> ops->create_vcpu_thread = mshv_start_vcpu_thread;\n> + ops->cpu_thread_is_idle = mshv_vcpu_thread_is_idle;\n> ops->synchronize_post_init = mshv_cpu_synchronize_post_init;\n> ops->synchronize_post_reset = mshv_cpu_synchronize_post_reset;\n> ops->synchronize_state = mshv_cpu_synchronize;\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=mO55csKO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1K1s47d8z1yDD\n\tfor ; Thu, 23 Apr 2026 11:56:01 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFjII-00046Y-H7; Wed, 22 Apr 2026 21:55:54 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFjIG-00045v-SR\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 21:55:52 -0400","from mail-qv1-xf2f.google.com ([2607:f8b0:4864:20::f2f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wFjIF-0006vB-C6\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 21:55:52 -0400","by mail-qv1-xf2f.google.com with SMTP id\n 6a1803df08f44-8acb550db18so65262246d6.3\n for ; Wed, 22 Apr 2026 18:55:51 -0700 (PDT)","from [10.72.56.227] ([172.59.184.224])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b02ae61332sm139201976d6.24.2026.04.22.18.55.48\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 22 Apr 2026 18:55:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776909350; x=1777514150; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=HCtz7K1W/kT5KEr6GYbvd/GBKUuFwf0Z3nD2u//Qx8g=;\n b=mO55csKOQ+B6MlensBU1StL8yemo/YP7cl/SoNix9051cehT9hNSupykQIZ5TOz7OH\n xk0tUXgPOprBDlkdGlZJSXhpTCykzA/bWhNoQxEYH92h9Wo0Ikwdw6EgHKNjwpwTQvZq\n RmX6KzELYYwpu23wggDh432Q2WiShl4fuE/MpFdQmMrzh1ycYyrLjzNCgOmsCi+zBX+p\n knxMPsDeanhVVkHjUxbwg4T4WdMGW+M81xTr7TGVEYoVE6iWVGKNJqyTaBb51ukgqtP1\n 5ZovW5wnTw7TGBF6BjhKQp8/Gz20bHdWXf93CBH24rQCT6X95WWXSFM10ZK1D+ORPyZ4\n sk7w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776909350; x=1777514150;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=HCtz7K1W/kT5KEr6GYbvd/GBKUuFwf0Z3nD2u//Qx8g=;\n b=LRw0sOKn9iHdipXjiGp5oovCNWv3msoi8wTB7CwJcHHkoDuxluhmizvyEVoIE5cHbk\n cv18TFtPRdQvVIzKSanmg2u1XYT3GpQ9gJL/YJDvlVB+2KzCpOaTshTi9mjJed7IEDFg\n g6S9IuISMI3ooJ++F7vqlF/yHdTD5lb2HH0bZ9mcLdz/xAXGdCnHUr5+xEBDH41dWRUt\n bQai1nZV+PYZycfwRw8ah0MB1Z9eLPDV/uGg15Q66hguI0xkI5KtysL4+4jH98WlqQjQ\n imbzW6cGiH/DdsfXUL8fEbAtn97EsJNYkrQZESGQbj/2Fvr0NONTD3iE9bGjeRvdzLMd\n 42ag==","X-Gm-Message-State":"AOJu0YzU1KsUcz8YRwoRIs37JAmLlO28sVcb0Z6OpCeGYxkvTLI6rE3J\n /EM44SIh8tia5fbXqCFgs3TB1sKgi2nbT8hQPoN2RlqPzT+IHoAFZHhK9kjokzqJhNp1EpSDFbU\n WMWEY3/s=","X-Gm-Gg":"AeBDiesH91HC7TF731kZ4XoyfgfHyOXwL1uFkd0AbdGY3A5Uf9NZReRtMUWSbo1QTqt\n W1vn7xdLf4HjsrAr5mO9SCpYylkED8pnMsehZ45D2IABKnbxiFTCj6P2lOs5RED1H2mSBBNBdtV\n h0ampDq/kkenZd5PGc4vkbi2clfb3pXdcGlA+YgkULwwo3C3zndMqwCba25CdO0l/jsgtcBl7/K\n PR7MnL3L/N7qPmxpXvRBbjzeFbXXVMvuiNYPrLliQTs3tXETrYVqMNMSy+y6So3YfBFkYYfoxtS\n cj+fm/0rRYrNOAwwlx4rZC5a/hc76vfcffB4+TQpzhMHa6ZtG2T4jZuVr3VkIrWvZhDyozyqM0n\n POyjEn8BQtS2fd9nJ2XCFDkiuoppsBzytWnaTdfowT2a/hUpSyfwG5DW9BAFn9bY+JajGJ1onUx\n jAnKZ5BMO/BWYuo69dZfiX5aPXFsmnHYCCCpPOkwK7iygGGgLHOy8mqAsGk+E7CZyQKOfiaGVD/\n WF9XMpsBLB/38QLkGTcsrVA0G5o","X-Received":"by 2002:ad4:4eef:0:b0:8ac:a689:34ce with SMTP id\n 6a1803df08f44-8b02818e4bcmr426648776d6.45.1776909350172;\n Wed, 22 Apr 2026 18:55:50 -0700 (PDT)","Message-ID":"<66ebbc64-7509-47bc-b7cf-27c0b5fd0eee@linaro.org>","Date":"Thu, 23 Apr 2026 11:55:43 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 09/14] accel/mshv: implement cpu_thread_is_idle() hook","To":"qemu-devel@nongnu.org","References":"\n <20260421-mshv_accel_arm64_supp-v3-0-469f544778ba@linux.microsoft.com>\n <20260421-mshv_accel_arm64_supp-v3-9-469f544778ba@linux.microsoft.com>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"\n <20260421-mshv_accel_arm64_supp-v3-9-469f544778ba@linux.microsoft.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::f2f;\n envelope-from=richard.henderson@linaro.org; helo=mail-qv1-xf2f.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]