[{"id":3681568,"web_url":"http://patchwork.ozlabs.org/comment/3681568/","msgid":"<20260423163307.989421-3-horms@kernel.org>","list_archive_url":null,"date":"2026-04-23T16:33:09","subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2] idpf: do not perform flow\n ops when netdev is detached","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"From: 'Simon Horman' \n\nThis is an AI-generated review of your patch. The human sending this\nemail has considered the AI review valid, or at least plausible.\nFull review at: https://sashiko.dev\n---\nidpf: do not perform flow ops when netdev is detached\n\nThis commit adds checks to prevent crashes when out-of-tree modules bypass\nethtool core locks and call flow operations on detached netdevs during a\nhardware reset. It introduces netdev and netif_device_present checks in\nidpf_get_rxnfc and idpf_set_rxnfc.\n\n> Even though commit 2e281e1155fc (\"idpf: detach and close netdevs while\n> handling a reset\") prevents ethtool -N/-n operations to operate on\n> detached netdevs, we found that out-of-tree workflows like OpenOnload\n> can bypass ethtool core locks and call idpf_set_rxnfc directly during\n> an idpf HW reset.\n\nIs it acceptable to add defensive checks upstream solely to accommodate\nout-of-tree modules that bypass core kernel locking?\n\nThe core ethtool infrastructure manages locks like rtnl_lock for in-tree\ncallers to guarantee safety. Modifying the upstream driver to paper over\nlocking violations in out-of-tree modules might contradict upstream policies.\n\nSimon says: If this is to address OOT module behaviour then I am concerned.\n And I would suggest that the correct approach is to fix\n\t the OOT kernel module.\n\n> diff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c\n> index bb99d9e7c65d5..8368a7e6a7544 100644\n> --- a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c\n> +++ b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c\n> @@ -43,6 +43,9 @@ static int idpf_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd,\n> \tunsigned int cnt = 0;\n> \tint err = 0;\n> \n> +\tif (!netdev || !netif_device_present(netdev))\n> +\t\treturn -ENODEV;\n> +\n\nCould this result in undefined behavior if netdev is NULL? Before this check,\nnp is initialized using netdev_priv(netdev), which does pointer arithmetic.\nIf netdev can genuinely be NULL from out-of-tree callers, should the\ninitialization of np be moved after the validation?\n\nSimon says: I think the actual problem here is that netdev is never NULL.\n And thus the !netdev check should not be added.\n\n\t Likewise for idpf_set_rxnfc()\n\nAlso, is there a time-of-check to time-of-use race here?\n\nThe netif_device_present() check is performed outside the vport_ctrl_lock\ncritical section.\n\nIf a concurrent hardware reset detaches the device and clears the present bit\nbefore acquiring the vport_ctrl_lock to set np->vport = NULL, this thread\nmight pass the present check, block on idpf_vport_ctrl_lock(netdev), and\nthen dereference the newly set NULL vport once the lock is acquired.\n\nShould the device presence check be moved inside the vport_ctrl_lock\ncritical section to prevent the NULL pointer dereference?\n\nSimon says: This seems to be a legitimate concern.\n Which seems to further suggest that the problem\n\t should be addressed by the caller.\n\n> \tidpf_vport_ctrl_lock(netdev);\n\n[ ... ]\n\n> @@ -349,6 +352,9 @@ static int idpf_set_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd)\n> {\n> \tint ret = -EOPNOTSUPP;\n> \n> +\tif (!netdev || !netif_device_present(netdev))\n> +\t\treturn -ENODEV;\n> +\n> \tidpf_vport_ctrl_lock(netdev);\n\nWould this be vulnerable to the same time-of-check to time-of-use race\nmentioned above, since the present check is outside the lock?","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=I4mBnGGD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1hcq5TW8z1y2d\n\tfor ; Fri, 24 Apr 2026 02:39:07 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 6884683C61;\n\tThu, 23 Apr 2026 16:39:06 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id jRip8PdqSoVn; Thu, 23 Apr 2026 16:39:05 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 8A2A283C66;\n\tThu, 23 Apr 2026 16:39:05 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id B7ADC24D\n for ; Thu, 23 Apr 2026 16:39:03 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 9DB9583C62\n for ; Thu, 23 Apr 2026 16:39:03 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id vIIoIzPHu_lc for ;\n Thu, 23 Apr 2026 16:39:02 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n by smtp1.osuosl.org (Postfix) with ESMTPS id B1DAC83C61\n for ; Thu, 23 Apr 2026 16:39:02 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id 4D00E60139;\n Thu, 23 Apr 2026 16:39:01 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id A192CC2BCAF;\n Thu, 23 Apr 2026 16:38:57 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8A2A283C66","OpenDKIM Filter v2.11.0 smtp1.osuosl.org B1DAC83C61"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776962345;\n\tbh=u494m2QsmyvCeAFzlRqosZ36tvsY2a+RrGFCd8+VKWk=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=I4mBnGGDvqjPOP2RCCyuAu/2psSGiEnETEhfImHSzOHYqOHz7tn28uSfq3+mr3LGM\n\t Z+uc7rLiuTpbgvj91Jsd0PmE6y/y6Bu1BIudVAHAzr0/U/S+qzdftrf8B5khIYBgGX\n\t /Qgb3GzNTyM0rWa/TPhxsAnwEcm/wAZf1Sro0j7gjGJbfuX4RgmncRIyMcLO3uGUeF\n\t COct1C1Fwk9pE/pRaS1jeK+DRgQKnyNgV65R7umgRq6fWThWk5Hx3vyjjKs0LCNoS8\n\t xh6wDvpr7PX9UTYhITML04ijn15z9BxdxIJDl3LblDqVwROcmrYJ21n5j7x7pPp1WG\n\t X+evfFR6CT/kw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254;\n helo=tor.source.kernel.org; envelope-from=horms@kernel.org;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org B1DAC83C61","From":"Simon Horman ","To":"boolli@google.com","Cc":"'Simon Horman' , anthony.l.nguyen@intel.com,\n przemyslaw.kitszel@intel.com, davem@davemloft.net, kuba@kernel.org,\n edumazet@google.com, intel-wired-lan@lists.osuosl.org,\n netdev@vger.kernel.org, linux-kernel@vger.kernel.org, decot@google.com,\n anjali.singhai@intel.com, sridhar.samudrala@intel.com, brianvv@google.com,\n emil.s.tantilov@intel.com, stable@vger.kernel.org","Date":"Thu, 23 Apr 2026 17:33:09 +0100","Message-ID":"<20260423163307.989421-3-horms@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260421051641.370436-1-boolli@google.com>","References":"<20260421051641.370436-1-boolli@google.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1776962341;\n bh=kX7pLScbuR1BMQ6cyntXkY/4oiaKg/6C0QQKGD8dxYU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=GwO+A49bwE2MsJ7xV6/BsjCM3Wxnx8UYUgghMEM9eyxNa8NKgfiWD2+u8waB24W4c\n 3sReF8vwvRm2JeGL5g9msoCkyHvJ+jJm1SfbxQ/H9DDSXxBMHe1lGce++QHmhqquc/\n mbpw/dlDCSTlJgWH3ksGHSDRKjN1x1umaLumAJYnOm1Urv5LbFTtOlBSY0kDk1ad7/\n O6MOuVEXHwtL9qmUVP+cmL0p2E1IdgPghQpzvc413XYcyapByymwcHu0La6UnDkBv1\n 0Tg0lEy0znq11eYibfW2KPyZENNTwVG+hz2lgulkjUmEb2RtfKRFwYoZo+vtU7wL2A\n fNSHjQ3A++Qtg==","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.a=rsa-sha256 header.s=k20201202 header.b=GwO+A49b"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2] idpf: do not perform flow\n ops when netdev is detached","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3681622,"web_url":"http://patchwork.ozlabs.org/comment/3681622/","msgid":"<25163a38-53b5-445c-936c-0cba94cb731f@intel.com>","list_archive_url":null,"date":"2026-04-23T18:40:14","subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2] idpf: do not perform flow\n ops when netdev is detached","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"On 4/23/2026 9:33 AM, Simon Horman wrote:\n> From: 'Simon Horman' \n> \n> This is an AI-generated review of your patch. The human sending this\n> email has considered the AI review valid, or at least plausible.\n> Full review at: https://sashiko.dev\n> ---\n> idpf: do not perform flow ops when netdev is detached\n> \n> This commit adds checks to prevent crashes when out-of-tree modules bypass\n> ethtool core locks and call flow operations on detached netdevs during a\n> hardware reset. It introduces netdev and netif_device_present checks in\n> idpf_get_rxnfc and idpf_set_rxnfc.\n> \n>> Even though commit 2e281e1155fc (\"idpf: detach and close netdevs while\n>> handling a reset\") prevents ethtool -N/-n operations to operate on\n>> detached netdevs, we found that out-of-tree workflows like OpenOnload\n>> can bypass ethtool core locks and call idpf_set_rxnfc directly during\n>> an idpf HW reset.\n> \n> Is it acceptable to add defensive checks upstream solely to accommodate\n> out-of-tree modules that bypass core kernel locking?\n> \n> The core ethtool infrastructure manages locks like rtnl_lock for in-tree\n> callers to guarantee safety. Modifying the upstream driver to paper over\n> locking violations in out-of-tree modules might contradict upstream policies.\n> \n> Simon says: If this is to address OOT module behaviour then I am concerned.\n> And I would suggest that the correct approach is to fix\n> \t the OOT kernel module.\n> \n\nThe commit message says: \"OpenOnload can bypass ethtool core locks and\ncall idpf_set_rxnfc directly\". But if it somehow calls\nidpf_set_rxnfc_directly without holding the appropriate locks, then no\namount of changes to the idpf driver will fix that issue. It is simply\nunsafe for that to be occurring, and this feels like it just patches one\nspecific problem without addressing the root cause that something is\ncalling the drivers ethtool function without correctly holding the\nexpected locks.\n\n\n@Li Li, could you please explain more details about the workflow that\ntriggers these behaviors? If it can't be reproduced with in-tree modules\nthen I don't think we can accept this fix.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=Rx8EXj1x;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1lJr2myWz1yDD\n\tfor ; Fri, 24 Apr 2026 04:40:26 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id B791660D57;\n\tThu, 23 Apr 2026 18:40:23 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id u1XozZtrTxBG; Thu, 23 Apr 2026 18:40:23 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id F37416075B;\n\tThu, 23 Apr 2026 18:40:22 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 75EFF24D\n for ; Thu, 23 Apr 2026 18:40:22 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 6739D6075B\n for ; Thu, 23 Apr 2026 18:40:22 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id awpcrPgK5YWx for ;\n Thu, 23 Apr 2026 18:40:21 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.18])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 38D00606BD\n for ; Thu, 23 Apr 2026 18:40:20 +0000 (UTC)","from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Apr 2026 11:40:20 -0700","from orsmsx903.amr.corp.intel.com ([10.22.229.25])\n by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Apr 2026 11:40:20 -0700","from ORSMSX903.amr.corp.intel.com (10.22.229.25) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 23 Apr 2026 11:40:20 -0700","from ORSEDG903.ED.cps.intel.com (10.7.248.13) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Thu, 23 Apr 2026 11:40:20 -0700","from DM5PR21CU001.outbound.protection.outlook.com (52.101.62.21) by\n edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 23 Apr 2026 11:40:20 -0700","from DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) by\n CO1PR11MB5075.namprd11.prod.outlook.com (2603:10b6:303:9e::14) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9846.20; Thu, 23 Apr 2026 18:40:17 +0000","from DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e]) by DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e%5]) with mapi id 15.20.9846.019; Thu, 23 Apr 2026\n 18:40:17 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org F37416075B","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 38D00606BD"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776969623;\n\tbh=SzLfioNbCLPt912VqEfffGknU1pPjgUvQSsBfLNqHE8=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=Rx8EXj1xIW0YFCAZRCP70+L7AMdVQtwNbSDc1DPfE04adRNXwPGIZVUajiZ0BhUsF\n\t RuA0uRBJd0A36RoX7Hqiu78gz/BETYhb9by7Bqgj9n6Me1zNTMhSX49xfVrt9MrYTL\n\t aK+ZXY6tws0kd4koSmHIFSWeFv1+iHH+x6jQJimDg1LulBko/9U2nhvsM1drXJuCXR\n\t X7BmVdrlrt7d5ViHdbDz+6qU/ACQLJPjowDWOB69AE2/yOyMLuZ+hkPmuoZy2KZYvP\n\t 4y67HAC2I4axUw9dqCtZOARKCt+Jm+K0klTHdhqu2tX3YYFbQIkSQPpo/ATjG308aB\n\t soko9TZlv31Fg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.18;\n helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 38D00606BD","X-CSE-ConnectionGUID":["GHbBj/xIS4+7iAR6Roxp5Q==","GpbQXfb1R5yo4j8hZziP3Q=="],"X-CSE-MsgGUID":["3FZPKWayQ3iESxn5ZgKBVQ==","5r2Mk9SRTMWXmaMAkgW9ng=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11765\"; a=\"77115563\"","E=Sophos;i=\"6.23,195,1770624000\"; d=\"scan'208\";a=\"77115563\"","E=Sophos;i=\"6.23,195,1770624000\"; d=\"scan'208\";a=\"263131772\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=kxAxRD9mmxBeLrqeNUjjFYdV31m8MI5RwF77wB6xHDkPR0/5u65JN41KotlbpLatEadeUKqHjLvqnVhoi6kHs1mjz9TI8sdq4vHCv7YFz/miULlzlsZttdjgcYQkjB/MRLLm6Ss5ejo/9LjVORv4SO4YZYKWBDeh4nB1cMyuidLKd4hzGBRoevcSCAECvHoR203IGU1e7JA58DEx6BjWTGa/G6nXAGn4yzZvgn26z5OFqfsuRg+Vpj7awy2nWfEE800+Ij/ezw1Q3KJJtZavtDT/N8PGyVrRiovgbI7P9XJ1zL8J013cl6H58IEvNlnP12JuezvW7f3y5T8yaAZ04g==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=SzLfioNbCLPt912VqEfffGknU1pPjgUvQSsBfLNqHE8=;\n b=i49r7wETX4jbtpMVQgRLwiM1Lj8HNRef9+DRzVBOF1JQ1QN9I4Bu5+2fwp4IBFrHpXe8Z6MdXsM9PvHZYZgTZkGNjcgwT9avr1Mj7bjeAbnyqmDRVVv2ozVeQuIUHHJwlYu4JteIufM7AGUCYX2YGRmkOPY7/HfnadtwYqTJXzWvvM1ENzl3yA57VPHQSNWS0CoOR+YsDsD36l6L0t5wFfWvXYzzDDyUJuk+sqY2Pz6RaPKOvdxe8ZOQnfJV7y+bBUe24PDZPcugryjtln4mJhavEwCAHOtud6UApJDZr6uwa5X5V6QpUxd41cpmuqcgNVY7lxhqUL2R/2ycsLzdwg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<25163a38-53b5-445c-936c-0cba94cb731f@intel.com>","Date":"Thu, 23 Apr 2026 11:40:14 -0700","User-Agent":"Mozilla Thunderbird","To":"Simon Horman , ","CC":", ,\n , , ,\n , ,\n , ,\n , ,\n , , ","References":"<20260421051641.370436-1-boolli@google.com>\n <20260423163307.989421-3-horms@kernel.org>","Content-Language":"en-US","From":"Jacob Keller ","In-Reply-To":"<20260423163307.989421-3-horms@kernel.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR04CA0091.namprd04.prod.outlook.com\n (2603:10b6:303:83::6) To DS0PR11MB7579.namprd11.prod.outlook.com\n (2603:10b6:8:14d::5)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB7579:EE_|CO1PR11MB5075:EE_","X-MS-Office365-Filtering-Correlation-Id":"1d2422d5-5176-46ad-f229-08dea167c3e2","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|366016|376014|7416014|1800799024|18002099003|56012099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n vx80BKTH0GHP7kFB9pTJAiBL3i0zNSEcNNFo0F5CUqvkAk2X0j/JnahVPzFZ9RkW1ME02QrQnLcSFQwnfAvHhnCId8dpPTaU7JKq2R4E1XmSflm/DmuRh1o1ksdLehLkSBFT5iat2FzYD0gVYJigJQG67QSqDIz0jbKTlqzGrhtaGyXDBOlA/cGqjI94hWCSmVd4CoVQ4tG5CKuQyd7cXFAhH1sCw+jAAEtScDEfdmw6QSqmKE/r6JIJ+hjoT4u+Z8OJU2XT7iL2KK3iUXQRaw3Dh6wrOWHH5PjPF1WWm9+X8hRBTVh1JZ8TFcupqkWFJYD3eZext+GrZ+gddqBTOwU9uWJ2j3018YpfueN8eS8xRe02tFWp6Q9p/E04s92eEAD42XSLZHKIxtdTHjdYWDEgYxAIjCLe7Iq5v0SjLFGgdPSvRqd1g7yY1zq/Or85bt8SW1Gko4Wa72qDRFpV2dldoFDoUY62+d8240Njdr3l0t+F5T9ShLaZ/5iueagCiHydzYJ60UsqOyQYjaoiB8y3sUFsar8Z+8EVGByOJ1GTYgnmsplXmkZ2IHdWzqbsm1X9bFvOgwY/m2oNZouTVGEDnVJPu9W0zW5YNyqhQTREnzH/WaltP0/hpfoGCgw93BhdD9brRkD4OChZXltA0OCyc8vv+Qx/4zn1EBluw2/KsO6cIom6clq7ky+XM7MX","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB7579.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(376014)(7416014)(1800799024)(18002099003)(56012099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?wLgzTIlQql4nhQNjXc4FH31gyCxj?=\n\t=?utf-8?q?6uEMNpGRBe6PqKkKarX5bTYGd6PYLEzXMuG3C0En+XXuZVI1BYAC0Ec4vOjZyxP1G?=\n\t=?utf-8?q?JMMQ/L0DCGJHhkzMn5iTWZ0GOto/BLp09TwkrRvNt5FpNLkn11L5+dGWHlpVfVPVi?=\n\t=?utf-8?q?tgZntmEad3TqWXAiHu6uXBnfPv9AMCiXreM+5XQALEmmTOUB6VvyrzHgfpfmfKVJw?=\n\t=?utf-8?q?9U4vw1eidm2svb7AAY/m3t/JjfQ7xrNVYQU1fob3bUuSa09eSpiJ5BLW7ykE2r9st?=\n\t=?utf-8?q?sltadml/4oCNccl+cyrzeLApigFo/IAt57F8eCuaNcgSeVSL/wFCTgLZzWKi05AAV?=\n\t=?utf-8?q?xAwn5c26kSA6ONvYc65G26DrsoziDED+E+mfgpYNVVJvDI7RBQ4cC3g7+LfSInHPR?=\n\t=?utf-8?q?c/CjZn9QV6XkFkOf2zlK0Ibgkk5qiKHGiSeVJkiKC6+33tTXDtEgtxIOHRAsb6PyQ?=\n\t=?utf-8?q?x5WVzpG6knW6DRPLIvcWPjUN0w8PvsIlwXJmheyfF4HvBmh2/AclrOZL4TvAjrcNq?=\n\t=?utf-8?q?PJfedbO3+K2eZgySspe3oW0AZ0yIPiEzjXf7f/ZGtDSClpC9L4mUKTMy0MdU+3XuE?=\n\t=?utf-8?q?iInFft64rQ8qgetfQO/ByuCU+lzNGK5+zlPGle+3BjWpYbaRUGvXobDtspiBiR/iR?=\n\t=?utf-8?q?9tJCCMt6zIjzNBcyGBCktqQMHkEAJYIHecM06H68uFT2YFk79Cal+d2dNiUtXpe4W?=\n\t=?utf-8?q?HvwZHD+vYVotK51JPw18q/ev+EIHGwElikBManv4ZSkwWqGDG7IJU2w827ngS8FhJ?=\n\t=?utf-8?q?4C/Q53Uijo+PI9QkVeHeo/Co3rPRPN2INJWLvKYvWQlTiWDAX67/IgeLVKVcDSBZF?=\n\t=?utf-8?q?aVKfcMW65trMNW0NEaBMaoyt3qQU6vmRDhTDdPx9BOFYQtoDSW1IkuiaZTQegVdlB?=\n\t=?utf-8?q?5joInIyzQyVpFntDsWb9+Acty661fBBwcX+4MUSA/H+G2T6JIln0rJPvtsTmKHcnZ?=\n\t=?utf-8?q?DhZAGnf0AMb4IoONwuPFkWVWXPAsrEHYZRE7mPMXjEFaUlQfk/Q8IjuwEMDnFjQsU?=\n\t=?utf-8?q?QPx1sC3Jdc/Qoc5clkr1JUM9RyyQQWsOseRWjnUAc+Au5oqjEdVLFrSfOaJTG+grM?=\n\t=?utf-8?q?gkq3ZIe5xvo5ghLHar1cQmeRgwSIqk/PSD7sF5OKuXGg8IVlzhF/n09KOBSvNk7h2?=\n\t=?utf-8?q?tIMTC0cG6cjxeAM9/ceEMiUBRDh4GBLee2qN6giR8MrB3PvX3j2TnZRGTFreA52GQ?=\n\t=?utf-8?q?lp3UqgAUjhLV/CFpN/ZQgcy50Ep4a/HOfA3TeOiFNAdxNdcRt8obwPwKLp85gcbdN?=\n\t=?utf-8?q?nfceFTad5ii7QMkhRCZiQ4MTH1NDBLr08ZS/mkHIxmSln+zhGk5yzAOg9Di+Dod5x?=\n\t=?utf-8?q?hE66rfwtWl8l5XoUw1dsuvd2khYiHiKOowDIJ1adGf/fXb7HIoPO7qH6A1cVyOpGc?=\n\t=?utf-8?q?Ig3zJ9PXi38F2EX9AM+8o71I6iY3zkfmh8vDu+78+6X/7niHtxkdR8C3eRb4Exydl?=\n\t=?utf-8?q?ZjJ2iNwEINHa6d40ygfgzV0lCLxo9dM9600817hOJZKUrP6/Bd/wt7tgSVApscTM+?=\n\t=?utf-8?q?i08VM+gO7ZGzl1+TQ61nllMk39AzT4nMFCI7d2wg8yfZgDcPboS9INr2OKyfkfYiQ?=\n\t=?utf-8?q?9UNIOSi+pv0ulnA1v4za+HScEO9lyC2NaO0JCdgHSnAjSEKx7+wwkz0UiXRkYacPj?=\n\t=?utf-8?q?UyFsyPUzZeFOB0C6v34wufHqeGHNtQSdUKbfEtDY9k2WW9wIwLc3w=3D?=","X-Exchange-RoutingPolicyChecked":"\n EkdOC3V0NZ+fDUzMtQBZiMWGEF7mG4gh3LJ3hai9knIjhlYYoFOYXXQZ14tuZhqhfQhtkhz3CpGkP7WQbnWECnw4O7qDt7WypdKOvfH5rG8qKFYq4jXebmPNRemMel+8tI9rSkraMGwOCYey7l1GehkXgXHBYgIGVFzHbgcyrHY9b7mtCamJNz7bMCs9DPQeybJuAdZWuqsWiqpcmtfGW0xJrI9YVIbd++FrrrTKZZEk21anosyqG6zXDUV+pyqgEzTAjwrKdomfRIcPQyxY9Yc6RnUxCMoSQ98c20CzOEOmZnSYLlh+0AHL5CtFiAx9EC/cXd+EZxSBqBT7WWVmfg==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 1d2422d5-5176-46ad-f229-08dea167c3e2","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB7579.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"23 Apr 2026 18:40:17.4956 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n qnK4CjVfmOESHyYu0ZkZMwxkusAwUoVqH9F9NPYbnVnPTQk5g/byVOsV+uhDbLrbbXCgtTQIlSlLtSZIeIjggN2RVQiR3JMlVUK2qFmQaqY=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CO1PR11MB5075","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776969621; x=1808505621;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=WLHCorsCt3ehYHPJCk84TimjQuYrQJ3Kxg/zY6eDZ7c=;\n b=kl2abOnQnNogDd0ndKjBsAF8ckda8Hl8Wj5P293Wu4TwOkgzDUqWsSio\n WxQHK6UaW+1WZoNkpGSRtoRmd0nhOy6t25if5KqeqUgqYWwOMBgtK6Yqm\n 63t6Y5vrReCNhenY8cnlyq2cIhbN2uT2QfqoMCV0sU658rYvBU+FhiZJZ\n v6RMvjuQKLBky3FLHNnutcHufIvKVoStnJ5YmyWsgprtrNAs5sQgZ6gEl\n 1YztAVoJfhy21vGL7x3ofkfhXwkfW2MybndPlOhaDHL6alHqg+YT52ro8\n nCuTypwWRqaEkb3Jtaf5R0XxSLPWloN056spEmntATvEEqi+p2Q4B3k7T\n Q==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=kl2abOnQ","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2] idpf: do not perform flow\n ops when netdev is detached","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]