[{"id":3680115,"web_url":"http://patchwork.ozlabs.org/comment/3680115/","msgid":"","list_archive_url":null,"date":"2026-04-21T22:49:21","subject":"Re: [PATCH v1] serial: msm-geni: configure RX watermark register","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-21T04:45:55, Gurumoorthy Santhakumar\n wrote:\n> serial: msm-geni: configure RX watermark register\n>\n> The SE_GENI_RX_WATERMARK_REG was not being programmed in the RX\n> setup paths. Set it to DEF_RX_WM (2) in qcom_geni_serial_start_rx(),\n> msm_geni_serial_setup_rx() and _debug_uart_init() to align with the\n> Linux kernel driver behaviour.\n>\n> Without this, the RX FIFO watermark interrupt threshold is left at\n> its hardware reset value, which may differ from the expected value\n> and can cause RX data loss or missed watermark interrupts.\n>\n> Link: https://lore.kernel.org/all/20200227132223.864425794@linuxfoundation.org/\n> Signed-off-by: Timple Raj M \n> Signed-off-by: Gurumoorthy Santhakumar \n>\n> drivers/serial/serial_msm_geni.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=Tg/qmHLr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"Tg/qmHLr\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0cxP5mHpz1y2d\n\tfor ; Wed, 22 Apr 2026 08:49:45 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 87CED84333;\n\tWed, 22 Apr 2026 00:49:39 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id BE02484355; Wed, 22 Apr 2026 00:49:38 +0200 (CEST)","from mail-ej1-x634.google.com (mail-ej1-x634.google.com\n [IPv6:2a00:1450:4864:20::634])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 99DE0841F2\n for ; Wed, 22 Apr 2026 00:49:36 +0200 (CEST)","by mail-ej1-x634.google.com with SMTP id\n a640c23a62f3a-ba9ad0fbc3aso169310166b.1\n for ; Tue, 21 Apr 2026 15:49:36 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776811776; cv=none;\n d=google.com; s=arc-20240605;\n b=GD0agNUiTtfx18y0RfBGTK5+VepW9hbha9w3MXMSAJXDuRHIgxcDUz25N/sun1Y+1S\n 2smFA1HGNQnMQk3hLjrggdNaiO9UvRREJYWgPbqfDfK75sY6qR1yU8shV9GqAO7DeBw2\n U9+OgpF24zufyi7rdNr2kOP0nqbASKvMA/eimVhnnQ5UrQudg64ATCKpcx4x7p7T8E/K\n mrS7jFcc/rMNzBrrREPGXXZE3ns/veU15+MqYYJXO67TLNQ4dUmAccvVMGPhp1OasYwU\n ceCnay6vod42yN1HDPO54ZFWCsEdZqs7A4Km3K8EV81O0FSNAluDR6yPGXPC88PvXGmX\n 94ng==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=owvtQLYNGntSyvozJirvvmVtrDkE7aYwHc6QHKSoItQ=;\n fh=q89F+Hk236NBin7Pn625k1/DTCSlW07o+Hb59cGfDWI=;\n b=ODuY7XHRq3gXYskmUrr0SqE03PRGxKiux11Q3RCnMblIiAjsUqO1/xw1v/N+s0hs4p\n IbnOFkELUs3E1rErtdHu4AZ5jZfYqjAVE77F/LJIA6TrsMR8ajdzVj1phnE5iyk4YSiG\n 6UQUpc5Jkd7UqFxNnc5AG+VhR6AhK7ErTgMH0ZgNmgU9PLAKUEW+6ziqrHTleYKxpv8W\n khlJyJj1S960L3VYrVRvoF6x3tFjvN5W0pDr9k4By8gJfJ4EaJKJjGOKL1qzeH0DZD2U\n JZ9BH74ZHwxo6A9c1xhjwXyoNIZhi9SLK0S8BudqJwBMvo51hIOywiAJJYQPeTJBpJO/\n xb1Q==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776811776; x=1777416576; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=owvtQLYNGntSyvozJirvvmVtrDkE7aYwHc6QHKSoItQ=;\n b=Tg/qmHLryA23hUfGvc/Abdk+b69ysVAudVsO1JlrHikILx/0IBKGEEfguIoo085ii7\n 3CUeS2/EL+/q36VQoLWzAzAoswWKMByCAhhl/hG0R6F8R71BwcOC6CeZRtZpiYORADxM\n iD4/bOhJ66wz98QJkw9siaigGIETOskg2GqKQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776811776; x=1777416576;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=owvtQLYNGntSyvozJirvvmVtrDkE7aYwHc6QHKSoItQ=;\n b=BD+Aj5dtj8gYDFqlKRkv88ALmgNsTwAmELhJjS5z5Buz4darkyoGLQNQjVuxO9M8lh\n KPI6WudKW2nK3UGgc7YoKG1UkgMd16ymDk7VvxY2tdzJss2M8kjuTOEhHEIg7nwkyBNd\n zbk95bh5NpMmcyrWqMiIXcyJ1ZasTNsiL+96Jf7GB/CmstbwoQHzmpVvyvKvIo3AFCEg\n bclHnoftl8j1xKu+r1/U2z3KF7OCvtlhSHwoPHDS+4lfW2zhJuZUm4GH+HnTUW05vRNr\n WV3C4CFqCWmIzD7beufXuAsKkGupeZSmI1uZfCHRbXOV/bclVlxcUBRyyNCEgP/Ahf33\n dg9g==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/FSfj7E+dnb2vcdI6tpA7llLZ87lM3kWzNcczec0wk3Y1/hwDZNoi9psM5K5kHeYyZ9Zwyh10=@lists.denx.de","X-Gm-Message-State":"AOJu0Yyujgi5WXO7+OTzShgGkOyleJ76YxW+rtgmTvEKBjGUI9ArGeLw\n mQkxPlJf6JUE2thTcX3tSTrNDyqCUUFxL7KcvVnOfhnrlHODBWUfncYyGCWbN21m1mRUPpiPxMH\n I1N+nhQKLXX4nr9lFHmULLW7EkB+6nAbxhZjwZVgy","X-Gm-Gg":"AeBDietaPqRk4bkrN04Ip3OSRDrwITPT+hY/Q3XY4xCPwcXFBZQXs8pa6aF1uE9YF1S\n sZaguYesQY66UlBDAJnmswi30kSMjJ5pu1+Mc+Ok1a2ELdLNjoOSem9bihZudGTc11gw80iz6VX\n 78V5VVCLCNib34vle+9dTNC46n1MXe348hd7rv8+9suf78QJ359s6WNe3GGQBGUU5dtf87jERvA\n R6S6MC6iR+ouPFAT0tdWSDnTtYY3xi2iyaps4nnHgKSmr+KQQSRK7btd9+/a5B1NbiJsqOwWHuk\n 84WQ5AGDkhAPNyCn3YZo","X-Received":"by 2002:a17:907:1b1d:b0:b9d:ffb1:17aa with SMTP id\n a640c23a62f3a-ba41aa16185mr949784966b.24.1776811776042; Tue, 21 Apr 2026\n 15:49:36 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421044555.368486-1-gurumoorthy.santhakumar@oss.qualcomm.com>","In-Reply-To":"\n <20260421044555.368486-1-gurumoorthy.santhakumar@oss.qualcomm.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 10:49:21 +1200","X-Gm-Features":"AQROBzBhjEaqyWw7FIcfcSuOr8LOt05eYooQ3zC3h6Yx7wdieQGUPTmQLuzXHb4","Message-ID":"\n ","Subject":"Re: [PATCH v1] serial: msm-geni: configure RX watermark register","To":"gurumoorthy.santhakumar@oss.qualcomm.com","Cc":"casey.connolly@linaro.org, neil.armstrong@linaro.org,\n sumit.garg@kernel.org, trini@konsulko.com, andrew.goodbody@linaro.org,\n quic_timple@quicinc.com, swboyd@chromium.org, u-boot-qcom@groups.io,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]