[{"id":3679670,"web_url":"http://patchwork.ozlabs.org/comment/3679670/","msgid":"<20260421053523.3918-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-21T05:35:23","subject":"Re: [LTP] Added new_behavior flag to detect kernel version Kernel\n >= 6.11: Tests that creat() succeeds (write to executed file allowed)","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Lekshmi,\n\nOn 2026-04-21, lekshmi-cpillai wrote:\n> Added new_behavior flag to detect kernel version Kernel >= 6.11: Tests that creat() succeeds (write to executed file allowed)\n\nUse imperative mood in the subject: \"creat07: Support both old and new\nwrite-to-executed-file behavior\". Also add a commit body explaining why\nthe change is needed — that the previous tst_brk(TCONF) silently skipped\nthe test on all kernels >= 6.11 instead of verifying the allowed behavior.\nFinally, the Signed-off-by tag is missing.\n\n> +static int new_behavior;\n\n[...]\n\n> - tst_brk(TCONF, \"Skipping test, write to executed file is \"\n> - \"allowed since 6.11-rc1.\\n\"\n> - \"2a010c412853 (\\\"fs: don't block i_writecount during exec\\\")\");\n> + new_behavior = 1;\n\nThe logic change is correct. However the doc comment at the top of the\nfile still only mentions ETXTBSY — update it to describe both behaviors.\n\n[...]\n\nPre-existing issues noticed in the surrounding code (not introduced\nby this patch):\n\n- creat07.c:35 — O_WRONLY (value 1) is passed as the mode argument to\n creat(); the second parameter is mode_t, not open flags — likely\n intended to be 0600.\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://github.com/linux-test-project/ltp-agent/actions/runs/24705759346\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=j2WpyH+1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0B054dSXz1yCv\n\tfor ; Tue, 21 Apr 2026 15:35:32 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 2B7AE3E25CA\n\tfor ; Tue, 21 Apr 2026 07:35:30 +0200 (CEST)","from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id D1E383E1B19\n for ; Tue, 21 Apr 2026 07:35:26 +0200 (CEST)","from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com\n [IPv6:2607:f8b0:4864:20::1043])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 451791A00999\n for ; Tue, 21 Apr 2026 07:35:26 +0200 (CEST)","by mail-pj1-x1043.google.com with SMTP id\n 98e67ed59e1d1-3567e2b4159so2539630a91.0\n for ; Mon, 20 Apr 2026 22:35:26 -0700 (PDT)","from\n runnervmeorf1.xp4uafbg1gjufkifmppbinpt2g.xx.internal.cloudapp.net\n ([4.154.76.23]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-36140edb04dsm12497956a91.0.2026.04.20.22.35.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 22:35:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776749725; x=1777354525; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=mG0duGw5y2s3rMlsSK7HHdmW6WFWsapHUBC2b73yk4A=;\n b=j2WpyH+1mJtzFKKsIS1mFawoA9Vn9V7Mm5rOjX7QmNouhKiA+IsbHV06QNmbWN4u24\n 8qz9KdWLZJ0F+V5iZekUdIUAKzjjuzDDMq4G94WbEPHhuPE9Jsm7f7x1uC+BSX3nST3f\n /9KmWdFDptX5SOqriajt/PE3yRkjl8f8M10SPAY0fRrOSCEwTPSHexDjTYwXIGMzpjLr\n QksK4msUqg+n+K53lkG0UpWQql1/VDCiZjA0tzfYWH9U+j5m4kbFlaDa3+DQpt+9y8Tf\n cKQDBqHpJ/gwxgmnnDktn6irClRC4lTVUPzV56jLIcSvs8ERSoWoTZyV2wyvaRnzSEKR\n JqKg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776749725; x=1777354525;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=mG0duGw5y2s3rMlsSK7HHdmW6WFWsapHUBC2b73yk4A=;\n b=Mb9LZS6OmbLAakxxQc+Bqx6OQWceeECgKA6HHyXjSj2kAFm+N9QiKpJS9JPm1p/hii\n 1RmG8cMlOzJECOmqN1jN0VKFntG1RLSsHPbyUpEBjVunpEC2Klws5fFsnMK5nvKs4FJ4\n gkJ+aQJNfK1NQkDK6PCpx3Y8iDEAmrKA+4Rw8ej7EQUY3aCBOWuVMGO1ymVnmBMz8BOX\n 19ee8R3XiAY4kN/YSE9FKEvSrGJRMy3eaNOxU0RbfzhlvABdyWjcdcI08bH5VYM5Jjwi\n voSN6YNoDAFouQY3s7V9eXzRc4n/cXCudsJeyWG8hsMplw91ZupadBiwvhmIDYw/2QWt\n UZWQ==","X-Gm-Message-State":"AOJu0YwlVBYl7gxId8y87aEnLeuYTcc1epKzuKV8Z8dYyKHYVqGds6mK\n GHLTmkLcPIgbEiU7JavSN76W1lsQM8xEWw6qHhRTQRfvCnDd/m4amVby","X-Gm-Gg":"AeBDieu+YhNpKtOZzRwJwPUibVNai65e5sLhNC1XnjpwLhcA/GcI0y1C+tlcVyweSSD\n fva0zyYcYd2mxV1KS3m1pDSKyPDzu3+arkb7EpMh6duyfo1RxvlzQXV0x7srtjhmWXDympvnQj1\n V1YZxS9egBsEyMUyR6mtOpt1lQ1KMhqtvwjJUztfqQ0tJS2hfQy0S0QxMdR1cs9o9tEEAAKLrls\n dUFi0e/x79wTg82FAfrshPCHg0Rpl0gsTv9ZD/JwK7pS4LI6zJxoPtzk1Shl0isSxhZvTjkfRKZ\n lU3c6V8XGDY02tvPNVRc07H5p2m15THzdWPmlbOoUjjSzRJcvFJtOpQNGgg2K8deQcrImretXbd\n 3q5HFOSxRc8Yzzu1NkFtJC1T/uBEKaIpO+q0FJ88OV2xxg4dromzBFSuz8LsPKEDNd6w2/IZZOL\n BbLvMJ7yyVegAoIxDAgK3ValQULaK4+kvg1OzHa7ZO9DdzR+PopiBJv6Vyi4v51BIm7Mliu1bzn\n +whIIlVUm4TzqAip5v9xvM7HAaIguZUQsiFTW3h3sNg1tpzJgipkVJOYA==","X-Received":"by 2002:a17:90b:394e:b0:359:d54:846f with SMTP id\n 98e67ed59e1d1-361403f10f9mr16166506a91.7.1776749724580;\n Mon, 20 Apr 2026 22:35:24 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"lepillai@linux.ibm.com","Date":"Tue, 21 Apr 2026 05:35:23 +0000","Message-ID":"<20260421053523.3918-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260421050251.3662828-1-lepillai@linux.ibm.com>","References":"<20260421050251.3662828-1-lepillai@linux.ibm.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-3.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] Added new_behavior flag to detect kernel version Kernel\n >= 6.11: Tests that creat() succeeds (write to executed file allowed)","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]