[{"id":3679664,"web_url":"http://patchwork.ozlabs.org/comment/3679664/","msgid":"<aeb50jwoCBvgEnec@localhost.localdomain>","date":"2026-04-21T04:15:14","subject":"Re: [PATCH v3 4/4] mm/mm_init: Fix pageblock migratetype for\n ZONE_DEVICE compound pages","submitter":{"id":76330,"url":"http://patchwork.ozlabs.org/api/people/76330/","name":"Oscar Salvador","email":"osalvador@suse.de"},"content":"On Tue, Apr 21, 2026 at 10:20:44AM +0800, Muchun Song wrote:\n> The memmap_init_zone_device() function only initializes the migratetype\n> of the first pageblock of a compound page. If the compound page size\n> exceeds pageblock_nr_pages (e.g., 1GB hugepages with 2MB pageblocks),\n> subsequent pageblocks in the compound page remain uninitialized.\n> \n> Move the migratetype initialization out of __init_zone_device_page()\n> and into a separate pageblock_migratetype_init_range() function. This\n> iterates over the entire PFN range of the memory, ensuring that all\n> pageblocks are correctly initialized.\n> \n> Fixes: c4386bd8ee3a (\"mm/memremap: add ZONE_DEVICE support for compound pages\")\n> Signed-off-by: Muchun Song <songmuchun@bytedance.com>\n> Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>\n\nWould not the call to __init_zone_device_page() from\nmemmap_init_compound() take care of the subsequent pageblocks?","headers":{"Return-Path":"\n <linuxppc-dev+bounces-19866-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=uS9iGCHG;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=p7mef9cN;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=cpuTQ+E+;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=kOVwBphL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19866-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=195.135.223.131","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=uS9iGCHG;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=p7mef9cN;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=cpuTQ+E+;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=kOVwBphL;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=suse.de\n (client-ip=195.135.223.131; helo=smtp-out2.suse.de;\n envelope-from=osalvador@suse.de; receiver=lists.ozlabs.org)","smtp-out2.suse.de;\n\tdkim=pass header.d=suse.de header.s=susede2_rsa header.b=cpuTQ+E+;\n\tdkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=kOVwBphL"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g08CZ5SFbz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 14:15:22 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g08CZ0xb2z2yl2;\n\tTue, 21 Apr 2026 14:15:22 +1000 (AEST)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g08CX70v4z2xc8\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 21 Apr 2026 14:15:20 +1000 (AEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out2.suse.de (Postfix) with ESMTPS id 081445BCDE;\n\tTue, 21 Apr 2026 04:15:17 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3596C593AF;\n\tTue, 21 Apr 2026 04:15:16 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid XgNfCtT55mlKcQAAD6G6ig\n\t(envelope-from <osalvador@suse.de>); Tue, 21 Apr 2026 04:15:16 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776744921;\n\tcv=none;\n b=SPCUavdhbv7dGPgBFwJJOnV8TBWbttFO2FXyH5N57DRHwWUYA8AUDwX6uuwW22mfV14/fx6/jVUi07daU2VvO+A2/cLiLqSOxxccxeu1SFRtavVtzVVwM5sL6++oUIbbrQgw79S7C0+ZL0OymyPnqUqbXt1K/Vh8zXbKPydB8HOuFszxVpGCivl0r1MQcc9l0NYQLVdVYN7j1UfxvUx16FzyKpX1iJHd/CzXgj8F6+fTAheIrsTDZc8FEn2x4O/4kfB2lL83jpvDo1/wPu9JIkK3WPmTXZaiuV6E8CWYSTrAsGscx5kuJdlIRq8TaTZe5TO3Uu+ddXimdBr5ZAVENg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776744921; c=relaxed/relaxed;\n\tbh=uYdfvAwxiyPMyDiaQbfwV8KtgdCe2VZI2NMXSwdaNgE=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=VNx0ZvSje2z8L7Qwx4G+CAI71aBNY9S8NX0YZwY6mBJ5dYLXvzOqhkBK+X5m66+7JYKn3B8og4zmr0w6ZPVlsotMS2ExtqDmYgeaNOUYVD3ocYU4fSCrR2m3YPOgOZHusihLqSLjg2vlmY6AQVFmYoSsuu8Eef3ApXic86SYCxZZwZQoqMkU9YcxLMlbbkTzTQj+DSTiW0I5c2nFgvZHUtQru0KMSWL416c1YGSNfrqazBkwBS2fGrisRfRV98Qd2ic4IAG1L04zEleQz81Rs/sMDdpFwW6KrOygKudHNuVKAmFu4EArtm0QYz3fOFoTroE3FoWajRBsBu3Lfy05fg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=suse.de; dkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=uS9iGCHG;\n dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=p7mef9cN;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=cpuTQ+E+;\n dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=kOVwBphL; dkim-atps=neutral;\n spf=pass (client-ip=195.135.223.131; helo=smtp-out2.suse.de;\n envelope-from=osalvador@suse.de;\n receiver=lists.ozlabs.org) smtp.mailfrom=suse.de","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1776744918;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=uYdfvAwxiyPMyDiaQbfwV8KtgdCe2VZI2NMXSwdaNgE=;\n\tb=uS9iGCHGvQBvNjSEu7edu6oNLt8+F8xuB14yELkLOpQXxsadBzPWYhYrLFMWJ5xeP4RXPy\n\t7fK1+lMia3dCqF6jVB1s2fI5UMUZ4ohsPgZkvCopOhhOIWKfQx1tcb/zHmuP0a+DFD3yyP\n\tqXGIELXY2L6XxYIpuhKHMEqYU5b2gkg=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1776744918;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=uYdfvAwxiyPMyDiaQbfwV8KtgdCe2VZI2NMXSwdaNgE=;\n\tb=p7mef9cNPGGWOlV5QoGVD8FI4gSIyoIfKK84yBtIOL5JQayGTZOAicEdBbzu9La5ub8ohx\n\tjo5vIKxwS5L9X5Cg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1776744917;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=uYdfvAwxiyPMyDiaQbfwV8KtgdCe2VZI2NMXSwdaNgE=;\n\tb=cpuTQ+E+r7kTV8su6DV45tSpkDqiqAmOUrQLPENj4/AZz9HS4NLvUWR3OHW35ULaAeCxPE\n\toKRpodFPNyB6j0ipMhOXQ0/Bh61IgyRSZRnHDMqfwsuXp+Gv5FHQve2aC+hX2NAwU7nI9c\n\tStPlzoQgu0KV8rWMEml9gGVzcJwxZw4=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1776744917;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=uYdfvAwxiyPMyDiaQbfwV8KtgdCe2VZI2NMXSwdaNgE=;\n\tb=kOVwBphL1mwqz+a1WqHY8SR63zj4AFkCC6JimPdReMUw2CHVWxLTudR1U48kpj8Zu/Dv7g\n\t209xASf4ob/zMYAg=="],"Date":"Tue, 21 Apr 2026 06:15:14 +0200","From":"Oscar Salvador <osalvador@suse.de>","To":"Muchun Song <songmuchun@bytedance.com>","Cc":"Andrew Morton <akpm@linux-foundation.org>,\n\tDavid Hildenbrand <david@kernel.org>,\n\tMuchun Song <muchun.song@linux.dev>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n\tMike Rapoport <rppt@kernel.org>, Lorenzo Stoakes <ljs@kernel.org>,\n\t\"Liam R . Howlett\" <Liam.Howlett@oracle.com>,\n\tVlastimil Babka <vbabka@kernel.org>,\n\tSuren Baghdasaryan <surenb@google.com>,\n\tMichal Hocko <mhocko@suse.com>, Nicholas Piggin <npiggin@gmail.com>,\n\tChristophe Leroy <chleroy@kernel.org>, aneesh.kumar@linux.ibm.com,\n\tjoao.m.martins@oracle.com, linux-mm@kvack.org,\n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH v3 4/4] mm/mm_init: Fix pageblock migratetype for\n ZONE_DEVICE compound pages","Message-ID":"<aeb50jwoCBvgEnec@localhost.localdomain>","References":"<20260421022044.1217503-1-songmuchun@bytedance.com>\n <20260421022044.1217503-5-songmuchun@bytedance.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260421022044.1217503-5-songmuchun@bytedance.com>","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-4.51 / 50.00];\n\tBAYES_HAM(-3.00)[100.00%];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tR_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tNEURAL_HAM_SHORT(-0.20)[-1.000];\n\tMIME_GOOD(-0.10)[text/plain];\n\tMX_GOOD(-0.01)[];\n\tDKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tRBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tFUZZY_RATELIMITED(0.00)[rspamd.com];\n\tARC_NA(0.00)[];\n\tRCPT_COUNT_TWELVE(0.00)[19];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[];\n\tMIME_TRACE(0.00)[0:+];\n\tSPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tFREEMAIL_ENVRCPT(0.00)[gmail.com];\n\tFREEMAIL_CC(0.00)[linux-foundation.org,kernel.org,linux.dev,ellerman.id.au,linux.ibm.com,oracle.com,google.com,suse.com,gmail.com,kvack.org,lists.ozlabs.org,vger.kernel.org];\n\tRCVD_TLS_ALL(0.00)[];\n\tRCVD_COUNT_TWO(0.00)[2];\n\tFROM_EQ_ENVFROM(0.00)[];\n\tFROM_HAS_DN(0.00)[];\n\tTO_DN_SOME(0.00)[];\n\tDNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from];\n\tRCVD_VIA_SMTP_AUTH(0.00)[];\n\tRECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n\tDKIM_TRACE(0.00)[suse.de:+];\n\tMISSING_XM_UA(0.00)[];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[bytedance.com:email,suse.de:dkim,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,localhost.localdomain:mid]","X-Rspamd-Queue-Id":"081445BCDE","X-Spam-Score":"-4.51","X-Spam-Level":"","X-Spam-Status":"No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3679698,"web_url":"http://patchwork.ozlabs.org/comment/3679698/","msgid":"<9343F329-BCD4-4D64-94CB-A94F0E9E4400@linux.dev>","date":"2026-04-21T06:54:35","subject":"Re: [PATCH v3 4/4] mm/mm_init: Fix pageblock migratetype for\n ZONE_DEVICE compound pages","submitter":{"id":84878,"url":"http://patchwork.ozlabs.org/api/people/84878/","name":"Muchun Song","email":"muchun.song@linux.dev"},"content":"> On Apr 21, 2026, at 12:15, Oscar Salvador <osalvador@suse.de> wrote:\n> \n> On Tue, Apr 21, 2026 at 10:20:44AM +0800, Muchun Song wrote:\n>> The memmap_init_zone_device() function only initializes the migratetype\n>> of the first pageblock of a compound page. If the compound page size\n>> exceeds pageblock_nr_pages (e.g., 1GB hugepages with 2MB pageblocks),\n>> subsequent pageblocks in the compound page remain uninitialized.\n>> \n>> Move the migratetype initialization out of __init_zone_device_page()\n>> and into a separate pageblock_migratetype_init_range() function. This\n>> iterates over the entire PFN range of the memory, ensuring that all\n>> pageblocks are correctly initialized.\n>> \n>> Fixes: c4386bd8ee3a (\"mm/memremap: add ZONE_DEVICE support for compound pages\")\n>> Signed-off-by: Muchun Song <songmuchun@bytedance.com>\n>> Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>\n> \n> Would not the call to __init_zone_device_page() from\n> memmap_init_compound() take care of the subsequent pageblocks?\n> \n\nNo, it won't handle them automatically, as the page count from\ncompound_nr_pages doesn't cover the following pageblocks.\n\nThanks.\nMuchun\n\n> \n> -- \n> Oscar Salvador\n> SUSE Labs","headers":{"Return-Path":"\n <linuxppc-dev+bounces-19869-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256\n header.s=key1 header.b=pk7L4Wn0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19869-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=95.215.58.183","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.dev","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256\n header.s=key1 header.b=pk7L4Wn0;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.dev\n (client-ip=95.215.58.183; helo=out-183.mta1.migadu.com;\n envelope-from=muchun.song@linux.dev; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0Cmc3m7Vz1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 16:55:44 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g0Cmb58k5z2yfS;\n\tTue, 21 Apr 2026 16:55:43 +1000 (AEST)","from out-183.mta1.migadu.com (out-183.mta1.migadu.com\n [95.215.58.183])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g0CmW5t7Vz2xlK\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 21 Apr 2026 16:55:39 +1000 (AEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776754543;\n\tcv=none;\n b=HdDRIFD+oP60DtmHZqrjLrEvVjUaS/ae0BKF2B6H7oM1Zii0+boRFAlszVabYotfknTpooO4DYeBMeLuKfkYETw82Gogu9qUll1Q4doawblL8FBH02KEYVQQ3lmfZ2fw6X3Ei5xxA9xslwRRqS+rlILnXryvVSG9YVION16Ehy+Y74RUWJTj+JJjYItIH8C26AywOt+I/dyXY5YcBLgi8Wdnxiqh1R7oWUHqyxeBU4TrERlPZWHwpVBdluJi6ALb4d5uYhjS/9ZeXPD6Ivvmp1VYFK6aItg62jQWa3+X9zCqefVFKsFmZSErjvS0C38nh9twiE9up8Lm/o7GKws/lQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776754543; c=relaxed/relaxed;\n\tbh=NxUMcETQuixlF3rMQVkit9JIIkPJRX+G/qfMeu7OkdM=;\n\th=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:\n\t Message-Id:References:To;\n b=SvSPMXFBLvF0rev0hfI+FfiE6yEcA/xmwInQgrrzVvLcGnsRsEEkame+h2ICtmqSmKRCRe2jnuXl7ru29NwFWwUN0mSIUusPloy2tgIyuaESH25uaiU55CHTL+NBmxac/mvKYcROAkSKOWLCfa5SvMjwxDEe/G0dl2vMv/OhQyz1T4NnS46RZoejeZuG5YJ+LiyKd8n+NP2LPFyvX/iSGTII5e6ahObwQn2wh09WkHGED3qRm0e3QFM91dpBDvRsfibww+elwPDPN2mpBvAgjf3Z33eYnwBdEmTOC+NxYjzjOZ6gnfaYoj3XBeZfpbp7BcjQAN/GkRmAoLwSJqqrRQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.dev; dkim=pass (1024-bit key;\n unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256\n header.s=key1 header.b=pk7L4Wn0; dkim-atps=neutral;\n spf=pass (client-ip=95.215.58.183; helo=out-183.mta1.migadu.com;\n envelope-from=muchun.song@linux.dev;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.dev","Content-Type":"text/plain;\n\tcharset=us-ascii","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;\n\tt=1776754518;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=NxUMcETQuixlF3rMQVkit9JIIkPJRX+G/qfMeu7OkdM=;\n\tb=pk7L4Wn0WxtolMrucH5sGuAJaeIzkBSFPNvgmYguRp0KXfsGDOalpq6EmsLz1HMn16rkdY\n\tl0JFXPxWXTYv9tEqYaXY7XCrs0hWc13c9n6czix2oXutSiup0LJg5lsBelcDL3AKWYgmYK\n\t+n+6x5MrhJgRcfdkMcXYW1/1Aw1QdpI=","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","Mime-Version":"1.0 (Mac OS X Mail 16.0 \\(3864.500.181\\))","Subject":"Re: [PATCH v3 4/4] mm/mm_init: Fix pageblock migratetype for\n ZONE_DEVICE compound pages","X-Report-Abuse":"Please report any abuse attempt to abuse@migadu.com and\n include these headers.","From":"Muchun Song <muchun.song@linux.dev>","In-Reply-To":"<aeb50jwoCBvgEnec@localhost.localdomain>","Date":"Tue, 21 Apr 2026 14:54:35 +0800","Cc":"Muchun Song <songmuchun@bytedance.com>,\n Andrew Morton <akpm@linux-foundation.org>,\n David Hildenbrand <david@kernel.org>,\n Michael Ellerman <mpe@ellerman.id.au>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Mike Rapoport <rppt@kernel.org>,\n Lorenzo Stoakes <ljs@kernel.org>,\n \"Liam R . Howlett\" <Liam.Howlett@oracle.com>,\n Vlastimil Babka <vbabka@kernel.org>,\n Suren Baghdasaryan <surenb@google.com>,\n Michal Hocko <mhocko@suse.com>,\n Nicholas Piggin <npiggin@gmail.com>,\n Christophe Leroy <chleroy@kernel.org>,\n aneesh.kumar@linux.ibm.com,\n joao.m.martins@oracle.com,\n linux-mm@kvack.org,\n linuxppc-dev@lists.ozlabs.org,\n linux-kernel@vger.kernel.org","Content-Transfer-Encoding":"quoted-printable","Message-Id":"<9343F329-BCD4-4D64-94CB-A94F0E9E4400@linux.dev>","References":"<20260421022044.1217503-1-songmuchun@bytedance.com>\n <20260421022044.1217503-5-songmuchun@bytedance.com>\n <aeb50jwoCBvgEnec@localhost.localdomain>","To":"Oscar Salvador <osalvador@suse.de>","X-Migadu-Flow":"FLOW_OUT","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3679708,"web_url":"http://patchwork.ozlabs.org/comment/3679708/","msgid":"<aecnZzXiFf2n70K6@localhost.localdomain>","date":"2026-04-21T07:29:43","subject":"Re: [PATCH v3 4/4] mm/mm_init: Fix pageblock migratetype for\n ZONE_DEVICE compound pages","submitter":{"id":76330,"url":"http://patchwork.ozlabs.org/api/people/76330/","name":"Oscar Salvador","email":"osalvador@suse.de"},"content":"On Tue, Apr 21, 2026 at 02:54:35PM +0800, Muchun Song wrote:\n> \n> \n> > On Apr 21, 2026, at 12:15, Oscar Salvador <osalvador@suse.de> wrote:\n> > \n> > On Tue, Apr 21, 2026 at 10:20:44AM +0800, Muchun Song wrote:\n> >> The memmap_init_zone_device() function only initializes the migratetype\n> >> of the first pageblock of a compound page. If the compound page size\n> >> exceeds pageblock_nr_pages (e.g., 1GB hugepages with 2MB pageblocks),\n> >> subsequent pageblocks in the compound page remain uninitialized.\n> >> \n> >> Move the migratetype initialization out of __init_zone_device_page()\n> >> and into a separate pageblock_migratetype_init_range() function. This\n> >> iterates over the entire PFN range of the memory, ensuring that all\n> >> pageblocks are correctly initialized.\n> >> \n> >> Fixes: c4386bd8ee3a (\"mm/memremap: add ZONE_DEVICE support for compound pages\")\n> >> Signed-off-by: Muchun Song <songmuchun@bytedance.com>\n> >> Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>\n\nReviewed-by: Oscar Salvador <osalvador@suse.de>\n\n> > Would not the call to __init_zone_device_page() from\n> > memmap_init_compound() take care of the subsequent pageblocks?\n> > \n> \n> No, it won't handle them automatically, as the page count from\n> compound_nr_pages doesn't cover the following pageblocks.\n\nOk, I see.","headers":{"Return-Path":"\n <linuxppc-dev+bounces-19870-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=xEksfWTK;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qUQJoihJ;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=xEksfWTK;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qUQJoihJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19870-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=195.135.223.131","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=xEksfWTK;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qUQJoihJ;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=xEksfWTK;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qUQJoihJ;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=suse.de\n (client-ip=195.135.223.131; helo=smtp-out2.suse.de;\n envelope-from=osalvador@suse.de; receiver=lists.ozlabs.org)","smtp-out2.suse.de;\n\tdkim=pass header.d=suse.de header.s=susede2_rsa header.b=xEksfWTK;\n\tdkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qUQJoihJ"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0DX76qRYz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 17:29:59 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g0DX64T3hz2yfS;\n\tTue, 21 Apr 2026 17:29:58 +1000 (AEST)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g0DX55tx4z2yFl\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 21 Apr 2026 17:29:57 +1000 (AEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out2.suse.de (Postfix) with ESMTPS id 1D01F5BCDE;\n\tTue, 21 Apr 2026 07:29:54 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 29EF1593AF;\n\tTue, 21 Apr 2026 07:29:53 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid h3awB3En52n4KQAAD6G6ig\n\t(envelope-from <osalvador@suse.de>); Tue, 21 Apr 2026 07:29:53 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776756598;\n\tcv=none;\n b=Z1rD3VaXToKcQulogDCkjxtZN/KKc3aKRkTdkOLHyYKWRJWFAfA7WABMrLkSh1WBi1MF5HFBg2dNbIRhuVCa/NYRFUzQXpV2wYKd2KvPQSJBo5OUUdpIMikBSAxT/RIAdDtUvZ9GMpBMAQAe46xwjLzfGtx7yBebiqUv1djPC6IeVHihdT047dpjreo2DUJo3bXk9WIQVicBQFQL7wo8DX7DS4s60f0ZVqa7vsenabZ7vlv8JpA90myY7MAZF3sAdm6y6/DobGAlx968mYucjjFXsxcS8p70fVUHaBoX4zaDn8+NIgbFnTUQZxz7mxXltVcVchax/V03cXhiKgJpPg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776756598; c=relaxed/relaxed;\n\tbh=VmpWofTIlMRvaJ2R/6EdvLQ0b7yTNFErU+2L4jvVqZ0=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=IuVS2ktzRVycg4B1LpvpK0K7IaewoBpc9FDUZwkLfgayFKD5LzqqULQEzcJg2FHFN9SWaXY3GZVOzdKU6SEmcFW6P/llEmSaZvKSxDp+BBop6R/ne5mI0MTeaKI6n+MfwVTZK3Mj9Xsw0u9lXg3nQTIiMG1R9bf/2k4NLTkIDjiIcYMxXHsv24cC+eaCVDv6rpxV+hzQEweFEf9ib/HG8UCaDTDhNX7lxmXWc6M+K6ujaNOgsmlpLwS6ew+tS4M0aMBrVAM5Hypk2fTegJ3TLKGUv/Gjn+gYVMrSLbuLBbhSUsVsocJ0P3w9PG3GGQHYnHaxfaBNTkOxlDfw16ihZw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=suse.de; dkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=xEksfWTK;\n dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qUQJoihJ;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=xEksfWTK;\n dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qUQJoihJ; dkim-atps=neutral;\n spf=pass (client-ip=195.135.223.131; helo=smtp-out2.suse.de;\n envelope-from=osalvador@suse.de;\n receiver=lists.ozlabs.org) smtp.mailfrom=suse.de","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1776756594;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=VmpWofTIlMRvaJ2R/6EdvLQ0b7yTNFErU+2L4jvVqZ0=;\n\tb=xEksfWTK1V92y20VMkyzbGQOjYDBcGO/gWhbuEyYcKEa+ycQJF5wp6W1MB99niJpWx84bk\n\tW102vN7KyOIr6MqHMYJybMDcZq3J2H9McFMkisag+oyd1sTqcBj297x6+VRYxdvpWNxDqR\n\tKE+NO28lRXCJDE79c/TuvwYc7Xv70SQ=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1776756594;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=VmpWofTIlMRvaJ2R/6EdvLQ0b7yTNFErU+2L4jvVqZ0=;\n\tb=qUQJoihJzeuHaNAO0HLLA7EYBdbRP/1+UK8T4zmec7ce/r6WXBask/Hk9tiJ3dN4AMFxNZ\n\tFodFjuFZWHSg7QAQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1776756594;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=VmpWofTIlMRvaJ2R/6EdvLQ0b7yTNFErU+2L4jvVqZ0=;\n\tb=xEksfWTK1V92y20VMkyzbGQOjYDBcGO/gWhbuEyYcKEa+ycQJF5wp6W1MB99niJpWx84bk\n\tW102vN7KyOIr6MqHMYJybMDcZq3J2H9McFMkisag+oyd1sTqcBj297x6+VRYxdvpWNxDqR\n\tKE+NO28lRXCJDE79c/TuvwYc7Xv70SQ=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1776756594;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=VmpWofTIlMRvaJ2R/6EdvLQ0b7yTNFErU+2L4jvVqZ0=;\n\tb=qUQJoihJzeuHaNAO0HLLA7EYBdbRP/1+UK8T4zmec7ce/r6WXBask/Hk9tiJ3dN4AMFxNZ\n\tFodFjuFZWHSg7QAQ=="],"Date":"Tue, 21 Apr 2026 09:29:43 +0200","From":"Oscar Salvador <osalvador@suse.de>","To":"Muchun Song <muchun.song@linux.dev>","Cc":"Muchun Song <songmuchun@bytedance.com>,\n\tAndrew Morton <akpm@linux-foundation.org>,\n\tDavid Hildenbrand <david@kernel.org>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n\tMike Rapoport <rppt@kernel.org>, Lorenzo Stoakes <ljs@kernel.org>,\n\t\"Liam R . Howlett\" <Liam.Howlett@oracle.com>,\n\tVlastimil Babka <vbabka@kernel.org>,\n\tSuren Baghdasaryan <surenb@google.com>,\n\tMichal Hocko <mhocko@suse.com>, Nicholas Piggin <npiggin@gmail.com>,\n\tChristophe Leroy <chleroy@kernel.org>, aneesh.kumar@linux.ibm.com,\n\tjoao.m.martins@oracle.com, linux-mm@kvack.org,\n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH v3 4/4] mm/mm_init: Fix pageblock migratetype for\n ZONE_DEVICE compound pages","Message-ID":"<aecnZzXiFf2n70K6@localhost.localdomain>","References":"<20260421022044.1217503-1-songmuchun@bytedance.com>\n <20260421022044.1217503-5-songmuchun@bytedance.com>\n <aeb50jwoCBvgEnec@localhost.localdomain>\n <9343F329-BCD4-4D64-94CB-A94F0E9E4400@linux.dev>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<9343F329-BCD4-4D64-94CB-A94F0E9E4400@linux.dev>","X-Spamd-Result":"default: False [-4.51 / 50.00];\n\tBAYES_HAM(-3.00)[100.00%];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tR_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tNEURAL_HAM_SHORT(-0.20)[-1.000];\n\tMIME_GOOD(-0.10)[text/plain];\n\tMX_GOOD(-0.01)[];\n\tFREEMAIL_ENVRCPT(0.00)[gmail.com];\n\tDKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tFUZZY_RATELIMITED(0.00)[rspamd.com];\n\tRBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tSPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tARC_NA(0.00)[];\n\tRCPT_COUNT_TWELVE(0.00)[19];\n\tMIME_TRACE(0.00)[0:+];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[];\n\tFREEMAIL_CC(0.00)[bytedance.com,linux-foundation.org,kernel.org,ellerman.id.au,linux.ibm.com,oracle.com,google.com,suse.com,gmail.com,kvack.org,lists.ozlabs.org,vger.kernel.org];\n\tRCVD_TLS_ALL(0.00)[];\n\tRCVD_COUNT_TWO(0.00)[2];\n\tFROM_EQ_ENVFROM(0.00)[];\n\tFROM_HAS_DN(0.00)[];\n\tTO_DN_SOME(0.00)[];\n\tRECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n\tMISSING_XM_UA(0.00)[];\n\tRCVD_VIA_SMTP_AUTH(0.00)[];\n\tDKIM_TRACE(0.00)[suse.de:+];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]","X-Rspamd-Action":"no action","X-Spam-Score":"-4.51","X-Spam-Level":"","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Queue-Id":"1D01F5BCDE","X-Spam-Status":"No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3679770,"web_url":"http://patchwork.ozlabs.org/comment/3679770/","msgid":"<67CABBD2-FA75-40D0-909D-9B6A523CCC8C@linux.dev>","date":"2026-04-21T09:31:36","subject":"Re: [PATCH v3 4/4] mm/mm_init: Fix pageblock migratetype for\n ZONE_DEVICE compound pages","submitter":{"id":84878,"url":"http://patchwork.ozlabs.org/api/people/84878/","name":"Muchun Song","email":"muchun.song@linux.dev"},"content":"> On Apr 21, 2026, at 10:20, Muchun Song <songmuchun@bytedance.com> wrote:\n> \n> The memmap_init_zone_device() function only initializes the migratetype\n> of the first pageblock of a compound page. If the compound page size\n> exceeds pageblock_nr_pages (e.g., 1GB hugepages with 2MB pageblocks),\n> subsequent pageblocks in the compound page remain uninitialized.\n> \n> Move the migratetype initialization out of __init_zone_device_page()\n> and into a separate pageblock_migratetype_init_range() function. This\n> iterates over the entire PFN range of the memory, ensuring that all\n> pageblocks are correctly initialized.\n> \n> Fixes: c4386bd8ee3a (\"mm/memremap: add ZONE_DEVICE support for compound pages\")\n> Signed-off-by: Muchun Song <songmuchun@bytedance.com>\n> Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>\n> ---\n> mm/mm_init.c | 43 ++++++++++++++++++++++++++++---------------\n> 1 file changed, 28 insertions(+), 15 deletions(-)\n> \n> diff --git a/mm/mm_init.c b/mm/mm_init.c\n> index f9f8e1af921c..e2d8eae23aa3 100644\n> --- a/mm/mm_init.c\n> +++ b/mm/mm_init.c\n> @@ -674,6 +674,19 @@ static inline void fixup_hashdist(void)\n> static inline void fixup_hashdist(void) {}\n> #endif /* CONFIG_NUMA */\n> \n> +static __meminit void pageblock_migratetype_init_range(unsigned long pfn,\n> +       unsigned long nr_pages,\n> +       int migratetype)\n> +{\n> + \tunsigned long end = pfn + nr_pages;\n> +\n> + \tfor (pfn = pageblock_align(pfn); pfn < end; pfn += pageblock_nr_pages) {\n> + \t\tinit_pageblock_migratetype(pfn_to_page(pfn), migratetype, false);\n> + \t\tif (IS_ALIGNED(pfn, PAGES_PER_SECTION))\n> + \t\t\tcond_resched();\n> + \t}\n> +}\n\nI found a positive comment from AI review:\n\nThis trigger a -Wunused-function warning when CONFIG_ZONE_DEVICE is\ndisabled.\n\nI'll fix it in the next version.\n\nThanks.","headers":{"Return-Path":"\n <linuxppc-dev+bounces-19873-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256\n header.s=key1 header.b=bF6yocuu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19873-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2001:41d0:1004:224b::ae\"","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.dev","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256\n header.s=key1 header.b=bF6yocuu;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.dev\n (client-ip=2001:41d0:1004:224b::ae; helo=out-174.mta0.migadu.com;\n envelope-from=muchun.song@linux.dev; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0HFp45k8z1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 19:32:46 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g0HFn71X5z2yv3;\n\tTue, 21 Apr 2026 19:32:45 +1000 (AEST)","from out-174.mta0.migadu.com (out-174.mta0.migadu.com\n [IPv6:2001:41d0:1004:224b::ae])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g0HFk2D1tz2ypk\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 21 Apr 2026 19:32:41 +1000 (AEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776763965;\n\tcv=none;\n b=Fn27usUU7LDeOAEYlw9pwj2CZd07mXWKwV8hfNY0oYLyT/kpFUn49FmD2Wdn+yLnNlYUXH3e2awemNIgQ9/wUs6l4iYior70v+iccVFZ96h5ksynsQtVMdg+bUSibtQGEqr7ztWChsFIjcb+mkhM4UVoYe2OSJUJu3ZWjmaZaERGJhRrv658XMxQz9SYXpVjLm7JWsEIF1SOQFHi3PBAdahd8VoYWCptECFyO0cTVXUjiNh/ECdJ+a6d1wCyJrj7YNY0Ds09CQM0OiBdAEakrjwBQGVn7PGNu8ecwUchnf2mLVlCuggLBUm3Dy8dJsYC0MIulGpGR8D88JxveGKxIA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776763965; c=relaxed/relaxed;\n\tbh=H7VXEbbN0/EFAsyspDHjyOjj9f+YNV767eZ9TvCWrBw=;\n\th=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:\n\t Message-Id:References:To;\n b=QL9TSwXpcXPSMOTKQNgIperiVv5dP0ICqmvV5/uZmbIp1XGk9zfehzxZC1qFIfU3SdM3jH8nsW4t/eazqfpRJTdwFoxr7YxIgaREsmSJg7OtNsx1eREDeJ3WlYbjWFqqTlRDuDYQGkdzTMzPO4kTPH0fBtMyp7F1kgV/iskB/iEy6u+PZC71RKRLx4Dclu5OxAtzCgbNxPCthuioOQ6TcTksIOKWZ36jDkDHO4KyzCYFs1f1xPWdYWB8dP85YYQV/ngfB+cSEc+XZ12hOxReKEUvUa817/LtsNGHsiGASv1dLj+dxvlOrKONw5w64i08CKUgsnw2GUK9OIsSTEZuzA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.dev; dkim=pass (1024-bit key;\n unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256\n header.s=key1 header.b=bF6yocuu; dkim-atps=neutral;\n spf=pass (client-ip=2001:41d0:1004:224b::ae; helo=out-174.mta0.migadu.com;\n envelope-from=muchun.song@linux.dev;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.dev","Content-Type":"text/plain;\n\tcharset=us-ascii","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;\n\tt=1776763936;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=H7VXEbbN0/EFAsyspDHjyOjj9f+YNV767eZ9TvCWrBw=;\n\tb=bF6yocuuZ5+0H8Fj7WvzL919cWKgFPNL8PdSdWurzXEOJq1H1pY/1J/qvHbN+HJ1tcyOns\n\t0TRyXPw7yhE8WRPiIeS845fY2+SuhVVLrT/9htCQjcZl2S2MUjm4PP27xLcp0mCQOqZcFn\n\twLmMzaDq8QJtPO4YC1f8nb4g+n+Pv4E=","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","Mime-Version":"1.0 (Mac OS X Mail 16.0 \\(3864.500.181\\))","Subject":"Re: [PATCH v3 4/4] mm/mm_init: Fix pageblock migratetype for\n ZONE_DEVICE compound pages","X-Report-Abuse":"Please report any abuse attempt to abuse@migadu.com and\n include these headers.","From":"Muchun Song <muchun.song@linux.dev>","In-Reply-To":"<20260421022044.1217503-5-songmuchun@bytedance.com>","Date":"Tue, 21 Apr 2026 17:31:36 +0800","Cc":"Andrew Morton <akpm@linux-foundation.org>,\n David Hildenbrand <david@kernel.org>,\n Oscar Salvador <osalvador@suse.de>,\n Michael Ellerman <mpe@ellerman.id.au>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Mike Rapoport <rppt@kernel.org>,\n Lorenzo Stoakes <ljs@kernel.org>,\n \"Liam R . Howlett\" <Liam.Howlett@oracle.com>,\n Vlastimil Babka <vbabka@kernel.org>,\n Suren Baghdasaryan <surenb@google.com>,\n Michal Hocko <mhocko@suse.com>,\n Nicholas Piggin <npiggin@gmail.com>,\n Christophe Leroy <chleroy@kernel.org>,\n aneesh.kumar@linux.ibm.com,\n joao.m.martins@oracle.com,\n linux-mm@kvack.org,\n linuxppc-dev@lists.ozlabs.org,\n linux-kernel@vger.kernel.org","Content-Transfer-Encoding":"quoted-printable","Message-Id":"<67CABBD2-FA75-40D0-909D-9B6A523CCC8C@linux.dev>","References":"<20260421022044.1217503-1-songmuchun@bytedance.com>\n <20260421022044.1217503-5-songmuchun@bytedance.com>","To":"Muchun Song <songmuchun@bytedance.com>","X-Migadu-Flow":"FLOW_OUT","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]