[{"id":3679662,"web_url":"http://patchwork.ozlabs.org/comment/3679662/","msgid":"<aeb2U5tUQQe1YzJY@localhost.localdomain>","date":"2026-04-21T04:00:19","subject":"Re: [PATCH v3 3/4] mm/sparse-vmemmap: Fix DAX vmemmap accounting\n with optimization","submitter":{"id":76330,"url":"http://patchwork.ozlabs.org/api/people/76330/","name":"Oscar Salvador","email":"osalvador@suse.de"},"content":"On Tue, Apr 21, 2026 at 10:20:43AM +0800, Muchun Song wrote:\n> When vmemmap optimization is enabled for DAX, the nr_memmap_pages\n> counter in /proc/vmstat is incorrect. The current code always accounts\n> for the full, non-optimized vmemmap size, but vmemmap optimization\n> reduces the actual number of vmemmap pages by reusing tail pages. This\n> causes the system to overcount vmemmap usage, leading to inaccurate\n> page statistics in /proc/vmstat.\n> \n> Fix this by introducing section_vmemmap_pages(), which returns the exact\n> vmemmap page count for a given pfn range based on whether optimization\n> is in effect.\n> \n> Fixes: 15995a352474 (\"mm: report per-page metadata information\")\n> Signed-off-by: Muchun Song <songmuchun@bytedance.com>\n> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>\n\nAcked-by: Oscar Salvador <osalvador@suse.de>","headers":{"Return-Path":"\n <linuxppc-dev+bounces-19864-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=l/rWzc7W;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qkBNhF1f;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=l/rWzc7W;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qkBNhF1f;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19864-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2a07:de40:b251:101:10:150:64:2\"","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=l/rWzc7W;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qkBNhF1f;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=l/rWzc7W;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qkBNhF1f;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=suse.de\n (client-ip=2a07:de40:b251:101:10:150:64:2; helo=smtp-out2.suse.de;\n envelope-from=osalvador@suse.de; receiver=lists.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g07tT5V2Yz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 14:00:33 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g07tT1njlz2yl2;\n\tTue, 21 Apr 2026 14:00:33 +1000 (AEST)","from smtp-out2.suse.de (smtp-out2.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g07tS3ZNFz2xc8\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 21 Apr 2026 14:00:32 +1000 (AEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out2.suse.de (Postfix) with ESMTPS id F05785BCDB;\n\tTue, 21 Apr 2026 04:00:29 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EB57A593AF;\n\tTue, 21 Apr 2026 04:00:28 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid CS6oNlz25mnwYwAAD6G6ig\n\t(envelope-from <osalvador@suse.de>); Tue, 21 Apr 2026 04:00:28 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776744033;\n\tcv=none;\n b=I3kpI2EkjmqJY961NsjFbL22KzdaUptZtgWB6N4Q+Vu1WthCvScgt4UIHC16/P0ZkZsAF43lQmniaSquBsU8C3ztuPb1Q97kfMd9yHftufJiGn27oSshB7iV7iT6qLbHJrdv8OKWtrvpzdMVbJzmt29gBpXeDbiz65yJT8OyK3KXZw2hdFSAOSVvH3Gq5OPaCgySFcA4ZnAjr084KOJhNxNBiLJ191/+jJoca56eZHg2PxU2MuhSYJdqTHJCx3k44Yn2m4E1FhRdzS015L620M9LVF97fbPGsqm15oocszWmeTqMA7CjeuohFlJsmZhwiBOT1jh5ad5SZO0QkgB+Ag==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776744033; c=relaxed/relaxed;\n\tbh=4A0ljlz7kc/WriQ+M/v/RuPawRjA5LvJ8/tA1kiAeS0=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=oQ31R+1QSmk4opM2x7mNmboxEdxvQXeiHURQE9n42NWZD22Qq9hUA1LTN6vpg792TCnYlFamyUq9MIhlVXmsheugbJ6wlw7lslamRzcth9o09PFr9reK5oVaOwiZ/SJY8sAwkQEqvJBKQx+IvzfvOse/5QjsHpNiwtrUDBQgsL7O4jbWaxQcN6/AAcicOS7z85kVP2D8N2y+AFJVAk6t5HH498noTZIE11HOWTkMOAsuCnQO598+z6nrpKi2+tRWOiuj2pr9yQqO5PfIBmdyz8VxGP4OC0zpWOFhDE+zZ6963va/kTUh9iZNbeaPiD89Vm6lNvE1W3t2dM6yPFei8A==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=suse.de; dkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=l/rWzc7W;\n dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qkBNhF1f;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=l/rWzc7W;\n dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qkBNhF1f; dkim-atps=neutral;\n spf=pass (client-ip=2a07:de40:b251:101:10:150:64:2; helo=smtp-out2.suse.de;\n envelope-from=osalvador@suse.de;\n receiver=lists.ozlabs.org) smtp.mailfrom=suse.de","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1776744030;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=4A0ljlz7kc/WriQ+M/v/RuPawRjA5LvJ8/tA1kiAeS0=;\n\tb=l/rWzc7WXlG1ul7xO38sOUa9Pgk1j890efsw9F/Rih7jfUqvFT7L7nTXY3ZWZA+jmp0C2r\n\tdBUr61YekC/8vZQR31aqOPcgWTO2+xJhDf4A5Qr0ZTSZxy/UAguM2PH0P5ivfSBvxWJjHF\n\tCWxvRGDpMuS2nfweEHs4sK/nYABxexs=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1776744030;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=4A0ljlz7kc/WriQ+M/v/RuPawRjA5LvJ8/tA1kiAeS0=;\n\tb=qkBNhF1fpYtHAmCt1yloAGLz1VUrShhp9DtGMDvaI/6hb/adOboe+fZLsHz1I9RCe4JdVg\n\tsnuwQAq3XP92dLAA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1776744030;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=4A0ljlz7kc/WriQ+M/v/RuPawRjA5LvJ8/tA1kiAeS0=;\n\tb=l/rWzc7WXlG1ul7xO38sOUa9Pgk1j890efsw9F/Rih7jfUqvFT7L7nTXY3ZWZA+jmp0C2r\n\tdBUr61YekC/8vZQR31aqOPcgWTO2+xJhDf4A5Qr0ZTSZxy/UAguM2PH0P5ivfSBvxWJjHF\n\tCWxvRGDpMuS2nfweEHs4sK/nYABxexs=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1776744030;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=4A0ljlz7kc/WriQ+M/v/RuPawRjA5LvJ8/tA1kiAeS0=;\n\tb=qkBNhF1fpYtHAmCt1yloAGLz1VUrShhp9DtGMDvaI/6hb/adOboe+fZLsHz1I9RCe4JdVg\n\tsnuwQAq3XP92dLAA=="],"Date":"Tue, 21 Apr 2026 06:00:19 +0200","From":"Oscar Salvador <osalvador@suse.de>","To":"Muchun Song <songmuchun@bytedance.com>","Cc":"Andrew Morton <akpm@linux-foundation.org>,\n\tDavid Hildenbrand <david@kernel.org>,\n\tMuchun Song <muchun.song@linux.dev>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n\tMike Rapoport <rppt@kernel.org>, Lorenzo Stoakes <ljs@kernel.org>,\n\t\"Liam R . Howlett\" <Liam.Howlett@oracle.com>,\n\tVlastimil Babka <vbabka@kernel.org>,\n\tSuren Baghdasaryan <surenb@google.com>,\n\tMichal Hocko <mhocko@suse.com>, Nicholas Piggin <npiggin@gmail.com>,\n\tChristophe Leroy <chleroy@kernel.org>, aneesh.kumar@linux.ibm.com,\n\tjoao.m.martins@oracle.com, linux-mm@kvack.org,\n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH v3 3/4] mm/sparse-vmemmap: Fix DAX vmemmap accounting\n with optimization","Message-ID":"<aeb2U5tUQQe1YzJY@localhost.localdomain>","References":"<20260421022044.1217503-1-songmuchun@bytedance.com>\n <20260421022044.1217503-4-songmuchun@bytedance.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260421022044.1217503-4-songmuchun@bytedance.com>","X-Spam-Score":"-8.30","X-Spam-Level":"","X-Spamd-Result":"default: False [-8.30 / 50.00];\n\tREPLY(-4.00)[];\n\tBAYES_HAM(-3.00)[100.00%];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tNEURAL_HAM_SHORT(-0.20)[-1.000];\n\tMIME_GOOD(-0.10)[text/plain];\n\tFUZZY_RATELIMITED(0.00)[rspamd.com];\n\tRCVD_VIA_SMTP_AUTH(0.00)[];\n\tMIME_TRACE(0.00)[0:+];\n\tRCPT_COUNT_TWELVE(0.00)[19];\n\tMISSING_XM_UA(0.00)[];\n\tARC_NA(0.00)[];\n\tRCVD_TLS_ALL(0.00)[];\n\tFREEMAIL_ENVRCPT(0.00)[gmail.com];\n\tDKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tFROM_HAS_DN(0.00)[];\n\tFREEMAIL_CC(0.00)[linux-foundation.org,kernel.org,linux.dev,ellerman.id.au,linux.ibm.com,oracle.com,google.com,suse.com,gmail.com,kvack.org,lists.ozlabs.org,vger.kernel.org];\n\tTO_DN_SOME(0.00)[];\n\tFROM_EQ_ENVFROM(0.00)[];\n\tRCVD_COUNT_TWO(0.00)[2];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,localhost.localdomain:mid,suse.de:email]","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]