[{"id":3679657,"web_url":"http://patchwork.ozlabs.org/comment/3679657/","msgid":"","date":"2026-04-21T03:45:40","subject":"Re: [PATCH v3 1/4] mm/sparse-vmemmap: Fix vmemmap accounting\n underflow","submitter":{"id":76330,"url":"http://patchwork.ozlabs.org/api/people/76330/","name":"Oscar Salvador","email":"osalvador@suse.de"},"content":"On Tue, Apr 21, 2026 at 10:20:41AM +0800, Muchun Song wrote:\n> In section_activate(), if populate_section_memmap() fails, the error\n> handling path calls section_deactivate() to roll back the state. This\n> causes a vmemmap accounting imbalance.\n> \n> Since commit c3576889d87b (\"mm: fix accounting of memmap pages\"),\n> memmap pages are accounted for only after populate_section_memmap()\n> succeeds. However, the failure path unconditionally calls\n> section_deactivate(), which decreases the vmemmap count. Consequently,\n> a failure in populate_section_memmap() leads to an accounting underflow,\n> incorrectly reducing the system's tracked vmemmap usage.\n> \n> Fix this more thoroughly by moving all accounting calls into the lower\n> level functions that actually perform the vmemmap allocation and freeing:\n> \n> - populate_section_memmap() accounts for newly allocated vmemmap pages\n> - depopulate_section_memmap() unaccounts when vmemmap is freed\n> \n> This ensures proper accounting in all code paths, including error\n> handling and early section cases.\n> \n> Fixes: c3576889d87b (\"mm: fix accounting of memmap pages\")\n> Signed-off-by: Muchun Song \n> Acked-by: Mike Rapoport (Microsoft) \n\nAcked-by: Oscar Salvador ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=FwnwfsJN;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=0g7slwHV;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=FwnwfsJN;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=0g7slwHV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19862-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=195.135.223.130","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=FwnwfsJN;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=0g7slwHV;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=FwnwfsJN;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=0g7slwHV;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=suse.de\n (client-ip=195.135.223.130; helo=smtp-out1.suse.de;\n envelope-from=osalvador@suse.de; receiver=lists.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g07Yj0dtMz1yCv\n\tfor ; Tue, 21 Apr 2026 13:45:59 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g07YY12Bbz2yl2;\n\tTue, 21 Apr 2026 13:45:53 +1000 (AEST)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g07YW0BCLz2ySk\n\tfor ; Tue, 21 Apr 2026 13:45:50 +1000 (AEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out1.suse.de (Postfix) with ESMTPS id 46DCF6A7EA;\n\tTue, 21 Apr 2026 03:45:47 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 58617593AF;\n\tTue, 21 Apr 2026 03:45:46 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid U/DjEury5ml4VwAAD6G6ig\n\t(envelope-from ); Tue, 21 Apr 2026 03:45:46 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776743152;\n\tcv=none;\n b=Hj/Ds4RV5vDgUkmUHY4m/ku7wlEbXwWkhdI9DOTNR9vS1NdtaLgsYEUy7GAcQBhamltyJc3+CiGutBB7dwYNzLAXl7EosWDY/95g8LEYxgvsc3Ee9WzvmGq8qy4QoXtl3RYz9FGjOr5//mSY9TRYlDTF8bsrl20+hv0iRq35D0+PJZKCuni+6B7AM4pQHRPrku9UhixHwppIJFWdDLGYDMDm27/MnKipm1S5sLw1J6my7nI2xAUtumiM759PWZ1KZENfr9Rt7scUjTq1IPUiV0c6mcwu7SOyZSW09+YqFlhe4tTy0Ax97lcjme9Uor2WCNNB8nLpDBJPKtyCYFI58Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776743152; c=relaxed/relaxed;\n\tbh=cJfTWXk1mSbZKfRW0DNvuHTmZm6Tw2gEEwGye/AIRbg=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=je7xj/lHoPioc9dYzwEaE8IZTUsQWVscJAI5toWY+x2KvuPsrawLj5YQ+KQpPxl4kppeMvAuOKCd1pmZJ7dDuO4zy8/wKWcOsK4NbfkoZnCdqAhv5SkRaPfS+2ws9xUImcTfw4a+9euHMu+9fCgDyadgDpBOdzA0X4KZBngUqb2uZB++CU6VpAj90ySA5wV7k/mRJnN1gze8lN3gJ6/rKgbBnbxZ221Gqa3LZPKsSDKA3yWBVuFc/dgycKKvzXZxV49EFAiOi8iTz3R2aWWbDe0hb9bteFbXlydVvt8CBaPEknqYy0TwK6sdAQ993CwN4hefUQwQacRCY/lIhhODLg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=suse.de; dkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=FwnwfsJN;\n dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=0g7slwHV;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=FwnwfsJN;\n dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=0g7slwHV; dkim-atps=neutral;\n spf=pass (client-ip=195.135.223.130; helo=smtp-out1.suse.de;\n envelope-from=osalvador@suse.de;\n receiver=lists.ozlabs.org) smtp.mailfrom=suse.de","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1776743147;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=cJfTWXk1mSbZKfRW0DNvuHTmZm6Tw2gEEwGye/AIRbg=;\n\tb=FwnwfsJNvJQyvE7l3cZfssEq4WjipWOchHPpCqYz8LwmH6Lmo4/24QiaMzyyBHixkRk2Oa\n\tMwuJTB0IcEOhwQzhpCCeVMOh9sNxCCEzpo4GLEbJ0KtsHSY19OyMkQDAofkMXzyNPLSRgK\n\txGKCMsBZAoyXj6XV7ATB+ZIxX6pv6qM=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1776743147;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=cJfTWXk1mSbZKfRW0DNvuHTmZm6Tw2gEEwGye/AIRbg=;\n\tb=0g7slwHVd1GI62pXsPEDF4i5WYqsG2QxlBjPi3h2Aoz/fswC+9NDUJM0gq63WiR24nZtWp\n\tRNRv9RnJqNtv4xCw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1776743147;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=cJfTWXk1mSbZKfRW0DNvuHTmZm6Tw2gEEwGye/AIRbg=;\n\tb=FwnwfsJNvJQyvE7l3cZfssEq4WjipWOchHPpCqYz8LwmH6Lmo4/24QiaMzyyBHixkRk2Oa\n\tMwuJTB0IcEOhwQzhpCCeVMOh9sNxCCEzpo4GLEbJ0KtsHSY19OyMkQDAofkMXzyNPLSRgK\n\txGKCMsBZAoyXj6XV7ATB+ZIxX6pv6qM=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1776743147;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=cJfTWXk1mSbZKfRW0DNvuHTmZm6Tw2gEEwGye/AIRbg=;\n\tb=0g7slwHVd1GI62pXsPEDF4i5WYqsG2QxlBjPi3h2Aoz/fswC+9NDUJM0gq63WiR24nZtWp\n\tRNRv9RnJqNtv4xCw=="],"Date":"Tue, 21 Apr 2026 05:45:40 +0200","From":"Oscar Salvador ","To":"Muchun Song ","Cc":"Andrew Morton ,\n\tDavid Hildenbrand ,\n\tMuchun Song ,\n\tMichael Ellerman ,\n\tMadhavan Srinivasan ,\n\tMike Rapoport , Lorenzo Stoakes ,\n\t\"Liam R . Howlett\" ,\n\tVlastimil Babka ,\n\tSuren Baghdasaryan ,\n\tMichal Hocko , Nicholas Piggin ,\n\tChristophe Leroy , aneesh.kumar@linux.ibm.com,\n\tjoao.m.martins@oracle.com, linux-mm@kvack.org,\n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH v3 1/4] mm/sparse-vmemmap: Fix vmemmap accounting\n underflow","Message-ID":"","References":"<20260421022044.1217503-1-songmuchun@bytedance.com>\n <20260421022044.1217503-2-songmuchun@bytedance.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260421022044.1217503-2-songmuchun@bytedance.com>","X-Spam-Score":"-4.30","X-Spam-Level":"","X-Spamd-Result":"default: False [-4.30 / 50.00];\n\tBAYES_HAM(-3.00)[100.00%];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tNEURAL_HAM_SHORT(-0.20)[-1.000];\n\tMIME_GOOD(-0.10)[text/plain];\n\tMISSING_XM_UA(0.00)[];\n\tRCVD_VIA_SMTP_AUTH(0.00)[];\n\tMIME_TRACE(0.00)[0:+];\n\tRCPT_COUNT_TWELVE(0.00)[19];\n\tFUZZY_RATELIMITED(0.00)[rspamd.com];\n\tARC_NA(0.00)[];\n\tRCVD_TLS_ALL(0.00)[];\n\tFREEMAIL_ENVRCPT(0.00)[gmail.com];\n\tDKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tFROM_HAS_DN(0.00)[];\n\tFREEMAIL_CC(0.00)[linux-foundation.org,kernel.org,linux.dev,ellerman.id.au,linux.ibm.com,oracle.com,google.com,suse.com,gmail.com,kvack.org,lists.ozlabs.org,vger.kernel.org];\n\tTO_DN_SOME(0.00)[];\n\tFROM_EQ_ENVFROM(0.00)[];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[];\n\tRCVD_COUNT_TWO(0.00)[2];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[bytedance.com:email,imap1.dmz-prg2.suse.org:helo,suse.de:email]","X-Spam-Status":"No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]