[{"id":3680205,"web_url":"http://patchwork.ozlabs.org/comment/3680205/","msgid":"","list_archive_url":null,"date":"2026-04-22T02:54:31","subject":"Re: [PATCH v4] Improve handoff prepare on SoCFPGA","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Brian,\n\nOn 2026-04-21T00:47:19, Sune Brian wrote:\n> Improve handoff prepare on SoCFPGA\n>\n> There are some cases that the Python scripts\n> are run and the qts files are not replaced.\n>\n> This patch introduces:\n> 1) TMP folder for Python script\n> 2) TMP folder will automatically remove on exit\n> 3) If PY script fails, the replace will not conduct.\n> 4) Only when PY script passed the replace with keep\n> or without keep will be done via NEW HANDOFF_KEEP=xxx\n> 5) When keep is selected the old files are renamed to\n> xxx.h.handoff.\n>\n> As such this ensure qts folder h files are properly\n> updated.\n>\n> Signed-off-by: Brian Sune \n>\n> arch/arm/mach-socfpga/config.mk | 27 ++++++++++++++++++++++++---\n> 1 file changed, 24 insertions(+), 3 deletions(-)\n\nReviewed-by: Simon Glass \n\nSome thoughts though.\n\nWe try to add a change log for each revision and use imperative\npresent tense (Introduce a temp folder... rather than This patch\nintroduces...). Spell out Python script rather than PY script, and\nreword as prose or a bullet list instead of 1), 2), ... You could also\nexplain *why* the qts files were sometimes not being replaced - the\nmotivation paragraph currently just says some cases without saying\nwhat goes wrong.\n\nThe message says kept files are renamed to xxx.h.handoff.\nbut the code uses .h.handoff_backup. - they should match.\n\n> diff --git a/arch/arm/mach-socfpga/config.mk b/arch/arm/mach-socfpga/config.mk\n> @@ -43,6 +43,27 @@ socfpga_g5_handoff_prepare:\n> + if [ -n '$${HANDOFF_KEEP+x}' ] && [ '$${HANDOFF_KEEP:-1}' != '0' ]; then \\\n\nHow about:\n\nif [ '$${HANDOFF_KEEP:-0}' != '0' ] ; then \\\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=k3EkVVhx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"k3EkVVhx\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0kNC3v6bz1yD5\n\tfor ; Wed, 22 Apr 2026 12:54:51 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 84C4883936;\n\tWed, 22 Apr 2026 04:54:48 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id BEB9F840D8; Wed, 22 Apr 2026 04:54:46 +0200 (CEST)","from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n [IPv6:2a00:1450:4864:20::630])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C74AA8352B\n for ; Wed, 22 Apr 2026 04:54:44 +0200 (CEST)","by mail-ej1-x630.google.com with SMTP id\n a640c23a62f3a-b886fc047d5so896897466b.3\n for ; Tue, 21 Apr 2026 19:54:44 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776826484; cv=none;\n d=google.com; s=arc-20240605;\n b=d0ey0WxuVvOHwNXiSYu9R9PE2FGbGE5to0tMEbu26+hHxNcpjXvT33Pwxd/72fJkvi\n uCSFu+Oop/hUkI7Or/yYbSsbwwzadlr37KCK/FRNlCl1fjrR6d/Q3vkkzqj+oGn74GGY\n rEW3fnwU3Bkg8PBLO21/WXhhssKhH5G6VtWrJeGk6MY8B+qOtUC6Lap+ziu3DEJ5Ggf3\n SEpa7g+XDaOkCClvWodBe7JVDk3P/UmxqCeDsOmAYYJf4L2oAv59SlI95oBjqbQOErjo\n favt/SQKqGRyLfSf9Im11+z1a3EmvnFd+nsqEnA+ik3Lm19epzzhdGYiM1+iw6jbz7p9\n k3Vw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=HTSpXNWMnOUUvXNIjlFpvixH0NVYJFzcgzRXVYG+lGw=;\n fh=PHo6SxFQeYGijuQxNVj6Mu5BE7imZMp7yjwDYBEMLIQ=;\n b=gc5CwkbG1I+CmVAKnELxIy7wMLHMvEQZ4zZd8c5RIBC9u3L+ewqaxpNpwW+1OV4iSW\n I8WQPw1wB2TbbOU6wtW+xth4sn5R99otSpgN5KTpjm0+YbCRghXgykMwHnRFN6owyAib\n xi4PxgHKO1FTRs5VP/sbZCuxezOEhn2RZQnOy2tMY4wpIOkWInCO8gxX+xMEQE8JG6we\n daJYTO/ZwzSiuxS3f/Alqb4cPRq+Wjb0E1QgMU0K3csYAXV2rIFUjkVPQ4UtxcFD2zKO\n RG6obxcUGeufsg0x9+2RepfUjbqY2x38LeZncLv6c9nE0rYD+Km+qqvWpc1iFFYoQ3CP\n absw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776826484; x=1777431284; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=HTSpXNWMnOUUvXNIjlFpvixH0NVYJFzcgzRXVYG+lGw=;\n b=k3EkVVhxUFoweCcniJJWQiwIEWJ3CfI5bCGa7LoyJnl/Fje2EgS0SloLb7H6F81TaC\n 05BqBHi+Ox5emDP8Z7xuFBglfUTbdJSHRiI51Qgu/QUJj2RtUjqJsCicCdHfS7OFI+5h\n ufC1DgRa54RKPwtX5kWY3knxfTEsklN0JnspA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776826484; x=1777431284;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=HTSpXNWMnOUUvXNIjlFpvixH0NVYJFzcgzRXVYG+lGw=;\n b=G9rOVIfz+c22alIWy1qk5OFoW5427WKNCvypEKofdBA2nY8/WTp6px0PjYwAWX7DaY\n cSx2LWvreyIy8/Bq+e1K5e7Ow9dwTbxy8uI0Fa25wuNgeVMRYo7civ0OoneysyfMl64H\n nLm5Sc07J25dd6DfVP/6o0o3lOOoqy8NmEw35qyE80nvSHdiaVVyG49j13ObqZxooJ1R\n bbm+oIbzR5p9P9JTE52/F1ehZr5lSVjB5xRPmfp6jLmcc0LK0prDPMdKrTj04fyR25Mg\n RqVNERxZqX7hF756tb268FQHtHGB0zZq5GeGDCtA5kksJOcKkRixJYBGMVwuns5cTLOY\n NSmQ==","X-Gm-Message-State":"AOJu0YwaRKg15uh5YBd0T/6uZkHznsUfohjCAj8WESn5ku6KWSn6YXUS\n 6so296XaMb41btRn7SojNheWCSYwaFXo4WrxU2MhPeLhPDm4P10gK4fKXttlpefsw6ltxZm5va2\n nP05cv+cj1EJK6ZIBXsARzRSk3MIbEbNV5fYdLwXajsNCeLVmO8A/faB/","X-Gm-Gg":"AeBDiessAmC0KAeuQ0lGw/j0Bg1tdp+I4Sc7tskPBPhdvvC93eJiVym+WN8wclVsM2i\n rPbLT9CFC+60GZ+jZJLVirMMsgq9uHVEOr0UciuT2AFC4/Y8XAlX03HM54y1+Ytcn5iyvWuNPCc\n Dd/K+OCh5HCFEOIucZtReChHa5I+vLrHtnUDdOkMDjnOlsD5QL3o0NvhEOtZ6uyMI8dkTC+P1s9\n ZH0nF5PpcIl7mzqpE/81zH/cwSW7m6Jm2iFT9/gWaasJpHTaaao8yCojsp06HECEgQ3VLXZC1/2\n O2LcfIMtnhpfEm1A4Vum","X-Received":"by 2002:a17:907:c1b:b0:b9b:3a1b:e2ed with SMTP id\n a640c23a62f3a-ba41de2db63mr990642766b.24.1776826483916; Tue, 21 Apr 2026\n 19:54:43 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421004719.73491-1-briansune@gmail.com>","In-Reply-To":"<20260421004719.73491-1-briansune@gmail.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 14:54:31 +1200","X-Gm-Features":"AQROBzCfkjOpyEtTAy68Jsyf7Jgx6SRRVG6_69woxpeq2uHxk0pfI3PPvXTeNok","Message-ID":"\n ","Subject":"Re: [PATCH v4] Improve handoff prepare on SoCFPGA","To":"briansune@gmail.com","Cc":"u-boot@lists.denx.de, Tom Rini ,\n Chee Tien Fong , Simon Glass ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3680211,"web_url":"http://patchwork.ozlabs.org/comment/3680211/","msgid":"","list_archive_url":null,"date":"2026-04-22T03:13:02","subject":"Re: [PATCH v4] Improve handoff prepare on SoCFPGA","submitter":{"id":91590,"url":"http://patchwork.ozlabs.org/api/people/91590/","name":"Sune Brian","email":"briansune@gmail.com"},"content":"On Wed, Apr 22, 2026 at 10:54 AM Simon Glass wrote:\n>\n> Hi Brian,\n>\n> On 2026-04-21T00:47:19, Sune Brian wrote:\n> > Improve handoff prepare on SoCFPGA\n> >\n> > There are some cases that the Python scripts\n> > are run and the qts files are not replaced.\n> >\n> > This patch introduces:\n> > 1) TMP folder for Python script\n> > 2) TMP folder will automatically remove on exit\n> > 3) If PY script fails, the replace will not conduct.\n> > 4) Only when PY script passed the replace with keep\n> > or without keep will be done via NEW HANDOFF_KEEP=xxx\n> > 5) When keep is selected the old files are renamed to\n> > xxx.h.handoff.\n> >\n> > As such this ensure qts folder h files are properly\n> > updated.\n> >\n> > Signed-off-by: Brian Sune \n> >\n> > arch/arm/mach-socfpga/config.mk | 27 ++++++++++++++++++++++++---\n> > 1 file changed, 24 insertions(+), 3 deletions(-)\n>\n> Reviewed-by: Simon Glass \n>\n> Some thoughts though.\n>\n\nHi Simon.\n\n> We try to add a change log for each revision and use imperative\n> present tense (Introduce a temp folder... rather than This patch\n> introduces...). Spell out Python script rather than PY script, and\n> reword as prose or a bullet list instead of 1), 2), ... You could also\n> explain *why* the qts files were sometimes not being replaced - the\n\nBecause it is not fully traceable, git pull sometimes could introduce\nsome kind of unknown cases that even run make prepare will not update\nthe h files or the python script itself does not fully replace it from\nfirst place.\nSo the easiest way to play safe in any possible condition is\n[remove and replace] or simply [rename and create].\n\nAnd I don't even fully confirm the cases, while this patch does improve\nthe previous .mk operation no matter if it is solving the unreplacing issue\nor not.\n\nSo the motivation was explained from the title itself.\n\n> motivation paragraph currently just says some cases without saying\n> what goes wrong.\n>\n> The message says kept files are renamed to xxx.h.handoff.\n> but the code uses .h.handoff_backup. - they should match.\n\nThat my mistake on the description, indeed it should be\n.h.handoff_backup.\n\nThe idea just follows T.F. previous optional idea so I don't fully pay attention\nto the wordings.\n\n>\n> > diff --git a/arch/arm/mach-socfpga/config.mk b/arch/arm/mach-socfpga/config.mk\n> > @@ -43,6 +43,27 @@ socfpga_g5_handoff_prepare:\n> > + if [ -n '$${HANDOFF_KEEP+x}' ] && [ '$${HANDOFF_KEEP:-1}' != '0' ]; then \\\n>\n> How about:\n>\n\nNo I don't like this because you ignored my original idea on:\n1) HANDOFF_KEEP= should run keep\nbecause HANDOFF_KEEP cannot without = in .mk usage\n2) When users use this flag, hence, it is telling that they want to\nkeep the thingy.\nSo it makes no sense to =1 or =0 to further control it from first place.\nThis flag is inherently boolean logic.\nBut due to your suggestion I further elaborated this boolean flag to\nsupport =0 or =1 or =x cases.\n\nSorry for this part, I will not change.\n\nCheers,\nBrian\n\n> if [ '$${HANDOFF_KEEP:-0}' != '0' ] ; then \\\n>\n> Regards,\n> Simon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ORiXmwcC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"ORiXmwcC\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=briansune@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0kng08dwz1yGs\n\tfor ; Wed, 22 Apr 2026 13:13:26 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0A01183936;\n\tWed, 22 Apr 2026 05:13:19 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 74F5284198; Wed, 22 Apr 2026 05:13:17 +0200 (CEST)","from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com\n [IPv6:2607:f8b0:4864:20::32a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 48B978352B\n for ; Wed, 22 Apr 2026 05:13:15 +0200 (CEST)","by mail-ot1-x32a.google.com with SMTP id\n 46e09a7af769-7dbcb467f2bso4753942a34.3\n for ; Tue, 21 Apr 2026 20:13:15 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776827594; cv=none;\n d=google.com; s=arc-20240605;\n b=I1DyNUhFdhOI6EsVGALiCNx/fFMavMdGmIgRbhbvmaJXzte2+qCXAHIVzY2DvCnWV8\n Wu7/pobwcOqfhfs8ort+NFlWA1NQZKBE3zKgiPSlWfWf9PRgxa3+F3EU5Bsri0R+ZGkt\n DjgVLTcs8h+st68Yc4TJrjOiJjh9iPOBcoOQP0wRoh+gqquG7szly6z+mtkd1n6LJsRe\n dh3Ynj8V6yseK34/VeNZZydZ0bGDc8/28lXQ3iaaGiJFxrOoEglHq3iduWgsBG3dZLFP\n 0iw70HrWIOH578iKIs3aYcPzTz23iqlj98I9LQBKtghaI9WcR2HKMCZzOuwIzlMOC7zH\n G76w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=HVVC0qLH7g9+gqfB8kwnvICXBTbSWYRu0cCM7P826NI=;\n fh=XmvCthC/BjXYU0ZrHKfxQew09xn0WtefmKj6MWJpbfI=;\n b=isQe8kitk9gNV78hAK0n2ncPyERhFv2Gm0Z+IbptLYiH9vWCFj6aJSCjzgnI45MLBh\n 5dOTL/1DnduR6WchyLlYS+Ppk6bFSCrS3cgN1ib1eOej8CCVZdXEn0reVaNrReMWhJ4x\n Nb6dEf/8ZeKUWrqBQylC0bI9fca5wTacyyPU+lUJzaV9A9uNFKctVmm487rrE1sm7E6y\n dR3Y7ziwZwQfm87OGPwZrPlOGn9QwIX1/0OK4LbTRB8RbXHIzsLn8WwtvggeJ2ZoU4Nr\n o4/S1UYLX7FatyF0rn9fq9Dm9qoHgZSzLPoRdeMoOpIOCYlooAOJdomGtPz6bbeSrlu6\n CLRQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776827594; x=1777432394; darn=lists.denx.de;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=HVVC0qLH7g9+gqfB8kwnvICXBTbSWYRu0cCM7P826NI=;\n b=ORiXmwcCaWI9TH855ShOLgWahvHDYHVYJtyZO7Oha5uqSeZwRTWIR8v6BKLupHK9m5\n 0DeYRo1OBRoIzzdZxdNYldKd5mkqHZKnfR3PZ1mOKxN7b6QR2qh5wnpGFN5/EJxIF7SO\n 36pnXpTu6fos5H1rEpoU8J+CA/FA3fMr+qn7rqkFFNNTjxal723pekRVpkgWRc5aoJv8\n 8Vz2EhT7qGqjpQRWQE05sslWfc2eQiMs56+JjPGLsTDcCdzAjXCaIElDLXty2yzyJOin\n t7OaoCPR/X/nOj1z2Y0DlGySrRe1QdvmSwsimBkKjF+5ty8tVaf6VDd36KinXGKXzAZg\n I23Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776827594; x=1777432394;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=HVVC0qLH7g9+gqfB8kwnvICXBTbSWYRu0cCM7P826NI=;\n b=QjQxu3VhsM1tS8Ts1SGp9/cr6zUQ8DGa8eWVS9sCfomzBsqKgf2+GL9DmEH51VTkAo\n NkFnMsBz6S7V5JPZ2+wgXNhW+WGVWerU6TWH9h1xQxN9YAcoR+5jjMqdpgAVqpTOTrc8\n vbNwf1gsQ+FQnjHEmXRI5JYhU0ytRlp80PrLOdPBXuYdgk9UUtQcfG+f82tQsdBb38ZS\n K+hxxD3pXzZYMc0qBHX2h+qh9oE40ENKiCHqOy3Suwi+7zyuCKQVJ/k1iUPm18qmaRKI\n mmbxkc9hl8dFvH8tepb+jz5ledKJV1z3U4ECSc79OK8h5XVzq/XswcFBuT7UWewgyg+O\n TRPg==","X-Gm-Message-State":"AOJu0YwU+IHwMpJ/L4DywOskgT6nGwS64GgwYxb+/erRkg3qC0bYnYEJ\n tk/PjuSgrTM6tfD5Oh0jjovqaew8wxs05jMlBO7oJR8gG/J52rmUtLgtRifVGc7E8UdkYjOVxSi\n pKUl5/r3P6eFHs2UzrMThihRGO50IQMK1rvPIS6Tvsg==","X-Gm-Gg":"AeBDieseuOP9AQHxIxrrf9eSYS9lbmu9kBLxOPNHj+IB9LYr94piM4dtcceGnT1TAWz\n loX43w5VjBADfZeMj/nnqgU2pgXgTTqKezAXsTcIBrdqf/smURjDMfPkU37E5QHXoBA75q1WQXk\n GNSfisH5Yln0hf1fiEhSB6KNaJRTJrV6GO+sl49i+/OWh6/nV2DHC/zPKfkLqJ98bXTpf3yD68L\n Yup+qljWfuJYHEKV4NM77P+90eoNSAEjkowx/s38zwQYStFOgVaYAajWJSv8AQRb+l+gz7EkHnm\n x+1O2QsTa1JzoTJR1g==","X-Received":"by 2002:a05:6830:264a:b0:7d9:ad90:5670 with SMTP id\n 46e09a7af769-7dc9518c0f3mr14930333a34.18.1776827593834; Tue, 21 Apr 2026\n 20:13:13 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421004719.73491-1-briansune@gmail.com>\n ","In-Reply-To":"\n ","From":"Sune Brian ","Date":"Wed, 22 Apr 2026 11:13:02 +0800","X-Gm-Features":"AQROBzCw14rY7143LDlkqgHe3RfJMRZUhvGTn8oQuL4A_mnapEhuGTDLtMRINtM","Message-ID":"\n ","Subject":"Re: [PATCH v4] Improve handoff prepare on SoCFPGA","To":"Simon Glass ","Cc":"u-boot@lists.denx.de, Tom Rini ,\n Chee Tien Fong ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3680232,"web_url":"http://patchwork.ozlabs.org/comment/3680232/","msgid":"<33279917-7f3a-4a33-83dd-0c78ed5e88ed@altera.com>","list_archive_url":null,"date":"2026-04-22T06:04:48","subject":"Re: [PATCH v4] Improve handoff prepare on SoCFPGA","submitter":{"id":90079,"url":"http://patchwork.ozlabs.org/api/people/90079/","name":"Chee, Tien Fong","email":"tien.fong.chee@altera.com"},"content":"Hi Brian,\n\nOn 22/4/2026 11:13 am, Sune Brian wrote:\n> [CAUTION: This email is from outside your organization. Unless you trust the sender, do not click on links or open attachments as it may be a fraudulent email attempting to steal your information and/or compromise your computer.]\n>\n> On Wed, Apr 22, 2026 at 10:54 AM Simon Glass wrote:\n>> Hi Brian,\n>>\n>> On 2026-04-21T00:47:19, Sune Brian wrote:\n>>> Improve handoff prepare on SoCFPGA\n>>>\n>>> There are some cases that the Python scripts\n>>> are run and the qts files are not replaced.\n>>>\n>>> This patch introduces:\n>>> 1) TMP folder for Python script\n>>> 2) TMP folder will automatically remove on exit\n>>> 3) If PY script fails, the replace will not conduct.\n>>> 4) Only when PY script passed the replace with keep\n>>> or without keep will be done via NEW HANDOFF_KEEP=xxx\n>>> 5) When keep is selected the old files are renamed to\n>>> xxx.h.handoff.\n>>>\n>>> As such this ensure qts folder h files are properly\n>>> updated.\n>>>\n>>> Signed-off-by: Brian Sune \n>>>\n>>> arch/arm/mach-socfpga/config.mk | 27 ++++++++++++++++++++++++---\n>>> 1 file changed, 24 insertions(+), 3 deletions(-)\n>> Reviewed-by: Simon Glass \n\n\nReviewed-by: Tien Fong Chee \n\n\nPlease roll a v5 with:\n1) Commit message: imperative tense, add a short v5 changelog vs v4,\n    spell out \"Python\", and fix the backup filename in the text to match\n    the code (.h.handoff_backup.).\n\n\n2) HANDOFF_KEEP: I am fine keeping your current semantics [OR: please\n    adopt Simon's single test ...]. Either way, add a brief comment in\n    config.mk next to the recipe stating: unset => remove old headers;\n    HANDOFF_KEEP set and not 0 => rename old *.h to *.h.handoff_backup.*;\n    HANDOFF_KEEP=0 => remove old headers even when the variable is set.\n\n\n3) [Optional] If HANDOFF_KEEP= (empty) should not mean \"keep\", adjust the\n    shell logic or document the current behavior.\n\n\nWith that I can apply from list.\n\n\nThanks.\n\nBest regards,\n\nTien Fong","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=altera.com header.i=@altera.com header.a=rsa-sha256\n header.s=selector2 header.b=NYuxmsZO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=altera.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=altera.com header.i=@altera.com header.b=\"NYuxmsZO\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=altera.com","phobos.denx.de;\n spf=pass smtp.mailfrom=tien.fong.chee@altera.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=altera.com;"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0pby28cpz1y2d\n\tfor ; Wed, 22 Apr 2026 16:05:18 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 6181084255;\n\tWed, 22 Apr 2026 08:05:09 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 4C79C8352B; Wed, 22 Apr 2026 08:05:02 +0200 (CEST)","from BYAPR05CU005.outbound.protection.outlook.com\n (mail-westusazlp170100001.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c000::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 14E2983BC8\n for ; Wed, 22 Apr 2026 08:04:59 +0200 (CEST)","from LV8PR03MB8137.namprd03.prod.outlook.com (2603:10b6:408:295::8)\n by DS0PR03MB7726.namprd03.prod.outlook.com (2603:10b6:8:1f9::15) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.16; Wed, 22 Apr\n 2026 06:04:56 +0000","from LV8PR03MB8137.namprd03.prod.outlook.com\n ([fe80::efa9:4b97:3b4a:8235]) by LV8PR03MB8137.namprd03.prod.outlook.com\n ([fe80::efa9:4b97:3b4a:8235%6]) with mapi id 15.20.9846.016; Wed, 22 Apr 2026\n 06:04:55 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=FCJksbGFakac6ziIETq33iAadEkAPMXS9D2F9CUcQz6QKpe5yVuqu9vXmGSeGXE9xmH54eriB0edOdkIe5jzrxQAqx4cAbvPcV4ZVCkIc0x5K1kjliM5S8dcQ6FTOSh1zse7Ma6qqcN1IuKIe91+EUNVt9iTy088o+QdVXxfgkueiue6ahQxdbP782KhJw5lXMW76BT42BRCdkEbiamxyJOqM7/iWXpBSCClwv6A8MQkqyJqYH8/BIrDCiJYa5spqG4zGtAy4xwqbfG7S9a5mbkenk6CMaDYlvS6lqOBHqM2pI2GYLIDST8sIe10wbx/tZ7wjStVCMWjcuxS8zEWCw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ZwXL7LSRqhB7tM+hs6qBlBtTCCVCeTVepAPi1d8cTFs=;\n b=rFQoHeDbbBmRwqix7wbuuA8qxhmYGxeSKtYPVTrDqEXPXfFRC4cS7IG9OjgV4fnoEZyhT4o6nu+RkO8Ba0aHLzr9cTGRaN0P5FAGfzZSNv2AVIzxvPUFPyhfYlc1BzB1mUFIOnit55ge5xqccOIvl2bUdsfgokfCZgO07/2aYdEQfaz18ik7Ti1ycNPc3NdK4lzs81TYsD4BCzKrGWcEHXLkgQbrqoZx4Z6Qw7tWXp2wA/Tp4+7IWGzO//ahPBVfcuWiuOeUvcUWUzGhb/tDiC58VUw5T36f1i2aawswH3oVFXw7uKci+lMddN/376UJK0VEOZ4Q8K6kbkNTAko6tw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com;\n dkim=pass header.d=altera.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ZwXL7LSRqhB7tM+hs6qBlBtTCCVCeTVepAPi1d8cTFs=;\n b=NYuxmsZOXzQ5vDmE8sxBuzmnoXR1NH+5Uxw+6MOCudPjxq9kepSGj7YH+ccfNOZ8wu8g/SgTPijYiAqaGOTG1XJoFEgtKdMj0nRf6Vm8jPedoHCpqpFTn1Gn7eUcEE8lpNy8oW4JHAamv3Ycu9l2nf4h/lLFQn0SmzG7pS+5nMieOHMQKIEdvcr9OnTHMM7qxoInFWi2Db9h1r9jHzyKIOFOf2jSzv36Kj3a5BY7QlIuToJ7kbNGPsSTNyfMGFPnfp8f0u955nQfnYhRJ0O0IYErgoLujLD9z9PcPBt/Ffy4PtoWhhPjlC0NsoBjEl3aNsaFmKvP/aLk1lZ9f89XWg==","Message-ID":"<33279917-7f3a-4a33-83dd-0c78ed5e88ed@altera.com>","Date":"Wed, 22 Apr 2026 14:04:48 +0800","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4] Improve handoff prepare on SoCFPGA","To":"Sune Brian , Simon Glass ","Cc":"u-boot@lists.denx.de, Tom Rini ","References":"<20260421004719.73491-1-briansune@gmail.com>\n \n ","Content-Language":"en-US","From":"\"Chee, Tien Fong\" ","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-ClientProxiedBy":"SI2PR04CA0007.apcprd04.prod.outlook.com\n (2603:1096:4:197::19) To LV8PR03MB8137.namprd03.prod.outlook.com\n (2603:10b6:408:295::8)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"LV8PR03MB8137:EE_|DS0PR03MB7726:EE_","X-MS-Office365-Filtering-Correlation-Id":"0fdaaf8f-f268-4753-a26d-08dea0351384","X-MS-Exchange-AtpMessageProperties":"SA","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|376014|366016|56012099003|11006099003|22082099003|18002099003|55112099003;","X-Microsoft-Antispam-Message-Info":"\n DNTvN7OLQrfX6vwm7TT49M0vVStRYd/KS0F7S18Cbi0Mxu0ebihXaXUk7g6pio4DxIsfcKesqWE+xX6hktLRYARMtQC+WA0aOz1zn4ZouuBm4iyXTMqKR++wdnij3HreilUGOUKFxMalG7rnEjJ6x4DiLNMVtmYYeUvfgoP2VZMY0NjH09N+ykkRrxyiZSQhA9ff1mOXFOzZxJ2xBzERdlKauJ1zUBz1neYv3v1xn+4c+85Ay10V8rGU1BEZVcz19c3qW8S8NOq+j83xz3MyoaTPkI3n1xkeY6Jxt5jM1Ac7yh/npa7b7G5QKxsjchZuml98LRhkyTTOjwuhZvpJbnsJw/7w4SpS6A3IYJN68+8dLEk82633kGHI3axKRTKBr32DFwI6BhrxetpbxM9mWTayPZxt/F15kdai7lK1BrdsVMbrKiFK90IHhs8siYgNsK9x14VwDqccIpZbrnX+6UEXqX3/EtFX/2rWileZIwoJVsNqaz9IBpC3hxnVpAsfMf8xG+XGauHODL2ox42zbdCM5GYM4BOqYXik92IeCD2ZwXqthmpZ0um1NGIlSK34Wf3iZG4YihmsDGhKHkqyTCbMwLdNEg+I8wzufwSivPGI0LomArHUCRt8kZsePwGL1yHbTTzebRPJZdZDi6DawvbAm5NojqDkhQknI1YOcLEYdK07E2ON5zN7e14DN1+rYHZN+yvCiYUylp4d7k9PXOOLwmB875bwNPy0aMsV11c=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:LV8PR03MB8137.namprd03.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(376014)(366016)(56012099003)(11006099003)(22082099003)(18002099003)(55112099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?/yvQ7WS94rl1Ff8PlRWX928THUu0?=\n\t=?utf-8?q?+DyzfphJf1m63KESuQY32J/7spzDI9FAMgn04y/emJDCPdKenGpU+uJym9SJZ5PD3?=\n\t=?utf-8?q?CpyhGZ0yDFkH9ojPLSYnUVho3fufgih2bDizfjUWAY6VouWWWRM0+cTFCiBiv4Xjt?=\n\t=?utf-8?q?QE602HRoJ1ViDzgNuUNad5wsMyoXOQuQlr6JGebZNySHTjrkagovyqnBb4StW7/rx?=\n\t=?utf-8?q?FdPYtXjXqi9A7yTvVP4AT87w4z9fp6vYV0kIbiD5l0PJdiKk9zqhE7yWLM/MjZDmE?=\n\t=?utf-8?q?4SlfSkTj1IsfBZZGQklHyd2wcRMtQCXOxXsSPdSF2WXvduJ3SxJBSLzuR4h89kdf1?=\n\t=?utf-8?q?qp14UVO88DWW2LWGV0QO925+M/xfcNyldTfiY+bYWFwjOpSKU7ssrSwsxaVDigatE?=\n\t=?utf-8?q?xCG4mmy60BhU4LChhE7WV6NohpNO7yD5eZHBRxhf8z59PcoL6eslDJqsAZQDuiejq?=\n\t=?utf-8?q?+isMwGEcNk9KiATnEJm4vZ746lzEZNoPYt2X3vfKcnY8EeGZoMUmAL0Y43cBnBBiV?=\n\t=?utf-8?q?I7Db4LQtLZCI8tUr0wN279TUusNzA1c/c6w9bBoWrBMa5JBeguUxp66K8ZhC/2pai?=\n\t=?utf-8?q?wDeFhLQufEJnVRd4fbtCUkePly/InUExthQmHWRL/UQbnlcE/kFBVxycU4AgXwJPV?=\n\t=?utf-8?q?b7ODjFe9lPC1PrTEXsB8EfEkITzc8zyfS9fdABUQVfzwaNcvBdvJNi2LAW6LqyyHF?=\n\t=?utf-8?q?FlxTmf9s7o+UfjRKUz6XkOvQ2uRfef4BVN069k3B4gAObY8ErEG64emKvGg0gQxKK?=\n\t=?utf-8?q?fOdbwqoc6GGujIiFjvjNu13wUgeUMWaCx/xTnxSqwLudCU9gosx4euQ6ehS2fgU55?=\n\t=?utf-8?q?XMfS8aK4gfSEuHOhiiAq+obUQ7lV8OZ9C/lqEPJEjxt12eT1ioaHg28ZRlfgCJqbW?=\n\t=?utf-8?q?Z6xmj0aLztpDLrfEvJfV+UYj5zzd+8HJtQEaR2khNcS9YsoZS5XZTNx61IbHP2Qvn?=\n\t=?utf-8?q?TEkMfuvvucmxs9/pHFDZlao4/1ia/9yaVmTUzOB0EXyOI54H9lEae9n71DyEYtkpR?=\n\t=?utf-8?q?8gZoZzC/lX0LuB+INVteXmc5lQqhS24m61dy6T2CCZzdPuVNYGEW3l8zPBi1oYDpZ?=\n\t=?utf-8?q?HNJ+m935y1vwNb7Ch2bgPvAQfPT+N+9PmPqXoq5Y2NXSgIwyHp8q9Rj/u6a1o1CHA?=\n\t=?utf-8?q?6sSzvQA2ZM0TNnI7SKlNtnC+kRoKM7iGFDu/owKmwqahZUVrvKLOuyVzl5sQAp/D/?=\n\t=?utf-8?q?BHKRVihFbQObm9bEj/S0bmJT7DbOt5iy2UgnYuaBWu4uXQ7IQJEGJgwdXy1aPf99g?=\n\t=?utf-8?q?sUcHllLJGUSTbmi0tk0SDlTmXNaAhYNbdddy8oYROMlN0Rogwrjq7/ZSfHdrY8pwB?=\n\t=?utf-8?q?XGLtlzINcG2IxRXwY07XO/o8DMCySoHTDINKYCdC4AIswsL3mO3pIWBfuSQqfkm2u?=\n\t=?utf-8?q?lghIoxP6WmuAGwJx0dFZ6Ydpy9L+3b3hOZ4dJQl+lw+T69bZXYWPPMtDt7iVCtShT?=\n\t=?utf-8?q?ylx7k/xlWYaXeKHGiYRQNdy4zWlLufawJqc7R0nfiNXtZ2f1b40V+gULZuHlr5oLh?=\n\t=?utf-8?q?lCIFa+v/4tXFsGVWYTVomQtRRH0cRNHMW3YBJ5WQ8/R3iPM3m3Ob1OnIfTeN0Apy8?=\n\t=?utf-8?q?HGs07bezHv51yEKWMfNiWQ+wodqlEHLLG8EtIHegZKQ58hK9tzJMQpD9BBwkdvhzp?=\n\t=?utf-8?q?VH2njeW7TM+jg9A1fu5SgRthS8eixEYWN41VqORp4mYteLe+3GvKs=3D?=","X-OriginatorOrg":"altera.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 0fdaaf8f-f268-4753-a26d-08dea0351384","X-MS-Exchange-CrossTenant-AuthSource":"LV8PR03MB8137.namprd03.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"22 Apr 2026 06:04:55.8803 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"fbd72e03-d4a5-4110-adce-614d51f2077a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n nNbqV4ZmfHaAKH1SxbB9tuBFAbu1AMbmdkbOeYusPAB2Y5C+6XFYrXCacE9c8r9Kz1ERn8L74BA4DLB5ekex2dTU6R9trr0HPiLiHwvalqE=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DS0PR03MB7726","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3682343,"web_url":"http://patchwork.ozlabs.org/comment/3682343/","msgid":"","list_archive_url":null,"date":"2026-04-23T03:06:40","subject":"Re: [PATCH v4] Improve handoff prepare on SoCFPGA","submitter":{"id":91590,"url":"http://patchwork.ozlabs.org/api/people/91590/","name":"Sune Brian","email":"briansune@gmail.com"},"content":"On Thu, Apr 23, 2026 at 10:24 AM Chee, Tien Fong\n wrote:\n>\n> Hi Brian,\n>\n>\n> On 23/4/2026 6:29 am, Sune Brian wrote:\n> > [CAUTION: This email is from outside your organization. Unless you trust the sender, do not click on links or open attachments as it may be a fraudulent email attempting to steal your information and/or compromise your computer.]\n> >\n> > On Thu, Apr 23, 2026 at 6:10 AM Simon Glass wrote:\n> >> Hi Brian,\n> >>\n> >> On Wed, 22 Apr 2026 at 15:13, Sune Brian wrote:\n> >>> On Wed, Apr 22, 2026 at 10:54 AM Simon Glass wrote:\n> >>>> Hi Brian,\n> >>>>\n> >>>> On 2026-04-21T00:47:19, Sune Brian wrote:\n> >>>>> Improve handoff prepare on SoCFPGA\n> >>>>>\n> >>>>> There are some cases that the Python scripts\n> >>>>> are run and the qts files are not replaced.\n> >>>>>\n> >>>>> This patch introduces:\n> >>>>> 1) TMP folder for Python script\n> >>>>> 2) TMP folder will automatically remove on exit\n> >>>>> 3) If PY script fails, the replace will not conduct.\n> >>>>> 4) Only when PY script passed the replace with keep\n> >>>>> or without keep will be done via NEW HANDOFF_KEEP=xxx\n> >>>>> 5) When keep is selected the old files are renamed to\n> >>>>> xxx.h.handoff.\n> >>>>>\n> >>>>> As such this ensure qts folder h files are properly\n> >>>>> updated.\n> >>>>>\n> >>>>> Signed-off-by: Brian Sune \n> >>>>>\n> >>>>> arch/arm/mach-socfpga/config.mk | 27 ++++++++++++++++++++++++---\n> >>>>> 1 file changed, 24 insertions(+), 3 deletions(-)\n> >>>> Reviewed-by: Simon Glass \n> >>>>\n> >>>> Some thoughts though.\n> >>>>\n> >>> Hi Simon.\n> >>>\n> >>>> We try to add a change log for each revision and use imperative\n> >>>> present tense (Introduce a temp folder... rather than This patch\n> >>>> introduces...). Spell out Python script rather than PY script, and\n> >>>> reword as prose or a bullet list instead of 1), 2), ... You could also\n> >>>> explain *why* the qts files were sometimes not being replaced - the\n> >>> Because it is not fully traceable, git pull sometimes could introduce\n> >>> some kind of unknown cases that even run make prepare will not update\n> >>> the h files or the python script itself does not fully replace it from\n> >>> first place.\n> >>> So the easiest way to play safe in any possible condition is\n> >>> [remove and replace] or simply [rename and create].\n> >>>\n> >>> And I don't even fully confirm the cases, while this patch does improve\n> >>> the previous .mk operation no matter if it is solving the unreplacing issue\n> >>> or not.\n> >>>\n> >>> So the motivation was explained from the title itself.\n> >>>\n> >>>> motivation paragraph currently just says some cases without saying\n> >>>> what goes wrong.\n> >>>>\n> >>>> The message says kept files are renamed to xxx.h.handoff.\n> >>>> but the code uses .h.handoff_backup. - they should match.\n> >>> That my mistake on the description, indeed it should be\n> >>> .h.handoff_backup.\n> >>>\n> >>> The idea just follows T.F. previous optional idea so I don't fully pay attention\n> >>> to the wordings.\n> >>>\n> >>>>> diff --git a/arch/arm/mach-socfpga/config.mk b/arch/arm/mach-socfpga/config.mk\n> >>>>> @@ -43,6 +43,27 @@ socfpga_g5_handoff_prepare:\n> >>>>> + if [ -n '$${HANDOFF_KEEP+x}' ] && [ '$${HANDOFF_KEEP:-1}' != '0' ]; then \\\n> >>>> How about:\n> >>>>\n> >>> No I don't like this because you ignored my original idea on:\n> >>> 1) HANDOFF_KEEP= should run keep\n> >>> because HANDOFF_KEEP cannot without = in .mk usage\n> >>> 2) When users use this flag, hence, it is telling that they want to\n> >>> keep the thingy.\n> >>> So it makes no sense to =1 or =0 to further control it from first place.\n> >>> This flag is inherently boolean logic.\n> >>> But due to your suggestion I further elaborated this boolean flag to\n> >>> support =0 or =1 or =x cases.\n> >>>\n> >>> Sorry for this part, I will not change.\n> >> That's fine...note that you have my review tag, so you can add that to\n> >> a new version, if you do one.\n> >>\n> >>> Cheers,\n> >>> Brian\n> >>>\n> >>>> if [ '$${HANDOFF_KEEP:-0}' != '0' ] ; then \\\n> > Hi Simon,\n> >\n> > V5 has been released.\n> > Due to T.F. \"please to use your check condition\"\n> >\n> > Logically speaking.\n> >\n> > The check condition now has become:\n> >\n> > A person has no intention to use the restroom.\n> > But that person intentionally walk in front of the restroom door and\n> > speak out not going to use the restroom,\n> > Then that person simply goes back to where he came from and does\n> > not even enter the restroom.\n> >\n> > What a wonderful world =]\n>\n> Just to clarify my earlier comments, the intent wasn’t to force a\n> particular approach,\n>\n> but to share review suggestions and ensure the commit message and\n> behavior are clear for future readers.\n>\n> On the shell test, I had meant: either your earlier semantics or Simon’s\n\nHi T.F.,\n\nInteresting, \"simplified one\" so when users use > make + keep flag\nwhere flag label is self explained still adding extra =0 or =1 is considered\nas simplified.\n\nNo one forced me, while you used \"please\" so no worries, just pleasure for me\nto copy and paste w/o further thinking is even easy for me. Love to do so.\n\nThanks,\nBrian\n\n> simplified one was fine, as long as the behavior is clear for reviewers\n>\n> I appreciate you incorporating the parts you agreed with.\n>\n>\n> Best regards,\n>\n> Tien Fong\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=LQ0UKKsU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"LQ0UKKsU\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=briansune@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2zwK476Yz1yHv\n\tfor ; Sun, 26 Apr 2026 05:12:01 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C13D38439F;\n\tSat, 25 Apr 2026 21:11:57 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 50EDA8439F; Sat, 25 Apr 2026 21:11:57 +0200 (CEST)","from mail-ot1-x329.google.com (mail-ot1-x329.google.com\n [IPv6:2607:f8b0:4864:20::329])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 0044C84372\n for ; Sat, 25 Apr 2026 21:11:54 +0200 (CEST)","by mail-ot1-x329.google.com with SMTP id\n 46e09a7af769-7dcd8ef572aso2945747a34.1\n for ; Sat, 25 Apr 2026 12:11:54 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1777144314; cv=none;\n d=google.com; s=arc-20240605;\n b=NYypl+6IPI7IK/1qeSk24uymxwgDHifGGo7uZyV3592JPWlVcOe1Daflu1LF1T0yUG\n +5wv9rIZvDgvn28DVKA4YW6K9e2LUTNmAaXVBpO/pFdrkE+fpEk9aox3/hC3F9WnKqhr\n HX3px06G2lpbypX+aGvQ3zZyOBHry8TLgBL/luTFBO6O6B9iCWrHy1IQeg1rar0yTdBx\n a+LZtcn6ZzbjTTunVXjiHsDG5lbx4zyJ2pS70DrU6EzMldODzo0P6EpcSqXuwvmYhX9P\n MNQ/LuI4/Tw2ZJ4d1i5lO1MtxMcmbzVEXdo6XHhzLNSmnq6Pu2ELvVLDh6FGax2qJsX4\n 2PYA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=TZww/rWtgxlamX8htSQgsfVajn/HZkjCwTcIwuiPxvM=;\n fh=O7GFOPQ6WLQUVnvP3Ux0HSkCcmdgEygIxNih4nllT2U=;\n b=bSreVtaAg5ywQGa9g+0zgkBSomyT9QJ3KORVy8LtzdDFOCwc6aA7zU9iuBVuUZCFyG\n sDQSC9tki77v3eOU+k32rhvyDWex/BICKrHZvCwhObumPqwLHL/PKb4zO7M1QyPVfkVM\n 1OEXJqwYJHKwHlsosYsKNRy+EFeVEAppmyqyYEmbJuyM2IkNDq5eddWYFbsgnb8xI71V\n q9QL2GXc5VAaVQg3yBq1J4NePgcN/EsCkn8MpyIOackrzFpLQyUnH5b3Du8huNOf98s7\n QAXb/bhX1hJ4IWa0dgvGZ9++bSstmY7aAyb16AW7VF0VJ/veAXo/eyzvRNqJpbA8u8eV\n WUow==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777144314; x=1777749114; darn=lists.denx.de;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TZww/rWtgxlamX8htSQgsfVajn/HZkjCwTcIwuiPxvM=;\n b=LQ0UKKsUn97sS2vzLKD5xcbW6e2DwFzFcE/nzSBIi/91I+pYRlSy/vSkKnAb0F9fs1\n Ak683eQ+hBYMrG+IL4Dx2/Lfji4iVKlgNC5NJm+f6dWYEypXdNG5Mw8BKZzSx+E+VOuS\n 1XBfQ3mu3cISKEF3QtcgIjEOl8DBsd/GJu9GIZDf0VYJUq501a3Dlxj1rdGBMIqji1CR\n y7OiCGK08PAVbfrwg0bdUUziZAnL5EcvDeXCVR/ic2bTB8suVCbbBX8mCZnJRpPSGCQz\n OqbAiFXtlgQREqi0F/x8rAe3G4sxrDzfrPv/2fAcFRoeRYf+/pVtolpZvPQ1BeEL2dpV\n aiZQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777144314; x=1777749114;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=TZww/rWtgxlamX8htSQgsfVajn/HZkjCwTcIwuiPxvM=;\n b=m1FMZLGS4cYm8lYlJ91O4fuupPEbk4e2rzFHTpsus1pz+ojwqBDmqviiTl5pUDiw4P\n aIaUUCz+lDga6op+wBdmHknFl6WHMGRAPZ3T8PctFBcAKTjJklrOpE4HuBqhMkM/GOrz\n eLgvwnFXJoqVqF6CQ4dvShHXaJb83cxlaL8lWmL08wXdpHVkKpi+3aG2zU5noIv2Mdwj\n ZneTfr8Ue43lWqWkHlshfCXhCgZfe6jhT13MhaKNXDNpmDc29c1dLVlAnJbYMmtx/bPq\n eZ/Y57uP8Sq7u9MD5kfT36nn07rnaGVtaiGj7ImAHQYS2ZP3zsTXlqRw8t77ERd0QLag\n qJcw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/lC+EbMxime5NORuxFZdO8hPDSTWW73WFVCFWGxorNn8MSAwSuEvuLOLh6jb/h9VpC4groV3o=@lists.denx.de","X-Gm-Message-State":"AOJu0Yw01zy1UfMxkJ5SwZwmsVZ1JZgYiGcxY3T4PlvPwdIyjobvJeRu\n vuis1k/5UDqLH/r+td4+iOqCxkkrNRQBh/tgLty7f2z4UlLZmu3ZGp8X4vQGmk0+JoG6O2QYbIq\n zD+Md8xH41xbEF26HZ9se+AL9FV2kFRUeMS8Kne4bGBmJ","X-Gm-Gg":"AeBDietRy7vdaMxaq1IOBtteK/kh0y6Ih7EeDCIJu54nVMhobx4W4ckbfXG/Q4a+RYb\n aZtmYj4fT+fDlWHBXGCL6BAPszPVkAkqu1QuDzIFP4w5I9OsMPO+ltIUDEL/tynF0gw2n+mq06b\n T/LP8jbb+WIxlI2eMyaWQl5tpK4KBJ59y8RVZr6+VdQD+i7rVw4QpX1AFgD0E8VzL+EV9JffeuG\n TRKJfLt1Udz0ZnL1eO/D/XCvA+7x3z6DTK3GUOSDdqXpUjssUH4FzmqhjDkQCHjeZzMlVPKmOil\n Tmht/zwZECTAudCPI94=","X-Received":"by 2002:a05:6830:411a:b0:7d7:eab6:fb23 with SMTP id\n 46e09a7af769-7dc951fc6admr16233163a34.22.1776913612550; Wed, 22 Apr 2026\n 20:06:52 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421004719.73491-1-briansune@gmail.com>\n \n \n \n \n <275c4b67-476e-4b15-82fe-e4f1d1c24b25@altera.com>","In-Reply-To":"<275c4b67-476e-4b15-82fe-e4f1d1c24b25@altera.com>","From":"Sune Brian ","Date":"Thu, 23 Apr 2026 11:06:40 +0800","X-Gm-Features":"AQROBzDcKxTfZZK3YLO5WsE1SzhqH6ILahFlFkOnawbP3CrdLVKexh7_TwGZCC0","Message-ID":"\n ","Subject":"Re: [PATCH v4] Improve handoff prepare on SoCFPGA","To":"\"Chee, Tien Fong\" ","Cc":"Simon Glass , u-boot@lists.denx.de,\n Tom Rini ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3682359,"web_url":"http://patchwork.ozlabs.org/comment/3682359/","msgid":"","list_archive_url":null,"date":"2026-04-22T22:10:08","subject":"Re: [PATCH v4] Improve handoff prepare on SoCFPGA","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Brian,\n\nOn Wed, 22 Apr 2026 at 15:13, Sune Brian wrote:\n>\n> On Wed, Apr 22, 2026 at 10:54 AM Simon Glass wrote:\n> >\n> > Hi Brian,\n> >\n> > On 2026-04-21T00:47:19, Sune Brian wrote:\n> > > Improve handoff prepare on SoCFPGA\n> > >\n> > > There are some cases that the Python scripts\n> > > are run and the qts files are not replaced.\n> > >\n> > > This patch introduces:\n> > > 1) TMP folder for Python script\n> > > 2) TMP folder will automatically remove on exit\n> > > 3) If PY script fails, the replace will not conduct.\n> > > 4) Only when PY script passed the replace with keep\n> > > or without keep will be done via NEW HANDOFF_KEEP=xxx\n> > > 5) When keep is selected the old files are renamed to\n> > > xxx.h.handoff.\n> > >\n> > > As such this ensure qts folder h files are properly\n> > > updated.\n> > >\n> > > Signed-off-by: Brian Sune \n> > >\n> > > arch/arm/mach-socfpga/config.mk | 27 ++++++++++++++++++++++++---\n> > > 1 file changed, 24 insertions(+), 3 deletions(-)\n> >\n> > Reviewed-by: Simon Glass \n> >\n> > Some thoughts though.\n> >\n>\n> Hi Simon.\n>\n> > We try to add a change log for each revision and use imperative\n> > present tense (Introduce a temp folder... rather than This patch\n> > introduces...). Spell out Python script rather than PY script, and\n> > reword as prose or a bullet list instead of 1), 2), ... You could also\n> > explain *why* the qts files were sometimes not being replaced - the\n>\n> Because it is not fully traceable, git pull sometimes could introduce\n> some kind of unknown cases that even run make prepare will not update\n> the h files or the python script itself does not fully replace it from\n> first place.\n> So the easiest way to play safe in any possible condition is\n> [remove and replace] or simply [rename and create].\n>\n> And I don't even fully confirm the cases, while this patch does improve\n> the previous .mk operation no matter if it is solving the unreplacing issue\n> or not.\n>\n> So the motivation was explained from the title itself.\n>\n> > motivation paragraph currently just says some cases without saying\n> > what goes wrong.\n> >\n> > The message says kept files are renamed to xxx.h.handoff.\n> > but the code uses .h.handoff_backup. - they should match.\n>\n> That my mistake on the description, indeed it should be\n> .h.handoff_backup.\n>\n> The idea just follows T.F. previous optional idea so I don't fully pay attention\n> to the wordings.\n>\n> >\n> > > diff --git a/arch/arm/mach-socfpga/config.mk b/arch/arm/mach-socfpga/config.mk\n> > > @@ -43,6 +43,27 @@ socfpga_g5_handoff_prepare:\n> > > + if [ -n '$${HANDOFF_KEEP+x}' ] && [ '$${HANDOFF_KEEP:-1}' != '0' ]; then \\\n> >\n> > How about:\n> >\n>\n> No I don't like this because you ignored my original idea on:\n> 1) HANDOFF_KEEP= should run keep\n> because HANDOFF_KEEP cannot without = in .mk usage\n> 2) When users use this flag, hence, it is telling that they want to\n> keep the thingy.\n> So it makes no sense to =1 or =0 to further control it from first place.\n> This flag is inherently boolean logic.\n> But due to your suggestion I further elaborated this boolean flag to\n> support =0 or =1 or =x cases.\n>\n> Sorry for this part, I will not change.\n\nThat's fine...note that you have my review tag, so you can add that to\na new version, if you do one.\n\n>\n> Cheers,\n> Brian\n>\n> > if [ '$${HANDOFF_KEEP:-0}' != '0' ] ; then \\\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=DhdrnEIT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"DhdrnEIT\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g319H710Wz1yHv\n\tfor ; Sun, 26 Apr 2026 06:08:19 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 169378419E;\n\tSat, 25 Apr 2026 22:08:17 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 3FFAA8420C; Sat, 25 Apr 2026 22:08:16 +0200 (CEST)","from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n [IPv6:2a00:1450:4864:20::32d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E387784178\n for ; Sat, 25 Apr 2026 22:08:13 +0200 (CEST)","by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-48374014a77so116976425e9.3\n for ; Sat, 25 Apr 2026 13:08:13 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1777147693; cv=none;\n d=google.com; s=arc-20240605;\n b=Ymy5oDZAmIuEdRaokNXG73w9VxPf9YbzB/33rMkaSiqjFczGQpOEiEtxTeVuXUD/zd\n hI2K6NkPw865uFaD2MwKnWTdMLYhy25JKtbGgYtWpX7GCeh7qqbhTwbMOzAeh1hO63vG\n 4q1TMVt0B5sc4+JiCJfj1tSWVzlqF3/Xd9x7nPznoHPJu22o89c37VL1htCkI3KlK23P\n E0x14Z4asX+zA2G3eVd/nzIDn6EyzcOJTysw/3aYLCi4bzdcUL7/tweiMXH1wR58oGgp\n zdndv3YYyfX/Ponq5BRxy0bEzgy5o/x7sJqaqwvCsHKpqIUNHW40SGOrb/M1nD7H25BT\n g/lg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=q2wh19CCCQ5JHODDT04EbXBebRoxxlL7efyGkhVuvZc=;\n fh=hEymi4IDFEKte3k2lI6EQ3gTkd/kHtxBaVclzQGgSGw=;\n b=XXdHkZEw2hmWBNhAsF7HLCV1lvyuddUoaPxhK7YyH6wGzuE9qHk4fmb1gRO20YTcS6\n xJFnnX/ZDHADe1NYDAZf3Wc0k+30JUeM/+CEoNnrNTskVeGKI31zkGl66mgaoWVI9TPA\n knrf0HS5qwLbbq+d5bq4jpv+PrNhUhj3poV3OykLGmzsfLccZXgZdMevmDaqCHzhun6h\n yZ3S0fPdldnSwX2LcCtGe4wCid64YzmzfkW/j6PqXfI15iB4jXQza9xggW7Bb6BsLUwv\n hRq4OY/ISnfs9uAgW36d7e8f45WeHIHRs33kNvDTmjqJz6eeI2CrRsDnkM6ctzVIleU8\n h7Kg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777147693; x=1777752493; darn=lists.denx.de;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=q2wh19CCCQ5JHODDT04EbXBebRoxxlL7efyGkhVuvZc=;\n b=DhdrnEITEzMdQO4BGYM4+M/3M8zH1E82NvNYuecwgxgPwSeI3eK732I4W1+1ZKsiPh\n 3NlL6l/hY7qnX+HxEgQtbqM96Sd2wWHVwawnk3W1mciT8qsJw8U4RFhKlrzdqOlg9DHv\n DRVM9R5fy97T+l/Ze5vldMX1Q5yZ2BQ1JIncw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777147693; x=1777752493;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=q2wh19CCCQ5JHODDT04EbXBebRoxxlL7efyGkhVuvZc=;\n b=OJhSh63ejrotNcW7TWuyVpMLme2r4AkDkQ5KSawgnNHCloZezhG5Od0HtG1ckC6I1N\n 7xjz6xfhR5ORD0RrmxZawjaHmAWGI9WtC4cb88bqNK8YhSZjeh7Ja5th7xI251lr3v1r\n +4sMef0LqHtP+rtROKQKZJ4GLbgRFzR/XNCMUhOcuRTR9DS48JRidxS61U+gl0kBZFV5\n o6AR0ELUfXWPu6GsveVdwuOsR3w1jr+fVZ+9EYu8QUWCX1uZgW/JUCTkRrN8hljFs0lF\n Ylnjaofec7RAp/8pP52XHKj8FOR2b86OWdXQiLgXa9So/P/EyznpuaEn/HVhMzkKGPMG\n qw3A==","X-Gm-Message-State":"AOJu0YzSwsVVdfESzxp03OCi7YSkdG1tRGqDixvgl8gr3sqKlzCRXUH5\n 777pq5TPNThy3pJk6gR/CZTpNYYo0AqUXDqt0nwtwAwtcEohUcL65ycnEdKWDGVXOTMWFPvy7py\n 3dHla5g6w/QR5+feaayBdnivp266gWZPeNDsHl7UDgXXfhTC/tJA3bA==","X-Gm-Gg":"AeBDietOhW8owuCi4ujg0TK2OG4zljrkNOvSCGgc9xGyoYXZOuRf7FaxZ6hd6THC1Vq\n 2dEzjI7TZtNQaWnNN9qkOCKcoUVwq4eWuIN9Qiqc3NWp1YEKJeUwp/7zG/wsv2sHr3Q5umFnDuw\n O0uObMeUReyGP0iORJY9amHnCQahH4Lvf60UxWq2HcqISuw1g87k0BwdKJEwI6SPjYhEqa6BC6S\n Ia2B0jdCbXWf1LrmER6GxKURgYbmTn4+EAV2GFTQ7gvRuC/aL3eGxyhHzeed2zL1x/UdisceVBE\n e3N1GxKe8TbVSuo8lgHU","X-Received":"by 2002:a17:907:3d8e:b0:ba9:7898:c0ab with SMTP id\n a640c23a62f3a-ba97898d80amr478251966b.13.1776895821187; Wed, 22 Apr 2026\n 15:10:21 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421004719.73491-1-briansune@gmail.com>\n \n ","In-Reply-To":"\n ","From":"Simon Glass ","Date":"Thu, 23 Apr 2026 10:10:08 +1200","X-Gm-Features":"AQROBzB732I9OyycwRY1OTpp8xpwNJ2Uvm-P1xOtcf-uqCReAP8hmHuss42vpQI","Message-ID":"\n ","Subject":"Re: [PATCH v4] Improve handoff prepare on SoCFPGA","To":"Sune Brian ","Cc":"u-boot@lists.denx.de, Tom Rini ,\n Chee Tien Fong ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3682360,"web_url":"http://patchwork.ozlabs.org/comment/3682360/","msgid":"","list_archive_url":null,"date":"2026-04-22T22:29:46","subject":"Re: [PATCH v4] Improve handoff prepare on SoCFPGA","submitter":{"id":91590,"url":"http://patchwork.ozlabs.org/api/people/91590/","name":"Sune Brian","email":"briansune@gmail.com"},"content":"On Thu, Apr 23, 2026 at 6:10 AM Simon Glass wrote:\n>\n> Hi Brian,\n>\n> On Wed, 22 Apr 2026 at 15:13, Sune Brian wrote:\n> >\n> > On Wed, Apr 22, 2026 at 10:54 AM Simon Glass wrote:\n> > >\n> > > Hi Brian,\n> > >\n> > > On 2026-04-21T00:47:19, Sune Brian wrote:\n> > > > Improve handoff prepare on SoCFPGA\n> > > >\n> > > > There are some cases that the Python scripts\n> > > > are run and the qts files are not replaced.\n> > > >\n> > > > This patch introduces:\n> > > > 1) TMP folder for Python script\n> > > > 2) TMP folder will automatically remove on exit\n> > > > 3) If PY script fails, the replace will not conduct.\n> > > > 4) Only when PY script passed the replace with keep\n> > > > or without keep will be done via NEW HANDOFF_KEEP=xxx\n> > > > 5) When keep is selected the old files are renamed to\n> > > > xxx.h.handoff.\n> > > >\n> > > > As such this ensure qts folder h files are properly\n> > > > updated.\n> > > >\n> > > > Signed-off-by: Brian Sune \n> > > >\n> > > > arch/arm/mach-socfpga/config.mk | 27 ++++++++++++++++++++++++---\n> > > > 1 file changed, 24 insertions(+), 3 deletions(-)\n> > >\n> > > Reviewed-by: Simon Glass \n> > >\n> > > Some thoughts though.\n> > >\n> >\n> > Hi Simon.\n> >\n> > > We try to add a change log for each revision and use imperative\n> > > present tense (Introduce a temp folder... rather than This patch\n> > > introduces...). Spell out Python script rather than PY script, and\n> > > reword as prose or a bullet list instead of 1), 2), ... You could also\n> > > explain *why* the qts files were sometimes not being replaced - the\n> >\n> > Because it is not fully traceable, git pull sometimes could introduce\n> > some kind of unknown cases that even run make prepare will not update\n> > the h files or the python script itself does not fully replace it from\n> > first place.\n> > So the easiest way to play safe in any possible condition is\n> > [remove and replace] or simply [rename and create].\n> >\n> > And I don't even fully confirm the cases, while this patch does improve\n> > the previous .mk operation no matter if it is solving the unreplacing issue\n> > or not.\n> >\n> > So the motivation was explained from the title itself.\n> >\n> > > motivation paragraph currently just says some cases without saying\n> > > what goes wrong.\n> > >\n> > > The message says kept files are renamed to xxx.h.handoff.\n> > > but the code uses .h.handoff_backup. - they should match.\n> >\n> > That my mistake on the description, indeed it should be\n> > .h.handoff_backup.\n> >\n> > The idea just follows T.F. previous optional idea so I don't fully pay attention\n> > to the wordings.\n> >\n> > >\n> > > > diff --git a/arch/arm/mach-socfpga/config.mk b/arch/arm/mach-socfpga/config.mk\n> > > > @@ -43,6 +43,27 @@ socfpga_g5_handoff_prepare:\n> > > > + if [ -n '$${HANDOFF_KEEP+x}' ] && [ '$${HANDOFF_KEEP:-1}' != '0' ]; then \\\n> > >\n> > > How about:\n> > >\n> >\n> > No I don't like this because you ignored my original idea on:\n> > 1) HANDOFF_KEEP= should run keep\n> > because HANDOFF_KEEP cannot without = in .mk usage\n> > 2) When users use this flag, hence, it is telling that they want to\n> > keep the thingy.\n> > So it makes no sense to =1 or =0 to further control it from first place.\n> > This flag is inherently boolean logic.\n> > But due to your suggestion I further elaborated this boolean flag to\n> > support =0 or =1 or =x cases.\n> >\n> > Sorry for this part, I will not change.\n>\n> That's fine...note that you have my review tag, so you can add that to\n> a new version, if you do one.\n>\n> >\n> > Cheers,\n> > Brian\n> >\n> > > if [ '$${HANDOFF_KEEP:-0}' != '0' ] ; then \\\n\nHi Simon,\n\nV5 has been released.\nDue to T.F. \"please to use your check condition\"\n\nLogically speaking.\n\nThe check condition now has become:\n\nA person has no intention to use the restroom.\nBut that person intentionally walk in front of the restroom door and\nspeak out not going to use the restroom,\nThen that person simply goes back to where he came from and does\nnot even enter the restroom.\n\nWhat a wonderful world =]\n\nEnjoy,\nBrian\n\n> Regards,\n> Simon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Swm+URC3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"Swm+URC3\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=briansune@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g31Jt2JFfz1yHS\n\tfor ; Sun, 26 Apr 2026 06:14:54 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 43B9884308;\n\tSat, 25 Apr 2026 22:14:52 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 2DD6A8437C; Sat, 25 Apr 2026 22:14:51 +0200 (CEST)","from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com\n [IPv6:2607:f8b0:4864:20::c35])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id EA7D784178\n for ; Sat, 25 Apr 2026 22:14:48 +0200 (CEST)","by mail-oo1-xc35.google.com with SMTP id\n 006d021491bc7-67e0d3f288aso5539294eaf.0\n for ; Sat, 25 Apr 2026 13:14:48 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1777148088; cv=none;\n d=google.com; s=arc-20240605;\n b=SfF7KI0Waa3sB5M9y4wkDT0QaQPSKlNTLCEULp44jY9MtIPoe0PupYb+EQRm8t0Bb9\n P41xvpXYnLD8BFOgT0kiF7uXEdtTD9kOfmlS3WGWilhefuK6uDuk/tKDY+RYHcmR3iwX\n rsUfd7MZVGR1/I8j5CFxy2tQ6u+Y9it8O2Nkt0KIA1wOT7awdBckbx0kPS5MDrRe0b8g\n XpqtCIlYdkf1lhJRv0kb1vPISoqfzdce43EeNk41shjfHsWRcI79l7EOaEfgUYDmcY4F\n MZYl3C7i9tAXbLXllqbixq3DCZau3EGeHOOp6m8REueZj7AFOQmZigFErzTGaLlDXBSs\n o85Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=FRN/HTs1GWpMnPsI/nbsgyuPMeMMax58Frmu13DK0Kw=;\n fh=XmvCthC/BjXYU0ZrHKfxQew09xn0WtefmKj6MWJpbfI=;\n b=ZoC7nGMmbjQsn07HVRGcS0Gr2Y84TQ36EJTe3mDKGWcK6+mvF8zrltNoKSJtnrGpuq\n LEO4aN63qvZNWIiUF0mIvAK835jzjKyRQLUQaG40LbOOhVy8ahZO76upsSYs6vAh/CKO\n G2eZLkYxt+iEMDMLWKomN5sTdJiOgKUE+NYK6a5+G5WGA+PfiClNsm2wFVKrnYxXRZEJ\n MOkGBQs1K5MrCKwDIM/Jp6eb8pUNVU+PjtSMwgdA/P6Qu3j408mRaL2bDfNcEa7oJc3Q\n Q2tW0ZoxZ5pOALohmh0eA1NaF+q/w5oLf6jEaDfjVCrOCm6GIuUfmHSRsWHNEmpWfpUZ\n 8v8A==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777148088; x=1777752888; darn=lists.denx.de;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FRN/HTs1GWpMnPsI/nbsgyuPMeMMax58Frmu13DK0Kw=;\n b=Swm+URC31SDguGP5eqyHCaSfKY/jr61ud8nyTGaeNi/BERPTliyfpc62w0GDM4CPod\n /dKIPmCYdHpJZSGyzDPEsx/5FIkspJaFfSkqeRG7xxLAaHgxe0qGRSO/zY5Aaia7ygN6\n fAma4OAUJKavdR0LuAtpvzqE+wtyl1R5qOx4lvx0zcw/0GjTvV0f8PFViGyZqwGzHDX6\n quqgCjSzqcclMGc75nqWsg+/hOfSESBBAcZU7Yrlpc1Z3KIK/83noBKDyMjvgXBUGUlk\n WUW2TRgfQp4Bx7o6KRgYTuFZTTecacZzqR3aWcHpdWzpwZQv3LEHzPrsqf0HX9gCGxkT\n djjA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777148088; x=1777752888;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=FRN/HTs1GWpMnPsI/nbsgyuPMeMMax58Frmu13DK0Kw=;\n b=sFEWXkB/N/ybq6xqCtAmcrshcy4z6bq01VKr9NBmqri9bayvR3MvDXE14Mdwxpm1Xr\n iETST2xBqCbk8Z+XaiQRGQugSc9KD6LxoV8pQhlJhZW0E4FwMtzrxFYAWPwoJP/TqTCC\n xqQVVilMWcg2d7suP7DqvPVM+q5CXItFKSho5CJVEadjognLpBdpXDhViTeIvNAPii1L\n Lk6r22jg+5Z+3oUkdyTxx6ZEvswLvhfh58SwP+S82/V/XJXBw8aK032jGmzAQlUZXjrF\n ArQGdgo1PRDeKCXU0+AWpjXMIaa6GiRmsu4nGHZQPrl704LfObe7Eb7FPrh18+4BYjuo\n yJrw==","X-Gm-Message-State":"AOJu0YztDGUE7/14xIZ/V8YZQ84KflC7QJjzbwn+NmFajYGb/PvJvIS+\n PM7XtVnbId8K8kKNRE5xdItHLTAcuRiHXv7VH0+ErRNc2QilwjmUlLq2EgDAz6lVI3cXNS388FI\n 4sQ45PJ4y/S8uEnnGemGFogQK0QFaacSpIfC8eKHj2ONR","X-Gm-Gg":"AeBDiethn0TpKapPU55r14pCQUfQvCEsKQQFtO5F1HMT/xbaoAmzTDKFbvpIOGm1fLI\n 4qnP4KgG/Sq6KavEkSqWwuNKhWLlsPn8tWx/54wq3gUhZG5ClZhPtcgkAptsuKOiN//fjDhTL0x\n bGUJIXSrhnJxaUbu5R/ZMFW8fz2GxQAypGEiSBmausF2+CGjpaSr7jKPeX/ZGANuAYVeKz1yM65\n +/zV59a/kWuMLUspD7fCbSBSJRiWgEEAdH284Dut4A/3AZlEefjmbCAgqBicu+5yhG5EF2L2qPu\n MoG2XzMAbEm7mYEMck0=","X-Received":"by 2002:a05:6830:f95:b0:7dc:e0d4:70c5 with SMTP id\n 46e09a7af769-7dce0d4726bmr4405025a34.25.1776896997959; Wed, 22 Apr 2026\n 15:29:57 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421004719.73491-1-briansune@gmail.com>\n \n \n ","In-Reply-To":"\n ","From":"Sune Brian ","Date":"Thu, 23 Apr 2026 06:29:46 +0800","X-Gm-Features":"AQROBzBscW54Xxfjk7RtpkNP_UsNFicw4wI1Cp-EL87gx4avEF7wktiBJO1qdi8","Message-ID":"\n ","Subject":"Re: [PATCH v4] Improve handoff prepare on SoCFPGA","To":"Simon Glass ","Cc":"u-boot@lists.denx.de, Tom Rini ,\n Chee Tien Fong ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]