[{"id":3680117,"web_url":"http://patchwork.ozlabs.org/comment/3680117/","msgid":"","list_archive_url":null,"date":"2026-04-21T22:50:44","subject":"Re: [PATCH v2 2/8] board: ten64: add fdt fixup to hide usb hub\n topology","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Mathew,\n\nOn 2026-04-21T00:04:33, Mathew McBride wrote:\n> board: ten64: add fdt fixup to hide usb hub topology\n>\n> The USB Hub (microchip,usb5744) can enter a dis-/reconnect loop\n> if a driver tries to re-initialise the hub over I2C.\n>\n> On the Ten64 board, this process only needs to be run once\n> per system reset cycle, which is carried out by U-Boot.\n>\n> As there are distributions shipping with the affected\n> driver by default, the best solution is to remove\n> the USB hub toplogy information from the FDT passed\n> to the operating system, so the OS won't attempt\n> to re-initialise the USB hub under any circumstance.\n>\n> Signed-off-by: Mathew McBride \n>\n> board/traverse/ten64/ten64.c | 45 ++++++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 45 insertions(+)\n\n> diff --git a/board/traverse/ten64/ten64.c b/board/traverse/ten64/ten64.c\n> @@ -186,6 +186,50 @@ void fdt_fixup_board_enet(void *fdt)\n> +/* The onboard USB hub driver (microchip,usb5744)\n> + * can cause a disconnect-reconnect loop if the operating system\n> + * attempts to re-initalise the hub after U-Boot has already done it.\n\nTypo: re-initalise -> re-initialise\n\n> diff --git a/board/traverse/ten64/ten64.c b/board/traverse/ten64/ten64.c\n> @@ -251,6 +295,7 @@ int ft_board_setup(void *blob, struct bd_info *bd)\n> + fdt_fixup_usb_hub(blob);\n> return 0;\n\nThe return value of fdt_fixup_usb_hub() is ignored here. I understand\nfrom the cover letter this is intentional (when the control FDT is\npassed to the OS, the fixup has already been done by board_fix_fdt),\nbut a short comment explaining why would be useful.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=lRwrgMkS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"lRwrgMkS\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0cyx5F6bz1yD5\n\tfor ; Wed, 22 Apr 2026 08:51:05 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A833E84319;\n\tWed, 22 Apr 2026 00:51:03 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 7E537842FD; Wed, 22 Apr 2026 00:51:01 +0200 (CEST)","from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com\n [IPv6:2a00:1450:4864:20::62d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 8920D83AC5\n for ; Wed, 22 Apr 2026 00:50:59 +0200 (CEST)","by mail-ej1-x62d.google.com with SMTP id\n a640c23a62f3a-b8f9568e074so813853066b.0\n for ; Tue, 21 Apr 2026 15:50:59 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776811859; cv=none;\n d=google.com; s=arc-20240605;\n b=G7Xqsq1hHM+CH9oFMHKsBBY82jLPSKQBIYCFoqlE4z9QIW9T5wVJRDTZ2KxwB6wmV8\n W6yhtTsXie/0iOVPfUJcjuxZewhV7QHh6QNOTifK/CMpKlrTxAMJkgwRS/f4/3mslNg3\n TuU52y+uCk/k1r/w0KRjdkxB42UiRDCGTUnNOOtGqNpSrVLKk5z0sNUfMzlNUvmu2p9E\n +jIYdSjaAwxzaaqMMTW4NCFbXmARVWbH6RScPgQrkvHGQZDOM95VaACEWrw5qNZyhMZQ\n zi30VjTHBCdRpb9rxDavpbfpvUrKHG2NC4RPG4FLoY0NC8nwsVkaijSDMvGZmIxUK/OJ\n npKA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=4Dc8yUHiogEq0hoKKQDXrfGWTfaHY5KTRzzGmvkb7Og=;\n fh=T79q7iQaKgdBLSTuhvl3jRYD2v6g+8MB8Joags6q2NI=;\n b=INnKbWowX+goougqJBQaaZlB5/cXrW7JGGuyKxYhsG3N5H6D4J4Wn4bbmzYjJ1c2Vo\n /+f0Zy2X0bej8Zt51X8QVsJ9TlYjaCqZ/ae4/0Q6ELeW9MONkjs6gYk0NIJzBDtuffGA\n DDmIO6ursIVuWT5McIEFqh3XVSQW9MpW6RM5WQ1j6AMYJ88CBOAm5HShB5472qfnVaDR\n a2Dpf+z3dXm8JmZKk8ypxGzeIysg1T6LJdvqi/srbo7DhFuBGK/3YjsYegyqqh+NlGe3\n x+sDgWdJ4hbjY/hb4wwXxdX8XhwuqQYOjKP8Nf17rWtwrbaiCvdtW2cMiL08ZKC3c/sY\n FO4g==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776811859; x=1777416659; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=4Dc8yUHiogEq0hoKKQDXrfGWTfaHY5KTRzzGmvkb7Og=;\n b=lRwrgMkSMwO9pmGA3WgLIBGAHvG/4P2gZkgfmAbBliJkShjyTrtK6o0FbPMrAI3tKI\n 0+ArF5HHLYyUyRaALhA26Zy11lgep/8/f6Yka7a8skUsgYAf+ndHjozSlIZ+hvFjeQrd\n H53PZshB+2k0UMKAzwor/I6FFtMTd+djv1huE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776811859; x=1777416659;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4Dc8yUHiogEq0hoKKQDXrfGWTfaHY5KTRzzGmvkb7Og=;\n b=k/q2xHA7tv4EMjznogQozLRI7BageB1afE+oK7FALdYvnCovsaI0aW2anUCB5DAmWp\n +lE8T6XszQMW11DLTksQIWatmCI3cCd8rZ8uzKouNiFqu4qBRvd0Uenc5i3an4nX/O1Y\n clxItpB7Ttf6lOHb/EcvWsoyUIjxGOcT30rXxaC2DRT4k+Vaz3DyijBQ2JB79/YCJydx\n m9WnAZbuWUVvTPvWK9vEzBS6/1dg/zykRqIAqWbaU2qD5hvwFZndTEf6+tUvEGNqyz+G\n LRRYgD+VeJzB1a8FYFpNsNcw1YmPW3gEwQkbbpPZ8Hm2BSCFCQ4FzMzBiPgM1itzY+B9\n 7tgA==","X-Gm-Message-State":"AOJu0Yzhuw9V5pQlK3b7PRM+PwQyT87nk3ayxg7eYms3IrCLLwP1G9MH\n pDNsbzdUnLYFgVYoAYkpcc24UG0X35rUfNpKAWxBEYp1NisxLx7UVVAVflFGIC5L1QAM7SJwF6N\n JFcBiYTIVmA2OtNPg8IoCQg3Cy5U2zFjoFA1WiMov","X-Gm-Gg":"AeBDieudn4OjkQEtsp9I5JQ14EbbJtq0tkFWiSQbrCnDNqCvncJDLpONHpV3ygYPfsP\n 0h18Y/Pz1EyAstz+H2126VC53knNBO9GahAaybtggdr9EAqmoUC4Z/ICDYLnM5C0Z5TjhZiGsRV\n V7WSLgL/wFfCbCEpKVU8c4fB/JD4tXbPr2lMqS1yau2iMkhkLta6HhUfzNB9E4CvcM3xc/qYj8z\n 1ZZeWTAGADUPbdGG3LcMoFTJlBXc4z1zOaSAG5BkTWac+Tpf/0jLm9se7kkFHwo1KM+KvBk5CBK\n +VVlDoucnnC/pR61aRbk","X-Received":"by 2002:a17:907:970a:b0:ba7:9885:b56e with SMTP id\n a640c23a62f3a-ba79885ba4amr500815866b.20.1776811858917; Tue, 21 Apr 2026\n 15:50:58 -0700 (PDT)","MIME-Version":"1.0","References":"<20260421-ten64-add-usb5744-v2-0-eaa81288e393@traverse.com.au>\n <20260421-ten64-add-usb5744-v2-2-eaa81288e393@traverse.com.au>","In-Reply-To":"<20260421-ten64-add-usb5744-v2-2-eaa81288e393@traverse.com.au>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 10:50:44 +1200","X-Gm-Features":"AQROBzCiW7U_AloyWMMGClzlX9a8JeZdrTFW0iK3YEoX-ADoexhqnVgC12KaKa8","Message-ID":"\n ","Subject":"Re: [PATCH v2 2/8] board: ten64: add fdt fixup to hide usb hub\n topology","To":"matt@traverse.com.au","Cc":"u-boot@lists.denx.de, Tom Rini ,\n Lukasz Czechowski ,\n Quentin Schulz ,\n Michal Simek , Marek Vasut ,\n Padmarao Begari , Peng Fan ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]