[{"id":3680113,"web_url":"http://patchwork.ozlabs.org/comment/3680113/","msgid":"","list_archive_url":null,"date":"2026-04-21T22:49:01","subject":"Re: [PATCH 2/4] cmd/acpi: add optional index parameter to acpi dump","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Heinrich,\n\nOn 2026-04-20T22:08:00, Heinrich Schuchardt\n wrote:\n> cmd/acpi: add optional index parameter to acpi dump\n>\n> Add an optional index parameter defaulting to the acpi dump\n> sub-command.\n>\n> Signed-off-by: Heinrich Schuchardt \n>\n> cmd/acpi.c | 19 +++++++++++++------\n> 1 file changed, 13 insertions(+), 6 deletions(-)\n\n> diff --git a/cmd/acpi.c b/cmd/acpi.c\n> @@ -12,6 +12,7 @@\n> +#include \n\nThis include seems to be unused?\n\n> diff --git a/cmd/acpi.c b/cmd/acpi.c\n> @@ -183,9 +184,11 @@ static int do_acpi_dump(struct cmd_tbl *cmdtp, int flag, int argc,\n> + char *endp;\n> + ulong idx = 0;\n\nendp is set but never checked. Please either check that the entire\nargument was parsed, or use hextoul(argv[2], NULL) and drop endp\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=MP+mclpo;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"MP+mclpo\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0cx12wcnz1y2d\n\tfor ; Wed, 22 Apr 2026 08:49:25 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id ED5F484319;\n\tWed, 22 Apr 2026 00:49:22 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id E0AEE842FD; Wed, 22 Apr 2026 00:49:20 +0200 (CEST)","from mail-ed1-x530.google.com (mail-ed1-x530.google.com\n [IPv6:2a00:1450:4864:20::530])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 044B483936\n for ; Wed, 22 Apr 2026 00:49:17 +0200 (CEST)","by mail-ed1-x530.google.com with SMTP id\n 4fb4d7f45d1cf-671ae79e617so6108523a12.3\n for ; Tue, 21 Apr 2026 15:49:17 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776811756; cv=none;\n d=google.com; s=arc-20240605;\n b=b1ADRY9u6gCmtU+0EG1T7stMrartnDYbAiG3YOk8cPvSVAuILLHS2exctR+Dli8lz5\n BBldRgYArN/sWlD23XUjc+G/EL+QFzEAzDzngvyMYaQwKZsEeW5eYmUv9F7j3kTWFyLX\n cf0Ty5/42wynThcZZPllcVWSemx4Fw6clhrYtpMaOkPGeNoiZo45+D+acOVH5UqsCQ+R\n Lo0nX3+ilWJBJhNfZn7j+pdNlLpFTCu1OizX3ij9fNiE8+jZ/w0IjPdAP9LUbetpJtzv\n AQSkudA/LdirG1QjQxOE9Xsz4awqTx1K2hlsXxfzjysNsvLEuZ+Ktofq1zqlpZn8xSkp\n w+/Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=ZRzqj+F/kgAqg7nO+HAZlpjlh1bPqWJsT4cDg4AY8Xg=;\n fh=pbCOP8hPpdi+r37R4azvlvc0fZkZayccZKdYXQY2i9k=;\n b=RZAB2t7mA8Jyeudwc9XKvHUZbPNV+XXTK1enGX9B/ye/1fjPm26dbheFrUGWuP/xeE\n WbMi38LwkV6fkgbakI8WsxxZ7pxluNpjmtqRR5mSEh6XZvSbNa/y13Ild7aGjuOQ5Gpi\n w49xprcf8cBMbQCKQMWUqA0dWFOht8+AwY9DXf0i548f22ZMeAt86PeGX59eAUeKr/zr\n 5sXBL4GmjXIOnx/m2iaOtns7UQwa1v3kYEiF7GpZgTky0ua4Yohi0Mq3qsiBsRGzxL+o\n xx3SaJLkJC12Vrav9EOQ1EsM+nMqUuhcbWWDLRSDYFwtLB1VIQI/XTWwRhnUeWOglRaw\n AYFg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776811756; x=1777416556; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=ZRzqj+F/kgAqg7nO+HAZlpjlh1bPqWJsT4cDg4AY8Xg=;\n b=MP+mclpo/0eALYv27xXZgWOPkMyWQae6gS/3gxbVtkEjfpj4sufeOqMEeCxwcTTsJU\n ukUJny/bEexZbwGpRWChipO4Yih7jqHk7QJfE12uHjmbnr/puMJRLBuKI9xqwLC2xoG2\n k4Qr4uIiHfcr20jg0dBCgyEH0sXyagtGHXVK0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776811756; x=1777416556;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZRzqj+F/kgAqg7nO+HAZlpjlh1bPqWJsT4cDg4AY8Xg=;\n b=Wk1AhYS9A0xECMvG7nRBj23sb0MnV7+CqZUes9BeDGw9dGagW9oPX/Xlw3d/qW6gOr\n QrmSeFHCWYxvzWNQ8gO77Gt6KlAFwCMI29EZ3ttw+Juh+ywd+Ov69RBDB4g8hqf8FNss\n hyfAezE5AUTpGNLvjMm7tBvaPskwVzzDEYQEWFLTB4gLr08J65ZwDyIk42xe0GV1dkyB\n MCYNfUsThwyUVANDVhi8+xCqTBfp397EAZ2EDjj5lRzG3uBK0D0skyx+5IPY+Zox+Daw\n xFoTtDf0VeJVnMhXbB34j20vBADafXog6q8Yj9tO+Jgl4Dk8Y2nXaXY1mEiVG8o1bsqE\n D/Lw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8JAbm5Js20zxXdGAXQR9r/se21LDX13/anTtLdEpxfjIj9cNIPG7MzY4wY9YnDhihrSMh4b58=@lists.denx.de","X-Gm-Message-State":"AOJu0YyF4RnK7vcJ9EK9xcmjPxItVNA6VuSIpVP5Vc3XmMhejuwmoOni\n bjSIFwS/trJek5q7GOs27GJvLmSyWyXxlhugyiEe8SbH5/1BOV+WbY0/9sNNWMYgtp0HPfI2vFX\n z3InMTwzEkF0jWxzqJrHf7djeUWfOCbLcJj8JUwyA","X-Gm-Gg":"AeBDiesLkZGFyApLDQ7hGNf/ZqBZ/xz9NPCuehnvR+08CZ8nPVOdCusnt9LJo++tykr\n pi4j/vhjq+hrTfT+tB9c4C/qeqTB1EuiDFq1C6Jvra7l+l0clT9xSZVh9Rj2gxmJCXOAqhYwRU5\n 9FiQEsOvemv5eNwUIeUybHXp+uCcN2GaPDI4Iy0Sz5yrB8jQUQozbGMw8l6uc/NoNGXwofriSlW\n Gy/SNn98/p27w8CGrtwwtv5Y7ssHa2vQCAx9SjBp4iyo0PiRZlOSQW+YKbusXgyJ+kboKvYNQhz\n TBOgtF5MpZdGs/AZKInKE8I+tDqXAh8=","X-Received":"by 2002:a17:907:d20:b0:ba4:bb78:b79a with SMTP id\n a640c23a62f3a-ba4bb78b9a9mr840491366b.44.1776811756196; Tue, 21 Apr 2026\n 15:49:16 -0700 (PDT)","MIME-Version":"1.0","References":"<20260420220804.71564-1-heinrich.schuchardt@canonical.com>\n <20260420220804.71564-3-heinrich.schuchardt@canonical.com>","In-Reply-To":"<20260420220804.71564-3-heinrich.schuchardt@canonical.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 10:49:01 +1200","X-Gm-Features":"AQROBzC518i2L42JTQDjVKS2h3Vo41n_uNYAGBU5beXE8i3vWP3TflR09gejMDk","Message-ID":"\n ","Subject":"Re: [PATCH 2/4] cmd/acpi: add optional index parameter to acpi dump","To":"heinrich.schuchardt@canonical.com","Cc":"Simon Glass , Tom Rini ,\n Bin Meng , u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]