[{"id":3680112,"web_url":"http://patchwork.ozlabs.org/comment/3680112/","msgid":"","list_archive_url":null,"date":"2026-04-21T22:48:46","subject":"Re: [PATCH 1/4] acpi: add index parameter to acpi_find_table","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Heinrich,\n\nOn 2026-04-20T22:08:00, Heinrich Schuchardt\n wrote:\n> acpi: add index parameter to acpi_find_table\n>\n> ACPI tables like SSDT may have multiple indexs.\n\nindices\n\n>\n> Add an index parameter to acpi_find_table() to allow finding the n-th\n> instance of an ACPI table with the same signature.\n>\n> Update all callers to pass index 1.\n>\n> Signed-off-by: Heinrich Schuchardt \n>\n> cmd/acpi.c | 2 +-\n> drivers/serial/serial_coreboot.c | 2 +-\n> include/acpi/acpi_table.h | 3 ++-\n> lib/acpi/acpi.c | 21 ++++++++++++++++-----\n> test/dm/acpi.c | 18 +++++++++---------\n> 5 files changed, 29 insertions(+), 17 deletions(-)\n\n> diff --git a/cmd/acpi.c b/cmd/acpi.c\n> @@ -55,7 +55,7 @@ static int dump_table_name(const char *sig)\n> - hdr = acpi_find_table(sig);\n> + hdr = acpi_find_table(sig, 0);\n\nCommit message says \"pass index 1\" but code passes 0. Did you decide\nto go with 0 in the end?\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=TDOEaPDG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"TDOEaPDG\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0cwr4Yrrz1y2d\n\tfor ; Wed, 22 Apr 2026 08:49:16 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 6F18A841F2;\n\tWed, 22 Apr 2026 00:49:11 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 3912D84368; Wed, 22 Apr 2026 00:49:10 +0200 (CEST)","from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com\n [IPv6:2a00:1450:4864:20::52b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A61C783936\n for ; Wed, 22 Apr 2026 00:49:03 +0200 (CEST)","by mail-ed1-x52b.google.com with SMTP id\n 4fb4d7f45d1cf-676f6c823c3so31587a12.3\n for ; Tue, 21 Apr 2026 15:49:03 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776811742; cv=none;\n d=google.com; s=arc-20240605;\n b=QEQW1qtAtI1Czjz/VZmdLJywyb1D8sKpvXhoZjdgwHGt7/LfevkKuDJyfnoh1WupFt\n 4HygKV0PhHztjVihpSO+v1c9u+snpF9H+qaaMx68InasiE00Z633x70d2VkYDaQSog38\n P3Y3BL+DvyyKLaRhNpXxuSIrQAMll+Lb6qtJiFttlAkFeqdgjSl/8nncS9VqdOoTExfW\n gGeUDf+PMFk+fjLmYjF6XB6wJXoG3xcSwLxUm7+Q17W92WTk8GhT7yUZMWWu/rZKRacq\n OcxWdPfarrKpKsq+kD0NmhA1NYomyW5wQZCLDUiMWhduDu80jMqjDqu6M7C+WjsmWjCN\n 5yNw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=fVQMIvyVs4riNxTQ3Ne1izpUQzix5rooeIGZHyyYcD0=;\n fh=g43PDCvbMQnBS84yLyS2MZ/lnMGufNsBZld9pcJafow=;\n b=g3zGk64a5Qm3lIBTJTpzH86DodgkPGMR397KpSdUY+DgHYDLsdhxHt0iVBfGhMR/e4\n /8TQtGck8KgXjo5/4sXVOYpkzjTfv5P/VH2vBJDvn7KqeDdBtTa1SF5urRogaTc0d3zA\n XaknwkhgLY2GhjakpRywRdktPLKpbgUepRNSj/om6a8n/fQmFB3Dz4eC2duPI6e2PPJW\n 2HNRUL6UCZK3tmw/+u4DnxVIq8ZeyiKh6OjtX0NpLwswMILhp4TTN0XFGNN6jA/yHd+d\n JT0Aq2eRHD6a3CYPjNuHEkZyAaDJKfObIOeZQ+ZKgNQLNnp5az6sZj3Kaew5J0JWwd0c\n 6PuQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776811742; x=1777416542; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=fVQMIvyVs4riNxTQ3Ne1izpUQzix5rooeIGZHyyYcD0=;\n b=TDOEaPDGSUErkjLmxVRk0deawjRHzns8UJUN6xSJJxJjq0swbCUSRFAskvgVdHC6US\n ODLjNGV4HCVSutdM2vjcTIGT5eS+LMfbRhJESzxVSDKj1MMXuYAeGeXNSFP7mKxEhqN4\n Un2wKcUyoDdvtfgvrlISkpBd+P4cR8qd5x+7A=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776811742; x=1777416542;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fVQMIvyVs4riNxTQ3Ne1izpUQzix5rooeIGZHyyYcD0=;\n b=ErmplLyLvS9L/XsfXiaVys43Pa+sNfhDxrEyjapskCAg+tjSg8ibGj2wRprPtaBKOt\n Ti1VuqbX1RKoonUr7zz60SQzt1CDhMF3x+/+wC+LHGSWdugBNqiT59Hm45goxKBhjw4g\n Gc9n94+/3TLAplEg8FHe/18u/281QJnKlCcyIawnlhQSs1n2UbPM7udBcxjD2OfuisDK\n jHUHZpPoi8e6XbzE+EeO4M3J50H+3nUzwhMujJCsyN9IqnaeC5UG35Tk0qvHr0CBO2CM\n XQfJx1l8gDyXz3BSG4fB4/faLcaBdDb5/yAvNJxkJHCfemiPHHJ3NWkW5GfvlD9+YsKp\n e9Xw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+a6j1WBhLu2QImjsjn1FiOiFurKfN9pnZ25Ya0hUVb+XevnquDwUoUsfkBld9y5B+Qi5c5RlI=@lists.denx.de","X-Gm-Message-State":"AOJu0YxzV8iOBCFxy/Z0WYof6K20kd6Q8Km5EgwVdrkmzlHPi2AkskHM\n 05pt25Ej9BA3TDUKWKdgRxCVdKVWqz1307zp9QRGBY0vmj+vMAizVwcC29d/+Z0dmrwTyt/Qu1Y\n 8afQDHNxkFg2fy1BAmdf0IlLfb0u+qZvq5Wv6AbWd/j+BBN7ZGpfwsA==","X-Gm-Gg":"AeBDieslnr/IH+YrSO1mNV0TM0kYg3MQgiPeZlhhtJfW3nVo7eJvEF7AbjD0G/8GiA8\n IHFkq8fXMH7cgzVX/j/+xHpT3xpCKiFg4oVR2D+HFB6HpTXxhXDv5zdOEyZ9OIlK/woV+L+QUEW\n L1Cegw3El4xbHzVDCqm8GWJdwcH8fHhTgZy2/pMJcKqOgKfw7eZlz8H1wAJ71QKcf4FjokgrAva\n BIaauJBr8MfVZ2V7QbTmN89Ik09iEaAu5LOIIea67J6WM/1GJ29cSryf29WU0gPTpGivBQ8BBjK\n fievg/gSriFf/D9YJ2By","X-Received":"by 2002:a17:906:c3a5:b0:ba9:2282:2897 with SMTP id\n a640c23a62f3a-ba9228229b5mr246742566b.15.1776811741913; Tue, 21 Apr 2026\n 15:49:01 -0700 (PDT)","MIME-Version":"1.0","References":"<20260420220804.71564-1-heinrich.schuchardt@canonical.com>\n <20260420220804.71564-2-heinrich.schuchardt@canonical.com>","In-Reply-To":"<20260420220804.71564-2-heinrich.schuchardt@canonical.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 10:48:46 +1200","X-Gm-Features":"AQROBzDWa6mJpKuLff-OqSDWSfgl41rOt2Pax9J2bCsTmpYsnwMAyyVcD0kIIZg","Message-ID":"\n ","Subject":"Re: [PATCH 1/4] acpi: add index parameter to acpi_find_table","To":"heinrich.schuchardt@canonical.com","Cc":"Simon Glass , Tom Rini ,\n Bin Meng , u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]