[{"id":3680167,"web_url":"http://patchwork.ozlabs.org/comment/3680167/","msgid":"","list_archive_url":null,"date":"2026-04-22T01:15:34","subject":"Re: [PATCH v2 4/4] efi_loader: centralize messaging for\n efi_init_obj_list","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Heinrich,\n\nOn 2026-04-20T22:03:17, Heinrich Schuchardt\n wrote:\n> efi_loader: centralize messaging for efi_init_obj_list\n>\n> If efi_init_obj_list() fails we cannot use the UEFI sub-system.\n>\n> * Instead of having messages for this everywhere write an error message\n> in efi_init_obj_list().\n> * Always use (ret != EFI_SUCCESS) when checking the return value of\n> efi_init_obj_list().\n> * Remove the return code from the error message as it does not help\n> users to understand which initialization went wrong.\n>\n> Signed-off-by: Heinrich Schuchardt \n>\n> boot/bootmeth_efi_mgr.c | 4 ++--\n> cmd/bootefi.c | 5 +----\n> cmd/bootmenu.c | 6 +-----\n> cmd/eficonfig.c | 6 +-----\n> cmd/efidebug.c | 5 +----\n> cmd/nvedit_efi.c | 10 ++--------\n> lib/efi_loader/efi_bootbin.c | 5 +----\n> lib/efi_loader/efi_bootmgr.c | 5 +----\n> lib/efi_loader/efi_setup.c | 2 ++\n> 9 files changed, 12 insertions(+), 36 deletions(-)\n\n> diff --git a/boot/bootmeth_efi_mgr.c b/boot/bootmeth_efi_mgr.c\n> @@ -58,8 +58,8 @@ static int efi_mgr_read_bootflow(struct udevice *dev, struct bootflow *bflow)\n> - if (ret)\n> - return log_msg_ret('init', ret);\n> + if (ret != EFI_SUCCESS)\n> + return ret;\n\nThis function returns int but you are returning an efi_status_t directly.\n\nPlease can you keep using log_msg_ret() here, maybe with -EIO, or\nconvert to an appropriate negative errno value?\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=QktUoV00;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"QktUoV00\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0hBL3fBmz1y2d\n\tfor ; Wed, 22 Apr 2026 11:16:10 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 6A852840D8;\n\tWed, 22 Apr 2026 03:16:08 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 2D2A28412A; Wed, 22 Apr 2026 03:16:07 +0200 (CEST)","from mail-pl1-x633.google.com (mail-pl1-x633.google.com\n [IPv6:2607:f8b0:4864:20::633])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id F0554805D7\n for ; Wed, 22 Apr 2026 03:16:03 +0200 (CEST)","by mail-pl1-x633.google.com with SMTP id\n d9443c01a7336-2aaf43014d0so29941415ad.2\n for ; Tue, 21 Apr 2026 18:16:03 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776820562; cv=none;\n d=google.com; s=arc-20240605;\n b=c8HFjarGOAZIsDwT8Yvwq9b5HUmd+X4/kj+SGIdPsilOwtYae2RdBpji5lA2g9567x\n tEDsIcHFUM28PVklmZ36vR7UfMXOvm98xeBf/DC0EDnJUHCvyT/mAX7RRZUSIUewsFz3\n 4XI7VWYt1+cgSelFGXApqNcOoMJy3wE8G5fkJjUMOd0RoDPGQJX/HT2MxwKZk++PMiXD\n LXB+VJ7jXbLJ8is+u33NkrcApTLJOYbR6SWCjN42FUy/AT0iKqsVHHnnUtTCu5+h2DPK\n 0e9VXQvWZAZa9QkE47EQwKw64IYrIcKlNlEijTnxKsXSFvvQwz5/SttUvr2om+AJLO4t\n CU/w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=f380575tfjgH/MpP8yId6uNPN9ubVecTNmizm5ioL30=;\n fh=B286HwM6/Dv+o0K0VY9DuUJQtpHJO1IEYbBzrGusgA8=;\n b=jxUk6MRFC/830FKrQ1D8MZZOUFViN+l1VsrM3pM1VRftYlw1rBaIrrlLZNsbvfx6XR\n D1xtIlB7xbeOhwtVDKefbuRZK8vQLvIJWAtYs3VZrPDbv+NrXG8BY8S9Ruw7Q3zA3x0k\n Q7sVERBhrCzHPe+kBqvmxDxBtL9oyG7ayfdZW0mcNbSjdiDrxR6rE1uqQnTgdbJ5j8en\n VKy73QOeupDy6vxJY0OhDjmmTznJ6AVQRti7h4hVb91Ailgg+cm0lBCbmGqBrlLftCG4\n WDNJ5gpUJNz7iTLXSPBxi6+EN4Ew+XHhDNy2A7wmHGiyZt/eWxH9zUUlhuawY/8FgO/9\n 3Neg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776820562; x=1777425362; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=f380575tfjgH/MpP8yId6uNPN9ubVecTNmizm5ioL30=;\n b=QktUoV00w3W+zKehl+ouz51jUrvc6fC8qsmgyTVL3rKbiI7/inWAcp/Oeb4nSPL/Uk\n 7f+LIisAsbpeM72pN5mT6F1HWSUzF/1AiNoVHcnXgnl5Yn1DU4XKfhlst9ifS7cW5uSQ\n jsh2jQfi0RlwfgXd7kwarE+II9hf5DmLuKj+w=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776820562; x=1777425362;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=f380575tfjgH/MpP8yId6uNPN9ubVecTNmizm5ioL30=;\n b=gVCGPubYR1F++c0TXAFpaPwaCJCGaJgNux/LEVs4u39Pm9kHTMaot0LYBHCMNNb3V7\n dzdqGlND/BVMGyEQaB69NWL8Mn1XEOFoynD/0b+OO9Tin5CO6O0Bs025kxdoFOtPTKt9\n l7WeG1NFRWuvq2vKDghcHuNRDbTkxFCSljnAZdVlcimEf8beOnT6gwmWYtHa6U5GGV8G\n wW9z7w5m5qZgtP/TJXDHKeEl8azXInRw0py6CVv2kez4be580OVBhTOLSjqjXqEJkouO\n /dPRfcv6zFIaVpjS5I01gKkXtLFrWdu0HeGtkCeBV3HpNrHrkIcFFwpDjlrJ6YDBGrrg\n fvRQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/BDe/vLQNaLRs58JwTa4AQ1TKz3NI8jjtG3pebQa96eJMgvj9yC4eXFLRXAS4BXzgDbzZTp18=@lists.denx.de","X-Gm-Message-State":"AOJu0Yy0Nj8n9LmkxX6FCOagM2BNyhWp1+m0ISFHlcRZYz2V6NEQiW0p\n nBBijrojehB2naoRN8woFv4sxzyLNoE6bimCIDPG0hQ/HcJAFG8Su5inZUyKsI8GRlbe90RSaEm\n GfV2QR7viMimvlfkce9X2VuUp/fvu3hIa1b1qm6xPzWleymVYVqmEcw==","X-Gm-Gg":"AeBDievE+zDPWCevpslWOy6h+TSh2G18Gx0CF1qoh8cz7xElyVGPNIfAbLjgTBPFent\n xv/c5I3sWZ1/7T41IijI0OEH5mu4AmF69bJZAlyiWgtvNVq+rzRwiWv97lOPgXj2patzxVjOsId\n dJPlW6YbQ/PBb1WDFVxgQcHSW41KnQVEvdZT4+dJRYbA8jS9Lg4MhD0pVcUQnSYnvGpilt+AXvN\n UjhaTBLUnApfahyP1LDazfB5/tZYTjtd5M3OZLfpKyy3NsOqYD2obXer2swn3TT1JmIh/rUFJYc\n K08WdChlrakJRLXo4FiX","X-Received":"by 2002:a17:903:1ac6:b0:2b2:5840:809c with SMTP id\n d9443c01a7336-2b5f9e77d75mr205753515ad.1.1776820561580; Tue, 21 Apr 2026\n 18:16:01 -0700 (PDT)","MIME-Version":"1.0","References":"<20260420220321.71147-1-heinrich.schuchardt@canonical.com>\n <20260420220321.71147-5-heinrich.schuchardt@canonical.com>","In-Reply-To":"<20260420220321.71147-5-heinrich.schuchardt@canonical.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 13:15:34 +1200","X-Gm-Features":"AQROBzBBxwk_NE5xUTovt753nHDQF1G0fxskF2i4Jk1nUjD3CnHk5XIUDCHo7PQ","Message-ID":"\n ","Subject":"Re: [PATCH v2 4/4] efi_loader: centralize messaging for\n efi_init_obj_list","To":"heinrich.schuchardt@canonical.com","Cc":"Ilias Apalodimas ,\n Simon Glass , Tom Rini ,\n Mark Kettenis ,\n Patrice Chotard , Peng Fan ,\n Christian Marangi ,\n Sughosh Ganu ,\n Casey Connolly ,\n =?utf-8?q?Vincent_Stehl=C3=A9?= ,\n Adriano Cordova ,\n Wolfgang Wallner ,\n Martyn Welch , Javier Tia ,\n Ying-Chun Liu ,\n AKASHI Takahiro , u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]