[{"id":3679702,"web_url":"http://patchwork.ozlabs.org/comment/3679702/","msgid":"<20260421-sincere-cherry-waxbill-1aada6@quoll>","list_archive_url":null,"date":"2026-04-21T07:13:31","subject":"Re: [PATCH v5 1/9] dt-bindings: mfd: mt6397: Add MT6392 PMIC","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On Mon, Apr 20, 2026 at 10:30:00PM +0100, Luca Leonardo Scorcia wrote:\n> From: Fabien Parent <parent.f@gmail.com>\n> \n> Add the currently supported bindings for the MT6392 PMIC. Its MFD driver\n> does not use the compatible property to bind the regulator driver, so\n> don't mark it as required.\n> \n> Signed-off-by: Fabien Parent <parent.f@gmail.com>\n> Signed-off-by: Val Packett <val@packett.cool>\n> Signed-off-by: Luca Leonardo Scorcia <l.scorcia@gmail.com>\n> ---\n>  .../bindings/mfd/mediatek,mt6397.yaml         | 27 ++++++++++++++++---\n>  1 file changed, 24 insertions(+), 3 deletions(-)\n> \n> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml\n> index 05c121b0cb3d..2866e95e338b 100644\n> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml\n> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml\n> @@ -40,6 +40,10 @@ properties:\n>            - mediatek,mt6358\n>            - mediatek,mt6359\n>            - mediatek,mt6397\n> +      - items:\n> +          - enum:\n> +              - mediatek,mt6392\n> +          - const: mediatek,mt6323\n>        - items:\n>            - enum:\n>                - mediatek,mt6366\n> @@ -68,6 +72,10 @@ properties:\n>                - mediatek,mt6331-rtc\n>                - mediatek,mt6358-rtc\n>                - mediatek,mt6397-rtc\n> +          - items:\n> +              - enum:\n> +                  - mediatek,mt6392-rtc\n> +              - const: mediatek,mt6323-rtc\n>            - items:\n>                - enum:\n>                    - mediatek,mt6366-rtc\n> @@ -99,9 +107,6 @@ properties:\n>                    - mediatek,mt6366-regulator\n>                - const: mediatek,mt6358-regulator\n>  \n> -    required:\n> -      - compatible\n\nPlease create a new binding file for your device. Having two ways to\ndefine child is not making this binding easier to follow.\n\nThe style of defining children with compatibles should be followed by\n\"requierd: compatible\". I am rather against of exceptions, unless needed\nand this is not such case where you need one.\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n <linux-gpio+bounces-35288-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Rk54KrE1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35288-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"Rk54KrE1\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0D9p0NQRz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 17:14:06 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id BA378300FC63\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 07:13:35 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id AF29737F8A1;\n\tTue, 21 Apr 2026 07:13:34 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 70E7240DFC6;\n\tTue, 21 Apr 2026 07:13:34 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id A1872C2BCB0;\n\tTue, 21 Apr 2026 07:13:33 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776755614; cv=none;\n b=txL2q9/1ND/7V1iJAEeGrC3vMdTGTimT62c5l6VSz5DxTikrkI8MYkP37ofM75BZGhbEUdu3N+SuuThIPYvWrvBcvwkpmifqf+VtqcE1uB6QXR5iUyJoBRIsUXfDoN8sRUE4OQYoJn3ENOD2gB6LMWu+AksKWa+TFvptluVcMto=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776755614; c=relaxed/simple;\n\tbh=FBWfjsIqM+7TuqnxYjhjiUQj1QqggKY45UCCbcTaQWs=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=PvEuOZm4yHnwjPE07ThZd3lTP6lZ6pk5INrPKXEBHsTmwx2nwrRGekW6BMbVYGVRM6u4uF3wdYB2vhz0sfq+74Tg2CY/By22KNM7zVV3+rfoZmbgcb8p1yJwBQ4KgZZWId5iTi4puzexBDvS69RJ8SWBZUQAJp5tPacNnbmsqsg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=Rk54KrE1; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776755614;\n\tbh=FBWfjsIqM+7TuqnxYjhjiUQj1QqggKY45UCCbcTaQWs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Rk54KrE161LTqGHyDseDnQJW9W+VdRSX+EJ2x09B826Rm888eSnDOS65Ig+dvbr2U\n\t M48YutSEbjzxtKF8DliJ9DYkjPxNv7U2xOZAyvzdfKzxLKMYamaehk6QIOd5gfumYp\n\t IJpMwY2dnTATYIoGB3I/ncrVLTwVKcvY0ycF/HNKq5vBZ73vOXKmS+w3N2Cs7vgrue\n\t im3cJtO4Jq8B7eAPaNx8d/rLJAN10ajV0wZYd6zy580tUCsJSRlO1lLsw0HL1dbcTg\n\t iNIctkMIRQPn1nx34cpV6hRMZDGgm5YQU8JPq8rbt5P8D1qpCkEPSo9q/aFxJLhN1a\n\t +8t7yT/JtC7jg==","Date":"Tue, 21 Apr 2026 09:13:31 +0200","From":"Krzysztof Kozlowski <krzk@kernel.org>","To":"Luca Leonardo Scorcia <l.scorcia@gmail.com>","Cc":"linux-mediatek@lists.infradead.org, Fabien Parent <parent.f@gmail.com>,\n\tVal Packett <val@packett.cool>, Dmitry Torokhov <dmitry.torokhov@gmail.com>,\n\tRob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,\n\tConor Dooley <conor+dt@kernel.org>, Sen Chu <sen.chu@mediatek.com>,\n\tSean Wang <sean.wang@mediatek.com>, Macpaul Lin <macpaul.lin@mediatek.com>,\n\tLee Jones <lee@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>,\n\tAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,\n Linus Walleij <linusw@kernel.org>,\n\tLiam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,\n\tGary Bisson <bisson.gary@gmail.com>,\n Julien Massot <julien.massot@collabora.com>,\n\tLouis-Alexis Eyraud <louisalexis.eyraud@collabora.com>,\n Akari Tsuyukusa <akkun11.open@gmail.com>,\n\tChen Zhong <chen.zhong@mediatek.com>, linux-input@vger.kernel.org,\n devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org,\n\tlinux-gpio@vger.kernel.org","Subject":"Re: [PATCH v5 1/9] dt-bindings: mfd: mt6397: Add MT6392 PMIC","Message-ID":"<20260421-sincere-cherry-waxbill-1aada6@quoll>","References":"<20260420213529.1645560-1-l.scorcia@gmail.com>\n <20260420213529.1645560-2-l.scorcia@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260420213529.1645560-2-l.scorcia@gmail.com>"}}]