[{"id":3680166,"web_url":"http://patchwork.ozlabs.org/comment/3680166/","msgid":"","list_archive_url":null,"date":"2026-04-22T01:15:29","subject":"Re: [PATCH] xen: Handle malloc failure in errmsg function","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Francois,\n\nOn 2026-04-20T19:15:24, Francois Berder wrote:\n> xen: Handle malloc failure in errmsg function\n>\n> Signed-off-by: Francois Berder \n>\n> drivers/xen/xenbus.c | 10 ++++++++--\n> 1 file changed, 8 insertions(+), 2 deletions(-)\n\n> diff --git a/drivers/xen/xenbus.c b/drivers/xen/xenbus.c\n> @@ -280,12 +280,18 @@ static char *errmsg(struct xsd_sockmsg *rep)\n> + if (!res)\n> + return NULL;\n\nCallers like xenbus_ls() check 'if (msg)' to detect an error, so NULL\nindicates success. With this change, malloc failure returns NULL,\nwhich callers will interpret as success and continue processing.\n\nMaybe return a static string like \"Out of memory\" when malloc() fails?\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=Lo6/arec;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"Lo6/arec\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0hB65xytz1y2d\n\tfor ; Wed, 22 Apr 2026 11:15:58 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1212A83BC8;\n\tWed, 22 Apr 2026 03:15:49 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id B72FE805D7; Wed, 22 Apr 2026 03:15:47 +0200 (CEST)","from mail-ej1-x635.google.com (mail-ej1-x635.google.com\n [IPv6:2a00:1450:4864:20::635])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2AE3983BC8\n for ; Wed, 22 Apr 2026 03:15:45 +0200 (CEST)","by mail-ej1-x635.google.com with SMTP id\n a640c23a62f3a-b8d7f22d405so834574266b.0\n for ; Tue, 21 Apr 2026 18:15:45 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776820544; cv=none;\n d=google.com; s=arc-20240605;\n b=j4Y9BuGw+GHPfxXmngzJaZ9vvm3Iwg4uV/iWnHIEJSIaLfaTk5qxNsujV5H5LyCrF0\n vXSAimkw9LRKJ6QpUu56LXpgT72dBQc1WiDbp2IR9D34vJ04tXMBIx6fpVdrfIrrlaDl\n LPcUL9Q3mLw/NioFm3Y1889JkUQ/X08zqovjY1iBRVemhk679U5N52tF7HDHCUuvPbwe\n eNYTVPQS3o0UL/Gn32gdkP4SXL1KvxDgHmip+7IPcJcPNvhFgTr9Ug4cgETVrrUvTaEg\n 46omya5wez6pJxfSZIyUq7pj4X1a9fmiMLFNPDFXMsTbsToJpBvXBC6VzkBvummCa+c9\n m3ZA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=2TTUYi/LNvZuK2ybNRb6oFqNP1IJC7/qcSXvtj3TSl8=;\n fh=/JwL+QfgvEmDut/hkVyWKzX1JzK7x9jVmeWqOhVMhyA=;\n b=VQf67+SKHS5ySuezNLqAl2rUPcq7OBan1lCBtSIt08Kib7y+uMDxeLwAu5qhfNLi9F\n xjFRpAxzWWlyfdZTsIcH8OXIVsnOI0+zdwGXPkkIw85VRQDP4R9ig8sOjAUcLDohqGba\n iMAfmQwCCGJtMaAkLHs+CmOD2ER8qu8u9Vu2Gc6LNqYmnHKhdNao/ZR3Ih0Zlj7YuRwG\n jiHMTWkisXm2azLhCOh89N/VBFnHoaz0KkqJQr/KXDpEZqm6qmggUYkiaw0zsm2vUQS1\n 3bRhduyzN35P1aIDGlHtrdzHPOr1SuyFKLNrnosES29WLcKD6UINr6eyCFgkXLd2a0f3\n Lhmg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776820544; x=1777425344; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=2TTUYi/LNvZuK2ybNRb6oFqNP1IJC7/qcSXvtj3TSl8=;\n b=Lo6/arecvXq063ZKGCMFKxlvcX+UwLttOOerxRufv7n8EC3OH2fztRVFTjGsK+a1pn\n 31y2bb4QK+SF/TGAN4Uy3l1P5tUgL2dAWBLjKoOUEU4IRS2f23OfVHRgamjOVrVZWLm3\n 2zujvb0OD7gKoo0El11ja96R6hORvDA0ZS1CY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776820544; x=1777425344;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2TTUYi/LNvZuK2ybNRb6oFqNP1IJC7/qcSXvtj3TSl8=;\n b=k831uhbt8v7CF30R1ewXJ+039l29JyKNOzagOj0ZC3QB+xWclGlZkzMpLyy4gHX3C/\n IrWJ4AUMPWAUkTEotb0s5fUEr1F8dKRkObQ5Q0w0Ue17XQvK7YgmvwL+9knrAR1fKzN2\n HLoZdTK/HODLGQ8QqyZ9vanljakYT3F7DxJQp26hmq2XurPQSYKEpZC+bc7cGHkhfrrh\n TICjD1u9dyAzAdJWqiDC4vZncByB5Iz18i1IMxIjfWYyA8DVOfSYTfAQtOvHV6TA7flM\n q1HwSxxzSu+maahdcNXCP6WZPKJUTX3XdIhEUabAjYTiqJyhAvVY4k9V6xRPXresl94e\n gCNQ==","X-Gm-Message-State":"AOJu0YyTVInDiwatpexPRcHePJfT3PZp3rBLct+ftpLhaqirdYT2vdz8\n w47gXV5Agf4pbtXaEmi5mCJOnQhGYV7jW/O6g2r/Td7rk3QqdQCGM6FaPvn/O73FXLD8gMpsdFG\n u5TsnxBbYBcDA0CXGfnDSYaCj3+o1kcyVTaJCfHJl","X-Gm-Gg":"AeBDies86BlanZvMW7+pVznINTY9P0kPbQd2mWg70AZoShUF9d0yfEtGvFaluQZxL92\n of1kFZQ7Z9p/CPhz3tTmktSS6bKNUNTLBtkT4oFfPNLKxr/gkgfBp0b257fCqfutEiVr85kbqPx\n S2OVVYg2mPvarQQewW9ixttfIdNAvswxS//yq4fCQUR7TxYacWg/ipH9RzcWWMTtMnedZJ5PlM1\n BNixHDmj5gmKAwGchAbIg4XbZkFuTTTtX6yVM5yitmLxyI/YrgCBHo5KoYyM7i7gyRuxaRJCTmq\n 3D03fZsENSz5Uh5T0+bz","X-Received":"by 2002:a17:907:c30a:b0:b96:f863:deba with SMTP id\n a640c23a62f3a-ba41aa13734mr967061366b.32.1776820544340; Tue, 21 Apr 2026\n 18:15:44 -0700 (PDT)","MIME-Version":"1.0","References":"\n ","In-Reply-To":"\n ","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 13:15:29 +1200","X-Gm-Features":"AQROBzChjO6M5Clh94TeOiBLs7Y0HWSoQavX2UrEDdwp9936zQH_GzvjbozoEmk","Message-ID":"\n ","Subject":"Re: [PATCH] xen: Handle malloc failure in errmsg function","To":"fberder@outlook.fr","Cc":"u-boot@lists.denx.de, Anastasiia Lukianenko ,\n Oleksandr Andrushchenko ,\n Tom Rini ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]