[{"id":3679599,"web_url":"http://patchwork.ozlabs.org/comment/3679599/","msgid":"<0587ebb7-06fc-5b96-bbfd-37d86475d718@eik.bme.hu>","list_archive_url":null,"date":"2026-04-20T21:05:19","subject":"Re: [PATCH] hw/ppc: remove duplicate include","submitter":{"id":16148,"url":"http://patchwork.ozlabs.org/api/people/16148/","name":"BALATON Zoltan","email":"balaton@eik.bme.hu"},"content":"On Mon, 20 Apr 2026, Osama Abdelkader wrote:\n> hw/ppc/ppc.h is included twice\n>\n> Signed-off-by: Osama Abdelkader \n\nIndeed, once is enough. Also cc'ing qemu-trivial list.\n\nReviewed-by: BALATON Zoltan \n\n> ---\n> hw/ppc/amigaone.c | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/hw/ppc/amigaone.c b/hw/ppc/amigaone.c\n> index 8074713fbe..9fba5ca03a 100644\n> --- a/hw/ppc/amigaone.c\n> +++ b/hw/ppc/amigaone.c\n> @@ -20,7 +20,6 @@\n> #include \"hw/isa/vt82c686.h\"\n> #include \"hw/ide/pci.h\"\n> #include \"hw/i2c/smbus_eeprom.h\"\n> -#include \"hw/ppc/ppc.h\"\n> #include \"exec/cpu-common.h\"\n> #include \"system/block-backend.h\"\n> #include \"system/qtest.h\"\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzyh22gnYz1yCv\n\tfor ; Tue, 21 Apr 2026 07:05:52 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEvoF-0000Xj-Pj; Mon, 20 Apr 2026 17:05:35 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEvoA-0000QH-2a; Mon, 20 Apr 2026 17:05:30 -0400","from zero.eik.bme.hu ([2001:738:2001:2001::2001])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEvo7-0003PW-3A; Mon, 20 Apr 2026 17:05:29 -0400","from localhost (localhost [127.0.0.1])\n by zero.eik.bme.hu (Postfix) with ESMTP id C9BC6596961;\n Mon, 20 Apr 2026 23:05:21 +0200 (CEST)","from zero.eik.bme.hu ([127.0.0.1])\n by localhost (zero.eik.bme.hu [127.0.0.1]) (amavis, port 10028) with ESMTP\n id 2xn6xil5UJJB; Mon, 20 Apr 2026 23:05:19 +0200 (CEST)","by zero.eik.bme.hu (Postfix, from userid 432)\n id CA6C359695B; Mon, 20 Apr 2026 23:05:19 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n by zero.eik.bme.hu (Postfix) with ESMTP id C8D8659695F;\n Mon, 20 Apr 2026 23:05:19 +0200 (CEST)"],"X-Virus-Scanned":"amavis at eik.bme.hu","Date":"Mon, 20 Apr 2026 23:05:19 +0200 (CEST)","From":"BALATON Zoltan ","To":"Osama Abdelkader ","cc":"\"open list:amigaone\" ,\n \"open list:All patches CC here\" ,\n qemu-trivial@nongnu.org","Subject":"Re: [PATCH] hw/ppc: remove duplicate include","In-Reply-To":"<20260420164058.335872-1-osama.abdelkader@gmail.com>","Message-ID":"<0587ebb7-06fc-5b96-bbfd-37d86475d718@eik.bme.hu>","References":"<20260420164058.335872-1-osama.abdelkader@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII; format=flowed","Received-SPF":"pass client-ip=2001:738:2001:2001::2001;\n envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3679870,"web_url":"http://patchwork.ozlabs.org/comment/3679870/","msgid":"<85722c50-873f-4452-ab48-d426a5d81089@linaro.org>","list_archive_url":null,"date":"2026-04-21T12:55:36","subject":"Re: [PATCH] hw/ppc: remove duplicate include","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 20/4/26 18:40, Osama Abdelkader wrote:\n> hw/ppc/ppc.h is included twice\n> \n> Signed-off-by: Osama Abdelkader \n> ---\n> hw/ppc/amigaone.c | 1 -\n> 1 file changed, 1 deletion(-)\n\nPatch queued, thanks.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=iPwmiPgq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0Mmg5CFFz1yCv\n\tfor ; Tue, 21 Apr 2026 22:56:18 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFAdm-0004Sm-Ba; Tue, 21 Apr 2026 08:55:47 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFAdi-0004QL-KI\n for qemu-ppc@nongnu.org; Tue, 21 Apr 2026 08:55:43 -0400","from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFAdh-0007ZN-1z\n for qemu-ppc@nongnu.org; Tue, 21 Apr 2026 08:55:42 -0400","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-4896c22fcbaso16840395e9.0\n for ; Tue, 21 Apr 2026 05:55:40 -0700 (PDT)","from [10.193.39.66] (140.170.88.92.rev.sfr.net. [92.88.170.140])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb7bf7besm128756345e9.34.2026.04.21.05.55.37\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 21 Apr 2026 05:55:38 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776776139; x=1777380939; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=LdOYyljqs+0qqKByZ2HK5DZmkxXYxzWDn5moLcQb/5s=;\n b=iPwmiPgqg9fmiTmUNFyqXbZehFHuL6nnWobP+dySKnPSKjm+SHxiABX7dmLuUBqAJh\n 4c9rX7rv3s0JdrW/CXp4BiWo+n2P6jVzUwNtqRuWv6H3DDOIgyh59M6wei5WN3VLkbkx\n o/fAwyIvuRzdVo3QAjKukFsfXR3uudwUT/noCEzENNYoJjcVit6Ms6nDqdtRawy9NpbZ\n 4PsWHajseRMfRIke2JnVSYegG4Q/ApF3wCQ0F68HqqjxEHlzrx8PPs6kgI6Ytg1yq/cp\n Kea8UWy69O63FJuQUrKcer07uQcogxHMvp33dDBhdcWVnYlaLh4uwZhhUHtfPJ70Dm1E\n 5h4Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776776139; x=1777380939;\n h=content-transfer-encoding:in-reply-to:from:references:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=LdOYyljqs+0qqKByZ2HK5DZmkxXYxzWDn5moLcQb/5s=;\n b=kF91QduT1PyenHPnEiFrz4ZHPAR3eygwnhBb3ES3RyxHWQX8uUxFgYCR3/qZl62OI9\n /a7jmatyof4MyOu4kXpBi3IOJfmhrymUbAYdmaBGU0b8zsiUhDQGV1xMbNPaSg3kWPFD\n SHsSh30z7GdIoEKWtMHV7kJHC3Yt0hyizCQ6GiW+l0vdETdKTHtVhxdqjLFyz20qnlpT\n 4VrkOgIPNV3l01QmKbIjfVnLuc/UEe6MN4lmvVwXXehoYEC9Y0hKoK8eORIKAAhmumhf\n eaDjt6mRAhSMAYhbX1dT94fj6pi4N7a013z3j/GxYxtvDjPOBHVklW/LNvlVoowo9ImP\n Tdkg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ96iKdFmhAa2koOPak3eGb1eXoWZbqOzUy2BKThoPtID282Mo2Kq4RtD32W+ZCbomnsQahBUOo3rA==@nongnu.org","X-Gm-Message-State":"AOJu0Ywg1oqBPHlzuUZiwi2HadxiGsZpMiU/d74XcSxxLMs3N5Lf5VLK\n A8Dsvd+m/FH75jxamRCPu8w6Ob0jsRjeWZ7yBK+DCK0z0vPobniImlJRIEdSLL5rHhw=","X-Gm-Gg":"AeBDieveczE6wmbAws5TpMfVlubWljn6cfr984iGxEZZ/wyfi3LSSrS6vRaJe2z1sUF\n Jn2dfUaCKcjoRwP85jkzgNtHqP/GYnwjTCdjy79M6o/f/06dO5UBqIcOoH7njM6H8WAN+b6c5ku\n WISOCnNOcBskElep6yHq/ZZ55tvpvI6QLQwwhOfG/4Ko19FKmgJM6jQ3F6XvcGsWYzFFOOT2QAt\n BUOriEEZzVKN2cCvpBC4J8d0a/4guILUUmU6Go4dPm+fyF0HgzPM7Uf5FOtigKq/cpZT7ZHVUVr\n O8PkqLD3oGUIP+5xQWZlsgYOQYRbTcEiGbUC+15x0homKarNVmeHut5nqKgeYHi+F/3+TphKcEL\n YQAg5yhagubuN66Mi0337GhFaGPN98AWJbZtRFaFSDIypzf4P5SQCG6HagK79Tnhd0RsF8P92XT\n QK8wemgQSquoNQvn3uYRE/cRxvuk/43E9h7Kq/EygQDAnevgXmN83fEfoBf4hLIavwh1cb8XwDR\n A==","X-Received":"by 2002:a05:600c:b90:b0:488:b99b:4177 with SMTP id\n 5b1f17b1804b1-488fb78ee4emr246458685e9.25.1776776139137;\n Tue, 21 Apr 2026 05:55:39 -0700 (PDT)","Message-ID":"<85722c50-873f-4452-ab48-d426a5d81089@linaro.org>","Date":"Tue, 21 Apr 2026 14:55:36 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] hw/ppc: remove duplicate include","Content-Language":"en-US","To":"Osama Abdelkader ,\n BALATON Zoltan , \"open list:amigaone\"\n , \"open list:All patches CC here\"\n ","References":"<20260420164058.335872-1-osama.abdelkader@gmail.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260420164058.335872-1-osama.abdelkader@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::336;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]