[{"id":3681509,"web_url":"http://patchwork.ozlabs.org/comment/3681509/","msgid":"<0ad8edf5-c916-43b9-b442-4f18d95d6228@redhat.com>","list_archive_url":null,"date":"2026-04-23T14:54:27","subject":"Re: [ovs-dev] [PATCH ovn] tests: Fix localport suppress gARP scapy\n input.","submitter":{"id":76591,"url":"http://patchwork.ozlabs.org/api/people/76591/","name":"Dumitru Ceara","email":"dceara@redhat.com"},"content":"On 4/20/26 10:14 PM, Ihar Hrachyshka via dev wrote:\n> send_garp() was refactored to build packets with scapy, so callers must\n> pass dotted IPv4 strings for the sender and target protocol addresses.\n> The localport suppress gARP test still passed ip_to_hex() output, which\n> was correct for the old handcrafted packet path but invalid for the new\n> helper.\n> \n> Commit 85f274f4a870 (\"tests: Fix incorrect invocations of send_garp.\")\n> updated this test's interface argument, but left the stale hex IP inputs\n> behind. Replace them with dotted IPv4 strings so the helper receives\n> valid ARP addresses.\n> \n> Fixes: 0814c5b164a9 (\"tests: Implement send_garp using scapy.\")\n> Fixes: 85f274f4a870 (\"tests: Fix incorrect invocations of send_garp.\")\n> \n> Signed-off-by: Ihar Hrachyshka \n> ---\n\nHi Ihar,\n\nThanks for the fix! Applied to main and all stable branches down to 24.03.\n\nRegards,\nDumitru","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=VxIasVy3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp3.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=VxIasVy3","smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp2.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=VxIasVy3"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1fJV24BCz1y2d\n\tfor ; Fri, 24 Apr 2026 00:54:50 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id CCF2360ECE;\n\tThu, 23 Apr 2026 14:54:48 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 95QMTQv8V8ju; Thu, 23 Apr 2026 14:54:46 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 45B5F60EC7;\n\tThu, 23 Apr 2026 14:54:46 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 2139FC058E;\n\tThu, 23 Apr 2026 14:54:46 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 89FC7C058D\n for ; Thu, 23 Apr 2026 14:54:45 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 7C0D340784\n for ; Thu, 23 Apr 2026 14:54:45 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id IhjkYzQCy1WW for ;\n Thu, 23 Apr 2026 14:54:41 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 0EAEA4078C\n for ; Thu, 23 Apr 2026 14:54:40 +0000 (UTC)","from mail-pj1-f69.google.com (mail-pj1-f69.google.com\n [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-156-GS3uhl4OPWuxnrNllofsVQ-1; Thu, 23 Apr 2026 10:54:37 -0400","by mail-pj1-f69.google.com with SMTP id\n 98e67ed59e1d1-35e59791605so7102633a91.1\n for ; Thu, 23 Apr 2026 07:54:36 -0700 (PDT)","from ?IPV6:2001:1c05:1417:d800:d1ef:9817:2a26:625d?\n (2001-1c05-1417-d800-d1ef-9817-2a26-625d.cable.dynamic.v6.ziggo.nl.\n [2001:1c05:1417:d800:d1ef:9817:2a26:625d])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-3613fb9b121sm10847568a91.5.2026.04.23.07.54.31\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 23 Apr 2026 07:54:33 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 45B5F60EC7","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 0EAEA4078C"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=dceara@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 0EAEA4078C","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776956079;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9NQ0oQBjdpG66f8DWzgLUWHQ9pHSrxBDcGXiQX3ZxmE=;\n b=VxIasVy3z5BFwt0sxzlhcHW2CSSla8bqEU2N3gbkwDtCgchBmO48TWxZS2jEL4vJ1E14KH\n nNbeNa6UafVD8zeSel9x+kuNF98irsaUcrL6uwjHx7fHoBi0R2m+daXIJ/Uy5aGGM9PvRq\n QsKv2Xu/5YoB9+bG+klc5PxEO7P44rg=","X-MC-Unique":"GS3uhl4OPWuxnrNllofsVQ-1","X-Mimecast-MFC-AGG-ID":"GS3uhl4OPWuxnrNllofsVQ_1776956076","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776956075; x=1777560875;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=9NQ0oQBjdpG66f8DWzgLUWHQ9pHSrxBDcGXiQX3ZxmE=;\n b=gleCL5G069kuFnqLNNM7Es/YkOq4KVN+66JepgBqOeXhvviNeVYM1MS4aJZKlDPP1g\n 5ycj5blh950XUBrZ8/gV75ldEZWa9XONkcTzvGqJY57ocEDnfViCjoMqst18fmIUTrmn\n RFkC5gvVjm9Zeh42DJdJQRwfieWbcPxXV4lRpk7euEWpjU8Oy0NfkOgUpVVRXIGJa6tA\n MFi+LILvU1w5E2Dis9MJ0lHHWfwb6Fp1sAaj+ikpdEIX+Q4En1em0Mv2lYNVl28Uu7ww\n eBd2CtC9H8QL29AzxGFUE2M2agKNFYDMQ3TnbGTyMsP3fOGfJ+5n6WYR32zM5u1WTDrK\n KI5A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8PCCc7T+6tzRRzuVgavHViHazkocSgXE+5uyUiFH/hNJ2SixVP9i5wZL5F5Jzd/Cua35I=@openvswitch.org","X-Gm-Message-State":"AOJu0YyQgGGTOEnSnzj1xjjIEUdiIYtG1TS5pg3B7CUc1fbPX23AvHRk\n pysFVqP2wj9/Ns7eu324jj7ZT5+a5CX3uUO/pICRJaIxaPkLRX/Jj1PCUFdknrIgsEaHe/Ow56l\n tVYYbcjnkg0v5k857YNPdiYRIiSuxx5MXEdc20eRi1ATfaL2xFUhIgXTqaBVzmQ==","X-Gm-Gg":"AeBDiesLjQtVUV7fMM4WgZESuI4L1IXD5WQ9ERg4rH4O4RwgDVr+jVFAj8fZSVSTjgP\n mW+lY4M9GBvHzm0Px8yXpXFSEbUu+lJqg0jfjFKHzuVch1+bdE3AU2dqWkTiZne98BCn/hhZ9/U\n 59nIvXkQvEUb/tBLXo9py3abiCuQFoJsoUecdxkIrnDdMFcduULi6eKAbNwLkYpILrTdaYBCd8n\n hGXVzXIjoS3pgFme4f2IoFEDeBK1B6Itfvrw7ClwOJI1HdklFKpssedmrgPquyRiZFQBaK97Dca\n JUtsdgjuZre7zBFXy3CZ24c8MQK9VlFecNYfVV8egUm8plDG/LKd2Y7xM+vkWvuFe5YAUsApfV3\n GfNHsgWSkePJHsWLSRfbflu4/r4t++XgT1vpps56/zuKHGP+/N+DaIrR1ZmRy8cUcbZJw7d19Cr\n a9CKipq/IpYWya930MvbU+ugs08FkcWdL9Uz4Te7C+As9zlFtmfJmNgou56oVfc0z8aWFvzGqZh\n kdh54i787c=","X-Received":["by 2002:a17:90b:3d01:b0:35a:cf:64a6 with SMTP id\n 98e67ed59e1d1-361404af0a4mr30062745a91.23.1776956074633;\n Thu, 23 Apr 2026 07:54:34 -0700 (PDT)","by 2002:a17:90b:3d01:b0:35a:cf:64a6 with SMTP id\n 98e67ed59e1d1-361404af0a4mr30062718a91.23.1776956074120;\n Thu, 23 Apr 2026 07:54:34 -0700 (PDT)"],"Message-ID":"<0ad8edf5-c916-43b9-b442-4f18d95d6228@redhat.com>","Date":"Thu, 23 Apr 2026 16:54:27 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Ihar Hrachyshka , dev@openvswitch.org","References":"<20260420201452.55538-1-ihrachyshka@nvidia.com>","In-Reply-To":"<20260420201452.55538-1-ihrachyshka@nvidia.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"_PkAW67tIt2pXWvOdZ1-f8gFWLxnJGI5odfJr9WVqqo_1776956076","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","Subject":"Re: [ovs-dev] [PATCH ovn] tests: Fix localport suppress gARP scapy\n input.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Dumitru Ceara via dev ","Reply-To":"Dumitru Ceara ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}}]