[{"id":3680055,"web_url":"http://patchwork.ozlabs.org/comment/3680055/","msgid":"","list_archive_url":null,"date":"2026-04-21T20:42:33","subject":"Re: [PATCHv4 6/6] memory: reserve from start_addr_sp to\n initial_relocaddr","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Randolph,\n\nOn 2026-04-20T19:25:18, Randolph Sapp wrote:\n> memory: reserve from start_addr_sp to initial_relocaddr\n>\n> Add a new global data struct member called initial_relocaddr. This\n> stores the original value of relocaddr, directly from setup_dest_addr.\n> This is specifically to avoid any adjustments made by other init\n> functions.\n>\n> Reserve the memory from gd->start_addr_sp - CONFIG_STACK_SIZE to\n> gd->initial_relocaddr instead of gd->ram_top. This allows platform\n> specific relocation addresses to work without unnecessarily painting\n> over a large range.\n>\n> Since PRAM comes out of this initial area up to initial_relocaddr, we no\n> longer need to account for it separately.\n>\n> Signed-off-by: Randolph Sapp \n>\n> common/board_f.c | 9 ++++++++-\n> include/asm-generic/global_data.h | 7 +++++++\n> lib/efi_loader/efi_memory.c | 9 ++++++---\n> lib/lmb.c | 39 ++++++---------------------------------\n> 4 files changed, 27 insertions(+), 37 deletions(-)\n\n> diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c\n> @@ -868,9 +868,12 @@ static void add_u_boot_and_runtime(void)\n> + uboot_start = ((uintptr_t)map_sysmem(gd->start_addr_sp, 0) -\n> + uboot_stack_size) &\n> + ~EFI_PAGE_MASK;\n> + uboot_pages = (((uintptr_t)map_sysmem(gd->initial_relocaddr, 0) -\n> + uboot_start) +\n> + EFI_PAGE_MASK) >>\n> + EFI_PAGE_SHIFT;\n\nThe reformatting makes the code harder to read. Please can you keep\nthe original formatting style and just change the variable reference?\nSomething like:\n\nuboot_pages = ((uintptr_t)map_sysmem(gd->initial_relocaddr, 0) -\n uboot_start + EFI_PAGE_MASK) >> EFI_PAGE_SHIFT;\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=aB/Mt/LY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"aB/Mt/LY\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0Z6z65DMz1yHB\n\tfor ; Wed, 22 Apr 2026 06:42:51 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B8AAD80433;\n\tTue, 21 Apr 2026 22:42:49 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id E60F383FED; Tue, 21 Apr 2026 22:42:48 +0200 (CEST)","from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com\n [IPv6:2a00:1450:4864:20::62f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4668180433\n for ; Tue, 21 Apr 2026 22:42:46 +0200 (CEST)","by mail-ej1-x62f.google.com with SMTP id\n a640c23a62f3a-ba5b107eaa2so169633866b.3\n for ; Tue, 21 Apr 2026 13:42:46 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776804166; cv=none;\n d=google.com; s=arc-20240605;\n b=ZeMOdQ5mJRWFARUUCWyUHUdH8flKteFF5osyAmbDyMrg8EJfVrL1NG7Puy1F5Ipml5\n qSb6LO27cNO/Lo/b5KB32ifkuZhAXH1L/qzJ4fn6u7I0FMPMdarOWS+kkH9o3gZ2k9re\n +Ywz4cTwcIVdF8K/OnlKO6bmj/obX11v0h7UBscN0MfsRJlGW49lRW1ZoI/Uzr7w83xM\n RPS9LDD1NWV5NhCFijlB8jx9M4ueQTdy7uamsdjrDzPnC9KSHu4BaGwP2gfd1eJJ5ShI\n 8Nymdk0fv6/+VxhuSUTn9z23P6wL/oakK6/cA02PkoUdYwIGoBkLAJQBKl2qCAZ0X6yC\n BbOw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=tHXcsnRqmkE79jCcDEJaqbIaXZN7xllKDsIgM6CoRIc=;\n fh=VotdAeOBTvm9DU94Rw6PBYjbvlHh0uHd97nnQV3+qtw=;\n b=Y9yrZuWMLDqhpEIioamPv3BegdpYWRpC9lJutQci744qV0R8Jjnq6+bkIUHbaHdz+x\n CyuRPpYSw/wXjWASk+U+RJrWdDqJsQzGD6J96YNYPfKsFbxC8vdDu156g3qs7ZoqtHVU\n ZvMvRNsJurpG0jhvTWfYzGlkz221WfD1HGJoeNGwfSRKVd+JmPlXKBva+Drv61RY6Bfi\n vFY3g34kXbx93J0rkHrZbdutps1eVMzhiISsfdBT9lv2SC36risaugpEcAcIfhsRgVSc\n JaNtH0lGBrHCOz14WFCZq2ybFwYfz+GC9fDCGVTP0pqggRv9HfUXjWDmakIqv5wZGkQ6\n j0IQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776804166; x=1777408966; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=tHXcsnRqmkE79jCcDEJaqbIaXZN7xllKDsIgM6CoRIc=;\n b=aB/Mt/LYoO5QkPrEhYtJ3qz99bc1eZGuyQ5V/tY18/vcOsJcAmg9ZzmpD1gu63BqOS\n EfOQ2sgGycV1maMtPFwoybU0xL9jCUpkg9fy5d1TouIYozrQRPepRB2pui2fsWX/vd66\n 5LfuVv6uJ5J6FaxjtMJyrD9SYjLvkDkBc9eRU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776804166; x=1777408966;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=tHXcsnRqmkE79jCcDEJaqbIaXZN7xllKDsIgM6CoRIc=;\n b=cOTymf4rvIhFE7T+XMOH20spfATUdiVYqEn2Q1HKwjHekjeln7md3tKKHSx5fPawyP\n TDh9gkBu2bJtcA99x6OOJRqflHffNFaHTcmI9+XJ+Hp9LLSiSEEuaq7Bv9IInRkc3cEH\n fgZBjm09SWSI4NIwe5gB6UzginK5ee+h9lWi49f+Kubgsd3ptWB5f/Wl2qXzmStETw2l\n Gwri4wTL5iFX5Ot7Jg80jzUlJefLnz1sy1jY35NTft9lFfKUW+NlxUyeyKoyqsSCBBwB\n zFRmmKdSa6Gzs6Fic/mEfI/tnrV8j5cp1dVvmB6htG/15DdGM+rC2OpyTG9KZI0U0frL\n yOrw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+ulIlTs+YKMJ8nIvAgeMkJSkNmaBtsSMkRLNeAyBImpidSd+DgXMuR4pswuDh0NPSh0P21O7s=@lists.denx.de","X-Gm-Message-State":"AOJu0Yx3ON4QIubahJQVrJutxJv8ZMd5UNkMsYmCZnAwaxDl6Elrolb/\n qegiofxuELZa41zSB9ltNTBkJ6g5fkSOm764pKavYU2QPG82txh8T1mMd9iMUjMVleQumhSYz/R\n A25LlRn8TogxrPhQpS/VF0Z2SA1/xdEal0QWvIusn","X-Gm-Gg":"AeBDies3aK6mxwhHMzLloEd2m9/STyzM4Pd0wHEjwkJF36XT8pcJUCZNUOpLoyfHjOD\n xjghdIwMJ4aNaRd6e2N4+22MzeEM6HOkEsWiWuG2AnTqdCtIPkRj92rNs2wACr734JICnX+LY0q\n MCzaGaNVf2t6U1M6LR/zCBqN3mnAl0z37btJoRoM4smVviUBsbr5nnP5zY53RApzmIZ9i7Rg4cM\n OZtys2N7YOzSnoSCEXVmOVLDKV77zT4m4IBPJGgGyCbEJt3UJJUWROrzhpVMBWrqB4+qErPT/DI\n hR+LBHXxXDCR5X9ufpZ7","X-Received":"by 2002:a17:907:a607:b0:b9d:31c2:37f9 with SMTP id\n a640c23a62f3a-ba41828cbe5mr1036681866b.2.1776804165690; Tue, 21 Apr 2026\n 13:42:45 -0700 (PDT)","MIME-Version":"1.0","References":"<20260420192520.1444749-1-rs@ti.com>\n <20260420192520.1444749-7-rs@ti.com>","In-Reply-To":"<20260420192520.1444749-7-rs@ti.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 08:42:33 +1200","X-Gm-Features":"AQROBzA5YXBx5syY2COc5zcLwe9WBPO8pgHCa0x2oEPsgB-qpuXHb3wGO573l24","Message-ID":"\n ","Subject":"Re: [PATCHv4 6/6] memory: reserve from start_addr_sp to\n initial_relocaddr","To":"rs@ti.com","Cc":"robertcnelson@gmail.com, ayush@beagleboard.org,\n Erik.Welsh@octavosystems.com, anshuld@ti.com, bb@ti.com, trini@konsulko.com,\n afd@ti.com, xypron.glpk@gmx.de, ilias.apalodimas@linaro.org,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]