[{"id":3679679,"web_url":"http://patchwork.ozlabs.org/comment/3679679/","msgid":"<87340oalzo.fsf@pond.sub.org>","list_archive_url":null,"date":"2026-04-21T06:03:23","subject":"Re: [PATCH v1] checkpatch: Allow spaces after all coroutine\n annotations","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Fabiano Rosas writes:\n\n> The coroutine annotations may be used in the declaration of function\n> pointers, which triggers checkpatch due to the space before the\n> parentheses. E.g:\n>\n> int coroutine_fn (*run)(Job *job, Error **errp);\n> ^\n> The coroutine_fn annotation is already included in the list of terms\n> where spaces are allowed. Add the other coroutine annotations:\n> coroutine_mixed_fn and no_coroutine_fn.\n>\n> Signed-off-by: Fabiano Rosas \n> ---\n> the next migration PR will trigger this\n> ---\n> scripts/checkpatch.pl | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl\n> index b77bd69328..e1cf2ff23b 100755\n> --- a/scripts/checkpatch.pl\n> +++ b/scripts/checkpatch.pl\n> @@ -2441,6 +2441,7 @@ sub process {\n> \t\t\tif ($name =~ /^(?:\n> \t\t\t\tif|for|while|switch|return|case|\n> \t\t\t\tvolatile|__volatile__|coroutine_fn|\n> +\t\t\t\tcoroutine_mixed_fn|no_coroutine_fn|\n> \t\t\t\t__attribute__|format|__extension__|\n> \t\t\t\tasm|__asm__)$/x)\n> \t\t\t{\n\nReviewed-by: Markus Armbruster ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Qralrnm6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0Bd13hKwz1yHB\n\tfor ; Tue, 21 Apr 2026 16:04:05 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wF4Cr-0007CR-4w; Tue, 21 Apr 2026 02:03:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wF4Cp-0007CF-NS\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 02:03:31 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wF4Co-0006S7-6Q\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 02:03:31 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-STgpznYzPyS2jx5CUYt4Dg-1; Tue,\n 21 Apr 2026 02:03:27 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 85D0719560BB; Tue, 21 Apr 2026 06:03:26 +0000 (UTC)","from blackfin.pond.sub.org (unknown [10.44.22.22])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 43E18180047F; Tue, 21 Apr 2026 06:03:26 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n id B482821E6A28; Tue, 21 Apr 2026 08:03:23 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776751409;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=QjzrciRq/TcwKBPqJXuJKSmOrzYtTKk7Kb4SvLreyuk=;\n b=Qralrnm6a7e03B8ZDe36anUwHn19oC0ZMNVHwurC+YPk0VkEVwd031x4bQ8yDgAXN+FD+3\n EdlbiZzV4Oin1vTuNXCVInOr1YnzMfaR69Xycxuklz/kA0dlbD8jgb1DKuoG+/e45JPT9t\n MXJGkuOf/sy83h9NcAr4fJeka0P6uZY=","X-MC-Unique":"STgpznYzPyS2jx5CUYt4Dg-1","X-Mimecast-MFC-AGG-ID":"STgpznYzPyS2jx5CUYt4Dg_1776751406","From":"Markus Armbruster ","To":"Fabiano Rosas ","Cc":"qemu-devel@nongnu.org, Kevin Wolf ","Subject":"Re: [PATCH v1] checkpatch: Allow spaces after all coroutine\n annotations","In-Reply-To":"<20260420191356.4439-1-farosas@suse.de> (Fabiano Rosas's message\n of \"Mon, 20 Apr 2026 16:13:56 -0300\")","References":"<20260420191356.4439-1-farosas@suse.de>","Date":"Tue, 21 Apr 2026 08:03:23 +0200","Message-ID":"<87340oalzo.fsf@pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3681330,"web_url":"http://patchwork.ozlabs.org/comment/3681330/","msgid":"","list_archive_url":null,"date":"2026-04-23T08:29:29","subject":"Re: [PATCH v1] checkpatch: Allow spaces after all coroutine\n annotations","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 20.04.2026 um 21:13 hat Fabiano Rosas geschrieben:\n> The coroutine annotations may be used in the declaration of function\n> pointers, which triggers checkpatch due to the space before the\n> parentheses. E.g:\n> \n> int coroutine_fn (*run)(Job *job, Error **errp);\n> ^\n> The coroutine_fn annotation is already included in the list of terms\n> where spaces are allowed. Add the other coroutine annotations:\n> coroutine_mixed_fn and no_coroutine_fn.\n> \n> Signed-off-by: Fabiano Rosas \n\nReviewed-by: Kevin Wolf ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ZNn+DU9t;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1Tnc63Dbz1yD5\n\tfor ; Thu, 23 Apr 2026 18:30:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFpRc-0001Z5-Sz; Thu, 23 Apr 2026 04:29:56 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFpRP-0001SN-JK\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 04:29:45 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFpRM-0000J6-65\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 04:29:42 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-NYqn4XV2Nb2Bh1wjtMv4lw-1; Thu,\n 23 Apr 2026 04:29:33 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B62061956050; Thu, 23 Apr 2026 08:29:32 +0000 (UTC)","from redhat.com (unknown [10.44.48.215])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 9952E19560AB; Thu, 23 Apr 2026 08:29:31 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776932975;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Mos+bQcAEHj4K5a62X6yzjC0RCfrU5JRF/fU1KxjrCI=;\n b=ZNn+DU9tW1FOlXfCLHDzo4sbiIcnQyU+9w9UiDrWAL3/ZhXESH/v+hMQno+KHZnH/r5pS0\n dRDYgPTRYXLzQ+0TpYaCFyaxJPGguUuJUIcww9OSFOhwR7+gaZSIqTfww+vyugxGsPQtTq\n L6XQIyl6sWym4oH35L3xJOShmnAiOdE=","X-MC-Unique":"NYqn4XV2Nb2Bh1wjtMv4lw-1","X-Mimecast-MFC-AGG-ID":"NYqn4XV2Nb2Bh1wjtMv4lw_1776932973","Date":"Thu, 23 Apr 2026 10:29:29 +0200","From":"Kevin Wolf ","To":"Fabiano Rosas ","Cc":"qemu-devel@nongnu.org","Subject":"Re: [PATCH v1] checkpatch: Allow spaces after all coroutine\n annotations","Message-ID":"","References":"<20260420191356.4439-1-farosas@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260420191356.4439-1-farosas@suse.de>","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"12","X-Spam_score":"1.2","X-Spam_bar":"+","X-Spam_report":"(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]