[{"id":3679497,"web_url":"http://patchwork.ozlabs.org/comment/3679497/","msgid":"<6997340d-b45f-4609-95c3-c503394c3333@linaro.org>","list_archive_url":null,"date":"2026-04-20T17:34:56","subject":"Re: [PATCH 3/3] migration/qemu-file: drop incorrect const from\n qemu_get_buffer_at buf","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 20/4/26 22:13, Junjie Cao wrote:\n> qemu_get_buffer_at() reads data *into* buf -- it should not be const.\n> Drop the qualifier and remove the now-unnecessary cast.\n> \n> Signed-off-by: Junjie Cao \n> ---\n> migration/qemu-file.c | 4 ++--\n> migration/qemu-file.h | 2 +-\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=HJyKFo/b;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzt1H1c6Gz1yGs\n\tfor ; Tue, 21 Apr 2026 03:35:29 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEsWY-0004JP-ON; Mon, 20 Apr 2026 13:35:06 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wEsWT-0004JF-Ng\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 13:35:01 -0400","from mail-wm1-x330.google.com ([2a00:1450:4864:20::330])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wEsWS-0005FB-75\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 13:35:01 -0400","by mail-wm1-x330.google.com with SMTP id\n 5b1f17b1804b1-48984d29fe3so12970895e9.0\n for ; Mon, 20 Apr 2026 10:34:59 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ffad20f2sm118088355e9.0.2026.04.20.10.34.57\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 20 Apr 2026 10:34:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776706498; x=1777311298; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=8TNhTgSb3MVHEeT0xN0XLy428ajVeu/fkK4elHpuOyE=;\n b=HJyKFo/bJ713azcii65zzR54XGWMXVQ9P4PKVkMN28QgAnth5N4MoJbf7WpOpbdxq3\n Z2r0fyudibeNfqzz0eMry+Qga8NvereuDURb/Qv6gB8x93XSRCGf/pcLZlWb2Y4AsZaZ\n zlFZ+VSJLqkKDWc8PyA/dEr3YfPPgxLIYXqUj4erIeHHw41tsjNpgSHRwsumP04N8XCi\n izw/188wOBslL5tN+41WreCtY8Za1hpDQfr9Od5edrk8FGn/Q/6BICZrHSihUPo3TeIs\n re8FQM58r2apNprDcIkkR9yl5uJ9GaOdFslSWtkvn1BpWbymCPzmnAvAQyci/j29hmEZ\n 5Kgw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776706498; x=1777311298;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=8TNhTgSb3MVHEeT0xN0XLy428ajVeu/fkK4elHpuOyE=;\n b=dnn9YDFvmq/TQcxv/09Yz/X5BJDeAbgmUMAzq3dN1SIb1Uo/zZoA+Rfirh2rAmEoX/\n pXvIPIEvPJBaLaHhJiGxvP/l/ZDMgYQFYjaU7Q095zI87PlZm4XobR5JUDIuN+RBbVKW\n sIsC8SewXJBraCJoWsIzNfq31zUlyHiIzPWmPONWaB8U4c74HbRQ4R8UmNTko/44bC0V\n 0CsXAtFudcjsfnD0jqHz+zKqO7gY9EclKeK8mppKXqvDZdrQqzzwAtpgr3PeBfZ14f6h\n AWLGZ4G4hvFMQb70cdOBeDikeLcwe4et5MhJTofhIPnaikLIgoPr78EzbgSno5MSnBB4\n J4bA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8XRK71BR+vvC/PzvqcMIdpw/Nh0ow61l4pEJ0QZDWZxBNQVh2hCNhpjNZmMwY7VVyN4ie6zxIM8/ka@nongnu.org","X-Gm-Message-State":"AOJu0Yyly5ot3MiCD/avhHoKWPlyj5QkUyz6ODSRx1jNqiXmBIr235/o\n MSuj153t05ZwMXieuQ7FUh3+0gDDYvKzWPZdl0rv5fVD+xhgf+gQ8bo2i+bEBRP97lo=","X-Gm-Gg":"AeBDievxz5XTGS+3nYNl7dhRAXtD8rMhfiW86Xsa5P+Lw6IPmCHRaPYoEFVpBWGN7ZK\n XJttrduNm9Kiwkx6tONEc3p900Sy49GsBlPtoLkmuJwYN35UBfn1c8n6Vf/YLDkO3CZ/3dbGbvF\n 1ZYIZSopxbA11UpOEx8qG1PAFK1VAksXjXWozWVARINt75yPii+JuBQn3/k8k4TcAWf9kuzOLAG\n Cjw4w68ycy3ky7c2JmfCEdThGHAHBRsgVy2J/bFQvgDZUWHx7VMEX7UgBhjSTroer+fNp7GZzeg\n kSAJxeTF5llxaEQNWwWHBppw7QAPHEQXNx1xfFU87qyo17P+3bmCpeY9IKm9nZldyvP0qCDQQg7\n BXKhJWt2AULhFIT6jGkTQ7OaQ+yacmEZPJtXVutSJEJx251HEfeA9jCLl7NdJiCvwDdYvUjslSQ\n 3Xue6zW+8HFMe6RBkjt6GuJPjRPAc6Dqu8f3BFO20nIe3AJPyvYRZuDkmWGMzpDJPKSFPEuKx/k\n C/1w48Ce5+YlwM=","X-Received":"by 2002:a05:600c:8b2e:b0:488:b749:8482 with SMTP id\n 5b1f17b1804b1-488fb7469b3mr229714715e9.4.1776706498512;\n Mon, 20 Apr 2026 10:34:58 -0700 (PDT)","Message-ID":"<6997340d-b45f-4609-95c3-c503394c3333@linaro.org>","Date":"Mon, 20 Apr 2026 19:34:56 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 3/3] migration/qemu-file: drop incorrect const from\n qemu_get_buffer_at buf","To":"Junjie Cao , qemu-devel@nongnu.org","Cc":"peterx@redhat.com, farosas@suse.de","References":"<20260420201317.30199-1-junjie.cao@intel.com>\n <20260420201317.30199-4-junjie.cao@intel.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Language":"en-US","In-Reply-To":"<20260420201317.30199-4-junjie.cao@intel.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::330;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]