[{"id":3679370,"web_url":"http://patchwork.ozlabs.org/comment/3679370/","msgid":"<4cfe307cc6b1197fc7bb3a11e79382764ac1d269a42eb4e4ffec9e991e6868e6@mail.kernel.org>","list_archive_url":null,"date":"2026-04-20T11:36:13","subject":"Re: [PATCH bpf-next v4 4/6] selftests/bpf: add icmp_send_unreach\n kfunc tests","submitter":{"id":91980,"url":"http://patchwork.ozlabs.org/api/people/91980/","name":null,"email":"bot+bpf-ci@kernel.org"},"content":"> diff --git a/tools/testing/selftests/bpf/prog_tests/icmp_send_unreach_kfunc.c b/tools/testing/selftests/bpf/prog_tests/icmp_send_unreach_kfunc.c\n> new file mode 100644\n> index 000000000000..24d5e01cfe80\n> --- /dev/null\n> +++ b/tools/testing/selftests/bpf/prog_tests/icmp_send_unreach_kfunc.c\n> @@ -0,0 +1,136 @@\n> +// SPDX-License-Identifier: GPL-2.0\n> +#include \n> +#include \n> +#include \n> +#include \"icmp_send_unreach.skel.h\"\n> +\n> +#define TIMEOUT_MS 1000\n> +#define SRV_PORT 54321\n> +\n> +#define ICMP_DEST_UNREACH 3\n> +\n> +#define ICMP_FRAG_NEEDED 4\n> +#define NR_ICMP_UNREACH 15\n\nJordan Rife previously suggested in v3 that these ICMP constants should be\nimported from rather than redefined here. Would it be cleaner\nto include the header and avoid the redefinitions?\n\nReference: https://lore.kernel.org/bpf/usz5bhydsiejr37owgt3zypckzh7fa7ygmhsyaaiprsljx7iy5@ipopnr5n4ds7/\n\n[ ... ]\n\n\n---\nAI reviewed your patch. Please fix the bug or email reply why it's not a bug.\nSee: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md\n\nCI run summary: https://github.com/kernel-patches/bpf/actions/runs/24663313503","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=N/HYEkIE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12047-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"N/HYEkIE\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzk302B70z1yD4\n\tfor ; Mon, 20 Apr 2026 21:36:28 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 30FC5301581F\n\tfor ; Mon, 20 Apr 2026 11:36:17 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B8AFB39E184;\n\tMon, 20 Apr 2026 11:36:14 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DAE5298CA5;\n\tMon, 20 Apr 2026 11:36:14 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id D640FC19425;\n\tMon, 20 Apr 2026 11:36:13 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776684974; cv=none;\n b=gdrcE04IfsK3O/nBVR48CXOoLxCgtyq5oPcototx5Sd4cxWK+NVhX+x1paSPMAug1aS5zcD+8l3ix4ixiD0zxemJD7uK0Cden0sIH/WdtpEGSuXvm4F/U6d9iyntyRhp2Wf9oHPAypKT4YzKKnkOKzI66b7NtRQtS6Job/vWzzs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776684974; c=relaxed/simple;\n\tbh=DZ2IJIsTPYRRREqEtaAfuRENNxtiPUVPNWrGhzjMUEI=;\n\th=Content-Type:MIME-Version:Message-Id:In-Reply-To:References:\n\t Subject:From:To:Cc:Date;\n b=QKjA2NVAOZ0VaCNA5BMqAkMwav8w37qN3L0HWDPR+R+zR/EVFVtKmqmEA5Lh7FfHGiVnlWpI5nfFLrNzd8Bs76JAq9rwfdCtEPr02BCrBUuF3spW3cY0iBqNdh3qTQ9W3hd0WHWz5233pwFZjNJT4K6sO/WkZF0yLDt+gCCroPw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=N/HYEkIE; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776684974;\n\tbh=DZ2IJIsTPYRRREqEtaAfuRENNxtiPUVPNWrGhzjMUEI=;\n\th=In-Reply-To:References:Subject:From:To:Cc:Date:From;\n\tb=N/HYEkIEulAcgdEg3Hrvoz9L6hmt1OeZ/WCReQx4cw87fdHCfI35sf5UWpBliPLHd\n\t HbZRdnmnGlIVU6U37npZaGkfeVgo6U/EGKhdjfPyWkdsHTcRt4uIQUiH2x5dGAPg9m\n\t yfVmdiXO5hcw35aCAL/AXDYKCw5UWsfGrqz8nunlYujPnwWDqmCgQ6mw7/J0fnd6a2\n\t LrWjZxDMMjngyKlaexAkzHij7gi4gXj93de2egQ3kmkLzYmtLK3S6uxg0gzLF/AG9g\n\t gMVAMWlravYWtFtN5iGJBbOawSznI+RbSMeMooSFOlCvrWNcvmf+LtBkVSTYVpgLli\n\t WgkzUTy8tfLTw==","Content-Type":"multipart/mixed; boundary=\"===============6902634143243539288==\"","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Message-Id":"\n <4cfe307cc6b1197fc7bb3a11e79382764ac1d269a42eb4e4ffec9e991e6868e6@mail.kernel.org>","In-Reply-To":"<20260420105816.72168-5-mahe.tardy@gmail.com>","References":"<20260420105816.72168-5-mahe.tardy@gmail.com>","Subject":"Re: [PATCH bpf-next v4 4/6] selftests/bpf: add icmp_send_unreach\n kfunc tests","From":"bot+bpf-ci@kernel.org","To":"mahe.tardy@gmail.com,mahe.tardy@gmail.com","Cc":"\n alexei.starovoitov@gmail.com,andrii@kernel.org,ast@kernel.org,bpf@vger.kernel.org,coreteam@netfilter.org,daniel@iogearbox.net,fw@strlen.de,john.fastabend@gmail.com,lkp@intel.com,martin.lau@linux.dev,netdev@vger.kernel.org,netfilter-devel@vger.kernel.org,oe-kbuild-all@lists.linux.dev,pablo@netfilter.org,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,clm@meta.com,ihor.solodrai@linux.dev","Date":"Mon, 20 Apr 2026 11:36:13 +0000 (UTC)"}},{"id":3679402,"web_url":"http://patchwork.ozlabs.org/comment/3679402/","msgid":"","list_archive_url":null,"date":"2026-04-20T13:08:35","subject":"Re: [PATCH bpf-next v4 4/6] selftests/bpf: add icmp_send_unreach\n kfunc tests","submitter":{"id":91349,"url":"http://patchwork.ozlabs.org/api/people/91349/","name":"Mahe Tardy","email":"mahe.tardy@gmail.com"},"content":"On Mon, Apr 20, 2026 at 11:36:13AM +0000, bot+bpf-ci@kernel.org wrote:\n> > diff --git a/tools/testing/selftests/bpf/prog_tests/icmp_send_unreach_kfunc.c b/tools/testing/selftests/bpf/prog_tests/icmp_send_unreach_kfunc.c\n> > new file mode 100644\n> > index 000000000000..24d5e01cfe80\n> > --- /dev/null\n> > +++ b/tools/testing/selftests/bpf/prog_tests/icmp_send_unreach_kfunc.c\n> > @@ -0,0 +1,136 @@\n> > +// SPDX-License-Identifier: GPL-2.0\n> > +#include \n> > +#include \n> > +#include \n> > +#include \"icmp_send_unreach.skel.h\"\n> > +\n> > +#define TIMEOUT_MS 1000\n> > +#define SRV_PORT 54321\n> > +\n> > +#define ICMP_DEST_UNREACH 3\n> > +\n> > +#define ICMP_FRAG_NEEDED 4\n> > +#define NR_ICMP_UNREACH 15\n> \n> Jordan Rife previously suggested in v3 that these ICMP constants should be\n> imported from rather than redefined here. Would it be cleaner\n> to include the header and avoid the redefinitions?\n\nYes it would be cleaner, but looks like I can't do it simply, maybe\nthere's a solution, see the answer from the cover-letter:\n\nto Jordan: I couldn't include because of redefines from\n.\n\n> \n> Reference: https://lore.kernel.org/bpf/usz5bhydsiejr37owgt3zypckzh7fa7ygmhsyaaiprsljx7iy5@ipopnr5n4ds7/\n> \n> [ ... ]\n> \n> \n> ---\n> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.\n> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md\n> \n> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/24663313503","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=OGltjTc6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12051-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"OGltjTc6\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.53","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzmDw1Gnsz1yCv\n\tfor ; Mon, 20 Apr 2026 23:15:12 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id BDCD430DD929\n\tfor ; Mon, 20 Apr 2026 13:08:47 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D703E3A16B8;\n\tMon, 20 Apr 2026 13:08:40 +0000 (UTC)","from mail-wm1-f53.google.com (mail-wm1-f53.google.com\n [209.85.128.53])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EE0D139FCAB\n\tfor ; Mon, 20 Apr 2026 13:08:38 +0000 (UTC)","by mail-wm1-f53.google.com with SMTP id\n 5b1f17b1804b1-488a8ca4aadso41683835e9.3\n for ;\n Mon, 20 Apr 2026 06:08:38 -0700 (PDT)","from gmail.com (deskosmtp.auranext.com. [195.134.167.217])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a52583fe7sm21505945e9.13.2026.04.20.06.08.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 06:08:36 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776690520; cv=none;\n b=DLMxCr3WMF0EvVoYEDQ6/TjzFjVj1e2L/B5SJkm7vZtA04v9ISfIQDp/pgyvr9At0oIH1gKIT1k2aAp1fAooZUaJY1PEGcN1zB2wBJ8h6WfLSgA4g+p6lwJbc3D91IN1EXRAdcs7OzqO9EbEgExLzOe06SiI3cU6QMvDzYgY6S0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776690520; c=relaxed/simple;\n\tbh=WfdVss5pRtKxRJBglQrxBTFvd3jpqaaHpT5PTY30qcU=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=SYaX4Z/5O55IleJztmnOXIfoQSF03vmcx1g75UOv4wsBQ0L2c52ZyMPbGJSQo5BzHc7oVZt+AJA2zo4gOeRmZB/nvQ4dVl6ZoZcHQ7463bqIzTVWbtNhDCoGAzI+b1667f5S4FvgSwdJimDoyJJjiZw8VexbWjbLUm5o4PCerTM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=OGltjTc6; arc=none smtp.client-ip=209.85.128.53","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776690517; x=1777295317;\n darn=vger.kernel.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=2wEN4jEMCOiQ0Wb/rEfzmY335o62y1i/d8QKlDPNvdc=;\n b=OGltjTc6So0lhKLVhds0TswoCWFDJLk1RyqcSpCHjngiDSXfD5qOTHXrYL2PTTDpO4\n v83z+cMlwjEC0txBbh1a2dPjxP8+QpQBw1ra0IcEEaVFjav8uooyRRDJ4kIl8ifz5mZ+\n 0iNp9vcdp2fR9/OHUfh9qEWcj6f7224FKwuHzEjC/xCOLwHlLOca3Asl1iH9YJYWVHg5\n 3fKqSRVvq8ri7c7pvk/zUHTlAfggOHqjCUVBjTqUh0gO2Hinc4TAZ78PrSL0tG//FHFm\n dmnkWl/uHG9tVclZ2rrwN4bGj9SDXe/mNO0Rv6nDsxLy9yoNA1IJfHCpSTeACMyxlcC/\n haxg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776690517; x=1777295317;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=2wEN4jEMCOiQ0Wb/rEfzmY335o62y1i/d8QKlDPNvdc=;\n b=l1Eu2jd/jz9zj11tAD1mS/RVI2nU85dlA8IhrPiKv31Ju6gXFBPKmK+EYBrPAPFhVY\n xNX+6/jdWF3zHMFTYQ2a4COyRkbBAlXY18vhpw7JcT2+AlOu8Gk+xnF8HWxXO2Fovgwq\n P1fYZ7+tjetL3f+y4rDysWCoQKpbzjJVMPhYTr+k+1SCmCdFFImBs/R3nIjLc16fZKRt\n Vh5wrMDVhf/p6Zabks7sfxZrxQ+cs/nzSAtVtbHQ0A3hTUL9WsSr0/YCu1hRrFAmJSl7\n F1tlz1HA2xZ4KcISQpKzVT0xGbrpxN2KMtt7Ubyv7MD7l4aSd6Edqe8YyFYvIKqu+vkM\n 0+8g==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9fL+4nUEcrxkrujiEQDcChD1ILY+wr8sW/mz00+kLeHWiBxLsQGo2K4IsnqJOQY1AdvuVcidv5MOICRGM8OYM=@vger.kernel.org","X-Gm-Message-State":"AOJu0YxdU3LAQxFR1MkqdhOoXqx9D8IIWuvKfq7bqVShYaHJXcix8Jqt\n\tr3VOfHYG0m9NZhJZhkq9EBM0O0uPYiW+3Q5u2TOgS1IKDKgf4D28iUHz","X-Gm-Gg":"AeBDiesb37WcWLA4bI3Se8xSkEoK7Zudlr4a4O00qawQVkLsBlj7/+uEB8+gGFTOmy6\n\tKMn4L4FWl8EaXO2eckUNnPAPioO1Xjx/f6angUMCx2+kOtTjlKTMR58rfhO5iLJDHrnE5X3l5Zk\n\t6G+1/jmGmCChxpwsm6wxUOfrkXUg53//Z1g3KimAOQ1r4KfUzb8t6DqgQV6Vx5YggbwUCOnFFbD\n\tgvhLisLlNBYjF0IeWMF35Uiyg4S7ik0y3XVcxFoBeTtey3FseG1xOLrCAvhEWMMn9Q8ub5QCxVM\n\tfTiQUvogWGmNjSQyy/ueOCEGsmYs9rinP3l2itV21tEs0x32A3gr9sJ/eN8j5LZIXVMveI2sXAb\n\tz+LRW6j7LD3B+WI84jK4avmhOUiycqdlngV7CbgdRtJB5CF+cmVNlU97IY8Gbz2npOgjdVdbBTO\n\tauXkMlZiIJJZmKDelWLwtisPPpHuNjeakGMcVcRx6YCAVoQaorVkzuW/eNSZ04l4TpueKOvx6jv\n\tSfC","X-Received":"by 2002:a05:600c:c09c:b0:48a:5363:8cac with SMTP id\n 5b1f17b1804b1-48a53638e07mr5220075e9.22.1776690517192;\n Mon, 20 Apr 2026 06:08:37 -0700 (PDT)","Date":"Mon, 20 Apr 2026 15:08:35 +0200","From":"Mahe Tardy ","To":"bot+bpf-ci@kernel.org","Cc":"alexei.starovoitov@gmail.com, andrii@kernel.org, ast@kernel.org,\n\tbpf@vger.kernel.org, coreteam@netfilter.org, daniel@iogearbox.net,\n\tfw@strlen.de, john.fastabend@gmail.com, lkp@intel.com,\n\tmartin.lau@linux.dev, netdev@vger.kernel.org,\n\tnetfilter-devel@vger.kernel.org, oe-kbuild-all@lists.linux.dev,\n\tpablo@netfilter.org, martin.lau@kernel.org, eddyz87@gmail.com,\n\tyonghong.song@linux.dev, clm@meta.com, ihor.solodrai@linux.dev","Subject":"Re: [PATCH bpf-next v4 4/6] selftests/bpf: add icmp_send_unreach\n kfunc tests","Message-ID":"","References":"<20260420105816.72168-5-mahe.tardy@gmail.com>\n <4cfe307cc6b1197fc7bb3a11e79382764ac1d269a42eb4e4ffec9e991e6868e6@mail.kernel.org>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n <4cfe307cc6b1197fc7bb3a11e79382764ac1d269a42eb4e4ffec9e991e6868e6@mail.kernel.org>"}}]