[{"id":3683321,"web_url":"http://patchwork.ozlabs.org/comment/3683321/","msgid":"","list_archive_url":null,"date":"2026-04-28T09:42:44","subject":"Re: [PATCH] pinctrl: pinconf-generic: fix properties bitmap leak in\n parse_fw_cfg()","submitter":{"id":92050,"url":"http://patchwork.ozlabs.org/api/people/92050/","name":"Linus Walleij","email":"linusw@kernel.org"},"content":"On Mon, Apr 20, 2026 at 12:56 PM Felix Gu wrote:\n\n> In parse_fw_cfg(), if fwnode_property_match_property_string() fails with\n> -ENOENT, the code returns directly and leaks the bitmap.\n>\n> Use __free(bitmap) for automatic cleanup to fix the leak.\n>\n> Fixes: 9c105255108b (\"pinctrl: pinconf-generic: perform basic checks on pincfg properties\")\n> Signed-off-by: Felix Gu \n\nVery elegant Felix, thanks!\nPatch applied.\n\nYours,\nLinus Walleij","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=CAGNKr26;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35675-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"CAGNKr26\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4bH90KZnz1yJH\n\tfor ; Tue, 28 Apr 2026 19:48:52 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 0FB46303A096\n\tfor ; Tue, 28 Apr 2026 09:43:02 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3B2933D6CDA;\n\tTue, 28 Apr 2026 09:42:59 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id F29BD3A63FB\n\tfor ; Tue, 28 Apr 2026 09:42:58 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 91B40C2BCAF\n\tfor ; Tue, 28 Apr 2026 09:42:58 +0000 (UTC)","by mail-lj1-f180.google.com with SMTP id\n 38308e7fff4ca-38e7b0903cdso100433761fa.3\n for ;\n Tue, 28 Apr 2026 02:42:58 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777369379; cv=none;\n b=IUJ1wyb8zkIQIal92XsDvOtx9npL5WFsh4OG2Z5aYGoPYvb+jIVtZxDsE1hGSL9TUL1pN+aA/dwPqUhR/NuF4IyXeZv8C1I+LHr8fzBnw7cLBZi9OyYxBo4qdVGVIQLNYg8oSd76X7d9QWg8PJueWy9HV5jAU9gd+pq0poIDh4g=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777369379; c=relaxed/simple;\n\tbh=p8Nv0AJoTta5EMpsjb7JOmpE8H5YhktE42ZUJI1zgRw=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=NuhndV1XOCGHcdVw8HfGxu4mLBkNIR5jWFykkH8Lm6PEygY0xkmQ7Hq4aRA9f6VjSPn9xpgojM83r9VlBeoP45AILv/RxTCcNgKz51I56KSZnpg7A815W7q2EE6pnRZvVWZYQTTv3qZk65ajgOmjPrtw9CG7NkCj0KPwZjzYI4E=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=CAGNKr26; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777369378;\n\tbh=p8Nv0AJoTta5EMpsjb7JOmpE8H5YhktE42ZUJI1zgRw=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=CAGNKr26cUeT5HAiyKc2K3chcRHBw7C7WpyNZdpPX99El6jXpyiszvphYeq0SFCA+\n\t sG0WubbC6HwsSx0ZE7ymc3Tl3xbzTRroiM7YpM0EH1yMiZ+CTshpfUWwRHcaYPk7Wk\n\t XnETXIbT/gw0kLptYlAHnp4I1HPmvNVPsktQ2Crq1nwjlbUgU7G9uQ8vfyjhl0f+Mr\n\t JTPzfNTwfJKtonc9WVl/EhEfAwiwPqz4CLqvFDfy386FPUWEbURMVx99BfxZD8Ytic\n\t 2cRsKv73dVjAuXKW+0s4C8TnbKWSyBQ5m2nBLYHo2QhwFx2ws1BAVaIJpBM0kgnDzd\n\t i/Jdp9AHSmPFQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/Vlcnr0Q0oQPe+WodZNyL4BiY8e3vd86aHZU5BGmg/5l7QHFhXO4HPuGSXnNCbLPDX2HPw4hWW29a1@vger.kernel.org","X-Gm-Message-State":"AOJu0Yzg819wF0SSsVzos8ZEMqbNASdw7iQObPnPoblzDXEJq5RpwdPG\n\th0Q0cATA5AN/ztBYJvsUO96b5irvyjc6BhSF7GrbVaaBnR1qSQzeIM0IJ2M+HlPY+9ssWPIx/91\n\tZPclHuYV3oKUPBb6eobQaAHSAvKAdsdg=","X-Received":"by 2002:a2e:bc11:0:b0:38c:562b:9bb6 with SMTP id\n 38308e7fff4ca-39240d1f9bamr8432241fa.15.1777369377303; Tue, 28 Apr 2026\n 02:42:57 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260420-pinconf-v1-1-82f8276d8aec@gmail.com>","In-Reply-To":"<20260420-pinconf-v1-1-82f8276d8aec@gmail.com>","From":"Linus Walleij ","Date":"Tue, 28 Apr 2026 11:42:44 +0200","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AVHnY4Idm6EHTtMScZdydO2A6TPmYvJ1MfBTf9NLYxUfXvnpkhcSF6iKRWa6Ec0","Message-ID":"\n ","Subject":"Re: [PATCH] pinctrl: pinconf-generic: fix properties bitmap leak in\n parse_fw_cfg()","To":"Felix Gu ","Cc":"Conor Dooley , linux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]