[{"id":3679395,"web_url":"http://patchwork.ozlabs.org/comment/3679395/","msgid":"<6c6f94b1-a4fa-418a-b471-8e3c82305233@sirena.org.uk>","date":"2026-04-20T12:50:26","subject":"Re: [PATCH] ASoC: fsl_micfil: Add DC output remover control","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Mon, Apr 20, 2026 at 04:53:44PM +0800, Shengjiu Wang wrote:\n\n> +static int micfil_put_dc_out_remover_state(struct snd_kcontrol *kcontrol,\n> +\t\t\t\t\t struct snd_ctl_elem_value *ucontrol)\n> +{\n\n> +\tif (val < 0 || val > 3)\n> +\t\treturn -EINVAL;\n> +\n> +\tret = pm_runtime_resume_and_get(comp->dev);\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n> +\tmicfil->dc_out_remover = val;\n\n...\n\n> +\t/* Update DC Remover mode for all channels */\n> +\tret = snd_soc_component_update_bits(comp, REG_MICFIL_DC_OUT_CTRL,\n> +\t\t\t\t\t MICFIL_DC_CTRL_CONFIG, reg_val);\n> +\n> +\tpm_runtime_put_autosuspend(comp->dev);\n> +\n> +\treturn ret;\n\nThis will return 0 not 1 when the value changes, meaning event\ngeneration is missed. The mixer-test selftest should report this.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ErFvZhLY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19849-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ErFvZhLY;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=broonie@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzlhd4W95z1yGs\n\tfor ; Mon, 20 Apr 2026 22:50:41 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fzlhW4dqqz2ypw;\n\tMon, 20 Apr 2026 22:50:35 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fzlhV2JK7z2xll\n\tfor ; Mon, 20 Apr 2026 22:50:34 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id D29B060055;\n\tMon, 20 Apr 2026 12:50:31 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 741BCC19425;\n\tMon, 20 Apr 2026 12:50:29 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776689435;\n\tcv=none;\n b=cAoDR01w0TjaRW9Rluw4m1ge9I9Ex3OiGuQGJGR1t+j78yjSXFfodhmtlGaV4jPn/HELRTKUR0T0tJid5fM87HvfOimi5fSWObdx8FZYbxeULTB22TbXqObb+5z3AOLr6q3YGIlBY1wOeQpTQEXC+BiLdDlpT3myAMyVoxPAy+mCG1zjixc80Ipv0dzeKIH80rpunvBMbYs68+a0BnXfgYD8NYPDKVIvULhSDamzAZDgjyz/7KboIoQmuWGapb1BNuO7J+TAzWJc8fVcy5qy6uVchrNuMJuzW9gIIU1qpDiths83xbml/4q5Mpu9meynLZrRHy28Xh4vmWHdUXrNyQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776689435; c=relaxed/relaxed;\n\tbh=JA5D5Lai+x906ctoJM5XVa8H3mRw6/oPTglOWqaX+aM=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=VquXYN++JSPI2DR6Ud+CIthZv2UZC07q5ceA7QSYq3hsqsQv3+k/EZ7PcWlB/gXnqsOXHCJPqLk6q2zAWIU/myRo2ifG7HKhiAmB4KiwnpE1+nPl60J4H2PSCuN0LbgvbgX/bcufcgSYyIhfi7t0zz0Xnv5fAVS05tNKntXbXpfulC34crRsn2JoZ/t2XhK2FwknmX73qhs6GYzahBE17ofrVQUpZ895FoXlmitMRFOXHkmAMkrjcOO1LuZ4JGVR+lIHwsgsZfaF/BCVQG+T1seku0B3v3MslZVwSpU0zNFUY+rntZyT5jUQ6RPIlxeieAb5wXEWpLYQMNjLYK1fPA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ErFvZhLY; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org; envelope-from=broonie@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776689431;\n\tbh=xTIIm6v0aDSvm3HYaOhaWOqM1+ERQmESsoyqC0gy2jc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ErFvZhLYCAbOYtZB5cf8nFzowfaWmqIlzHDrYgZOwAlRd+mB/ObVF3AY+Z67NZO1A\n\t 7d5wh23h/7qfyILBYz6Dp4Sge8caG/OaqOPxjA+eeNP6ckMwYFwQE8lTkfsEHnaraL\n\t l+xeFvDTZBtdZ7vOg2nkcgggY+Czj+982kopyvxVcWiH8Qu8mbel8J+hnL6ZMXMGdZ\n\t qqtkRx2YrAsl3MmCCZkmHiqBvEIimWRqE6cjc4zzuLXfs8FfZkYTEVJwUwKWH2nLNu\n\t nsFY+8lD/HvolznL/3BBG1ySRdti/nlBKDhAj4AucT/EMY0k34Q7ygP/u/6kVyJF0/\n\t OQcv0NE1VAg2g==","Date":"Mon, 20 Apr 2026 13:50:26 +0100","From":"Mark Brown ","To":"Shengjiu Wang ","Cc":"shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com,\n\tnicoleotsuka@gmail.com, lgirdwood@gmail.com, perex@perex.cz,\n\ttiwai@suse.com, linux-sound@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] ASoC: fsl_micfil: Add DC output remover control","Message-ID":"<6c6f94b1-a4fa-418a-b471-8e3c82305233@sirena.org.uk>","References":"<20260420085344.2081805-1-shengjiu.wang@nxp.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"flMtTIAJpPEILprL\"","Content-Disposition":"inline","In-Reply-To":"<20260420085344.2081805-1-shengjiu.wang@nxp.com>","X-Cookie":"Sales tax applies.","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3679712,"web_url":"http://patchwork.ozlabs.org/comment/3679712/","msgid":"","date":"2026-04-21T07:40:12","subject":"Re: [PATCH] ASoC: fsl_micfil: Add DC output remover control","submitter":{"id":77868,"url":"http://patchwork.ozlabs.org/api/people/77868/","name":"Shengjiu Wang","email":"shengjiu.wang@gmail.com"},"content":"On Mon, Apr 20, 2026 at 8:50 PM Mark Brown wrote:\n>\n> On Mon, Apr 20, 2026 at 04:53:44PM +0800, Shengjiu Wang wrote:\n>\n> > +static int micfil_put_dc_out_remover_state(struct snd_kcontrol *kcontrol,\n> > + struct snd_ctl_elem_value *ucontrol)\n> > +{\n>\n> > + if (val < 0 || val > 3)\n> > + return -EINVAL;\n> > +\n> > + ret = pm_runtime_resume_and_get(comp->dev);\n> > + if (ret)\n> > + return ret;\n> > +\n> > + micfil->dc_out_remover = val;\n>\n> ...\n>\n> > + /* Update DC Remover mode for all channels */\n> > + ret = snd_soc_component_update_bits(comp, REG_MICFIL_DC_OUT_CTRL,\n> > + MICFIL_DC_CTRL_CONFIG, reg_val);\n> > +\n> > + pm_runtime_put_autosuspend(comp->dev);\n> > +\n> > + return ret;\n>\n> This will return 0 not 1 when the value changes, meaning event\n> generation is missed. The mixer-test selftest should report this.\n\nsnd_soc_component_update_bits() will return 1 if the value is changed.\nand the mixer-test pass\n\nok 120 get_value.micfilaudio.8\n# micfilaudio.8 MICFIL DC Out Remover Control\nok 121 name.micfilaudio.8\nok 122 write_default.micfilaudio.8\nok 123 write_valid.micfilaudio.8\nok 124 write_invalid.micfilaudio.8\nok 125 event_missing.micfilaudio.8\nok 126 event_spurious.micfilaudio.8\n\nIs there something I missed here?\n\nBest regards\nShengjiu Wang","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=HhqP6sBq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19871-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=pass smtp.remote-ip=\"2607:f8b0:4864:20::1035\" arc.chain=google.com","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=HhqP6sBq;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::1035; helo=mail-pj1-x1035.google.com;\n envelope-from=shengjiu.wang@gmail.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0DmD3lzKz1yGt\n\tfor ; Tue, 21 Apr 2026 17:40:28 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g0DmD2r3Vz2yfS;\n\tTue, 21 Apr 2026 17:40:28 +1000 (AEST)","from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com\n [IPv6:2607:f8b0:4864:20::1035])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g0DmC0VMzz2yFl\n\tfor ; Tue, 21 Apr 2026 17:40:26 +1000 (AEST)","by mail-pj1-x1035.google.com with SMTP id\n 98e67ed59e1d1-36146ae9dd4so2940051a91.3\n for ;\n Tue, 21 Apr 2026 00:40:26 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776757228;\n\tcv=pass;\n b=F6TeUAh46SrPTUxqd816lXbdxTN3maz416eyuWP/FKr8EpMjxENK/W7afkTmtRARQGjk8d6m2BrVzu2KuXLOYLFwbag/wQsIYPlD41RWb0Gjl9Yjl6vzkXePo2PnqcD8sbozajbj772kM5skaHx9keq3T9T5JbJO3AHO5QXmcWNj8M4s2ioUfFRXoZeQ5R2HUm0sk6Mmveexrltidngar+OaSeUUkO6tYSY5hEcEqySEq6FRQDr6rdQX7KfbKu8FInqi3p8LJvBt53Gk76FhBzGb3Uq8/6zNP87oigQY2eQJpjftTckbV0yywzjqvJk6hRdPEJn4yZluRlUdKjcFDQ==","i=1; a=rsa-sha256; t=1776757224; cv=none;\n d=google.com; s=arc-20240605;\n b=SnJg91r8j1YW+kdXfW7a6Shv0S/D1dmRSUaTJBOfyFObGmg/Txt55rbiFxLST5hzv0\n F0dtJiZrK02sDmFd4KJF1r1IjgaMJB5TYD4cOzLicjybazER9h9LgtQ8rP4BakVkNH+p\n BPBCOGxkRP4y0Pj9xoiH+Jz+AJzUsySZ+ENeB6gDxTijjeO+9Hm8sFQo4lKa7jpzxoex\n Pxo5cAoYDAfKdDcDdLYCrRK9j+PviKk481QNnNAiuVF9KXnnAqaBsa3IOPL/EuYw9h2C\n uSigQibK6sTDyAf4+ZDFWqYSjdhTIwqOszf7Czr0eYr9i6nMjD55txslNXJam6jgvm87\n uG1Q=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776757228; c=relaxed/relaxed;\n\tbh=Bh0VOjbMhtH+2V4ttttWsNwgrNIKj1T3RMmt6G5B52U=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=IWjxAAFnsKqRGNw2HTwNH38VXWSjJjzSMVHTgXZGTPhqFrue3l39fZwDbUK/n5Vzx0lTGGDaa6w/ytIDkBXlMuaSX+k++rvQMlFNMxzFxBDc/WRxH/0R1UULR801rZAGs0Jb9uEn1T0OizsMyCvAe4Hpk2Eb32pkSTfiK+CR2y3xTs5yilVV2vO4IxxHZklIDoCFSzfynFDVEGq3rM+Ar18ZXZVmlNqhD/3ZwLHKDbaWI8/Ju09v1+XNnAOEjmiPYqApx5AYrponVV9gxangTa31bd/hjVDUsOGj650Li0l9qNxoYaghNFnnR9Fvxa/sJljrs4J+/qaspwFYraHfVA==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=Bh0VOjbMhtH+2V4ttttWsNwgrNIKj1T3RMmt6G5B52U=;\n fh=3MGGbV8ddC3XGfDmmFCRNXsYzZsetqo2C1+8T4Ncqds=;\n b=F01Siwbz3ezDccyL0EkjCiy8nu0C/swt13Mf/SsXJgxje2h0QBI7wMfESXOckxLRX1\n PrD+mAqve0vfIn5kg3jVphynIKHv3mgVzRDQv4Za7H70jvPL5zuFIHGfO07HmJjG3aSa\n 4vy4hyJ4eAgjT8Q509I6jg9VsVmorulG7ZAVLlL2q6+AxnOoAxfH7r6NNbysjjoPK1fG\n TDq6cgYFEauxudCCUo1be7wiij3gLuplxX3qZYH/v0cRFYC4uUNnDtCjoIWvBXQU/GDj\n 0Q+lmeDamTNFziRrIVEAABeTGmHBeli9IKf7STOZ/sQA6KHKG3/uEcGddWoC97/7DfjR\n i8bQ==;\n darn=lists.ozlabs.org"],"ARC-Authentication-Results":["i=2; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=HhqP6sBq; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::1035; helo=mail-pj1-x1035.google.com;\n envelope-from=shengjiu.wang@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776757224; x=1777362024;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Bh0VOjbMhtH+2V4ttttWsNwgrNIKj1T3RMmt6G5B52U=;\n b=HhqP6sBq6jwnIqeGX+gFsTcNPHjthNa+GaM3ZHa8MCVFarWdFa+BbJsHtnsbA+XAjR\n m+dI7kSNsEdYZsYEocP6PvaVKuZUkVTsnMpBJ8W+tHvvUMV84wGwJIq8HyBjlkNXDFFj\n F5w0s4597QashiFldGpxuUJjc/Oe8RvW1cDcYkvl9qt1uk/g2y5loSsZtyRPBX0CsB8r\n XivYUDwZJVFRZNEv2V1ntPilFq/iJYqXzdr/UOPsNTX6qyJmslssULirP7PzF0QG2Gmb\n GvHmPmpAZ1Zl0XyE2oNRC2OqLtiQuJXXkL2zgEm8VeQDwkgerdgA2tIo+AB4rizpvqyW\n MLQg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776757224; x=1777362024;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Bh0VOjbMhtH+2V4ttttWsNwgrNIKj1T3RMmt6G5B52U=;\n b=BP5JZnjeaD6DPuSIyWe6UY/kXlKTHSl6UN97bbhPUWoHuIYYtKPVFPbMt7B1ijs8rN\n roxYA9AHDOyIgZZHarDMoikdHLystugT7lXUCkhMxtC+10+WwL84Ap+0x4JbZ8Ogj3Dz\n kusGYyxpCJI7jftBx56lX8mhkeUaJ4jt4wGa2/Kh2Of/IWkuoLPRpG5RolSUotRR2mAF\n u/GO7fHBwebaNIrR8zAn3Sysl6Qsq5baUGE6xJxOCNqIMOt3C5I0/h+dBVGnnSm+EkEr\n WcJ8TdJ46Zf5qZHTY2hDbJdiY5IINkBAOTX/FnB+l2CkSYDFCYj3zwSS2XDU1WJ/ryKi\n Xl2Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+axod/qmt7DK9jQB+6LsKju22wEPjEISJoPZfLFajrL7e8qyCIizIsTYUAe7gwHKtz8qcDKyPWOyiCsPA=@lists.ozlabs.org","X-Gm-Message-State":"AOJu0YyT1E8WNDLHrz/V9LUVJda8Dk7FsC7cZdaHGTwzkV4r/WksSfTr\n\t8Mv2XSz+Dn39Xi306QX/kTUIhgV8WUGf+EJcnVXLy483lmpSS5RgjoxZhx8kqT0/lCkDXcF7hQb\n\tPjyw0DLg9z5BimrURk0KpdHpJmY/o4bs=","X-Gm-Gg":"AeBDietbGNNiQjZP8Iaj2HsUoTCc25DTuUwE+1bkPlYpV/NaPVwX7MvTtmR/F6adTXo\n\tTZNTj9oNWQ4IYPCRZ00dqEtS4hqfvtX9cMEvRsFBNTlJvS4aKbjviDSi6eKiop8qPNT5K4ywHvc\n\t4avlxnmKO6KTb59mxUsOESDBJ24Yh6rrlEXQs6pbsrFHgEtEr5fWyNd2+O+8yVpgk/DukrRD+/I\n\tIUbuLHImATOWvUjIW332XzD0cPxQula4UohVm6L+EqPjeH1OauqrNWzVBnCHPw9D5Qfj3eVGvdl\n\tmPJYXPzIcSBbvyDsBA==","X-Received":"by 2002:a17:90b:5288:b0:359:fe72:3559 with SMTP id\n 98e67ed59e1d1-3614048b1aemr21085898a91.21.1776757224448; Tue, 21 Apr 2026\n 00:40:24 -0700 (PDT)","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","References":"<20260420085344.2081805-1-shengjiu.wang@nxp.com>\n <6c6f94b1-a4fa-418a-b471-8e3c82305233@sirena.org.uk>","In-Reply-To":"<6c6f94b1-a4fa-418a-b471-8e3c82305233@sirena.org.uk>","From":"Shengjiu Wang ","Date":"Tue, 21 Apr 2026 15:40:12 +0800","X-Gm-Features":"AQROBzD1FwWrSiTcb4_TXXYBoiE2Up6O4dADIks7SRo1J0rNtrKh2cWtOkBvP_Y","Message-ID":"\n ","Subject":"Re: [PATCH] ASoC: fsl_micfil: Add DC output remover control","To":"Mark Brown ","Cc":"Shengjiu Wang , Xiubo.Lee@gmail.com,\n festevam@gmail.com,\n\tnicoleotsuka@gmail.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,\n\tlinux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Spam-Status":"No, score=-0.2 required=3.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3679874,"web_url":"http://patchwork.ozlabs.org/comment/3679874/","msgid":"<2b26c51c-d90b-4a47-99ca-652edd7f1f4e@sirena.org.uk>","date":"2026-04-21T13:00:56","subject":"Re: [PATCH] ASoC: fsl_micfil: Add DC output remover control","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Tue, Apr 21, 2026 at 03:40:12PM +0800, Shengjiu Wang wrote:\n> On Mon, Apr 20, 2026 at 8:50 PM Mark Brown wrote:\n\n> > > + /* Update DC Remover mode for all channels */\n> > > + ret = snd_soc_component_update_bits(comp, REG_MICFIL_DC_OUT_CTRL,\n> > > + MICFIL_DC_CTRL_CONFIG, reg_val);\n\n> > This will return 0 not 1 when the value changes, meaning event\n> > generation is missed. The mixer-test selftest should report this.\n\n> snd_soc_component_update_bits() will return 1 if the value is changed.\n> and the mixer-test pass\n\nAh, so it will - I'm used to the regmap one which doesn't do that and\ninstead has a separate function to get a bool back for changes. The\ncode is fine","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=b7oDuzYl;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19894-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=b7oDuzYl;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=broonie@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0MtG6Z0Hz1yGt\n\tfor ; Tue, 21 Apr 2026 23:01:10 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g0Mt862mjz2ySW;\n\tTue, 21 Apr 2026 23:01:04 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g0Mt74bXCz2xQB\n\tfor ; Tue, 21 Apr 2026 23:01:03 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id B22BF40B5A;\n\tTue, 21 Apr 2026 13:01:01 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7484BC2BCB0;\n\tTue, 21 Apr 2026 13:00:59 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776776464;\n\tcv=none;\n b=CBpL272oOIuthDtbayt+kdGGBDzbv2Jfap8cnXgxFKcEOe9+XbXkYHIbR4sQ7NsvW3Xv8aGBKwHGj5L0XRW/54kANP5IS0wvfZqAqJqQJtgUlwa3Bd0TTZJGnvgHUSweDnW61X5Hu/VLLZwRu9+bHIgsI5GV7SwU13xhvmfIuTdQLM2S1QAZWp059dP3eFRwTJVW/00Rh6wHMmeBocoVppsDLJ0NfLqvmrG6AAPYRgcSqGtRYB6JANMnoN1rd6E1Myb68+J4o8SVYo93Wp6HTPxrGc7hKkYMm7+TeTG9kB3W9oI1WN2+21bET/3XsH1DTeU/opRWjtE0HROFmApOhw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776776464; c=relaxed/relaxed;\n\tbh=lo0QBxTRUKOpgkoiN58ag+HBWtyMn+FDfg54Nuvii/M=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=AomelLnAgIGbfNocUwm52glDJBQamYhOBcfbj8acNqMc2egR5CY4aNkJPUp3Emu4EEPREXOfltFYE0E5buWcVh5yy794G/gaehlaWw5UPAIWGcPIpWIo1tuQZKBhU9oGXMvGqPwVZDqaNpljQGlOe8f+1YPk3jZsR4U4Ez+2jT67qBxy8i7be8uotgWST3OR45CHZgHYgndiROrz3pVIlNJKijfEJL2/X++kMBkWDc21DhCATieE5i6G7yfns1ebbFExdtE9URmbClzVrXuE6eS+Mif/dI9TqKvgWBTJeUaFeknSoyJafmNooTMTKPOMdcpLOXQ6wqPeVcG6jMrYdw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=b7oDuzYl; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=broonie@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776776461;\n\tbh=8r0ZFydET/AAmgi2IM70w+skNgAL6Sai3o0ra7HDchw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=b7oDuzYl6g7/X9Rlfy8hCFWbnBxptHemsqSWOeG95T0xf64RZKh9Z9UEFzgX08Ip4\n\t yHywN4KWWTFyTTxIpPIpj7JBl1Z0yEY4gXosqekCaLrybxRxwDGAvkS4SLJaC0xO17\n\t KsOIamAcNUuKj9HkUv8gGejSO1Ld30u3GjVKtgO3TxVCje36oKnePnzgoVYV/0GGtL\n\t xm7d2moJt31XHKwNxeb+bySQnJQHuLTclcvrr+Qd1cFCTuPK4gYcLscLs7MIAGhKVX\n\t f0RXacEl7JcMcI1uRNvK+j4QfSW5LJN42SX1X/htMYxByewVtDkPPVIcO7RkazKsKG\n\t p79g+a0dj25Sw==","Date":"Tue, 21 Apr 2026 14:00:56 +0100","From":"Mark Brown ","To":"Shengjiu Wang ","Cc":"Shengjiu Wang , Xiubo.Lee@gmail.com,\n\tfestevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com,\n\tperex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] ASoC: fsl_micfil: Add DC output remover control","Message-ID":"<2b26c51c-d90b-4a47-99ca-652edd7f1f4e@sirena.org.uk>","References":"<20260420085344.2081805-1-shengjiu.wang@nxp.com>\n <6c6f94b1-a4fa-418a-b471-8e3c82305233@sirena.org.uk>\n ","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"+1FrIIXGICkEe5jg\"","Content-Disposition":"inline","In-Reply-To":"\n ","X-Cookie":"Jenkinson's Law:","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]