[{"id":3679550,"web_url":"http://patchwork.ozlabs.org/comment/3679550/","msgid":"","list_archive_url":null,"date":"2026-04-20T19:34:33","subject":"Re: [PATCH 1/1] test: fit: Use shared make_fname from fit_util","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-20T07:48:05, Aristo Chen wrote:\n> test: fit: Use shared make_fname from fit_util\n>\n> test_fit.py declares a local make_fname closure that is byte-identical\n> to fit_util.make_fname. Drop the local copy and call the shared helper\n> at all seven call sites so there is one definition to maintain.\n>\n> No behavioural change. Both implementations return\n> os.path.join(ubman.config.build_dir, basename).\n>\n> Signed-off-by: Aristo Chen \n>\n> test/py/tests/test_fit.py | 24 +++++++-----------------\n> 1 file changed, 7 insertions(+), 17 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=Yptd92ow;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"Yptd92ow\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzwfz1Lpnz1yCv\n\tfor ; Tue, 21 Apr 2026 05:34:51 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 252CE8441A;\n\tMon, 20 Apr 2026 21:34:49 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id D1AC484419; Mon, 20 Apr 2026 21:34:48 +0200 (CEST)","from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com\n [IPv6:2a00:1450:4864:20::62b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id EC7B984376\n for ; Mon, 20 Apr 2026 21:34:46 +0200 (CEST)","by mail-ej1-x62b.google.com with SMTP id\n a640c23a62f3a-b9910707d82so532862966b.1\n for ; Mon, 20 Apr 2026 12:34:46 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776713686; cv=none;\n d=google.com; s=arc-20240605;\n b=RcuIJACvALsxDqvNBmxDAnnlV6hHfp9Get6/QTGivPonnKnUyftp3Yd9DiJ1IZmHmu\n 8J77M3LEJyrGkG9YZlHiGu9MgAbW+UZrXAIL0oS2XOLpgGGksEEkwI/uj90oBS1HApdb\n M5sJRO/grmKj+6+lOyTs0vHUnV3mEN+OUAADZ/sn6Idrn4k/wYMYpoKLrQZIifPalnXL\n 3iP7TeQzaEAs9b26ovfXuffXOiSDyEAhPRU4P8SgFNr6Y+kfLc3WaeTTKDXx11IulvZL\n U9vWdcAantrGz/D9MN6BQPnqgPXGqJAF5ym45fBFP0nQQN6L82vhuqIYi7PObdy+pcHZ\n 4vYg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=Me2apjqOYUAZyMPwT+AXD8o/0tr5hrLA4C42ylMR00Q=;\n fh=RMotW0d5XlV4ufFtnrZdzQ0yk4gZppNtVCUWCpNgShU=;\n b=QyvkZ9Z65Jlem8AoVK7gV7j0/BX6vfD3hnJF7y7xrfUfUWPzCZCH0mB1BjncGJEsGN\n RYN5ZIAby0ztExPimZ59U3DPPtSXbOtk5BeXzwXnXofSea+qUz6wx9iUwORunZat4U46\n xF/pfBiFVv25UFupqjVbqT9H65BIdSLum/X4KZmNdNbk8f/pUivAdD5t+o+xx1UeRltE\n Hz3hjHYpSZdn3a0D4sFDIQCYBw+Wf2Slmrq8fpa92F96w6oojhaBU1b0Y5Har9+RoXlS\n ccKebL2JiMbmZ3I8zPnt/4Z7egXj/GMw/RIEMi6D/xOz3AEuGbrtWksYiKalBln1rqaw\n OORA==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776713686; x=1777318486; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=Me2apjqOYUAZyMPwT+AXD8o/0tr5hrLA4C42ylMR00Q=;\n b=Yptd92owr6Q2XCKitVjhdHPI6jHDIVsDDvuSueLFschTJTh0pUbCFjvoq1PX6vBBSE\n EQksWquxTuajpSqEQ94a8TNm7JZ0FqxLAe4TaguwCHFjB3ivjaLAhwM3Jl608+lOsgPv\n B1eSAcc05afCHGRiMAmC8eOcQBoEBGSsnSFTE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776713686; x=1777318486;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Me2apjqOYUAZyMPwT+AXD8o/0tr5hrLA4C42ylMR00Q=;\n b=act58Y4aWl5qPKyEHYxVXqoq4Oy7S0eq/Xb5oVVzCpsVm0tIYRrBayN+8+eBm7j0UF\n huKdqwQwcIp0+QY3yXwZ+Kx5hNEd79tDA98lAKXEsIiyWsE8hwfkUoqVnzNnBRGQp2fO\n FIjDlVPCyUCqWehhgIgzRm4q9KxEGRHOMkB1GTsIA0KVW8XDBn75zfMyijizf7Qmk2+1\n o/0SvPEm1K949zZzaoYoX0zDBfoJIZo5scRoZE9ZYb6YFprzOSNlz227fluRR79onI2m\n zoQThlZQ/+1XSodLtfV9dIOdAPCkXZFgam3nRNGV/vFQfDFBxtSXv/xZx6Gur2iUhVc7\n cpKw==","X-Gm-Message-State":"AOJu0YwM6qlCOxsXkU5voAVqPYXwJk/ezb8GUlASZKeb1WklvMYtdzCk\n wtnIzUncVhDuu0YiygQtR/5GZSLGjdLvAgA33vpHS7rX3MeiTeAaeQRWvwtylplzyzp0Q1DP3yV\n rH2fQWvNU9ye6OXATDoJcWycokn9ATI/Wui3BJJY4BMFHyqmdkJ5SmA==","X-Gm-Gg":"AeBDietLktboXKQJh8brhNW6/jdXOsZKXFJOgLYvqnihq6AitZjugEVo+haH6Qfy1up\n i0CfQ0isFbfPH9WYexgXetoO5TNLOIeQdWNdJa8KLPVDeudftsrjULi3MBB/QcQ2ro/CQ0VrQyQ\n ATZI9f459xx8574wZffhHBvGE/dCMnwWGn5xPFlwNbivRTMsm/6gThLLSeFzV87COxyB09hpwdV\n j5v2FZfSUVyrptQi2EC+zthVchJgh7tSnuvY2wjKRPwkJCUKwbOegYI8rhIDEB17Qwnox/8f2vQ\n 8eUWVDyv9WF4IQOA9i1wu1T76zO72eU=","X-Received":"by 2002:a17:907:608e:b0:ba5:95b1:f152 with SMTP id\n a640c23a62f3a-ba595b1f822mr487432266b.0.1776713686444; Mon, 20 Apr 2026\n 12:34:46 -0700 (PDT)","MIME-Version":"1.0","References":"<20260420074827.3917463-1-aristo.chen@canonical.com>","In-Reply-To":"<20260420074827.3917463-1-aristo.chen@canonical.com>","From":"Simon Glass ","Date":"Tue, 21 Apr 2026 07:34:33 +1200","X-Gm-Features":"AQROBzDZpwr6J5_w3tPvGf63owq5kds3LAcLhsulhOrfypB-kugJbr2NuBPbtBM","Message-ID":"\n ","Subject":"Re: [PATCH 1/1] test: fit: Use shared make_fname from fit_util","To":"aristo.chen@canonical.com","Cc":"u-boot@lists.denx.de, Tom Rini ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]