[{"id":3679549,"web_url":"http://patchwork.ozlabs.org/comment/3679549/","msgid":"","list_archive_url":null,"date":"2026-04-20T19:34:10","subject":"Re: [PATCH] efi_loader: expand disk device names with drive details","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-20T07:28:41, Padmarao Begari wrote:\n> efi_loader: expand disk device names with drive details\n>\n> Increase the boot menu device name buffer so we can append extra\n> metadata. Append the disk capacity and trimmed vendor/product strings\n> to the device name so users can differentiate drives in the EFI boot\n> menu. Also tighten the parameter validation and pull in linux/string.h\n> for strl* helpers.\n>\n> For example, the U-Boot boot menu now shows entries such as:\n>\n> usb 0 (29.7 GiB, Generic Ultra HS-COMBO)\n> usb 1 (28.6 GiB, USB SanDisk 3.2Gen1)\n> scsi 0 (1 GiB, MICRON MT064GBCAV1U31AA)\n>\n> Signed-off-by: Padmarao Begari \n>\n> include/efi_loader.h | 2 +-\n> lib/efi_loader/efi_disk.c | 86 +++++++++++++++++++++++++++++++++++++++++++++--\n> 2 files changed, 85 insertions(+), 3 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=Qld1EuZm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"Qld1EuZm\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzwfY5CZ6z1yCv\n\tfor ; Tue, 21 Apr 2026 05:34:29 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 9FA18843FB;\n\tMon, 20 Apr 2026 21:34:27 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 6F5B4843FF; Mon, 20 Apr 2026 21:34:26 +0200 (CEST)","from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com\n [IPv6:2a00:1450:4864:20::62f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 894FE84376\n for ; Mon, 20 Apr 2026 21:34:24 +0200 (CEST)","by mail-ej1-x62f.google.com with SMTP id\n a640c23a62f3a-ba92146cc86so76204266b.1\n for ; Mon, 20 Apr 2026 12:34:24 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776713664; cv=none;\n d=google.com; s=arc-20240605;\n b=kqVuaFxVeOwKJNfGs2Cy8sEulntuZyJkE6XS14nLSwBgK8Ykl9l42I3/eaPHrahs9x\n 50CfHAUzPm1JCugB8+mjXGm2i1WYdYDj1WmwPDhM1oI24Uhj4aLMglpexyv2J1YBOCTb\n xVqtfSL+ly/IhMTpLc/lfx2R9+FWyY2UmsfuwZWs7ukf0geRvvKN4xq73YloSXU72uCR\n yzWczoT4XdudIaHsXTAkjO5f94gqwyoD7nhAoQD3VvAz6BBHel5w9B4sOVF6H6kzRqu1\n xNUH4uk7Xf2LtQtqrIeB8ymFW9MGQn6RwpRsFv9/kT942FYvwVgiuVUuy206M2sYlB/S\n TUXg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=qcxhFtN1vj6SttfNha2T6o2U5kluRFpNFuDkBx3ZgJ8=;\n fh=udYPg2+gcJSgNZwfCxxvl5AGPDvYxuycLRmb6JwDAjA=;\n b=WMQzU/sgw18JQhX4lq8bTyipYJEgJ3FMPFfEu1xlmgJv5oWYaAKZu4IEDauPuqFSha\n UPIHfpaJp+kIdCxfD+zptfahqI8BsVTzxKhwVOKuBAE6vZIhUSkjAXMT2B3bY03Qqx4T\n /71bC1zhoAdh1+wUhw+gQV+LWq23WgfDppWCdOq07PggLs2mRs3IO6NskEoEDDCLxT79\n 7e9Zmd46Y2nsE0ivX5Z6xd9JOYroNsI/WegrbQ9XyQouftdOKc2OsHXIhiKFpCW3A5Q5\n +shKrS0M3p9q6ujNa8EGSm8Tj7oU1YSYn9ah0kidOs7WTEWnXn1oGZlRqDSifg+JAW/v\n gLDA==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776713664; x=1777318464; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=qcxhFtN1vj6SttfNha2T6o2U5kluRFpNFuDkBx3ZgJ8=;\n b=Qld1EuZm26HkLcbpUESzdhPm/GZd56YlLCEJ6Co2qcnFoUY3fN0E6r8FaUVwtJ3/Q9\n fr00bkQzVpe92ftU0jRETjYzVPqtp9WeOiUxRr2NBOzpP9nAdyPzW9F3ATB96bcPyTt2\n xGUE9i4kh5SfQxO2SvHocv0IrJWkLG48+ERJI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776713664; x=1777318464;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=qcxhFtN1vj6SttfNha2T6o2U5kluRFpNFuDkBx3ZgJ8=;\n b=Mj3zbfaNVbjGLM9bswKdiLJnbhtpTZQcw1p8OBBSD5eVuYy/UYWzdnGbdR4eL1IgmG\n JYcX4CeApcMFxBa4OUIjwXU9QW6VBRo63iKExBbDOQTrI/lJQIo5FATvs8+TyuYoCKZE\n Y/HvSbaegHB5QDb4o0Oq4bzvb6K7fDklMHtghBGtUS+5F5gWrIkEz/lEu3Tyx3NwqHOJ\n crnBQfO4clHSFAkAGV9ZTQ4hsGObS7BdBDRhzNGFkgmDIl8osFQDdZllehgyzqoF3EAO\n /E+FxinHJnpVga3eKl4VaPUeJYnRlT/43BqOOrIhlWVmoSf0i8+vnw6ukMw6haa/IM7A\n ePyw==","X-Gm-Message-State":"AOJu0Ywt9KqQ3uiD7pSPAz6ieO8kpKYNPorS6CLzH62Ed46kckBwFsux\n 5pRPmPue/Z9q8vov9upi+BX56gKA5MtZz7rQL6Vdb7/yeLsLtQk+g7XecCZ0MWaDyDEDTHaEorT\n a7KKl0GxsiBGmlRuSNSSLkzmLJYFYaFTt300qXjm+","X-Gm-Gg":"AeBDievNFsFuuud/eFNCxCokeQVVc2SjRYmaAitMyAf7K10wc8iaWFHby7wl77EPf/Y\n gieJqeQDkMj194l4jIisEFFIdZ97t70NKhepmHA9XJv7bQti8fCZFC6+pNMLXLA5y9j+agYqWdk\n qsT/p1qzjLrmA6YVvdMCvZcavWlIzJ2nbPmQL7IB95L7qlE2ZRrcfmzVpL6BTInyjcVmNlyFqJY\n aPkr0Z2eOx8Nvy5UkAwqgj+Uwkh0iUk+ZLVZnG2AOn7rW1aXMFkg352Q8+Zad9gh1QSvcb++5xG\n EoBPknuVDjHU1EKuyxAV","X-Received":"by 2002:a17:907:2d0d:b0:ba5:dfa6:1e8e with SMTP id\n a640c23a62f3a-ba5dfa624e3mr518461466b.5.1776713663987; Mon, 20 Apr 2026\n 12:34:23 -0700 (PDT)","MIME-Version":"1.0","References":"<20260420072935.3024696-1-padmarao.begari@amd.com>","In-Reply-To":"<20260420072935.3024696-1-padmarao.begari@amd.com>","From":"Simon Glass ","Date":"Tue, 21 Apr 2026 07:34:10 +1200","X-Gm-Features":"AQROBzDhPZPqYfEVnEN81_dgO-h14KVnXTkv_6dt7xdFi2Cd1xxmz-o21jWRzLw","Message-ID":"\n ","Subject":"Re: [PATCH] efi_loader: expand disk device names with drive details","To":"padmarao.begari@amd.com","Cc":"u-boot@lists.denx.de, michal.simek@amd.com","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]