[{"id":3679821,"web_url":"http://patchwork.ozlabs.org/comment/3679821/","msgid":"","list_archive_url":null,"date":"2026-04-21T11:21:36","subject":"Re: [PATCH] rtc: ab8500: replace sprintf() with sysfs_emit()","submitter":{"id":92050,"url":"http://patchwork.ozlabs.org/api/people/92050/","name":"Linus Walleij","email":"linusw@kernel.org"},"content":"On Mon, Apr 20, 2026 at 12:36 AM Maxwell Doose wrote:\n\n> This patch replaces sprintf() with sysfs_emit() to ensure proper\n> bounds checking. It also simplifies the return logic by directly\n> returning the error after logging, instead of logging, calling\n> sprintf(), then returning.\n>\n> Signed-off-by: Maxwell Doose \n\nReviewed-by: Linus Walleij \n\nYours,\nLinus Walleij","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=eCWAgGob;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6390-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"eCWAgGob\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0Kgr0zqPz1yCv\n\tfor ; Tue, 21 Apr 2026 21:22:00 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 77B5C302B83A\n\tfor ; Tue, 21 Apr 2026 11:21:52 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 634563BD648;\n\tTue, 21 Apr 2026 11:21:51 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FED13B95E0\n\tfor ; Tue, 21 Apr 2026 11:21:51 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id F2371C2BCB8\n\tfor ; Tue, 21 Apr 2026 11:21:50 +0000 (UTC)","by mail-lf1-f49.google.com with SMTP id\n 2adb3069b0e04-5a62a049c1fso1099555e87.3\n for ; Tue, 21 Apr 2026 04:21:50 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776770511; cv=none;\n b=rpj1pv+CqLX0W4Y7BJkL1UHAa0PR2Qc1xrPeHdmXOWdA1t3LLAmot/HyoqGndaGBhnplj+yidb3oYlBIJv1j1uujZri43HVQbDhobuq6rS7fyzct8Z36BD1vy9sj0OdvyqVfO8RwKEl+446WOgst22a6z5NJfdIer6VNM07MPhs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776770511; c=relaxed/simple;\n\tbh=9s8/6CxAimRxSBzycRWJAays1e9oC2blAl7hbQ4gthM=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=NZH0yx5YFieqJRI436WkBg6oZGUJzKBCNDqGXpF53FT1oOuRMJPDY5gm0s+2yjqG0LEI3zqsYp8r48H4WvwqeDZjcSTP+RMSIcTXKfexEpk3FHT5JDKGrlKrSRApfCX/s2TJxUKH9WfLxjNtVym2JXQRDPlaTsCezyMl9C2SOis=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=eCWAgGob; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776770511;\n\tbh=9s8/6CxAimRxSBzycRWJAays1e9oC2blAl7hbQ4gthM=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=eCWAgGob4ru5rmVKZXHGN1rgp4N4E29mvj8oML1mkerMFOyh/gje8QrwIPevd7vxh\n\t vRyyOiOAGniq0SdA9lhCW95uraysEJunixqCPH6i3gPPCNtudkbd+AKlhWVt1LE616\n\t vrab/W6qIPVIeuh4KXr/Yugar73d23YBT10dmiCff+Zq1RmFH/OGCJxiQVEbLxYzie\n\t /nHUA5tR+n5tDuSzj1eA0BpmSXywBt+WH6LE6v5goohNVANcRvVYaaL6EDPjGP5Yd7\n\t p8+YzHXHEHrtYUdAAIMQMQxcJCEFtrp/a1fapgaiH61szJhKXLWAHbjfvT6wJacelC\n\t 2jwlsNFOU7iCg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9pxIoGHvxD5RQxY/tzzzxUQIP0sPMBsUxMWUUvHV8Ljoe5LIEn0usEGbtFoNgPE+jSSBsSyY8JZf4=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yx55Q9+DE6s0nmLEQH5BNbxC/1BSrFwSM0mVJjqTkzjRFwa2lBS\n\tra8t9ZfnCx1frEre/WTmLVJphuflIo9imIWCi3wofG7euLCGTemxHSzfz+uWBXV6+8sNKCpYEmS\n\tMi4xq7fAHaUpZvAbhlPnq7I1X1QuKr6c=","X-Received":"by 2002:a05:6512:1285:b0:5a1:33b6:2b6d with SMTP id\n 2adb3069b0e04-5a4172c590dmr7176236e87.14.1776770509364; Tue, 21 Apr 2026\n 04:21:49 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260419223630.67644-1-m32285159@gmail.com>","In-Reply-To":"<20260419223630.67644-1-m32285159@gmail.com>","From":"Linus Walleij ","Date":"Tue, 21 Apr 2026 13:21:36 +0200","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzD3vULz9bpY6-B9483r_xgyXE67qFa2sjkZj_vQ2SieZ3MVsEEIVSb4PuE","Message-ID":"\n ","Subject":"Re: [PATCH] rtc: ab8500: replace sprintf() with sysfs_emit()","To":"Maxwell Doose ","Cc":"alexandre.belloni@bootlin.com, linux-arm-kernel@lists.infradead.org,\n\tlinux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]