[{"id":3679571,"web_url":"http://patchwork.ozlabs.org/comment/3679571/","msgid":"","list_archive_url":null,"date":"2026-04-20T20:12:55","subject":"Re: [PATCH] hw/i386: Use qemu_open_old for kernel/initrd","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"Hi,\n\nOn 19/4/26 21:35, Sertonix wrote:\n> \n> Allows using \"-kernel /dev/fdset/0\" and \"-initrd /dev/fdset/1\" (if the\n> file descriptors are opened read-only).\n> \n> For the sake of consistency it would be best to do the same change in\n> the other hw/* subdirectories as well but I lack the means to test all\n> of them.\n\nThanks for this patch. Note however there is a comment before\nthe qemu_open_old() declaration in \"qemu/osdep.h\":\n\n /*\n * Don't introduce new usage of this function, prefer the following\n * qemu_open/qemu_create that take an \"Error **errp\"\n */\n\nDo you mind using the latter in your patch?\n\nThanks,\n\nPhil.\n\n> ---\n> hw/i386/x86-common.c | 13 +++++++++----\n> 1 file changed, 9 insertions(+), 4 deletions(-)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=qAmfYeFt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzxWc2mc1z1yHB\n\tfor ; Tue, 21 Apr 2026 06:13:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEuzP-0003gH-MX; Mon, 20 Apr 2026 16:13:03 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wEuzN-0003g3-3d\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:13:01 -0400","from mail-wm1-x335.google.com ([2a00:1450:4864:20::335])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wEuzL-0004Bf-Eb\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:13:00 -0400","by mail-wm1-x335.google.com with SMTP id\n 5b1f17b1804b1-488ff90d6c7so25780905e9.2\n for ; Mon, 20 Apr 2026 13:12:58 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4891bb3d121sm180944575e9.14.2026.04.20.13.12.56\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 20 Apr 2026 13:12:56 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776715978; x=1777320778; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=SYVYGLv+vwoNpHesJVFj33FWrAlNal7SsLu4kzVmOaA=;\n b=qAmfYeFt39dYsUwCB1eL/rReIo9HDsrHswO+otXei2m75ExHTmI1UoqB955jVetosm\n Nol/+hWpVbsfu6MNk3VyvwThGf59NOfYyecTS6b/uZaY5hPR5VmBfNkZ70myYXAubKlS\n rC1B2GW8T+UO2jqHXQfXL14UYrmh+u/+/EavLzHDMXKc0CihW+l+ibM9avcSFo8q5J4F\n twSCGs+7MPU6N2/WIc/Flk/Xvjn6bvqNAZnr0Vj3Pso1kYG+2nOR7dVv7ztb5JZluIND\n uPmkhZkN9AV7IL4L16eN3+Po+6xR0em6Gc5qNivoo9Tq/79G7obtPKSy9kSCuQ1RPtbw\n 0TZw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776715978; x=1777320778;\n h=content-transfer-encoding:in-reply-to:from:references:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=SYVYGLv+vwoNpHesJVFj33FWrAlNal7SsLu4kzVmOaA=;\n b=mRj3q9Utt7D0S6zdgVu5oQ8Edk+c5Dg0sv924x+QSx8VRz5PEAwirCY7FlxDdwEacx\n G/8OPoJzWpOMV4Z0Siry7e5CL9T3Yi4TOATidVwYzhQPsChV7Pbrz95DJk/rZ1h763TK\n y8Gx0ZoT73eXuxCdWbKlWM7pY4F3I+3mPIOErlWu5VUECwNEqFnppt7421T+acuyo0zr\n ZDkHiBH29VqeNCqcI7rvRFGgY4tdpxQDtyr3vY+0SH12F12npVow8Onp50x+Efw7E1wM\n bWpll1RITBexKNw0CjC9F8Ri24BtORj9GBPKuGrCVuHOq0FaUHzacsxwuNvNutLhK2Lo\n ob8w==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+hpItrBTYudh0JZ6fVpnGqpZduz8blMGVIndfeRm1Mxkp8aCjBLitQus8VUQ2bBJS+ak8X0xEbDx9F@nongnu.org","X-Gm-Message-State":"AOJu0Yz2EjqNfPGZUWnHRv2JZ5X75HinjUYTWRV3swRmZpeI8BT5bAEa\n vOjAz7sDudnyjSpxh5BliXZlXTJk8W4UN3uzG03qHNMSTAFe4oAY8nR8q4lwVxhF2+Y=","X-Gm-Gg":"AeBDievD6aQT3Ti7lY5Lr3bl2HHCVuwDgEm3Ij5jaRGHyjRL4kKyqmhyTlaZROE5+qY\n CcrsnZdg6d9ssOBAX9i8xOXotBXMjLmiamCpxrtw3U+TIcDgf5fZbVQWJKJA+CRaMRmCK1X5xCg\n Jf2ZnlYj/EtW+DLjH3bMGCEoWZ/VMVam91UsN9HDHxaLZHSEZLtO64ogvZ1U9OnJ0TFKxEI8E3i\n Ozo+haYonAyswWdRkyfXnzNrcZHyRq2ddsRtpwL+FMSrV+B3eFd5uGkfwfgo7t1VpBWVWyxlh9C\n w6ALJB5231ATblQV5F9vrUFpETMOAjEGSMd1d9dr220EXs6Yd1mk3msVZ2kQWuUDkV9YKWcSfBg\n 1iHv2db9moJQMAqiSFIgbhooSjEHG/22sj+Tz+KG4SpQlKH1AqWkZkXAsgxyY0iYZEZmFpMCtnF\n u2qhV+qrHirnrYVpkeUmR/41lPUH2DJaXdWLo+eHeojOgKOMwtqzOVDbHV0UsYkGfT6DGYZ/IYw\n 7UiFlz+5Lly7qE=","X-Received":"by 2002:a05:600c:8a08:b0:488:a82f:bb9b with SMTP id\n 5b1f17b1804b1-488ff369a1cmr140807235e9.30.1776715977582;\n Mon, 20 Apr 2026 13:12:57 -0700 (PDT)","Message-ID":"","Date":"Mon, 20 Apr 2026 22:12:55 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] hw/i386: Use qemu_open_old for kernel/initrd","Content-Language":"en-US","To":"Sertonix , qemu-devel@nongnu.org","References":"","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::335;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]