[{"id":3679170,"web_url":"http://patchwork.ozlabs.org/comment/3679170/","msgid":"","list_archive_url":null,"date":"2026-04-20T01:28:36","subject":"Re: [PATCH 2/2] ksmbd: destroy async_ida in ksmbd_conn_free()","submitter":{"id":79386,"url":"http://patchwork.ozlabs.org/api/people/79386/","name":"Namjae Jeon","email":"linkinjeon@kernel.org"},"content":"On Sun, Apr 19, 2026 at 8:03 PM DaeMyung Kang wrote:\n>\n> When per-connection async_ida was converted from a dynamically\n> allocated ksmbd_ida to an embedded struct ida, ksmbd_ida_free() was\n> removed from the connection teardown path but no matching\n> ida_destroy() was added. The connection is therefore freed with the\n> IDA's backing xarray still intact.\n>\n> The kernel IDA API expects ida_init() and ida_destroy() to be paired\n> over an object's lifetime, so add the missing cleanup before the\n> connection is freed.\n>\n> No leak has been observed in testing; this is a pairing fix to match\n> the IDA lifetime rules, not a response to a reproduced regression.\n>\n> Fixes: d40012a83f87 (\"cifsd: declare ida statically\")\n> Signed-off-by: DaeMyung Kang \nApplied it to #ksmbd-for-next-next.\nThanks!","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=E9Gs4DMe;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10921-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"E9Gs4DMe\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzSZ16CzMz1yCv\n\tfor ; Mon, 20 Apr 2026 11:28:57 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id BF134300D466\n\tfor ; Mon, 20 Apr 2026 01:28:50 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8599031AABF;\n\tMon, 20 Apr 2026 01:28:50 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 506B233E34E\n\tfor ; Mon, 20 Apr 2026 01:28:50 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id DCF39C2BCAF\n\tfor ; Mon, 20 Apr 2026 01:28:49 +0000 (UTC)","by mail-ed1-f52.google.com with SMTP id\n 4fb4d7f45d1cf-6714f678bdaso4147857a12.3\n for ;\n Sun, 19 Apr 2026 18:28:49 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776648530; cv=none;\n b=sRzTtRbxNgaGkYpgdPMXJnrYumSa7FMQbUPQAUFZzYCEAgibQtxJoYXFZ7yearCwuJ5XW3bCC0eYK1O0GXqJIyNe7CHmzCW6mrQD49dqsOINnaIhtqtN4wDJP36HzqEwuZGWeOmHGPwpFcNMZM5WHDQ+ueQGayrAMnkPaiymbHI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776648530; c=relaxed/simple;\n\tbh=nDhqbfnQUsARKZvjBJ06Bn0aF5eFj/S58zIRRm3ouMw=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=QdTLgkMT918vH0CEyAlEXTEXpaUuFYxsifa9l1SZf+MBB7txK+VvT8uuXUfjVRawbzYN98We3ndOyZ2cw43Fh+Tue7P6V3BXcoYK7e8v+eNIo202L90Sa6MVPBV+evfXqkuZPtXKm2PWQLzXknfdo+oZywB7viTMBPO06fg1Ess=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=E9Gs4DMe; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776648529;\n\tbh=nDhqbfnQUsARKZvjBJ06Bn0aF5eFj/S58zIRRm3ouMw=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=E9Gs4DMeM0hQsvR94K4JXZ2BQ405+2M14/OM6pFDksI9jzzx0fIfoukdRHncdI8Ic\n\t qCMVa2QqEMndbjcbwdDLih6+mhneIHFLr69TEgW3vzy5IkNqI1a1LvG3FwRiZu/MfU\n\t nP2Ci1lXpmi2A4sNH0hTqTQe5ZDd6pCN5f0+QLBOVFWeQXacnTxsVRoWqrqLohmAn2\n\t kIATwhYUz6+Q2GEHp+M9i9x9rzf4AXaOWzOb7V2iBMimIczpddj+Xrf7VPiziJ1DLS\n\t RNtcDZKrTs5xATXOe4yXg7wbjqCYYmjtAL5D8uyBi0lb2McHLU4ficj7U4xS2flZ9u\n\t dy3hyqtZ8zIrA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+oIImuvmBetwfew6bgEPeqFzhPnCVkrDKFD1BvbyyvR8wYb9wJNVf7ythEe4mqN4bwbgOQOn9uWljH@vger.kernel.org","X-Gm-Message-State":"AOJu0YyAIiqcWasKHHSgNzwQ0/NM+yolqovcc9tzPQ6ZiBls5QnCkhEF\n\t5zSjSUfOQTb+xs3BVYN1suswKHLhMrLfKz+WZzM7LQN60QY6yCOOdRd9GUJ2zslMBhduSad+sty\n\tZOC+llaYGAHCT1Ui538gBb4lrFEc4fzw=","X-Received":"by 2002:a05:6402:e9c:b0:672:7109:61a0 with SMTP id\n 4fb4d7f45d1cf-672bfd975e5mr4199192a12.9.1776648528446; Sun, 19 Apr 2026\n 18:28:48 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260419110255.2477785-1-charsyam@gmail.com>\n <20260419110255.2477785-3-charsyam@gmail.com>","In-Reply-To":"<20260419110255.2477785-3-charsyam@gmail.com>","From":"Namjae Jeon ","Date":"Mon, 20 Apr 2026 10:28:36 +0900","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzCKD2uY6PElWh-wRWg1jsPlD_DcAfDDNFA_Rn2WTrrhEHTNBWPQFpMqBYU","Message-ID":"\n ","Subject":"Re: [PATCH 2/2] ksmbd: destroy async_ida in ksmbd_conn_free()","To":"DaeMyung Kang ","Cc":"Steve French ,\n Sergey Senozhatsky ,\n\tTom Talpey , linux-cifs@vger.kernel.org,\n linux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]