[{"id":3679164,"web_url":"http://patchwork.ozlabs.org/comment/3679164/","msgid":"","list_archive_url":null,"date":"2026-04-20T01:18:16","subject":"Re: [PATCH v3 5/5] test: dm: Add partition type GUID lookup test","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Balaji,\n\nOn 2026-04-19T10:24:02, Balaji Selvanathan\n wrote:\n> test: dm: Add partition type GUID lookup test\n>\n> Add a unit test for the partition type GUID lookup functionality. The\n> test verifies that partitions can be correctly identified by their type\n> GUID, specifically testing the ChromeOS kernel partition lookup.\n>\n> Signed-off-by: Balaji Selvanathan \n>\n> test/dm/part.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 48 insertions(+)\n\n> diff --git a/test/dm/part.c b/test/dm/part.c\n> @@ -195,3 +199,47 @@ static int dm_test_part_get_info_by_type(struct unit_test_state *uts)\n> + if (!IS_ENABLED(CONFIG_PARTITION_TYPE_GUID))\n> + return -EOPNOTSUPP;\n\nPlease can you return -EAGAIN instead? The test framework uses -EAGAIN\nto indicate a test should be skipped (see test-main.c lines 486 and\n492). Returning -EOPNOTSUPP will cause the test to fail rather than\nskip when the config is not enabled.\n\n> diff --git a/test/dm/part.c b/test/dm/part.c\n> @@ -195,3 +199,47 @@ static int dm_test_part_get_info_by_type(struct unit_test_state *uts)\n> + partnum = part_get_info_by_type_guid(desc,\n> + \"FE3A2A5D-4F32-41A7-B725-ACCC3285A309\",\n> + &info);\n> + ut_assert(partnum > 0);\n\nHow about ut_asserteq(2, partnum) here, since the first ChromeOS\nkernel partition (KERN_A) is at partition 2 in the test image. This\nmakes the test more precise and would catch regressions if the search\norder changes. Alternatively, you could verify the partition name\nusing:\n\nut_asserteq_str(\"KERN_A\", info.name)\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=UGFBjEPA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"UGFBjEPA\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzSL80V5Pz1yGs\n\tfor ; Mon, 20 Apr 2026 11:18:40 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 08DF680433;\n\tMon, 20 Apr 2026 03:18:38 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 12DEF80433; Mon, 20 Apr 2026 03:18:37 +0200 (CEST)","from mail-pf1-x434.google.com (mail-pf1-x434.google.com\n [IPv6:2607:f8b0:4864:20::434])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D592B80087\n for ; Mon, 20 Apr 2026 03:18:34 +0200 (CEST)","by mail-pf1-x434.google.com with SMTP id\n d2e1a72fcca58-82f4a53ae20so1887636b3a.3\n for ; Sun, 19 Apr 2026 18:18:34 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776647913; cv=none;\n d=google.com; s=arc-20240605;\n b=GOxPWfgBcgq7rr+x4QtUXIlK2GDgM1o7KYCAjp2Z0anWBRkX9cOjlcrLlzeOGxJSJX\n FxwAhuAF6hWut+Z8u9qQnLHGjx8GA1BBSnbOO6ca9OY4MGKUi9mv5vQ5jvl/G4zF8URJ\n dToyq1VAVhu4bsQYx2iSNgMhi9EF69PaGbqAL2i3z+zeQbR1gtbBCklgMjhApkjH/Zym\n RWqacBl8892UF+zHdxJdQzwHsvN8LC+IpOrPrNuxQTc6jX/dW99odKpkUIylMBNebKWl\n hmu+A8JcWO+6F3TgvpCmQiHlpuYD7w3h+Zftx58AjSmKV9sMBTUDQ4nPjGeiCc1EE9ve\n FoqQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=TdRDuPNZhQLd9WBITx+MdRktaZTgJPHvKKuzARZYYjU=;\n fh=S8xjaNhDK5zkqclbPZi4D14oajyF+NpuR2kRzRAZ3EE=;\n b=MoB5LquYzUt7D/3MRwAmzHnkBDV6VdAfx9pO48NJcztjjhg50Mvn4I4KqGbdN4lMRI\n HPaNPQUL0fcmH0Cj2t0E5bL6T7oTg/QqhfW64L2U1gROzQYQejk/NyXLdRlNMd3bnfGK\n b3r3xSK2M6OXXO5pNiKEcckENo9fJG8Nkdg8X22CUE751dFOxnmTpooNnhHdF9Ca3m5s\n cgVuAEvWCHJSnzopWcWmVoElsjaMMU67xMKqklkxUxiOfwPq/HKbM11RKEmc6OSABYLY\n Hi0xibGxg5B0QKLOXEuk9enjExnlzraq0ieRXDYHKiH/dPLdD8h66kDqBj+EmiG9qdpZ\n aDxg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776647913; x=1777252713; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=TdRDuPNZhQLd9WBITx+MdRktaZTgJPHvKKuzARZYYjU=;\n b=UGFBjEPA+cqWlAZFzfwCKWhtKpldyU4jPUKtE5rKpZTgkq0EPvGHR5VzYTGq85VY85\n gZn8qe4md6/JLm9gTHoZb0ZINsAH0FcWKLfWOlnNon4CadHmBau4kKZFa9DKNlGls4CR\n exytrIN+kKz38qFP/wllywNeUuzX/TsYM2zaE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776647913; x=1777252713;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TdRDuPNZhQLd9WBITx+MdRktaZTgJPHvKKuzARZYYjU=;\n b=rVoywezRABtx0wWB3+46eygk9ol1dSBfyJhejuuPB2dwQlirL/INAOQ1wBjF1/HE4z\n EOEqwOlk+kGEstOQn1FgER5dn/iw1YF3Z3N6kVgVMLrBCDcQy1i0Y2FrbkGCJMzv9W8H\n YsiBdhA+RWVdRrZS74+MF5vgirQH5PcBbNJDIh+YfypdoDQuRuLXTRhVEAgIn265Tq4S\n 7rXeEqolDQl+1qeme6hGvkHcYipAs9Tpxfzllw8KdNs4bG6YuQMacE03wKHpqryIUASM\n Tra04CGwS/RB+nOB+DYOlW1XO7FBPQ4PDJRObKo8Aw3VkpYlRJd6h713FUpxXHE5qFgb\n TtOA==","X-Gm-Message-State":"AOJu0YzVg/mY4ZBrDKjQxQ01lAn72Hb9thA4Gu/mc2XOLNt1LSWpop9U\n BF0x3XRlOfoptM8cjaE+uJXPbYyUE3YnLndujTSZH4davlfJ7Otc9zr2wG/J1SDMcjVqbFXmOyY\n QtigmS0dLLSCPhF61UqM5eDBAQcCFYDpt5qViOQpR","X-Gm-Gg":"AeBDieufNt11xuNoI2YSyDJtJ+of+SO9yDkqRyNDvfU7R7/bSx2+DqSR9M+eRcgDH4a\n fTVUuO++1E7GaXubU0AaGol03YZ/RF/b+3pzQIEaKk6HajWLx5nC0GOO/QUbnyH8dRzZI1neAuE\n bTJ4jV5lBwZmz/8ONUm1Vm8ykcZQz7PpWMf9oWJZfWcMwghvQTs9S4Xg8DA/4iNIcxV9lRQQC8a\n ELpS6Oq+HDPsbtOvToQ5Zt+X0W7KrOmZnwTM6E9sF64xTpSWb5fz3pF+GvQq+h3HodV38FVYX4B\n 0VG++o4y803whq+4SGtj","X-Received":"by 2002:a05:6a00:2ea8:b0:82d:603f:f3a with SMTP id\n d2e1a72fcca58-82f8c8c7bcfmr11624971b3a.24.1776647913317; Sun, 19 Apr 2026\n 18:18:33 -0700 (PDT)","MIME-Version":"1.0","References":"<20260419-type-v3-0-ec49acd6870e@oss.qualcomm.com>\n <20260419-type-v3-5-ec49acd6870e@oss.qualcomm.com>","In-Reply-To":"<20260419-type-v3-5-ec49acd6870e@oss.qualcomm.com>","From":"Simon Glass ","Date":"Mon, 20 Apr 2026 13:18:16 +1200","X-Gm-Features":"AQROBzCVyEUNC6cb_0hAqao65PDAT6kKBtXTil08UgkfZ5i4sTkUjJD9vyJmjeg","Message-ID":"\n ","Subject":"Re: [PATCH v3 5/5] test: dm: Add partition type GUID lookup test","To":"balaji.selvanathan@oss.qualcomm.com","Cc":"u-boot@lists.denx.de, Sumit Garg ,\n u-boot-qcom@groups.io, Tom Rini ,\n Quentin Schulz ,\n Ilias Apalodimas ,\n Javier Tia ,\n Varadarajan Narayanan ,\n Rasmus Villemoes ,\n Mikhail Kshevetskiy ,\n Javier Martinez Canillas ,\n Miquel Raynal ,\n =?utf-8?q?Jo=C3=A3o_Marcos_Costa?= ,\n Tien Fong Chee ,\n Richard Genoud ,\n Jan Kiszka , David Lechner ,\n Casey Connolly ,\n Simon Glass ,\n Marek Vasut ,\n Christian Marangi , Michael Walle ,\n Sumit Garg ,\n Neil Armstrong ,\n Aswin Murugan ,\n Varadarajan Narayanan ,\n Simon Glass ,\n Mattijs Korpershoek ,\n Jerome Forissier ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]