[{"id":3679163,"web_url":"http://patchwork.ozlabs.org/comment/3679163/","msgid":"","list_archive_url":null,"date":"2026-04-20T01:18:04","subject":"Re: [PATCH v3 3/5] env: scsi: Add support for partition type GUID\n based environment","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Balaji,\n\nOn 2026-04-19T10:24:02, Balaji Selvanathan\n wrote:\n> env: scsi: Add support for partition type GUID based environment\n>\n> Add support for locating SCSI environment partition using GPT type\n> GUID instead of unique UUID. This enables the saveenv command to\n> work with partitions identified by their type rather than unique\n> identifiers, providing flexibility for systems where partition\n> UUIDs may vary across devices but types remain constant.\n>\n> Introduce a Kconfig choice statement to select between three partition\n> lookup methods. The choice provides mutually exclusive options:\n> ENV_SCSI_PART_USE_UUID (default), ENV_SCSI_PART_USE_TYPE_GUID, and\n> ENV_SCSI_PART_USE_HW. The corresponding string configs depend on their\n> respective selection method, creating a clear configuration structure.\n>\n> Introduce CONFIG_ENV_SCSI_PART_TYPE_GUID configuration option that\n> allows specifying a partition type GUID for environment storage.\n> When SCSI_ENV_PART_USE_TYPE_GUID is enabled, the environment subsystem\n> uses the type GUID based lookup method via\n> scsi_get_blk_by_type_guid() to find the first matching partition.\n>\n> [...]\n>\n> env/Kconfig | 50 ++++++++++++++++++++++++++++++++++++++++++++++++--\n> env/scsi.c | 29 ++++++++++++++++++++++++++---\n> 2 files changed, 74 insertions(+), 5 deletions(-)\n\n> diff --git a/env/Kconfig b/env/Kconfig\n> @@ -763,12 +763,58 @@ config ENV_MMC_USE_DT\n> +config ENV_SCSI_PART_USE_TYPE_GUID\n> + bool \"Use partition type GUID\"\n> + help\n> + Use the partition type GUID to identify the SCSI partition\n> + for environment storage. The first partition matching the\n> + specified type GUID will be used.\n\nHow about adding 'select PARTITION_TYPE_GUID' so that users do not\nhave to manually enable it. Otherwise the lookup will silently fail at\nruntime when part_get_info_by_type_guid() returns -ENOENT\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=FdUkRPJj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"FdUkRPJj\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzSKq5skGz1yGs\n\tfor ; Mon, 20 Apr 2026 11:18:23 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C1B7F83FF5;\n\tMon, 20 Apr 2026 03:18:21 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 7451C84181; Mon, 20 Apr 2026 03:18:20 +0200 (CEST)","from mail-ed1-x536.google.com (mail-ed1-x536.google.com\n [IPv6:2a00:1450:4864:20::536])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 6A52880087\n for ; Mon, 20 Apr 2026 03:18:18 +0200 (CEST)","by mail-ed1-x536.google.com with SMTP id\n 4fb4d7f45d1cf-674a44b84fcso1229675a12.1\n for ; Sun, 19 Apr 2026 18:18:18 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776647898; cv=none;\n d=google.com; s=arc-20240605;\n b=gOduzxLTk3ZzjIec5Lr4B6z1l6J42kIOmqN/qy3Zc4zXVz1IwrHEK01fvYO6+v8swI\n dizshEfuv8iOT5m4IgEMhnure6UNClnJ2Suxp334JfHX9O9pqfnXAevPvCD/hF9t6Ck3\n JXZw5uEzmIbBE6B11E51FXodeo2d64w4AjkOao1NnHSd+fnzTRBFDhKlg/xgYMNrJhrZ\n VtCOwuOb9F9rL7CqwnZfclNIBhfD2pFbATG2Cos4RW3dMHc/+9TK+hlUiFxCm7RIwwy3\n VTTBSW9Vm+Yz9p8xNEe/m6DITCTwinx3jAxM2gSyNXT48eZDy6kO5lCsX1ZtMfeglmcj\n Nv0A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=axD+jozH5GUPmtU/8aKhVCsDLQuoRVPiYcgvqBF0qi4=;\n fh=S8xjaNhDK5zkqclbPZi4D14oajyF+NpuR2kRzRAZ3EE=;\n b=B4Vr2oPVFdB/Zx7y58zde41kwzeUySKKgmug/oLRWRDZIPTSL8GQolNpP3YguTZkf/\n S5JXOv3wkgdoJzCUBYGOMv7JCmygUXdGb4Ynm4ORuWXuyMFXwkdYrdJRQ2yT2F/s7GkY\n 5t8IEXEiTRdXnttbuWunl0djtAIuR9Tt+M4YxCjsP0NK54L0sALCHplC7+fCT2/f0xGB\n VIIszF36EPUXW832vIjkJaozbpvAhpMrpQtiXCPaLHMWlYglU6zw05InQiKoUudrPWMT\n lr7GBEMWzruK8qGRLFTadGN1IUs4/GhzfG3VGBxKKhi7Solb6OBAfJ99Dr3DinMz7392\n x+sw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776647898; x=1777252698; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=axD+jozH5GUPmtU/8aKhVCsDLQuoRVPiYcgvqBF0qi4=;\n b=FdUkRPJjSH/sWlz6c/2CNDCD8pKszxw+ZMX5MmlaOmdbEZ27Kw4olHY83Kw4hb6BHj\n 3PCaKa1VnVgJ61rqcQC3kt/lo4b9d5e04gDP5R6yvN2Zz6eQmF8zpsDR+wMdq15Ewun7\n R8oD3jlxujiK95GrOk3gzDp9M0JPj4FnRKLQ0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776647898; x=1777252698;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=axD+jozH5GUPmtU/8aKhVCsDLQuoRVPiYcgvqBF0qi4=;\n b=F3nPqJ1PzQZ9C49iv7t6CCDfB49P6fRXluCxV7b4tCXVKr86b60TQYi/I3muEi71JQ\n G3wwv0fFR7fu82reih9HkyGdFeLPmKqF1uYKiePMwixnxF916oJiGDXGa6reT0E0iQth\n lVoIbbhC3pXcVuETYeRLcWZfjcUDumfSvrwXNCOcPVV7ddE97Avi1kKE3gckKduSzFVD\n zuzVP3GLdMz21IHFNgFf21xqdHMS4QbmMkcxIIwf/50Hk3/YMhjvk+r31gzuVnWlGO3Y\n BWFOYNwLyZPaWMZ3gmJywVgyvXRGDd2VDaoHSkuWG3woenafqUfB5Z1n8JYpyazSQFrG\n P1Uw==","X-Gm-Message-State":"AOJu0YyJFjGeFZmusE7WGwYBU3UZK839OseQrIxRarzL6rJIX2wROSB5\n OvclnenlcPt6Nr5MI1cOu2E6snn3VO8DrHnAK1p++2oaBmh4FZOc34UPAVC/L2ohpqmRsc2HQa2\n I/PkQ+ILUGdGqVsMw9Ye6dko7+Mu3/KMckrXFyAMo","X-Gm-Gg":"AeBDietLJMnS7mSr+e80IIMgN26g8LbclvT9Hli1mbdunKamejRf7iu0uy3iJDlmQlG\n HlTAouWm/6nCpps7QCwL5m7qpIo5+g6UBJrBbelhu2FzurorKehqOoYlIIon0cAYSLRNopyKGA+\n F1iS3D98R992UFA9Y7DOhShwueZ/p9KmXTCXplYUpbXiwvNFuoL4InWEqVXcB0mg+iiifwh4gym\n IzN3DMdRR4+knPy/En1mfkONxK0DcmglZ0IZpImYMy2RSDqEYBSXCXlra+5Lt1Bz2E4VvFxwug7\n WE25If3bWcUjbU3Yxz2S","X-Received":"by 2002:a17:907:c30a:b0:b9b:7bf8:800b with SMTP id\n a640c23a62f3a-ba41afe998emr529926166b.40.1776647897757; Sun, 19 Apr 2026\n 18:18:17 -0700 (PDT)","MIME-Version":"1.0","References":"<20260419-type-v3-0-ec49acd6870e@oss.qualcomm.com>\n <20260419-type-v3-3-ec49acd6870e@oss.qualcomm.com>","In-Reply-To":"<20260419-type-v3-3-ec49acd6870e@oss.qualcomm.com>","From":"Simon Glass ","Date":"Mon, 20 Apr 2026 13:18:04 +1200","X-Gm-Features":"AQROBzBIF_SQfAAlTgjORCLQyyu-FYDDDU3tFeYhnqnZfIJhmRpn7tDCfkHzCug","Message-ID":"\n ","Subject":"Re: [PATCH v3 3/5] env: scsi: Add support for partition type GUID\n based environment","To":"balaji.selvanathan@oss.qualcomm.com","Cc":"u-boot@lists.denx.de, Sumit Garg ,\n u-boot-qcom@groups.io, Tom Rini ,\n Quentin Schulz ,\n Ilias Apalodimas ,\n Javier Tia ,\n Varadarajan Narayanan ,\n Rasmus Villemoes ,\n Mikhail Kshevetskiy ,\n Javier Martinez Canillas ,\n Miquel Raynal ,\n =?utf-8?q?Jo=C3=A3o_Marcos_Costa?= ,\n Tien Fong Chee ,\n Richard Genoud ,\n Jan Kiszka , David Lechner ,\n Casey Connolly ,\n Simon Glass ,\n Marek Vasut ,\n Christian Marangi , Michael Walle ,\n Sumit Garg ,\n Neil Armstrong ,\n Aswin Murugan ,\n Varadarajan Narayanan ,\n Simon Glass ,\n Mattijs Korpershoek ,\n Jerome Forissier ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]