[{"id":3679063,"web_url":"http://patchwork.ozlabs.org/comment/3679063/","msgid":"","list_archive_url":null,"date":"2026-04-19T08:16:24","subject":"Re: [PATCH v2] ksmbd: Use AES-CMAC library for SMB3 signature\n calculation","submitter":{"id":79386,"url":"http://patchwork.ozlabs.org/api/people/79386/","name":"Namjae Jeon","email":"linkinjeon@kernel.org"},"content":"On Sun, Apr 19, 2026 at 7:18 AM Eric Biggers wrote:\n>\n> Now that AES-CMAC has a library API, convert ksmbd_sign_smb3_pdu() to\n> use it instead of a \"cmac(aes)\" crypto_shash.\n>\n> The result is simpler and faster code. With the library there's no need\n> to dynamically allocate memory, no need to handle errors, and the\n> AES-CMAC code is accessed directly without inefficient indirect calls\n> and other unnecessary API overhead.\n>\n> Acked-by: Namjae Jeon \n> Reviewed-by: Ard Biesheuvel \n> Signed-off-by: Eric Biggers \nApplied it to #ksmbd-for-next-next.\nThanks!","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ATjQnqa3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10912-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"ATjQnqa3\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fz1fy1Qqdz1yCv\n\tfor ; Sun, 19 Apr 2026 18:16:42 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 5F8993014C20\n\tfor ; Sun, 19 Apr 2026 08:16:39 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A10A933507C;\n\tSun, 19 Apr 2026 08:16:38 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DA041B81CA\n\tfor ; Sun, 19 Apr 2026 08:16:38 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 3B45AC2BCB5\n\tfor ; Sun, 19 Apr 2026 08:16:38 +0000 (UTC)","by mail-ed1-f46.google.com with SMTP id\n 4fb4d7f45d1cf-67482e67171so1291505a12.1\n for ;\n Sun, 19 Apr 2026 01:16:38 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776586598; cv=none;\n b=fSm+gnznofQiOqBAEwlpHT3h1kzKhfIdBxNF2alcewUpJcjsKKQcAoHMVJOmWq0E1YSU13syu4RKDyj8Z8Or1lMuEcVZyBCLFX0xhuUEdo+lG2PlzlYqevKMWwKOLkvQmf6SCnBfMt6vXk6Fuj8GfxJQ7+Knoa6H6hbsuj9cinE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776586598; c=relaxed/simple;\n\tbh=ZAd+IFCa9tZH5vzsuiUNeNba8lEtkX8vemyuywiscs0=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=i7QrhcHyLv7RMF9C7W+HnBDeuiNEgZmxczlmYR/tvAsWQrirYASyfvQGp9NYunfaeh0d8h5uX7oNimf1MD28fb9t4y7HhIWA3dRfIa2NAcYlliIWF4uw/eqanm546uUc686oSt5K4pgl/udQ3z93ZCpJlIOC3UVwgDY94jwGtbE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=ATjQnqa3; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776586598;\n\tbh=ZAd+IFCa9tZH5vzsuiUNeNba8lEtkX8vemyuywiscs0=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=ATjQnqa3/boYdJ63gWBAI6DpeXnJ1Ha6sGbcmc8hs1oklqwpL6t4jWxI0f0f4+Q2P\n\t u3GnkaGF59e8QeStNmXilPFvAgZ7y2SB5JzUE5SmMldmHsZj/7troSe0xmiizcw8W0\n\t A/Fue5MjjgRkBH+brXtSHl5KjEm4j9DJhTKDcApVCRHj8Uhq5wJnPxY38y/MOpZho2\n\t x88WP2ezvSZP9tmzxbx2xFfsDxT25nPyKfiWYAEj5KTH2/p0ULb30iwJ32eZZxOD+q\n\t Pfj4tUsmOloGwe4l3hTpI95h4YP7fbvp/Nx+jS8CNiVNfYELaUnea3eMBq3wdXnHiK\n\t 0ul56XU8A9QJg==","X-Gm-Message-State":"AOJu0Yw0CP8Xl+VsUsnrXdq+PAg7btPbb0zVLy3ohkFe3Hg8+IZuUxdA\n\tp2qqYz9Uatk/fkcQuXL5QvTwlwz0cFX3TkqCdGpwQaz3XLxBNpjRuaT5SQt1QoIgzpvCxH3xK24\n\ttMOl2vKZQ4Negl5YvCKg1u84S2I1Nm/4=","X-Received":"by 2002:a05:6402:325a:b0:672:158d:9de4 with SMTP id\n 4fb4d7f45d1cf-672bfdc8c14mr3002401a12.14.1776586596796; Sun, 19 Apr 2026\n 01:16:36 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260418221707.67972-1-ebiggers@kernel.org>","In-Reply-To":"<20260418221707.67972-1-ebiggers@kernel.org>","From":"Namjae Jeon ","Date":"Sun, 19 Apr 2026 17:16:24 +0900","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzC7I1NiVlK1mnmba71tTfBdEbCO96YGQ7tM90Z8yYOaVhayMgG7K860Qkw","Message-ID":"\n ","Subject":"Re: [PATCH v2] ksmbd: Use AES-CMAC library for SMB3 signature\n calculation","To":"Eric Biggers ","Cc":"linux-cifs@vger.kernel.org, Steve French ,\n\tlinux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tArd Biesheuvel ,\n Sergey Senozhatsky , Tom Talpey ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]