[{"id":3679278,"web_url":"http://patchwork.ozlabs.org/comment/3679278/","msgid":"","list_archive_url":null,"date":"2026-04-20T07:57:33","subject":"Re: [PATCH] [v3] mtd: spi-nor: gigadevice: Add support for\n GD25LQ255E","submitter":{"id":86646,"url":"http://patchwork.ozlabs.org/api/people/86646/","name":"Michael Walle","email":"mwalle@kernel.org"},"content":"On Sat Apr 18, 2026 at 10:42 AM CEST, Weimin Wu wrote:\n> Add support for the GigaDevice GD25LQ255E (JEDEC ID c8 60 19),\n> a 256Mbit (32MB) SPI NOR flash chip which supports SFDP.\n>\n> The chip supports 4K sector erase, dual read, and quad read modes.\n>\n> Link: https://download.gigadevice.com/Datasheet/DS-00562-GD25LQ255E-Rev1.2.pdf\n\nPlease move the Link: tag above your SoB line.\n\n..\n\n> diff --git a/drivers/mtd/spi-nor/gigadevice.c b/drivers/mtd/spi-nor/gigadevice.c\n> index ef1edd0ad..22a430798 100644\n> --- a/drivers/mtd/spi-nor/gigadevice.c\n> +++ b/drivers/mtd/spi-nor/gigadevice.c\n> @@ -82,6 +82,10 @@ static const struct flash_info gigadevice_nor_parts[] = {\n> \t\t.size = SZ_16M,\n> \t\t.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,\n> \t\t.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,\n> +\t}, {\n> +\t\t/* gd25lb256 */\n> +\t\t.id = SNOR_ID(0xc8, 0x60, 0x19),\n> +\t\t.flags = SPI_NOR_HAS_LOCK | SPI_NOR_4BIT_BP | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6,\n\nReviewed-by: Michael Walle \n\nIt looks like the gd25q256 is also missing the 4BIT_BP flag. Could\nyou add second patch fixing that one, please?\n\nFWIW, the GigaDevice datasheets are super confusing, sometimes there\nare 5 BP bits, where the last one is the TB, sometimes there are 4\nBP and 1 TB but only 3 BP bits are used..\n\n-michael","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ToL1tcbs;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dsuwx8hL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=temperror (SPF Temporary Error: DNS Timeout)\n smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133;\n helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzdCN1rPvz1yGs\n\tfor ; Mon, 20 Apr 2026 17:58:00 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wEjVl-00000006ZMp-0RPN;\n\tMon, 20 Apr 2026 07:57:41 +0000","from tor.source.kernel.org ([172.105.4.254])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wEjVi-00000006ZMS-3ivQ\n\tfor linux-mtd@lists.infradead.org;\n\tMon, 20 Apr 2026 07:57:38 +0000","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 04CF260055;\n\tMon, 20 Apr 2026 07:57:38 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 1876DC19425;\n\tMon, 20 Apr 2026 07:57:36 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tIn-Reply-To:References:To:From:Cc:Subject:Message-Id:Date:Mime-Version:\n\tReply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date\n\t:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=uHtYGN0lAnz4C31hLORNETibzNbVs5tlnGWpvekw1oI=; b=ToL1tcbsVbvEry9uyFEQSUapHP\n\tELR+tv9TuVG2hAxcxL/eWS/RjnksO7XMT0SZw792gIXHc4otMlEJ8UXaEcmdqOtZeD8zoMCICWna3\n\tJkMxP+NiRXY926+PYozmgI9ve/uPu34SS7CwjIoN6jSilr7ymVKGGFLVkXoK050iGIJka4uY7jMh4\n\tzYKKUAbNZ/hpkwlsIjKdT0EKxqUwpN2xGj/lKK3HJ3peFJ+tRGglVXz6nwfhUU08sq1mG5NCH6tJG\n\t7j9AtnPcOtx8eWnFd/Bl/kEWwm9A0+rjpI2XeZziWMgsBPNxjtYHf/Pjm/1URC66tv1/tpIKk7fkO\n\tuebeQZ+g==;","v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776671857;\n\tbh=wZ05Hm/1dyxpzWq56J2q/l3jEulKGa6cD1wP+dC7+Jk=;\n\th=Date:Subject:Cc:From:To:References:In-Reply-To:From;\n\tb=dsuwx8hLw5o5t1ep/qxH+h07JWWU0PVHT9+LZqa4O1152TKrmd/g/fIrQBjymw2gm\n\t FzwxnkSGKdxbYdSB6V75B+ubljvFIpRPBRG+hDXM/QjK0+Hrz5MrA7V7Gi9xQXzcyM\n\t Tmz+izdH5JJOpYdJe9HYoG1D2AGJdnYV1jIVnfEDyS9CoPSICYQ/tJGdJqX2QXnc1D\n\t a4NGd70/cQweP1i4imnOB5WXSnW2L/2kYT9vkI7pm1oQO1nL1vE2OZ0AxDOM35Ndg4\n\t dSePmkRNy5vxtMNMh5xgIc/ApHRsM4DYL9TKpRgZzct8HoFZr+eIw75NY/XaEDZoNc\n\t fCEt4RSsthjJw=="],"Mime-Version":"1.0","Date":"Mon, 20 Apr 2026 09:57:33 +0200","Message-Id":"","Subject":"Re: [PATCH] [v3] mtd: spi-nor: gigadevice: Add support for\n GD25LQ255E","Cc":", ,\n , ","From":"\"Michael Walle\" ","To":"\"Weimin Wu\" ,\n ","X-Mailer":"aerc 0.20.0","References":"<20260418084253.792395-1-wuweimin@huaqin.corp-partner.google.com>","In-Reply-To":"<20260418084253.792395-1-wuweimin@huaqin.corp-partner.google.com>","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"multipart/mixed; boundary=\"===============4057993207956825191==\"","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":3679328,"web_url":"http://patchwork.ozlabs.org/comment/3679328/","msgid":"<19592fee-979e-4b94-89a1-76581c95b877@linaro.org>","list_archive_url":null,"date":"2026-04-20T09:42:05","subject":"Re: [PATCH] [v3] mtd: spi-nor: gigadevice: Add support for GD25LQ255E","submitter":{"id":85360,"url":"http://patchwork.ozlabs.org/api/people/85360/","name":"Tudor Ambarus","email":"tudor.ambarus@linaro.org"},"content":"On 4/20/26 10:57 AM, Michael Walle wrote:\n> +\t\t/* gd25lb256 */\nplease clarify the name:\n\nhttps://sashiko.dev/#/patchset/20260418084253.792395-1-wuweimin%40huaqin.corp-partner.google.com","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=aVRA9Y6G;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=XAGIblxO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzgWK2Gsvz1yGs\n\tfor ; Mon, 20 Apr 2026 19:42:21 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wEl8x-00000006gu4-1IZ9;\n\tMon, 20 Apr 2026 09:42:15 +0000","from mail-wm1-x333.google.com ([2a00:1450:4864:20::333])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wEl8u-00000006gtX-0fg2\n\tfor linux-mtd@lists.infradead.org;\n\tMon, 20 Apr 2026 09:42:13 +0000","by mail-wm1-x333.google.com with SMTP id\n 5b1f17b1804b1-48984d29fe3so5369665e9.0\n for ;\n Mon, 20 Apr 2026 02:42:10 -0700 (PDT)","from [10.11.12.108] ([79.115.63.48])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e59f97sm31101696f8f.37.2026.04.20.02.42.08\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 20 Apr 2026 02:42:09 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:\n\tSubject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=ujHKOme7yF7QbqaKMfzSJR0Jf4R3sU2st5nANF23Vas=; b=aVRA9Y6GDtx+e8\n\tOmSUZchTKLdoN55QdPjTPiFAJopsFelojMmlnfl61Ta9r31i6rB+hi1w0ydrUpnV4JZ39NbdRfH8p\n\tsffFeSJOhPF2yX7D15G0k2Klh5OxlN7cu7twRCFD3j6EwjaDXicvl/NCLSauQHYWh9tHoHkITAT74\n\tYKHx84PZCjDnrpY4smq5P48SY8mLMAE/F1F/iWIq5OYhTdJg1DUvLokZaG/bNx2GXdS+wGRAkKPge\n\tccdKQljG9gUFwtjUsvMin9kpulp7C9yOpk0ytTGbQeN7rzSE9swldU062drRxI4yEzwJYwUbeJOr0\n\tCJqK5Iw4X8I+qyMGSM+A==;","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776678129; x=1777282929;\n darn=lists.infradead.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=XVj2E0kR9vgM3fFufU475XcX4Uh+G31rNfkdN/woTQg=;\n b=XAGIblxOHwn4MSQawThLhhbpT2UuYZai269czQThzlo/NR08TcYuVin6X0A/zBwwN4\n /VQfcL3UXttuMKZXZQkdwlkvf9MTILBDMIsZ3UV86NSAUgVYdpyRntATwDXGpdL8a3K+\n uuYfInxEI0Rgd0ut/PzWUXDVXCODj/Et9J6OPrEZfuNisPRcYHfgjlZ4GrelJvciaIne\n WmrFYmTX3N2CJiacLkyWVIshpXsvOXpSEAolMxIGLyV910rAH5xW4zimkZuT1F2HLq13\n usGzF3NjYbvcuImrmE+9Rg+ve8X2hfigd3h61RhJuZOU1Q7l8I1EmsujHmtE3SL9jWtm\n Lq1w=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776678129; x=1777282929;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=XVj2E0kR9vgM3fFufU475XcX4Uh+G31rNfkdN/woTQg=;\n b=jKrsAXG2mcyC2FBImIFUHCsgNFsw60MO+h/7Cf6ET5Pv/DzwPtp7Bz3Qs800VwMTIY\n O1Fc2mHyfq+aE+tkRvxcx4x+u77g0IbtRNelG28nB94aB0RrwoPx4tahWFAiFTWIhpBN\n 7L2P3Rxpk7gbLuUzA+oe4tIy6Qapl7tLF6iJZ8N4pq5udXX9hihGB5vGn6IF7OfbNHGp\n lJo5y5qdQK/GzXrsYwuX1gzXnYRNFj4aYSugqr98HzCCLmRr5nxIyfq2U75FQEckQG5L\n llC71PbzcQPYkMbMTdRM4Ze5GLiqAd/87fw+p3qZP7Iek3IFhemivuQtF4LlgtkmnE6v\n CO+A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/ZpUYsvmAVCpunNwxYeFJ4TLpBNQeD98UT84yTZRBCAr/c1EpZCB53N9j/oAEHi3j1263DpGBZyF0=@lists.infradead.org","X-Gm-Message-State":"AOJu0YyDjpsUj9Sl+6U4cbl37SYiDbrBVMraXGiz4t5pxKt+7O0ZUz6i\n\t/6aU1ecqHg791Y3jChTzLm8LY75Kdac5dACT21Y2HERHOppWf81o1gs6c1zsK8maTlU=","X-Gm-Gg":"AeBDiet6bRWrS+2S4bPxigbm8rpxJVhiI6VNI0WONnIG2n1hBVW4SsXQQGjBIlXt5rM\n\tk/XNzLaKUlh82x42MrOtSDn3AQ1TX0Ik/jYe9PvksRa0R+mAMaowzHC1OfAXaU1ggMsSHG0Jf8q\n\ttIi6FLX0JUHNEIEmbxMGegtuLC/cjWSRAxv/cT6Xv1eRWPshWQ72ZjCpYcOUidyjUWs8TQd0gUa\n\t7bfkva8t1TVzpo4qgdwNNnKGLupO9UsEn4BJrC6NJ2ls/ZVb3kUMTfcT6Ljhkhn8GPYhqZOafg9\n\tv9BJVa2hPtQTvAwHLGAyx+bBQJa/K8oxkPcWMS++wZacHoFnpjgxM4p766fC2IQPM39UbIUYMNE\n\tbo45jU/URpU7p9cW4hcY/WdImoYWaGfo+nR04fVlsJrQStkFI9nmLCMKF1U7e17q2Uy3skGDIBq\n\t05PO75Jg3XqE1UhIPfFBmb1SE4Q/X29R5COk/E4AiqFw==","X-Received":"by 2002:a05:600c:4895:b0:488:ffad:6728 with SMTP id\n 5b1f17b1804b1-488ffad67f4mr78373285e9.19.1776678129400;\n Mon, 20 Apr 2026 02:42:09 -0700 (PDT)","Message-ID":"<19592fee-979e-4b94-89a1-76581c95b877@linaro.org>","Date":"Mon, 20 Apr 2026 12:42:05 +0300","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] [v3] mtd: spi-nor: gigadevice: Add support for GD25LQ255E","To":"Michael Walle ,\n Weimin Wu ,\n takahiro.kuwano@infineon.com","Cc":"pratyush@kernel.org, linux-mtd@lists.infradead.org,\n linux-kernel@vger.kernel.org","References":"<20260418084253.792395-1-wuweimin@huaqin.corp-partner.google.com>\n ","Content-Language":"en-US","From":"Tudor Ambarus ","In-Reply-To":"","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260420_024212_284205_F50D10E3 ","X-CRM114-Status":"UNSURE ( 5.31 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.1 (--)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: On 4/20/26 10:57 AM, Michael Walle wrote: > + /* gd25lb256\n */ please clarify the name:\n https://sashiko.dev/#/patchset/20260418084253.792395-1-wuweimin%40huaqin.corp-partner.google.com \n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no\n trust\n [2a00:1450:4864:20:0:0:0:333 listed in]\n [list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":3679335,"web_url":"http://patchwork.ozlabs.org/comment/3679335/","msgid":"<792c09f5ae754bf899693f110ef1dbe0@infineon.com>","list_archive_url":null,"date":"2026-04-20T09:51:13","subject":"RE: [PATCH] [v3] mtd: spi-nor: gigadevice: Add support for GD25LQ255E","submitter":{"id":79570,"url":"http://patchwork.ozlabs.org/api/people/79570/","name":"Takahiro Kuwano","email":"takahiro.kuwano@infineon.com"},"content":"Hi,\n\n> \n> On Sat Apr 18, 2026 at 10:42 AM CEST, Weimin Wu wrote:\n> > Add support for the GigaDevice GD25LQ255E (JEDEC ID c8 60 19),\n> > a 256Mbit (32MB) SPI NOR flash chip which supports SFDP.\n> >\n> > The chip supports 4K sector erase, dual read, and quad read modes.\n> >\n> > Link: https://download.gigadevice.com/Datasheet/DS-00562-GD25LQ255E-Rev1.2.pdf\n> \n> Please move the Link: tag above your SoB line.\n> \n> ..\n> \n> > diff --git a/drivers/mtd/spi-nor/gigadevice.c b/drivers/mtd/spi-nor/gigadevice.c\n> > index ef1edd0ad..22a430798 100644\n> > --- a/drivers/mtd/spi-nor/gigadevice.c\n> > +++ b/drivers/mtd/spi-nor/gigadevice.c\n> > @@ -82,6 +82,10 @@ static const struct flash_info gigadevice_nor_parts[] = {\n> > \t\t.size = SZ_16M,\n> > \t\t.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,\n> > \t\t.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,\n> > +\t}, {\n> > +\t\t/* gd25lb256 */\n> > +\t\t.id = SNOR_ID(0xc8, 0x60, 0x19),\n> > +\t\t.flags = SPI_NOR_HAS_LOCK | SPI_NOR_4BIT_BP | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6,\n> \n> Reviewed-by: Michael Walle \n> \nThe datasheet explains (in Table 5) that BP2-BP0 control the length\nof protection area (all, 1/2 ... 1/64, 0) and BP3 controls upper/lower.\nIt looks 3 BP and 1 TB so SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB should work.\nBP4 protects top or bottom 4KB to 32KB and current SWP doesn't support\nthat protection mechanism, right? Sorry if I missed something...\n\n> It looks like the gd25q256 is also missing the 4BIT_BP flag. Could\n> you add second patch fixing that one, please?\n> \nThe GD25Q256 looks 4 BP + 1 TB, according to the datasheet.\n\n> FWIW, the GigaDevice datasheets are super confusing, sometimes there\n> are 5 BP bits, where the last one is the TB, sometimes there are 4\n> BP and 1 TB but only 3 BP bits are used..\n> \n> -michael\n\nThanks,\nTakahiro","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=KD9k1EvI;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=infineon.com header.i=@infineon.com header.a=rsa-sha256\n header.s=IFXMAIL header.b=BoRVDsWE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzgmB6vt8z1yD4\n\tfor ; Mon, 20 Apr 2026 19:53:30 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wElJj-00000006hZS-3apN;\n\tMon, 20 Apr 2026 09:53:23 +0000","from smtp2.infineon.com ([2a00:18f0:1e00:4::4])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wElJg-00000006hOb-0FlB\n\tfor linux-mtd@lists.infradead.org;\n\tMon, 20 Apr 2026 09:53:22 +0000","from unknown (HELO MUCSE814.infineon.com) ([172.23.29.40])\n by smtp2.infineon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Apr 2026 11:51:15 +0200","from MUCSE818.infineon.com (172.23.29.44) by MUCSE814.infineon.com\n (172.23.29.40) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 20 Apr\n 2026 11:51:14 +0200","from MUCSE815.infineon.com (172.23.29.41) by MUCSE818.infineon.com\n (172.23.29.44) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 20 Apr\n 2026 11:51:13 +0200","from MUCSE815.infineon.com ([fe80::b54c:c0bd:546c:c9be]) by\n MUCSE815.infineon.com ([fe80::b54c:c0bd:546c:c9be%12]) with mapi id\n 15.02.2562.037; Mon, 20 Apr 2026 11:51:13 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:\n\tMessage-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=Vof+HduS+t2qFmshachiav786FNOKeVoWxNP6Fp4Kmw=; b=KD9k1EvIpl9lFg\n\tPG5VvQUnedFYSyJ0JBBv5ZMJ7IOOv1Vvrg8k/JmMeR4VCBJpvY0TLiGdBL9JTbMNhBusGGhTekVCQ\n\tuXlzjlfOuU3RSxWF6pcskbk4wYLH9Ro0rsDEYigtAhR0YyOacnXJr3YN0RJlsqhE8vCKve8Sj+CxU\n\tk9UyINX6W7sMdk61QV8hUyxVGL+XD+8VGmjffiKVXQakFN0DzjQaNZkcgHrbyxehcJ4HMeR4QXfJe\n\tbAcQRH7XWgrMxeyeMGWaJTZ2E2cBOt+ECQn9NK52ahuGhNM1pSrSRXIMT+03+dgXX5eZFZ6+tSH9T\n\tqe2fAj9sMlEmcxRh9buQ==;","v=1; a=rsa-sha256; c=simple/simple;\n d=infineon.com; i=@infineon.com; q=dns/txt; s=IFXMAIL;\n t=1776678800; x=1808214800;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=X5UfUdR9jGooYFjEEzS/6kJ5YJf4NT7at4t7F/oqPZ8=;\n b=BoRVDsWECVEsZYwT84uNlG19aSEl7aRPu1XumzsCQ9bI6kNU0KYKoU+j\n fTj8W9KKdqW6mcKXu+FmUNdlquvJPVNxxnCs4qSwIKlDb0OJfum+MM9jn\n ROnm3PDTuHrmQtxfARKfGnLIzOqnIlxHfe6NeMLYpJpiCGnC72kQWrTyV\n k=;"],"X-CSE-ConnectionGUID":"9BfHqPaoSfagm3o89GmVRA==","X-CSE-MsgGUID":"GVlrDzK1SD2hPGDTe+vbwg==","X-IronPort-AV":["E=McAfee;i=\"6800,10657,11762\"; a=\"153965079\"","E=Sophos;i=\"6.23,189,1770591600\";\n d=\"scan'208\";a=\"153965079\""],"X-Amp-Result":"SKIPPED(no attachment in message)","From":"","To":", ","CC":", ,\n\t, ","Subject":"RE: [PATCH] [v3] mtd: spi-nor: gigadevice: Add support for GD25LQ255E","Thread-Topic":"[PATCH] [v3] mtd: spi-nor: gigadevice: Add support for\n GD25LQ255E","Thread-Index":"AQHczw+FlAbYwg9LE0q1dMBwwlMtI7XndwmAgAA6tvA=","Date":"Mon, 20 Apr 2026 09:51:13 +0000","Message-ID":"<792c09f5ae754bf899693f110ef1dbe0@infineon.com>","References":"<20260418084253.792395-1-wuweimin@huaqin.corp-partner.google.com>\n ","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.161.6.196]","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260420_025320_419378_AD576E6E ","X-CRM114-Status":"GOOD ( 18.04 )","X-Spam-Score":"-2.1 (--)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Hi, > > On Sat Apr 18, 2026 at 10:42 AM CEST,\n Weimin Wu wrote:\n > > Add support for the GigaDevice GD25LQ255E (JEDEC ID c8 60 19), > > a\n 256Mbit (32MB) SPI NOR flash chip which supports SFDP. > > > > The c [...] \n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":3679355,"web_url":"http://patchwork.ozlabs.org/comment/3679355/","msgid":"","list_archive_url":null,"date":"2026-04-20T10:44:52","subject":"Re: [PATCH] [v3] mtd: spi-nor: gigadevice: Add support for\n GD25LQ255E","submitter":{"id":86646,"url":"http://patchwork.ozlabs.org/api/people/86646/","name":"Michael Walle","email":"mwalle@kernel.org"},"content":"On Mon Apr 20, 2026 at 11:51 AM CEST, Takahiro.Kuwano wrote:\n> Hi,\n>\n>> \n>> On Sat Apr 18, 2026 at 10:42 AM CEST, Weimin Wu wrote:\n>> > Add support for the GigaDevice GD25LQ255E (JEDEC ID c8 60 19),\n>> > a 256Mbit (32MB) SPI NOR flash chip which supports SFDP.\n>> >\n>> > The chip supports 4K sector erase, dual read, and quad read modes.\n>> >\n>> > Link: https://download.gigadevice.com/Datasheet/DS-00562-GD25LQ255E-Rev1.2.pdf\n>> \n>> Please move the Link: tag above your SoB line.\n>> \n>> ..\n>> \n>> > diff --git a/drivers/mtd/spi-nor/gigadevice.c b/drivers/mtd/spi-nor/gigadevice.c\n>> > index ef1edd0ad..22a430798 100644\n>> > --- a/drivers/mtd/spi-nor/gigadevice.c\n>> > +++ b/drivers/mtd/spi-nor/gigadevice.c\n>> > @@ -82,6 +82,10 @@ static const struct flash_info gigadevice_nor_parts[] = {\n>> > \t\t.size = SZ_16M,\n>> > \t\t.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,\n>> > \t\t.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,\n>> > +\t}, {\n>> > +\t\t/* gd25lb256 */\n>> > +\t\t.id = SNOR_ID(0xc8, 0x60, 0x19),\n>> > +\t\t.flags = SPI_NOR_HAS_LOCK | SPI_NOR_4BIT_BP | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6,\n>> \n>> Reviewed-by: Michael Walle \n>> \n> The datasheet explains (in Table 5) that BP2-BP0 control the length\n> of protection area (all, 1/2 ... 1/64, 0) and BP3 controls upper/lower.\n> It looks 3 BP and 1 TB so SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB should work.\n> BP4 protects top or bottom 4KB to 32KB and current SWP doesn't support\n> that protection mechanism, right? Sorry if I missed something...\n\nHa, you are right, thanks for pointing that out. I actually fell for\nthe wrong comment and looked at that datasheet in the end.. for\nwhich the flags are correct. And what weird name is that gd25lq255..\nAnyway. The ID matches the linked datasheet. So something is wrong\nhere. Weimin, please test the locking properly and update the\ncomment as Tudor already pointed out.\n\nThanks,\n-michael","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=VC/j1WQW;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=tMdX5Cwi;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=temperror (SPF Temporary Error: DNS Timeout)\n smtp.helo=bombadil.infradead.org (client-ip=2607:7c80:54:3::133;\n helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzhwP3Ktxz1yCv\n\tfor ; Mon, 20 Apr 2026 20:45:14 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wEm7d-00000006kHi-44Lh;\n\tMon, 20 Apr 2026 10:44:57 +0000","from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wEm7d-00000006kHc-1lUZ\n\tfor linux-mtd@lists.infradead.org;\n\tMon, 20 Apr 2026 10:44:57 +0000","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id DCDA960141;\n\tMon, 20 Apr 2026 10:44:56 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 3F3EFC19425;\n\tMon, 20 Apr 2026 10:44:56 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tIn-Reply-To:References:Subject:To:From:Cc:Message-Id:Date:Mime-Version:\n\tReply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date\n\t:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=3F68mXOgD1ykVGDhvrVDEEzyyZypiU7yWJscZvBryAQ=; b=VC/j1WQWBDnJi64b8cQ5Dr7yjn\n\tMsco5FZHK36eDMaEc0dsnDBnAIo53ZtlsIXc9IJreqfv+IBrZ2Emzs+0u0xXUmvdFwYqB4hpVy4P/\n\tiVL3pHRR9H8bxbgXLOgC7bJYK7UxtX7nDMQdlF+WxXmrLqrO9R+RxzhCkSiIIzfs4RPISxjaGn+nV\n\t/4Mb9eFIZAFN1u3uOWXzSZxhTdtg+KAlyvDpx3XZs/ia5Huw4teOvO7zqi68skUOSVU82tM22I/8K\n\tX4gn+Kwv8pdCRQ3lainy3vD37m/zIMJ/h2zGJq9CJNT2Yf2ErBBgHOu+DMGjNDFSLXg4pENPjbd3U\n\tPEApzAjQ==;","v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776681896;\n\tbh=TMJkCzOessYLb1VcTlPJbCPICj+wBOUKL06CBrs8khA=;\n\th=Date:Cc:From:To:Subject:References:In-Reply-To:From;\n\tb=tMdX5CwiHoXzX8CUsVQ/OzXjx8I7xpNwOcJBlDObbQv3H4ZFVp+s6ZGOIuMxZFu1l\n\t 87FXhgEmowV85SSAQ+COeSBAAGHzPWX8DhZ2mTvTI61aPRlYcXslBFJrld5alQnS1r\n\t 1TRgpRbY25k6MZpHdoASSnu9vuHSz1DdlnGBdTP0VmxnCDfp16M/VaYDFoqornyyDL\n\t 9pxOdpEPON6Au0xAiU2Dy1CTI0cmR0vf9LgNRDNl7wJv0vGDwRk6thCjlpJtnyGgLt\n\t zv1dMpbiysbd+snOZuOksjzl4+IGb+vrQaj+Z1Xyd6a+6VbxamNqNfzViIWJlaD1Sv\n\t 575Acx3/pdD5Q=="],"Mime-Version":"1.0","Date":"Mon, 20 Apr 2026 12:44:52 +0200","Message-Id":"","Cc":", ,\n , ","From":"\"Michael Walle\" ","To":",\n ","Subject":"Re: [PATCH] [v3] mtd: spi-nor: gigadevice: Add support for\n GD25LQ255E","X-Mailer":"aerc 0.20.0","References":"<20260418084253.792395-1-wuweimin@huaqin.corp-partner.google.com>\n \n <792c09f5ae754bf899693f110ef1dbe0@infineon.com>","In-Reply-To":"<792c09f5ae754bf899693f110ef1dbe0@infineon.com>","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"multipart/mixed; boundary=\"===============3204903764092697500==\"","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]