[{"id":3680056,"web_url":"http://patchwork.ozlabs.org/comment/3680056/","msgid":"","list_archive_url":null,"date":"2026-04-21T20:45:26","subject":"Re: [PATCH 1/1] tools/asn1_compiler: avoid -Wdiscarded-qualifiers","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-18T06:32:13, Heinrich Schuchardt\n wrote:\n> tools/asn1_compiler: avoid -Wdiscarded-qualifiers\n>\n> Building with GCC 15.2 results in warnings:\n>\n> tools/asn1_compiler.c: In function ‘tokenise’:\n> tools/asn1_compiler.c:442:37: warning:\n> assignment discards ‘const’ qualifier from pointer target type\n> [-Wdiscarded-qualifiers]\n> 442 | dir = bsearch(&tokens[tix], directives,\n> | ^\n>\n> tools/asn1_compiler.c: In function ‘main’:\n> tools/asn1_compiler.c:632:11: warning:\n> assignment discards ‘const’ qualifier from pointer target type\n> [-Wdiscarded-qualifiers]\n> 632 | p = strchr(grammar_name, '.');\n> | ^\n>\n> bsearch() is defined as\n>\n> void *bsearch(size_t n, size_t size;\n> const void key[size], const void base[size * n],\n> size_t n, size_t size,\n> typeof(int (const void [size], const void [size]))\n> *compar);\n>\n> * Use the correct type for dir.\n>\n> strchr() is defined as\n>\n> char *strchr(const char *s, int c).\n>\n> * Use a conversion for the assignment to p.\n>\n> Signed-off-by: Heinrich Schuchardt \n>\n> tools/asn1_compiler.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=axQG0U5A;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"axQG0U5A\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0ZBN2XnXz1yGt\n\tfor ; Wed, 22 Apr 2026 06:45:48 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 89AD1805D7;\n\tTue, 21 Apr 2026 22:45:45 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 6F9278412A; Tue, 21 Apr 2026 22:45:44 +0200 (CEST)","from mail-ej1-x633.google.com (mail-ej1-x633.google.com\n [IPv6:2a00:1450:4864:20::633])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7895980433\n for ; Tue, 21 Apr 2026 22:45:42 +0200 (CEST)","by mail-ej1-x633.google.com with SMTP id\n a640c23a62f3a-b9c9d03524cso654154366b.3\n for ; Tue, 21 Apr 2026 13:45:42 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776804342; cv=none;\n d=google.com; s=arc-20240605;\n b=CZ67jADGejZ8Crg3jx4tuTHUNoAARqHrOShifbMCodYApCSIPm4l04LSPXM/EDWxjU\n o6feN3B4fx9fuxvhQg3w4763VQjVtcHk550Fg6DipFqpKiEGroBXWJVlE3EovlA079D0\n uHccFZPys2yXSMIgv1ekX8L650HLDF/VsgGD/FjDHmLlBWMQXaCHR7ySbdHEVBjDL3QV\n ZPhbA1hKLkyfyBZtEOrySb8ROD74vsDSnJYD6k6aBuh19BhUXTJ2SS5/0yQUop0l2FTE\n YaaY9ddxnxxmbZQpb7wjeV/vSFLZX5aYCTaZpoy/jRayc8qMlGaWRaDmhuowZ70zmWMx\n nv6g==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=vjlQq8Ouo5yI+NQPZ6UmHFCgQ+1axBkUeCsIpU1UAhI=;\n fh=WUSM7NyYjw1TqkhKTdZ6GOmcvqXW3L4nmfQNfz2zbrs=;\n b=l0HrozYxa0TmxfINMGkIawW01QvVfrkqkn0pITnpNHSoBNRcJsSNLUJbkmL5cd8vCB\n qPlOECYm1HLPs5hXY7hzo8SD4U2zRtQ/O1zVGsTcB64g+/HXH99616alpScAJnEM9vey\n yGOOWWcNa2GilS7B03yM9MHeMY4bOSFPizF4NPijyvGlIFTWbMGw2w9LeX4Keq3O1UjA\n /MZwvwB/ma3oUiF7ZEV99uDMf6wsjM2gDg1PYMNc+KjSdKduxWgr8EznC4XBrXW+Kl2S\n eHe5hy5zvj8Syl3v6A/DbDpfmEauHP3SQBwLOL8tAe9E/TuOw1eGjJRSSa3+3L4Dr9ap\n 06iQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776804342; x=1777409142; darn=lists.denx.de;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vjlQq8Ouo5yI+NQPZ6UmHFCgQ+1axBkUeCsIpU1UAhI=;\n b=axQG0U5AzgsfolUQRCS6zh47P4MRULYQkPcXWOZnFd0RYhLtf9izK7ugqDRe2SMDy+\n lKAoB3NxeGULUOSUmqV+OTvHJApJorn0qPpTXIiXCHU6/TYEIIJduVGaDhToUEZW5AZF\n rtWX2mZGZMCGKT67tCCj+vNS0oZGV0tZ4L+f8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776804342; x=1777409142;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=vjlQq8Ouo5yI+NQPZ6UmHFCgQ+1axBkUeCsIpU1UAhI=;\n b=BMzm5txnb1mPQCx1nL9E39c6pZcJJjq5dmp87gvUJW0D7Z1QF061UkqVnsZ+HJoH1f\n p1gOqIR9cOFTZVYMtgm9QtDzoLaaTtdsK1f0dQrxdnVVjiiGOzJBU6YambZM82autBLv\n JFUVp9y2BhOnKtRX3SiqsfiLopN2+GcpMBNCTgYIAtZfzqUPxNsZbJ09AqMuWwXHwlEt\n nhNRnA8cOU63vuJo7l8tniDWkz4oSDajVymL59JbkqLiO4RdgBBuWG+foJ+YnKX5vC7M\n LokN1OHeXYWmq0LDGXsQb7MwIOkAeb0OgccH6ve3DoNE4PFW1HaENS0AS2ru/7Acw4D5\n JUlg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8lezPc84mjRfTSnxLXgQ5ML3cGLu5hncIQvrGTU3AGxLMvMLjTPRIr8LTDhNUIfFAmbY/SE3E=@lists.denx.de","X-Gm-Message-State":"AOJu0Yyv0M2/9VPPxEhlOBOWeeTRsKv5nFv0o70hqg3fZeQDz+i0xiOI\n nm8nFWTwMfNbT6fnzXeF8CbE18lJtSEZCWTUNe3Wx+plwz8RaJItXtaEefA0pDeWfIiPlPN/Ve7\n nSBtS9XzopWT8ksHYow9HMQPMP30Cd6U4xzEQBTrV","X-Gm-Gg":"AeBDieuAP3Km7Sl1040iD598hrIJ0CpXpkeVirtFY5ndNKtnSpxvRY1rBXlyCTNzM9C\n hw6BjN/swW6Vb7GTLwG8XWEn8PTtItaKeG6SgjqKQfU1LPFDAhAJxcljw3h4Rt7iheXmcjFd+mx\n WnmLT+TccoSdZsxmKF6mVQq9x1ncKJv4R/4C9Iba2XJIDH4qcTIkpbqLzFwkTZ0kQLt+X6a63Mt\n YTMsGiq1Acj+phTE4H9IqIRunTZ7jxTisnDiJjabWr75iLKYoO4J6CtlDwpnit+1/ifOKc29kYH\n L2DnfMuaCQ3Hx+LBOyi4","X-Received":"by 2002:a17:907:948d:b0:ba8:d9d5:cf9d with SMTP id\n a640c23a62f3a-ba8d9e51cb4mr392372666b.21.1776804341757; Tue, 21 Apr 2026\n 13:45:41 -0700 (PDT)","MIME-Version":"1.0","References":"<20260418063213.110024-1-heinrich.schuchardt@canonical.com>","In-Reply-To":"<20260418063213.110024-1-heinrich.schuchardt@canonical.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 08:45:26 +1200","X-Gm-Features":"AQROBzCSpNzZZWouamOGF45NjzllIHIO-7S2VDONlQXeuCIlxfOi_Sv1DiE8B1E","Message-ID":"\n ","Subject":"Re: [PATCH 1/1] tools/asn1_compiler: avoid -Wdiscarded-qualifiers","To":"heinrich.schuchardt@canonical.com","Cc":"Tom Rini , u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]