[{"id":3679218,"web_url":"http://patchwork.ozlabs.org/comment/3679218/","msgid":"","list_archive_url":null,"date":"2026-04-20T04:56:04","subject":"Re: [PATCH] Makefile: fix host CPP pollution in cmd_gen_envp","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-17T22:45:09, Levi Shafter wrote:\n> Makefile: fix host CPP pollution in cmd_gen_envp\n>\n> Commit 2956a84 (\"Makefile: don't use CFLAGS for environment text file\")\n> switched cmd_gen_envp to use $(cpp_flags) so that KCPPFLAGS would be\n> honored when preprocessing the environment text file. However,\n> cpp_flags also includes $(PLATFORM_CPPFLAGS), which carries\n> architecture-specific flags such as -march=armv8-a+crc set by\n> arch/arm/Makefile for CONFIG_ARM64_CRC32=y targets. These flags are\n> appropriate for cross-compiled object files but cause the host CPP\n> invocation to fail on x86 build machines:\n>\n> cc1: error: bad value ('armv8-a+crc') for '-march=' switch\n>\n> KBUILD_CPPFLAGS already accumulates the user-supplied KCPPFLAGS via\n> \"KBUILD_CPPFLAGS += $(KCPPFLAGS)\", providing the behaviour 2956a84\n> intended without pulling in target architecture flags. Use it directly.\n>\n> Fixes: 2956a84 (\"Makefile: don't use CFLAGS for environment text file\")\n> Reported-by: Levi Shafter \n> Signed-off-by: Levi Shafter \n>\n> Makefile | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=c6p8F0gP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"c6p8F0gP\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzY9M6Yc6z1yHB\n\tfor ; Mon, 20 Apr 2026 14:56:23 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8C73283B99;\n\tMon, 20 Apr 2026 06:56:20 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 71C3083BC8; Mon, 20 Apr 2026 06:56:19 +0200 (CEST)","from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com\n [IPv6:2a00:1450:4864:20::62f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7CD4883693\n for ; Mon, 20 Apr 2026 06:56:17 +0200 (CEST)","by mail-ej1-x62f.google.com with SMTP id\n a640c23a62f3a-b936331786dso320636766b.3\n for ; Sun, 19 Apr 2026 21:56:17 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776660977; cv=none;\n d=google.com; s=arc-20240605;\n b=W9p2sXXBTSWxoCuRCBLKWTvJCEgCLLur4bPiKAxIRmoA02T2lrn/S7v/urewEFgRGJ\n PJ7QJihyOGjigp7KUa9aQL6KO6ZgZo6dOSwwTOOh/La2iiaajU7saWwFisvFH2lTYjEE\n wcIHgF1dxnaeNaZz2lZQm7IunTVJXEX7CVCiNPSLmt4e6CxRGBSee/IPXGUCTPUJY9GK\n QrdWTrT+FVBvslkbcGuf+rycI2fypEEZZJMlZiGlut68JKIMnH2nnX34KiexDwVvJK1U\n 8TjLGfr09QQcbDFD+HhrxH1zfgdRSNwNbvtEKwaXpSRa9M7xeF2OoZhY3amuPGKTwdtC\n +oUQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=Sr9hNCt1+ltTARbtsmpneXekMatSk6ciARBrzyJoKQo=;\n fh=BzNny66zVUeNeqRlM9a/rqRWUqgkGcPCEVSByT3bkxY=;\n b=g+Z4GDVpUHACeokRKmsVxrAk9HGjnpfdpqJdwRLrkjf5D+8NGivZQ3XUgElJDUnj53\n 7V46pfMOqCNkc/M1KEN6CtcEf8+LHTTrUPCjBSEGCqEQiaeKymfAYKNaLRPF5BG0lu5h\n 6wejvcFNUrt3tv1eOsuND3/g1Fxds3rVZVWl7jzubfIXJc5gPgoIaq5Wax5sRnKjZoNZ\n 32RpJR1ztQ+fU+ke7EZiAHb/5kmuHpyqfZR3XSRc64VF4QF0z09SfL/1Q1C/ZoQLYLXd\n fQ+/DHmOQRDGOrTKBhh1eo62uhKpAtsUHYbTBkaU2ohcqv2ntK6RlNKyAXml0OVH59tc\n ZwsQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776660977; x=1777265777; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=Sr9hNCt1+ltTARbtsmpneXekMatSk6ciARBrzyJoKQo=;\n b=c6p8F0gPpnIGY8vSGZEpvzVMoyHdT5a3DKdZSg8T5jrjaA0zIKhhSfG1u50fEb3wpu\n IgZj9v2hvtYCFoj7grXSDsLYZEAoyi8N4LNp9e9S19RnooP9bFikfG0RZkTT3/s0J3Dt\n irqgxN7z718CBzkBauMn77Yh1Maij5AMv7wzY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776660977; x=1777265777;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Sr9hNCt1+ltTARbtsmpneXekMatSk6ciARBrzyJoKQo=;\n b=D7lBcDrjwBDkQIoBXzEjkrTwBIddWzajd+6PSbQd+TtnA28gyGA1+KXe6ILZKcl0Z7\n FG6m4YjMVifhLtlaM5GXTirqYAkNmzc+QP8HELo55dQIEkX5R/MLEF/DKv6cc9S1ipHM\n odXpNpDBXEDn1AvfvlLjnK8WZ20n5TxEB4V5CVhSYsX06OqmafG7DfvMKC3yk0nkt5j1\n 3HGdYaXmDNJdepB4cALrNLLsxgttApuT8XKeWuBv5+Lf84EzcVm6/pMjlCtd5ArsBHMN\n WIpYeJ7JJTetRxyA1br/jwCTaLFzWhL/AMeLLuecbSWCK7DcIrmWatFbvCGpSI5Ow21H\n ttGw==","X-Gm-Message-State":"AOJu0YzPWbd1rh5eDthp7J/RP7t0FLQDND520gpIH5NSvI8VZW3XS3Ir\n maFo5UeN5Eo2e/oKbB84D3A30Qm22Fjdr4gzr2FoPWWbVtsVRVqptgURzOpTLz9fqqW9O+cAT/C\n PEJeivb1kzsoniZjPJvDjIVp40hIuYgNd3npNbC4AJEWbGkj9pHC7ZQ==","X-Gm-Gg":"AeBDiesoDcmSMgK1wJXb5Drfp3QmdnZ87peesoG8VQgPnohz0kA03BiqcrfcrBRXv+z\n n4O/n1n9R2biWkG1AxKXu2jC9OJThqfvERz04J7HeAISvvew7+FQsotaSN/gfpHh+jRD4dDsMvG\n sqhfBVeUJzf08Uk/JVnBnjKaOc3E/ieAM+ZX3kJ5SwzVKjjKX1FIEb2U7oJ3i8QQk3rPuU8kll+\n By3YX7EQrV3DMwdlLtb6KrnSiya6izlwWOh1AEFf8XSeZlmsPqsg7yjvrNUM5s/ywVX34LG5JU3\n cRCZAhtzxrqtxs7c43C5","X-Received":"by 2002:a17:907:a0e:b0:ba7:d65f:3b2c with SMTP id\n a640c23a62f3a-ba7d65f4834mr87515866b.11.1776660976739; Sun, 19 Apr 2026\n 21:56:16 -0700 (PDT)","MIME-Version":"1.0","References":"<732a4d19-0e19-47ed-9f8e-0f28b8c50f73@elder-tomes.com>","In-Reply-To":"<732a4d19-0e19-47ed-9f8e-0f28b8c50f73@elder-tomes.com>","From":"Simon Glass ","Date":"Mon, 20 Apr 2026 16:56:04 +1200","X-Gm-Features":"AQROBzC4L4RvDA-Qol3gLX4XoNFnc_7-dwOsH5Yp-hS6aL8uCdG44YhA3C5TUnI","Message-ID":"\n ","Subject":"Re: [PATCH] Makefile: fix host CPP pollution in cmd_gen_envp","To":"levi.shafter@elder-tomes.com","Cc":"u-boot@lists.denx.de, heinrich.schuchardt@canonical.com, sjg@chromium.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]