[{"id":3678933,"web_url":"http://patchwork.ozlabs.org/comment/3678933/","msgid":"","list_archive_url":null,"date":"2026-04-18T00:51:39","subject":"Re: [PATCH 5/7] Fix some mode switching doc/comment typos","submitter":{"id":91428,"url":"http://patchwork.ozlabs.org/api/people/91428/","name":"Andrew Pinski","email":"andrew.pinski@oss.qualcomm.com"},"content":"On Fri, Apr 17, 2026 at 5:32 PM Alice Carlotti wrote:\n>\n>\n> gcc/ChangeLog:\n>\n> * config/aarch64/aarch64.cc (aarch64_mode_confluence): Fix\n> comment typo.\n> * target.def (mode_switching): Fix incorrect variable names in\n> documentation.\n> * doc/tm.texi: Regenerate.\n\nOk, with slightly more in the commit message something like:\nFound a few typos relating to mode switching. Fix thusly.\n\nThanks,\nAndrea\n\n>\n>\n> diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc\n> index ba73c2376a3cbb38567f36f5d3be28784e393165..bb4c95d33a692b3ea7c171afb803459070f4eb5c 100644\n> --- a/gcc/config/aarch64/aarch64.cc\n> +++ b/gcc/config/aarch64/aarch64.cc\n> @@ -32388,7 +32388,7 @@ aarch64_mode_confluence (int entity, int mode1, int mode2)\n> }\n>\n> /* Implement TARGET_MODE_BACKPROP for an entity that either stays\n> - NO throughput, or makes one transition from NO to YES. */\n> + NO throughout, or makes one transition from NO to YES. */\n>\n> static aarch64_tristate_mode\n> aarch64_one_shot_backprop (aarch64_tristate_mode mode1,\n> diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi\n> index 5edddd7f36e17fd121a1dff6229d0ed7d5034760..2832a447e3ee1a8f6ea7880de2737ee8d1ed0949 100644\n> --- a/gcc/doc/tm.texi\n> +++ b/gcc/doc/tm.texi\n> @@ -10696,8 +10696,8 @@ mode or ``no mode'', depending on context.\n>\n> @deftypefn {Target Hook} void TARGET_MODE_EMIT (int @var{entity}, int @var{mode}, int @var{prev_mode}, HARD_REG_SET @var{regs_live})\n> Generate one or more insns to set @var{entity} to @var{mode}.\n> -@var{hard_reg_live} is the set of hard registers live at the point where\n> -the insn(s) are to be inserted. @var{prev_moxde} indicates the mode\n> +@var{regs_live} is the set of hard registers live at the point where\n> +the insn(s) are to be inserted. @var{prev_mode} indicates the mode\n> to switch from, or is the number of modes if the previous mode is not\n> known. Sets of a lower numbered entity will be emitted before\n> sets of a higher numbered entity to a mode of the same or lower priority.\n> diff --git a/gcc/target.def b/gcc/target.def\n> index a9fcce7850fba9999d5961bf298ee4a7c93b411b..11b358f4160f0ec8d91dfdfe5c406e069ae9263c 100644\n> --- a/gcc/target.def\n> +++ b/gcc/target.def\n> @@ -7425,8 +7425,8 @@ HOOK_VECTOR (TARGET_TOGGLE_, mode_switching)\n> DEFHOOK\n> (emit,\n> \"Generate one or more insns to set @var{entity} to @var{mode}.\\n\\\n> -@var{hard_reg_live} is the set of hard registers live at the point where\\n\\\n> -the insn(s) are to be inserted. @var{prev_moxde} indicates the mode\\n\\\n> +@var{regs_live} is the set of hard registers live at the point where\\n\\\n> +the insn(s) are to be inserted. @var{prev_mode} indicates the mode\\n\\\n> to switch from, or is the number of modes if the previous mode is not\\n\\\n> known. Sets of a lower numbered entity will be emitted before\\n\\\n> sets of a higher numbered entity to a mode of the same or lower priority.\",","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=Vqs8640e;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=JhJIjAii;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=Vqs8640e;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=JhJIjAii","sourceware.org; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com","sourceware.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=205.220.180.131"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fyCrm5ygrz1yDF\n\tfor ; Sat, 18 Apr 2026 10:52:24 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id BA7034CCCA2E\n\tfor ; Sat, 18 Apr 2026 00:52:22 +0000 (GMT)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n by sourceware.org (Postfix) with ESMTPS id B99654BA2E2D\n for ; Sat, 18 Apr 2026 00:51:53 +0000 (GMT)","from pps.filterd (m0279871.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63HG4hXq2669968\n for ; Sat, 18 Apr 2026 00:51:53 GMT","from mail-dy1-f200.google.com (mail-dy1-f200.google.com\n [74.125.82.200])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dkaxcv6ee-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Sat, 18 Apr 2026 00:51:52 +0000 (GMT)","by mail-dy1-f200.google.com with SMTP id\n 5a478bee46e88-2ddd8ef5343so1479442eec.1\n for ; Fri, 17 Apr 2026 17:51:52 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org BA7034CCCA2E","OpenDKIM Filter v2.11.0 sourceware.org B99654BA2E2D"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org B99654BA2E2D","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org B99654BA2E2D","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776473513; cv=pass;\n b=OvYT1i5ydl0iDhxeEyZfP0zYaCQpWod3czpXu6OvVJFIhMzYkMDrULGt0SDGLGcbEp7hzFQ/KePjoFyqGlY3vakt15wjEKw/bvvvy77sJ6HrNXh83arY9JuIzt/1g+T3RI/nSDKaI1keELhvPqTIrzPzgMoWna5pR7Sxf4aGMgM=","i=1; a=rsa-sha256; t=1776473512; cv=none;\n d=google.com; s=arc-20240605;\n b=BWUShwMXpTWIZ632V+Nf1OeShAL+JdE2Lfy7CNWjaTMhdMk+Zu/194vuy9w089xTrj\n 7x+XnDmsoCwGHVGEkYG1hUE4cJ0CeKfuLoRLDe+aJ/NFhcwKKPVl4s87NNynAV80T7T5\n EQjmvYMzBWvAEjuX6YZsEbSefMmQ7AjRVpXYpzMjry7nAg24C/RJp0LHLah8OBFHggiw\n a/7hXdk0Sv9OuYiQy7+TuhIgetOyH2N5b4Nws/SjOS2TCJb0U+ZqcgT9YfZ/l2LEAAW9\n 3h7WV2Y3yiFrz2psWKbO6YXtqpZmaB+fQeS2NphqrTML/XMOAgfgZHAuRBNE8nZvW+gV\n Z6Kw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776473513; c=relaxed/simple;\n bh=tFvyC3B9gpadyM4gVF6JVlgMPd8ApgBzsXiAJQn3ack=;\n h=DKIM-Signature:DKIM-Signature:MIME-Version:From:Date:Message-ID:\n Subject:To;\n b=wMlu2FFyMwJ6BY06+gHtuf5u1i7uIT+4zeupemHalZgFjTkrMzXuKcyCX03Vu0faGVm3ZHiWu13hYOLr1WdxlenUUfTBhoOHsmhMnenkXXZ340/WRizfQsV+NKEu1RWNiMjqU4EhUzwFA8DGMKHu338glEyPTRAN1M327jzm8GU=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=/+xHMAGwd33n/Xya67ONG92S6V2Vn9eVTMiviJOWdwU=;\n fh=rd4jnMVIT7B45tfqYaIUE+ATKDPgBgU/xgE5rHrtEFY=;\n b=VnfHw30OOkLne/bdDp/gTo9EPCOCs6f50dwd0NggFryAVDPvtBhj0UtCNDJkxhJX42\n 2hTrDRgWKLMCZLUJFpaS3YJvOkFofML3+ur1sF0mN047upEwtVhBMmQGLZAncKrY5bpU\n 31RNsdmqRlHvhiIIiy49YTD+tKvEvJKhydUiA1yVOyOYdazSGgS2QS4fEJW9u/Gwn06+\n P0qPI6zdnq8JvC0jTESjGWzIkoYaHmvDkLOFy4ZzKlJ9rEdcVI2Ko65g14VkrPfeVlOX\n /k9ZiaIJIjaksMCu1+vJWbnCIcd57E8KFlblLvxBC4WN2kX2tm5fqyJIkVTET0a4b6XK\n 8TlA==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n /+xHMAGwd33n/Xya67ONG92S6V2Vn9eVTMiviJOWdwU=; b=Vqs8640eJDce0hCi\n Ld7a4u1WQduN0Xv1rBrn3V3RopNfyxgaI/vWz6fKHmqq7RPRJ4ptdKJ/DC9GDhSG\n xFeClASrLsJEbx4DtWG6hv+0VvQXJ/8ZbVZGrDx86nBTGPhe3+m4DbFY0Tq+Yf/R\n vTJXt/CMxUMt/o+wLTPHhKJ+Qo718JRx+J8FodUNcwPKNKEBcop/LuFEHFduGr1J\n yAS/r4v+CJb5z84BB/0OSRu+5Ucv7sKFlW+QCExza+ASdB/RFKqROUsrZwv2O8Aa\n yiClIhe07K/XX+IjdbzdWgXyhz93RUF/3oT/VCNGF3LvnlRC0oWohrkH7B9cjRcy\n Pf2aYg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776473512; x=1777078312; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=/+xHMAGwd33n/Xya67ONG92S6V2Vn9eVTMiviJOWdwU=;\n b=JhJIjAiiNVMPmeq99xkyixPh2ZWG6jthkgJjVBHO4srOl2kAOGqFLPCD1PftdTAWLn\n 9Wb3s6RMKX4+aWrf3ZHAhLEyNzV/IrbQ6s6E7BWnc2PMS3BK2Uxm9bbvlpm8BlI9lfzo\n wlEO+RYhLUHjVZaRevdKzhBfb+nuIG+N7rVY3P9e8mL8YfJqt2DLua06IwsivAt2Hs+V\n EhnrzlXdBQVdEgXEcS4tnO5mhwSun6CW4oozik4RC63SakleEmyC98CnwS+fFKcN3xS0\n qqnHmz4bIS08WCpUd9WGgpWu9loNHLA4hP+j+zTe1gBT3tFACgl88udJk0vdaYcp8mAx\n 0/DQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776473512; x=1777078312;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=/+xHMAGwd33n/Xya67ONG92S6V2Vn9eVTMiviJOWdwU=;\n b=NlxheBCIJwIv1YpA1T2F+QcBcZ0F/4i3JWr9M+b4Po4FeY1bxn6rsIovxIpm55gdiC\n 12SAB/6ohe4XkryNrk1+cwAX6I3SauuLN5q23OAjX7TXe8bmH9r9Ku5wg89G6el1+FWp\n AfW/m5UWlH6fqOe5EOp1HZNhg/K2UiI4tq29kBetmE7XuR1NUDbkUy9HmXAqQV2aS7HN\n 8dsULqiYjTZY0YuvJMqcC84Ee8m34Zhsr/MUSDhGlTmmgDt25p50aKFKr7CXpUj+ydIO\n 7JSzPLJaBSlq42NynNmEGNVBJbUvxSKaEB/FXgKHsgThiiUl+s8vHYT8SyF0CENjTrL3\n pWEQ==","X-Gm-Message-State":"AOJu0YzsUkshDhsIe0UAXLDqZ2HeDqwyfF+8wggdR8aTQ/N0Z1/tfY8e\n TgVbK0NcZ4B/zuzFuYNw0CWIamm6EIWFI21MO4BfR545BpUjhwlvSyZP8nP5wCxdXIl9FPnzwjg\n rYSE9wqUVKkjKfTJc+Ei50czYqRW/Id3RW8Q6vb6FMmut2Y1s4N/fXt1yyiiU9LNPxrot2lk8Tx\n pGRAnRpCEDhogtXk0OQXX2TEyQp7Z7Bjv7W5U=","X-Gm-Gg":"AeBDieusD1dKK/KtwklbS8UJh3fqMKH4ZXDwfMD6dCI58KUzWuf4bMuxOqBOBCRv1GM\n GLL3X8YFnN7NGHuIsvzP+ZzWwYpHxXbj7XuSrXnWb89gJOSo5sqY52Z+z+ui5LgGpf9NjvGG1z/\n Dn16JdGfBet62p0VeK2ESz7OpDnqIYEoy3S315T44DUn0Ke8j04UVctt+QDNiAIh4EMAp1WT0Js\n lTIpip2VI3q5Ig=","X-Received":["by 2002:a05:7300:3252:b0:2c4:ec89:bc7 with SMTP id\n 5a478bee46e88-2e464dacc71mr3164012eec.10.1776473511877;\n Fri, 17 Apr 2026 17:51:51 -0700 (PDT)","by 2002:a05:7300:3252:b0:2c4:ec89:bc7 with SMTP id\n 5a478bee46e88-2e464dacc71mr3163997eec.10.1776473511374; Fri, 17 Apr 2026\n 17:51:51 -0700 (PDT)"],"MIME-Version":"1.0","References":"<500b3dee-1ffe-5d08-2308-5bf06d38650c@e124511.cambridge.arm.com>\n <576b56b2-fce9-c187-c129-642f29988186@e124511.cambridge.arm.com>","In-Reply-To":"<576b56b2-fce9-c187-c129-642f29988186@e124511.cambridge.arm.com>","From":"Andrew Pinski ","Date":"Fri, 17 Apr 2026 17:51:39 -0700","X-Gm-Features":"AQROBzBTeA1wrtMSg_3qa514cMRz0NR1jl4vt9AZtoVI7_ALoqxQgNdbrbvnbHk","Message-ID":"\n ","Subject":"Re: [PATCH 5/7] Fix some mode switching doc/comment typos","To":"Alice Carlotti ","Cc":"gcc-patches@gcc.gnu.org, Richard Sandiford ,\n Richard Earnshaw ,\n Tamar Christina ,\n Kyrylo Tkachov , Alex Coplan ,\n Wilco Dijkstra ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Authority-Analysis":"v=2.4 cv=JcqMa0KV c=1 sm=1 tr=0 ts=69e2d5a8 cx=c_pps\n a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10\n a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n a=3WHJM1ZQz_JShphwDgj5:22 a=7CQSdrXTAAAA:8 a=wauKA3YMT2UaPeG8t8kA:9\n a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 a=a-qgeE7W1pNrGK8U0ZQC:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE4MDAwNCBTYWx0ZWRfX7+H/ZpKqK6fL\n z199ukZDeU2OD3F81DXhsbRHzEh5bAhHGOT+bbMjx6N1Bt9juWbgxC2uo5WoszFX73/Taipdwlq\n Bse5oB390FMOF6f18pm1mxcFixX93jAIVzmiIHbZOT9Ozp953A+k+v962Kqm6Q9W1mF4TwAA4Ry\n 4k+qphFLrEA1F3S/Ag9lI4gCNN0njNOZdyVsVb9L9GlK0dBXrltQe+3pYdGoSC127VOl+3kvijd\n 6cG+8v73kCeJU4EIZ9rpxbdl+vNr9NGpnnwTzhOUqlxOa6uYw01yxOYulfJ2ZKol/DecTRlHJyA\n Zr6e2yzOJ9uPgAFuw7hCdR6qKJicYVtHn56RAnF9YKxDbudxZSrfOOApTbV9SvIvnDgM77jaBQI\n 1/i96q0F4m2aLh8R3pkHgTkqJOoJ17z3eP5pSWxzhZs6V7b1Ry/BNT2MV1lfpRxjFzugzH+TqyX\n p7DxX9ovEXb2/vhWP8w==","X-Proofpoint-GUID":"6MqQMT5m9t-Sd9LMqR5Zqjcp0keci2t4","X-Proofpoint-ORIG-GUID":"6MqQMT5m9t-Sd9LMqR5Zqjcp0keci2t4","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-17_03,2026-04-17_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n spamscore=0 adultscore=0 clxscore=1015 malwarescore=0 phishscore=0\n suspectscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0\n bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000\n definitions=main-2604180004","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]