[{"id":3678887,"web_url":"http://patchwork.ozlabs.org/comment/3678887/","msgid":"","list_archive_url":null,"date":"2026-04-17T20:52:06","subject":"Re: [PATCH 2/2] target/hexagon/meson.build: simplify source\n generation","submitter":{"id":89839,"url":"http://patchwork.ozlabs.org/api/people/89839/","name":"Brian Cain","email":"brian.cain@oss.qualcomm.com"},"content":"On Fri, Apr 17, 2026 at 2:46 PM Pierrick Bouvier\n wrote:\n>\n> Use a for loop with a dictionary instead of repeating custom targets.\n>\n> Signed-off-by: Pierrick Bouvier \n> ---\n\nReviewed-by: Brian Cain \n\n> target/hexagon/meson.build | 48 +++++++++++---------------------------\n> 1 file changed, 13 insertions(+), 35 deletions(-)\n>\n> diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build\n> index d993e1b520..db3f3a5d32 100644\n> --- a/target/hexagon/meson.build\n> +++ b/target/hexagon/meson.build\n> @@ -241,44 +241,22 @@ endif\n> #\n> # Step 5\n> # We use Python scripts to generate the following files\n> -# helper_protos_generated.h.inc\n> -# helper_funcs_generated.c.inc\n> -# tcg_funcs_generated.c.inc\n> -#\n> -helper_protos_generated = custom_target(\n> - 'helper_protos_generated.h.inc',\n> - output: 'helper_protos_generated.h.inc',\n> - depends: helper_dep,\n> - depend_files: [hex_common_py, gen_tcg_h, gen_tcg_hvx_h],\n> - command: [python, files('gen_helper_protos.py'), helper_in, '@OUTPUT@'],\n> -)\n> -hexagon_ss.add(helper_protos_generated)\n>\n> -helper_funcs_generated = custom_target(\n> - 'helper_funcs_generated.c.inc',\n> - output: 'helper_funcs_generated.c.inc',\n> - depends: helper_dep,\n> - depend_files: [hex_common_py, gen_tcg_h, gen_tcg_hvx_h],\n> - command: [python, files('gen_helper_funcs.py'), helper_in, '@OUTPUT@'],\n> -)\n> -hexagon_ss.add(helper_funcs_generated)\n> -\n> -tcg_funcs_generated = custom_target(\n> - 'tcg_funcs_generated.c.inc',\n> - output: 'tcg_funcs_generated.c.inc',\n> - depends: helper_dep,\n> - depend_files: [hex_common_py, gen_tcg_h, gen_tcg_hvx_h],\n> - command: [python, files('gen_tcg_funcs.py'), helper_in, '@OUTPUT@'],\n> -)\n> -hexagon_ss.add(tcg_funcs_generated)\n> +hexagon_gen_files = {\n> + 'helper_protos_generated.h.inc': 'gen_helper_protos.py',\n> + 'helper_funcs_generated.c.inc': 'gen_helper_funcs.py',\n> + 'tcg_funcs_generated.c.inc': 'gen_tcg_funcs.py',\n> + 'analyze_funcs_generated.c.inc': 'gen_analyze_funcs.py',\n> +}\n>\n> -analyze_funcs_generated = custom_target(\n> - 'analyze_funcs_generated.c.inc',\n> - output: 'analyze_funcs_generated.c.inc',\n> +foreach file, gen_script : hexagon_gen_files\n> + t = custom_target(\n> + file,\n> + output: file,\n> depends: helper_dep,\n> depend_files: [hex_common_py, gen_tcg_h, gen_tcg_hvx_h],\n> - command: [python, files('gen_analyze_funcs.py'), helper_in, '@OUTPUT@'],\n> -)\n> -hexagon_ss.add(analyze_funcs_generated)\n> + command: [python, files(gen_script), helper_in, '@OUTPUT@'])\n> + hexagon_ss.add(t)\n> +endforeach\n>\n> target_arch += {'hexagon': hexagon_ss}\n> --\n> 2.47.3\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=luOQibEs;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=Gy1krhGs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy6XZ0TXGz1yHl\n\tfor ; Sat, 18 Apr 2026 06:53:00 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDqAw-0006sH-4C; Fri, 17 Apr 2026 16:52:30 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDqAt-0006rq-Qo\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 16:52:27 -0400","from mx0a-0031df01.pphosted.com ([205.220.168.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDqAs-0001d0-09\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 16:52:27 -0400","from pps.filterd (m0279865.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63HG4AfC2932850\n for ; Fri, 17 Apr 2026 20:52:23 GMT","from mail-dl1-f72.google.com (mail-dl1-f72.google.com\n [74.125.82.72])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dkhshab0y-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Fri, 17 Apr 2026 20:52:23 +0000 (GMT)","by mail-dl1-f72.google.com with SMTP id\n a92af1059eb24-12c726f4019so1267161c88.1\n for ; Fri, 17 Apr 2026 13:52:23 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n 9gQ8nxKYIf/4EH6ajlrHLijjyyVVFSIf9cgmdG8S6Gk=; b=luOQibEs9vv7F3wY\n T+ynQiimGMH3znNjPXnWAYenX38TCZYvUIoSNkFmoaDt8DR3oONImN68UPjeuM2G\n GYsC8KYf8/5g+Z0L35rZDzww41OVYhXFGprExzPqBIZ6qe1mqUyBdpDyGjvN6im8\n T84ZH8irASzJTtEAEg/PX/rHHw6LFb4arW6Dg3hnmeqVCu5e+GGWgnFGMvL2PAkG\n xwFm5l3pO3fbq3NJ7MbdQRF1yFjhGsiZMD5rk7RNrmIiLoWEpvy0Z/qpB5S7swgf\n Ft8FohCuHS5P9rZyHjs8QVnylQlD7r8FGxxC65P+pPZaAhUl6Zn62QVwSIhwaU6h\n eB0EEg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776459143; x=1777063943; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9gQ8nxKYIf/4EH6ajlrHLijjyyVVFSIf9cgmdG8S6Gk=;\n b=Gy1krhGsRt6xjid/SdJ5NUhILzpf+aWpHjh54epAQ0qy3z1c0xDx7cbOChDHFCBSoW\n 2+Qv3R2fSAhmcFd14tanp9Vm6t23fpm6DtxVx0huhvujjvbMZqV70FVEpK9Lof6agLVG\n AsOcmbzjnwum4lUAfqCnZEWbqAnrQY8pf25bRDEsmQrUWnzxDU8p3Hktu9fLoRJDkFvC\n C/huDCiAdMEKXGLD7TYOZksNRGqznhLBdCZXga2nEEDz38NW/cGixmX6/8KrdA7ZFq6u\n L7vDeY12hS5qC2t0ZGm5o3ryRJVgjyQkfVGCzTVC/6J1lpxFq3s9DjYMRVnR55AW2jnj\n R6sA=="],"ARC-Seal":"i=1; a=rsa-sha256; t=1776459143; cv=none;\n d=google.com; s=arc-20240605;\n b=cu6L/B0lZrdOQhvDwkGzTUkV6IrwsddOKWgynNz0A7O5FWo69EY+3nQIzQSJwoLsP+\n 24OqlQD+7lrb3whliKfKXBTJmkEYcPFNMDzjM9KSL+nN77ffFps11ZZCznbAGwQblyTU\n itx8JXtsjU/MvhXDp3Vw2uVvVx8pxzZPEbhGQfHmIaB0cCuFG1YcDHntuVPi+FqJf2ov\n If3NhrcH6SgKVqd4fRWAwG5mFTGeOU30GEq2zzsY3dSbzY4rKmgo1S+t+NHDB26XwETq\n JreGp0gnd7lqbZ56drxGPsyQUxPS94XSx7+Sxw1ZZPgUWyuDE2sCgX1SsXs41KVPBoPh\n GXUA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=9gQ8nxKYIf/4EH6ajlrHLijjyyVVFSIf9cgmdG8S6Gk=;\n fh=GWvQFnvgluS9XxOXx8Aj3eG17Oq+EZKzvZqSKBLhuHU=;\n b=LjUCrvy55ZwePJuYFANQwdSNeLR9zkR0J7Re1K6O/LGSyyPFXxptAcspJpY9aEcXcX\n 18fc7w0TGVsVS56Fse1FuryiA7X1dXn+Xihxw3CLocaoIzooQT5ybNRzHgZb9HeblS4b\n BGiGUucBT3Coe8c2U0pfQMkcT7RCws284X0wrZ8Qr+Mt9p76lvBUUYOud8OrnMJPwAlP\n 6pPqipmIsavyE4t2anYbT9Hk8SiNOBHxYhEt5jUMKKRGtSQBef2vF3OjhyLqTh5+gJ8h\n ekCyWXrgHomm95CmCqnQ3+yeJXfYNkIa+s3adMRBiDKu4humwE+cXZ6HutTAu4TsBGA6\n eIzA==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776459143; x=1777063943;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=9gQ8nxKYIf/4EH6ajlrHLijjyyVVFSIf9cgmdG8S6Gk=;\n b=giE7+w8P8myPbtzwNQMUv/Mj2G2q6uM+7hzmTZpz8jlsZrT56QEVc4vlEozxC9hU6h\n zfG9HiorkDn7uaoaJtCfbGOlHrTVkHXj5egPQOQmpqacM0Q57XiVkdNFerUEjUSI77zp\n 8DVNrvMZITRD5103hOJii37IHfKqnOVBAoqxlQZ6cTnHGLa4EC5mN+66V8TunwTHS3b2\n FG/ZWBea0GQE3VdNtgmqfiTdByr9afWjOt5u9MXdqyrUz6jrZ4JmtHhUxamB1pFidUR1\n 8fPT+V2BSGcbSyzyUnDc9bD4Tfm9JooLD7voWw+l2N2yjs0ha3PNn1sxdUudB/alr1s1\n g/Qw==","X-Gm-Message-State":"AOJu0YwdWbhhloqFnte+P6I9kYOp7J5W1iQuDjjFGOUrj0AO05Fy1dY+\n ufROTlR/FPsXwqCjOtMU+kg4Z0qrV056avCT9olD7cNjw7/4gu6SE39NogOnHM/4N/TBzMffsWa\n KFYlE6MvpH+Ms7g6LUEQ2RqRLMKevDHJexPuyjB/MRs9BIB8xiOFuScOS6OHXEm3UmBVUqh3RXS\n z1R0IxxKuObhnNGsmw/Hz1SXeaIawL5/cwLmL2a68DG+o=","X-Gm-Gg":"AeBDiesEF7QKQOIFIT32Z0B7LKPKlizU2ND3XpBb04kq3r7PVBtnYkbGiiDv4/vBcZL\n BT24xIhBZL508iatMtGHH4eoxavMH6uUspqhyQ800Cx1lBH2EnSy6ly2qzusjUP/fnn8NQqZcKN\n H8XG0RCFszYNqS5zUH7wE7KWRAn5forWh4dYJySEyGsf9AYWv8iHlKufRHUQStwz2YSfXw8VsAQ\n khX1bf2ygwqU82aMOg=","X-Received":["by 2002:a05:7022:f016:b0:12a:72af:83f5 with SMTP id\n a92af1059eb24-12c73f644a2mr1888133c88.7.1776459142692;\n Fri, 17 Apr 2026 13:52:22 -0700 (PDT)","by 2002:a05:7022:f016:b0:12a:72af:83f5 with SMTP id\n a92af1059eb24-12c73f644a2mr1888125c88.7.1776459142169; Fri, 17 Apr 2026\n 13:52:22 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260417194606.39997-1-pierrick.bouvier@oss.qualcomm.com>\n <20260417194606.39997-3-pierrick.bouvier@oss.qualcomm.com>","In-Reply-To":"<20260417194606.39997-3-pierrick.bouvier@oss.qualcomm.com>","From":"Brian Cain ","Date":"Fri, 17 Apr 2026 15:52:06 -0500","X-Gm-Features":"AQROBzCAn850jTE02IjeScISBEhxRFH9_nNLpHO2_H5PLluw1ud842e8WOmA9g4","Message-ID":"\n ","Subject":"Re: [PATCH 2/2] target/hexagon/meson.build: simplify source\n generation","To":"Pierrick Bouvier ","Cc":"qemu-devel@nongnu.org, matheus.bernardino@oss.qualcomm.com,\n Marco Liebel ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Authority-Analysis":"v=2.4 cv=d6/FDxjE c=1 sm=1 tr=0 ts=69e29d87 cx=c_pps\n a=bS7HVuBVfinNPG3f6cIo3Q==:117 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10\n a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=r2ihebJaxEnmDMgX0roA:9\n a=QEXdDO2ut3YA:10 a=vBUdepa8ALXHeOFLBtFW:22","X-Proofpoint-GUID":"mNfkjPl344P1lmZNhngm9LYvD04-a5zS","X-Proofpoint-ORIG-GUID":"mNfkjPl344P1lmZNhngm9LYvD04-a5zS","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE3MDIwOSBTYWx0ZWRfXyuwILPhe8OYp\n TRwlm6GiFteDyLn3R2o4fYgC0I4oAMnauN1yjoF6wo9/wSCIMxQDSk8uh46L7sTa2aLiPuEXFcN\n exhyJeXDQ7d1+yyOcD8uLvKN/DxwmhJbj/nSlVJ/UBO7FfStdRBDqG4QiWUEi61EAn/qJpEthl5\n yZQBWJbpHuMu5HhXi9tkj/TEmuxCgOwFEVFx33za/YxkcLtiGUfBldf+NzWKXFmc7kXyXQTlH+O\n sTMhiEEqJYMXeuokds1GoL3CDymX7uv5KLKqh3ftX1iQWJogHvmnzmDJpmiqYufJd1nDoh/Vm8o\n k7fgo4g6DglftlwuyMk6Cupk+pbvW5Qvz1mv3BzEmeUr392kowxQxHE6+drZ3qqoi+7DwflOCPb\n uE1vIrjjxGHFCVd4ueCWsSYG7LCTFCiGXnZxXF3jcMjGZ+/oMkg0yKdLFYWPq6dg7DACnDOWqY0\n yUnIxRQymQtKPPfxmcw==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-17_02,2026-04-17_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 malwarescore=0\n lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170209","Received-SPF":"pass client-ip=205.220.168.131;\n envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]