[{"id":3678868,"web_url":"http://patchwork.ozlabs.org/comment/3678868/","msgid":"","list_archive_url":null,"date":"2026-04-17T19:48:28","subject":"Re: [Intel-wired-lan] [PATCH iwl-net v1] igc: set tx buffer type\n for SMD frames","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan On Behalf\n> Of Kohei Enju\n> Sent: Friday, April 17, 2026 9:32 PM\n> To: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org\n> Cc: Nguyen, Anthony L ; Kitszel,\n> Przemyslaw ; Andrew Lunn\n> ; David S. Miller ; Eric\n> Dumazet ; Jakub Kicinski ; Paolo\n> Abeni ; Choong Yong Liang\n> ; Vladimir Oltean\n> ; Gomes, Vinicius ;\n> Choong, Chwee Lin ; Simon Horman\n> ; Kohei Enju \n> Subject: [Intel-wired-lan] [PATCH iwl-net v1] igc: set tx buffer type\n> for SMD frames\n> \n> Sashiko pointed out that igc_fpe_init_smd_frame() initializes\n> igc_tx_buffer fields for an SMD skb, but does not set the buffer type:\n> https://sashiko.dev/#/patchset/20260415025226.114115-1-\n> kohei%40enjuk.jp\n> \n> Since igc_tx_buffer entries are reused, a stale XDP or XSK type can\n> remain and make TX completion use the wrong cleanup path.\n> \n> Set the buffer type to IGC_TX_BUFFER_TYPE_SKB.\n> \n> Fixes: 5422570c0010 (\"igc: add support for frame preemption\n> verification\")\n> Signed-off-by: Kohei Enju \n> ---\n> drivers/net/ethernet/intel/igc/igc_tsn.c | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c\n> b/drivers/net/ethernet/intel/igc/igc_tsn.c\n> index 02dd9f0290a3..52de2bcbadbe 100644\n> --- a/drivers/net/ethernet/intel/igc/igc_tsn.c\n> +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c\n> @@ -34,6 +34,7 @@ static int igc_fpe_init_smd_frame(struct igc_ring\n> *ring,\n> \t\treturn -ENOMEM;\n> \t}\n> \n> +\tbuffer->type = IGC_TX_BUFFER_TYPE_SKB;\n> \tbuffer->skb = skb;\n> \tbuffer->protocol = 0;\n> \tbuffer->bytecount = skb->len;\n> --\n> 2.53.0\n\nReviewed-by: Aleksandr Loktionov ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=YZ4M7a1n;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy56M6R8Zz1yCv\n\tfor ; Sat, 18 Apr 2026 05:48:43 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 492F181EA0;\n\tFri, 17 Apr 2026 19:48:42 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id yPoJ0mPbOJPa; Fri, 17 Apr 2026 19:48:40 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 0162681E9B;\n\tFri, 17 Apr 2026 19:48:40 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 9D5AF396\n for ; Fri, 17 Apr 2026 19:48:38 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 8EEF940F36\n for ; Fri, 17 Apr 2026 19:48:38 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id stEJGGw4j6iq for ;\n Fri, 17 Apr 2026 19:48:37 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.9])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 7D89340D0A\n for ; Fri, 17 Apr 2026 19:48:37 +0000 (UTC)","from fmviesa006.fm.intel.com ([10.60.135.146])\n by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Apr 2026 12:48:36 -0700","from fmsmsx903.amr.corp.intel.com ([10.18.126.92])\n by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Apr 2026 12:48:36 -0700","from FMSMSX903.amr.corp.intel.com (10.18.126.92) by\n fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 17 Apr 2026 12:48:35 -0700","from fmsedg901.ED.cps.intel.com (10.1.192.143) by\n FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Fri, 17 Apr 2026 12:48:35 -0700","from CH4PR04CU002.outbound.protection.outlook.com (40.107.201.61) by\n edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 17 Apr 2026 12:48:31 -0700","from IA3PR11MB8986.namprd11.prod.outlook.com (2603:10b6:208:577::21)\n by LV1PR11MB8844.namprd11.prod.outlook.com (2603:10b6:408:2b4::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.25; Fri, 17 Apr\n 2026 19:48:29 +0000","from IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c]) by IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c%5]) with mapi id 15.20.9818.017; Fri, 17 Apr 2026\n 19:48:29 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0162681E9B","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7D89340D0A"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776455320;\n\tbh=PYAXDmhnuMMPh9MLGezbtM/m4IDzOUyswtux6dIevOA=;\n\th=From:To:CC:Date:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=YZ4M7a1nnf225JD9BUpKUDeg0M90BFDkVcG+/gmg4AaN1TlKMk7S8vME8Y0zC68rb\n\t iv25QZ7m0tveefjLNWeTRgt972aEQg2lhJw4G4hqI8OLpRuKmye1jC824F79VOtcjj\n\t tBxvHeZ0k+oDj2+nFtbGwGPWP0pGahprovcVT5pNrVcFPVAHenLEiyFUIvCcZahyg9\n\t K21O+zdBBIFIGFNU66jFEfCQPWIH3O49RT6YY3wsSTJQ2Sn0XmySquNrN95TVU0j0R\n\t aOwQk/M5fW1Jk75m7EZNeNeBwCrbw7n6C2LhqspfHTAOdP4uCU+aoykmFE2B8Cf/qn\n\t pyO+jMVJzODhQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.9;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 7D89340D0A","X-CSE-ConnectionGUID":["eCn/vcIBQjyDpNO9d0LRRQ==","i+C6+uOmTSeTTXnoCwL6ng=="],"X-CSE-MsgGUID":["m8P87cdiQuylzTPLK0TL6Q==","ctTscXdkSweKaRK9oF8vug=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11762\"; a=\"88174355\"","E=Sophos;i=\"6.23,184,1770624000\"; d=\"scan'208\";a=\"88174355\"","E=Sophos;i=\"6.23,184,1770624000\"; d=\"scan'208\";a=\"226438417\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=H101lcd+nuQTEY/P9FC456j8K5S1ew5U3cr0cCXEwq5rwIfNPF6UzLWJHbbPlKVltkVbdgpKjjAWrm3WE63vFbg/I7r9++8th0X9hZWYuq1Q1Jd1a1rT15d1TIf1500vom/1RoX9mu6w2jl/sNzNmas5m9ilJcT8rtjxZRnSHX7Xr4QSNPOw+Tm8Fc8E9Vg7grTlrxx0OZtNplMaLngdoDGinCU6ZrkXShKKP0Kc24/zxn1UL4OgAZMvktYjxGjiOOIVOitS15ZkzAXdbm5wF68P9aklXKmyG/Hkz5KLJHkwyhdJHIxA2y6Xygs4D89mk3C6VkSj0ckLt772PD/ZKA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=PYAXDmhnuMMPh9MLGezbtM/m4IDzOUyswtux6dIevOA=;\n b=Y045VZDuIF7V+f3yu2yDa6YWDOfYmAbKjcvVnNKVatMeVtfThlFskNtcNO0XAPOy7gsJDSGjY+T0O3wA8ZpUdZDbsjSXh9kDLl46B/OMnYY/yuzA8ay7ILijxQSTyjtpwyECprFljhoWKFIOniI2UKOP88qKWyhw25RoH8dBv46B7hg5+WiSH5t65oYfruxH0p47NUNK2aWNCdZnqLlNbgdDWbKrhy7nYHKDJKzw3D/CoMCTg6ZgHyq/gIuTCj3E6ymFqXMJLvBBqTzeA708a968gJBIDESzgHSsvafDqz+KXOL3QD8CHKY6u0dTAA+LqTpvfQFJ8yVBPZFGDUXB8A==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","From":"\"Loktionov, Aleksandr\" ","To":"Kohei Enju , \"intel-wired-lan@lists.osuosl.org\"\n , \"netdev@vger.kernel.org\"\n ","CC":"\"Nguyen, Anthony L\" , \"Kitszel, Przemyslaw\"\n , Andrew Lunn , \"David\n S. Miller\" , Eric Dumazet , \"Jakub\n Kicinski\" , Paolo Abeni , \"Choong Yong\n Liang\" , Vladimir Oltean\n , \"Gomes, Vinicius\" ,\n \"Choong, Chwee Lin\" , Simon Horman\n ","Thread-Topic":"[Intel-wired-lan] [PATCH iwl-net v1] igc: set tx buffer type for\n SMD frames","Thread-Index":"AQHczqEFVWMQsWO+1Uu8kNLKYNnfP7XjqPlg","Date":"Fri, 17 Apr 2026 19:48:28 +0000","Message-ID":"\n ","References":"<20260417193223.291093-1-kohei@enjuk.jp>","In-Reply-To":"<20260417193223.291093-1-kohei@enjuk.jp>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"IA3PR11MB8986:EE_|LV1PR11MB8844:EE_","x-ms-office365-filtering-correlation-id":"cf38febf-0832-4d60-8f44-08de9cba4c40","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|366016|376014|7416014|1800799024|38070700021|56012099003|18002099003|22082099003;","x-microsoft-antispam-message-info":"\n Z19TXH7gsZH+ZZYAdIxrIgfFN1Lo+E2ntS63V2fLgGLflj9sewMl1Q95yI1LkcAXHxQK1lFOcDyVpEKMHWoYELVyX3/yybYjVmGOui1fL6C/ISbEE/7qyxn9oRtOkJDufDCrVdhLxYgJwq+pMB2ZXyucKGGaYLQ9fontOSRvN1Fy0Yo/uhG1u6w0tft9YQ+b1l4InCCzU0XsRw4DrP16O5x4/fCMKX5cPEuAPBDhbtfJPpzweoQ+SVzq/WChx3xqYtFVAQHgn5TnVMG1iIQvjnqzXumnE58xg5vgCbu1mFkLD9N1w69DIQ+X2rmLQ0GeYdyfKz1USzNHCUF5ptT/uN0ofZFCRIX5loGpQAcO9uWUSPrDqsoKO00876trSQKabq5mUsajiorWWVhXpH+JsB5oMINWkZ+52pEyQPy+MctikaPxv/Jm6cmtQOU2gK6BSmBLaUbJSWi3tFNeOkTLlasGd5z43T3BTcHVUB+vaTX8iFq+TZzs3X9yfgHHK3/ZYX8bdd/Fmtbd/t+rG5o9CJD9M6X9CIx/ocTnciy1GIiwniT7msN7RCT3c/Sk5TEPx9G3lJJp3iGnglERyTtHCvBJe8qCdxIBxBJ+3m1XyXIvMI1zM3MGu5j78WqVJdvbdDglpTqsSW2VnDiRgeNY3zr1On76UYilPA+e/d4+Ak34kua/V7IvlAa4XOQmMImbDROuEYDg4VOtQzKQl871yrRt/xNzOkushfEShcnPYdo=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:IA3PR11MB8986.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(376014)(7416014)(1800799024)(38070700021)(56012099003)(18002099003)(22082099003);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n Euh9UlfC0a3lCHEvfR9pWRWdTy60+0mbbld/rYXLVxwF3zBuSCRtnbbA5ka2P7K7TAhJsWwvh+Y2I2vdQF2xTVXVhGfmUErsHI2+vH2tU3qzz3t/LtCyOgD2kkn3EFrplWBXNzyHSoYPX8Un8lh0suLbHy7fyEjiwBaz7JFsh0XamS9syIO/8EV2vcWZoWF+XtjC9HGNBgLnEPYo+Dx5RgPoqQzVqp2WHnfw0cHdRkAn2WXV7aT0GLykvglHR99gzt2Y109elR5rsGx+lxMIsuemvZSkQgtQlcdam4vVrGfa6O93S9+y9XQORypx3muPWskvvpaivYG59JLCqKTNDhi5ait3S8gSTmb3l65BJ4Ox893OsSQXPFen2jabrLlZ1mZY5r083CWeIjhbytYvDN8jbbbxt0NM7H4yMFGFj6SDjkCRVn1JxP0VXw9PJt6lk8v46q2tEgJV/S5bDCTpLeRW2cyCAGEXy1X4UMmskimfWIPh+NBarBY37temvze++XsXzKrv1Iq3RrkJ6u9l67ogQNXwWIR4Bmp2xgantLxD/Sc2TYjoZ4L4DCeCAv9pKfKYlNF8Wfjon3VBLNaNQavxHheWgKtSThN6w/IVcTpcQoGPmZkrkCfvWgQOvGaTj91oV3Vko9KsTJzjRQFactf96gtzwK5zXWQzSEktqYGG2Ho+YWodadd5n/wJpgm+VmCEMRy15/xBiqZDMQfPyKeUcHOYpUuiCeBjuHu1khM6wNSBAA1dbEhMHsdYPQIfDuJvUFhpch7oxYBqlriC3hLiafMv6bpIlYCz3iZkM+4XbBgW/H09/JXxxyAqjijK5MBrL/YoRubz/FwyuDjV4bTsmb6q0XJ3L0mvat/9fBLBjFWOWWsCtqculzuFBmDX/WrwlXw4cfwsFTiHZ9FFcq0KZZqdIP1nGgNb5/0rsJ7vDW6kSGqQK7Tj+UtubaFtVo/MHmsuNDZ0HCngLAthkPh2beUskO8oldJn+fVJyjAXDj5ZFN+11LF6V0WUnjHYJVrLsvtNbtC91Lg+inkou7gXIbfnau09S9wXf83BcV8VBROxBNh9Sa0953tq5z5O26JSrFpvdWwoEpZnS3kjVALJRbB9DEusr5KBvij25xhptbubLYZxa5m8TPWnrgcah1XuKDoXtcX6iUwgfF0dUVkPuQbX9TQLmnqOnIe77RqczE5BehtNFYbnzRtoWpSZmCiXiuCoCuj3rqRN4tyn84s1kT6/d4xH4Fdm/c+j5BoUQFvdTBsT7nejuqYq7jMTXbUktmqdKJEzsnBxg1TWBSN+Y1CCtOmHD2l+SHI1vMJx/HjGr3El7NGEj5XtdqPdp1vODk6ZQR9BaPXi4XwnBbJ7WsxzmS2LuOJMCaKgzPUwT69ul/jZgCCI2jJuJRatI/2WVJK7lg11e6HcC3xvESJKs+dRgbmEntSYbtwrnHntLQCZ3vtivASycWuzzzHVqjH75MeF2zdCovxkYFrEGzOnUp5/N/Fbsn8v/Y464Y6HOjspuJINgK0cDzWuwYVrexYTQvx4xHenQmU5zpFrTUl1Z+yKP8u3TOaA5GTlrMqfLH3z7FzxvsX1MIjkXzQHdsz+gfDqrQaW9j4q9M7u3fz3J2rqOMlvBZWGPiU7CIONlXqNKhGyuEIwgh+BJu65T6T0F1bYhpOKHdFphMpT0QERvwFunRL94mTwsYMvzBJ1qHuPqxA+uEgL99vjpfnZmA+MT4PDyoyK5fXGl2O0wPNvctmU0V3BWr0AMFvGIbU=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n W1bteuxKqzBHf0RY1kCjJ+50C8tE2LUXK7DwIrJgoFQN0nGrfOwuQK5LP4iMf1s9WpADoSL/3rjFuxRqbb5M2EacE5rdMh0tZay8ilmoikOBntP8jmbR4fKf/VYd70mKs0eO2p9+cwjOZeLwnI/pw5/1gnnXA6XWrByaGIhogZXcq+4RHCO6/pl9s16su4fPdMNZ16cmWl0wQiMaoggpky1JcLoExS0TXGJj6FM0VK2rQ50KXRrxH7Au8Uv261f5wx/VAPRrl/nCBG/9SmBZ3gMBcn4VXY7G+/F1mFbV5vSNM6D6HYmBoqLvbgtxESqnL1O8kYrQuVXPGM4UXx7SyQ==","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"IA3PR11MB8986.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n cf38febf-0832-4d60-8f44-08de9cba4c40","X-MS-Exchange-CrossTenant-originalarrivaltime":"17 Apr 2026 19:48:28.9278 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n MTYdGqe2NfTAURPZdSeRabtIjNQVB8MA+3iaa66tBx0FSXqa0EaJDz0oCIxejGkNNlDXi0GDCN8jvPSqRKe570uLfbisdvGr2BCQgtoQ5qs=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"LV1PR11MB8844","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776455317; x=1807991317;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=FvJ9QMgcnZ9nendVEIt1x8KrpQ0sL+wvarn2BvB3Fz4=;\n b=CzpzBbAP0gf2WWXMZml//6XBQ+WKW3nPpghVWZnmvs8EWzL+H/VbX+Bm\n LB8TMl9OJBnHZvHK1R2fnupvfio4bt/3xkRs1rj8ZHSSJ3ynwjVc8xKTi\n ThcMwf0Vtk1VLhOXCNZO0tgwl4/s/DM2RBffs0tCpnEtvDqj6z9Pqps/j\n 7YcoyQymssLrLeV3StZ6jIie4EmPkUFhH+bVLyR03diAI9flHCeVkD6YT\n BMRuBEX2ipw0pLGPRBy99DY37hMmC+Ub3J6+TGxDqhNPdDjzH4FNjrmfu\n 3kCR1JYkk+QP2p6tfBnyYeoyO4MAp7w1DNasNN59cqKoEu1G5FVLbJJ6j\n A==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=CzpzBbAP","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net v1] igc: set tx buffer type\n for SMD frames","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3680701,"web_url":"http://patchwork.ozlabs.org/comment/3680701/","msgid":"<20260422164659.GP651125@horms.kernel.org>","list_archive_url":null,"date":"2026-04-22T16:46:59","subject":"Re: [Intel-wired-lan] [PATCH iwl-net v1] igc: set tx buffer type\n for SMD frames","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Sat, Apr 18, 2026 at 04:31:47AM +0900, Kohei Enju wrote:\n> Sashiko pointed out that igc_fpe_init_smd_frame() initializes\n> igc_tx_buffer fields for an SMD skb, but does not set the buffer type:\n> https://sashiko.dev/#/patchset/20260415025226.114115-1-kohei%40enjuk.jp\n> \n> Since igc_tx_buffer entries are reused, a stale XDP or XSK type can\n> remain and make TX completion use the wrong cleanup path.\n> \n> Set the buffer type to IGC_TX_BUFFER_TYPE_SKB.\n> \n> Fixes: 5422570c0010 (\"igc: add support for frame preemption verification\")\n> Signed-off-by: Kohei Enju \n\nReviewed-by: Simon Horman ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=fscBjqC/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g14rb5jGFz1y2d\n\tfor ; Thu, 23 Apr 2026 02:47:11 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 63BEF42822;\n\tWed, 22 Apr 2026 16:47:10 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id XkpoSSM6XiS7; Wed, 22 Apr 2026 16:47:08 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 4B80542821;\n\tWed, 22 Apr 2026 16:47:08 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 246EF257\n for ; Wed, 22 Apr 2026 16:47:07 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 14C2384A6B\n for ; Wed, 22 Apr 2026 16:47:07 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id FsoPImzD7XEo for ;\n Wed, 22 Apr 2026 16:47:06 +0000 (UTC)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 44B9184A67\n for ; Wed, 22 Apr 2026 16:47:06 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id 658534026E;\n Wed, 22 Apr 2026 16:47:05 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 90FDBC19425;\n Wed, 22 Apr 2026 16:47:02 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4B80542821","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 44B9184A67"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776876428;\n\tbh=iBcNeFy4bwZg4GDcMVrL3GGrQh0CpdmkUzKSHKENMeA=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=fscBjqC/fvKJP2csbEODSjkN8r1lmGLf3LhAYSNanOvPqXj7Q5MYGNNvCd+JGxtM0\n\t 1Zh/1L84UZ3jO2EZdUVWm3n53r3g0GaR3VjedB6FUOp9GOo2JX4rK/flCIsQSPu/xH\n\t SvgraWTCdnnqFlD2p+nreGva42bDysL2fe5jLhtdAODsLSAf1PgoZzCUCocnxua3iG\n\t iljc8UvT559tCaMYRnRKfos4EN+bkAdNSk/JI9q81455FGChQzuA5uu3sqHTEmFsgQ\n\t KpkB7h4vPRsp/lcvzt+PVZ+KNK4f7IMPgScjx4A2/cZki2Ygabv0hkfWHT4nE038jP\n\t I97tE+FovklQg==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=horms@kernel.org; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 44B9184A67","Date":"Wed, 22 Apr 2026 17:46:59 +0100","From":"Simon Horman ","To":"Kohei Enju ","Cc":"intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n Tony Nguyen ,\n Przemek Kitszel ,\n Andrew Lunn ,\n \"David S. Miller\" ,\n Eric Dumazet ,\n Jakub Kicinski , Paolo Abeni ,\n Choong Yong Liang ,\n Vladimir Oltean ,\n Vinicius Costa Gomes ,\n Chwee-Lin Choong ","Message-ID":"<20260422164659.GP651125@horms.kernel.org>","References":"<20260417193223.291093-1-kohei@enjuk.jp>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260417193223.291093-1-kohei@enjuk.jp>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1776876425;\n bh=I8t8RTkMnBk+PgfRd8qWXKGoXCX45BEPArwzNaPdUEA=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=GSL703Ul2+Tt5SG3MlOUok3KwhVze8aPcd3RcX44dFVCbrvu26z6JNRLHD5EBcAxX\n kPMoIyOh85Cb4fRr2/21W4lMSVr2M+1Wsf9GAZpmfSA/asx6V7/XlO007Ov2lwUPOi\n penS2jrrKVKxLoXhuQYoAlwH5lmYZKYRiSiAp1l+4o9SKf8bLF1vCvl/iY3hU7JCdu\n DmWImt1Ndaf87G6jJJ2GXWvHXvdNTZa2CPi1LtHVIgy8YKI9RgYHM06D19nrhxQzGa\n 8UPbT8bC96AKuIIXZ9QAS757e4QdivycUe3c8H1P080Id6o1ESsMz3j9kWC/S3IUMX\n 7TQcHzYJB50dw==","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=GSL703Ul"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net v1] igc: set tx buffer type\n for SMD frames","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]