[{"id":3678863,"web_url":"http://patchwork.ozlabs.org/comment/3678863/","msgid":"","list_archive_url":null,"date":"2026-04-17T19:03:10","subject":"Re: [PATCH 17/30] Change `class escape_summary` to `struct\n escape_summary` to align tags","submitter":{"id":91428,"url":"http://patchwork.ozlabs.org/api/people/91428/","name":"Andrew Pinski","email":"andrew.pinski@oss.qualcomm.com"},"content":"On Fri, Apr 17, 2026 at 10:36 AM Torbjörn SVENSSON\n wrote:\n>\n> Building GCC with clang gives warnings like:\n> warning: class 'escape_summary' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags]\n>\n> gcc/ChangeLog:\n>\n> * ipa-modref.cc: Change `class escape_summary` to `struct\n> escape_summary`.\n>\n> Signed-off-by: Torbjörn SVENSSON \n> ---\n> gcc/ipa-modref.cc | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/gcc/ipa-modref.cc b/gcc/ipa-modref.cc\n> index af508d75d06..10ad174fcc7 100644\n> --- a/gcc/ipa-modref.cc\n> +++ b/gcc/ipa-modref.cc\n> @@ -514,7 +514,7 @@ dump_modref_edge_summaries (FILE *out, cgraph_node *node, int depth)\n> return;\n> for (cgraph_edge *e = node->indirect_calls; e; e = e->next_callee)\n> {\n> - class escape_summary *sum = escape_summaries->get (e);\n> + struct escape_summary *sum = escape_summaries->get (e);\n\nThis is another example where removing the tag is better than keeping it around.\n\n\n> if (sum)\n> {\n> fprintf (out, \"%*sIndirect call %i in %s escapes:\",\n> @@ -527,7 +527,7 @@ dump_modref_edge_summaries (FILE *out, cgraph_node *node, int depth)\n> {\n> if (!e->inline_failed)\n> dump_modref_edge_summaries (out, e->callee, depth + 1);\n> - class escape_summary *sum = escape_summaries->get (e);\n> + struct escape_summary *sum = escape_summaries->get (e);\n> if (sum)\n> {\n> fprintf (out, \"%*sCall %s->%s escapes:\", depth, \"\",\n> @@ -3803,7 +3803,7 @@ modref_write ()\n> bp_pack_value (&bp, sum != NULL, 1);\n> if (sum)\n> bp_pack_string (ob, &bp, sum->fnspec, true);\n> - class escape_summary *esum = escape_summaries->get (e);\n> + struct escape_summary *esum = escape_summaries->get (e);\n> modref_write_escape_summary (&bp,esum);\n> }\n> for (cgraph_edge *e = cnode->callees; e; e = e->next_callee)\n> @@ -3812,7 +3812,7 @@ modref_write ()\n> bp_pack_value (&bp, sum != NULL, 1);\n> if (sum)\n> bp_pack_string (ob, &bp, sum->fnspec, true);\n> - class escape_summary *esum = escape_summaries->get (e);\n> + struct escape_summary *esum = escape_summaries->get (e);\n> modref_write_escape_summary (&bp,esum);\n> }\n> }\n> @@ -5454,7 +5454,7 @@ ipa_merge_modref_summary_after_inlining (cgraph_edge *edge)\n> /* Now merge escape summaries.\n> For every escape to the callee we need to merge callee flags\n> and remap callee's escapes. */\n> - class escape_summary *sum = escape_summaries->get (edge);\n> + struct escape_summary *sum = escape_summaries->get (edge);\n> int max_escape = -1;\n> escape_entry *ee;\n> unsigned int i;\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=m3BP909f;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=HxjCOxZ2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=m3BP909f;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=HxjCOxZ2","sourceware.org; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com","sourceware.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=205.220.168.131"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy46q3BXKz1yCv\n\tfor ; Sat, 18 Apr 2026 05:04:03 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 1BA5E4CCCA2C\n\tfor ; Fri, 17 Apr 2026 19:04:01 +0000 (GMT)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n by sourceware.org (Postfix) with ESMTPS id 804254CCCA2C\n for ; Fri, 17 Apr 2026 19:03:27 +0000 (GMT)","from pps.filterd (m0279865.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63HG486L2932783\n for ; Fri, 17 Apr 2026 19:03:26 GMT","from mail-dy1-f198.google.com (mail-dy1-f198.google.com\n [74.125.82.198])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dkhsha3ga-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Fri, 17 Apr 2026 19:03:25 +0000 (GMT)","by mail-dy1-f198.google.com with SMTP id\n 5a478bee46e88-2dd6fb4c867so2960614eec.0\n for ; Fri, 17 Apr 2026 12:03:25 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 1BA5E4CCCA2C","OpenDKIM Filter v2.11.0 sourceware.org 804254CCCA2C"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 804254CCCA2C","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 804254CCCA2C","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776452607; cv=pass;\n b=VlI/xdVbp0TQ+OyTnBOk4htULu6Tj+8ZZGYxBsFSh+HloqWd7o/wJflfiqAjnIJN6Z6jW+9RFd/vLWPsLnWTayPxkOnwwlH7p3uwV7uAnicwq/xA3Husj2d7vq03ltBhDSmwuIk6lHSQoBc8ve5S6XrmTPXbvJ82ryJCmZmPkXE=","i=1; a=rsa-sha256; t=1776452603; cv=none;\n d=google.com; s=arc-20240605;\n b=cyRIXuGNKYKcGT2C0iccK5uDIljMALFwMo+pmGjIdNPa2tpkeCAvqmD4thyY9ei6HX\n pL+eA9SZF4kkgTZ4xpG52QL+IDZ12G+3i0YmA1M67TrorqCICE3kx3NqOZfqzYEpKvi5\n yMRnzkYXwymeAD0RWFk0ZSrTlwIjzI9Ws+ZSDW5KsY6ZXYIgGUE6TCFrGyRfer5G1p94\n wbeckvAgoDVwn4kmxuwhgQuteSE2kKCM5minAQZOtrt8lfa/xLmDpltVtCGpfv/lFsSr\n AnOnmf9RJb6JRN6RauwDGxL72XnUuA1fsdMh7wvgKnLQ91rRoSPdMWc7Z+GGSQoV60R+\n bVsw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776452607; c=relaxed/simple;\n bh=KV0ppXpHZgM2HrRl73Ui8a7lPnymW+aDMKGH6WC4iwk=;\n h=DKIM-Signature:DKIM-Signature:MIME-Version:From:Date:Message-ID:\n Subject:To;\n b=JoH9v6YMHDn1ThiMt2pDEmTWZj7CxQySXWtqVnGB9SAssPMsshw3NbHUP3F9yV+4RmfwiYiXCyOVoP5RFWh0bvseKwGQZ/hBmDlbO4saQ6BL9JNioW4aJ4dm4sAnIiOB8SCfsqtFBeu1NsbHurnwQQBg1mWFXjITpeKOY7rb2o0=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=0Wy7aEvsN/clgEXN9b33xr0KG5eaCEirucVfLQg6+E4=;\n fh=DG0ZxEQyojbJOuIOd/MOxKcbunKJQ5dnNBaCVPRTkp0=;\n b=GeohOwmieYMIbZepaKUlAI+pUotO7IxnqxLmHIM66mFyikkvl3aMRLL+HLVbwP3LXO\n c3aiLsCyACxD0NkHU7FcQTNdrmCEz3Uuo7tc5YpBzftQdW2Sa8prnkP/DZe0wkBi5Y6Y\n YJ5YCok8DwISJU1IfwVd10dWHJqTATo0JhP+o4biAqrk5ZfBdFcFPB+aDQTdoa/yYXgs\n vu1hE74yrym6H5+A6Jk41dx2/CZZXo3S2DoOC3ZDLYboDvKx0ipNBhvkHs8Kc8Ylt++W\n OHHws0FVnzgl+kqVaOCOUczoOCCiWRYHNvAkwxXRsaFVsWuzI/pN5hln1tq/L2k5nX4x\n l4UQ==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n 0Wy7aEvsN/clgEXN9b33xr0KG5eaCEirucVfLQg6+E4=; b=m3BP909fNtGqyJSo\n zakT2tqleqQjZIkRfkH/hyT06rvs7lchsdcXUn39L1Flqp3rpeLBhRPOgbfEfmrV\n avtGq5mSR2XFYFSlHNwEvZHz+2+rz9Cq0PvdvWEuHBO1r3KId391gvipbnAhPxpc\n DsTJTJ2wRgCxc4bR95gPgvP7wHXusOaCezcFDconAkwzJrfP6LvH68rcwcwkFObg\n DswizLOSJFQ0rPUXWRqDL4XIVg/j/dW/og/xvHeYqvwBM4Qk2aU9cFfBeorGHzib\n PMbICpd1x8dH3NdYf3FOsIDMg6yPAiwb1rxZohvNT10HOVHP+g0bwbVeNCWZx+IV\n kLv/gA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776452603; x=1777057403; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=0Wy7aEvsN/clgEXN9b33xr0KG5eaCEirucVfLQg6+E4=;\n b=HxjCOxZ2Mv+Aa7j9NbPZmy9wDokDiu8rtrHc1w3wr8ClaF5nkpiiGs8BucI/QZZtJC\n Y4QqjV+9Rn7nBwaHccaBJdEtoRtfZUXW9MuJI8OLo9xSaqQ4e2hhsgRy9MUehgxgCfIx\n fTWnarfhUSnV14M+xVU4e+lEM3eCI95pNmUZrKMMkQnbhlWsakUJzl0M9bl99CdKIyVf\n 31ii3//SpvHIldvhVNzrmbQ5am4V4N2GpI4RdOEv3Jl+dx1TGfmq1Y312SyA1/JiCQl5\n PDs/jOZq/bQ/tQJ0mm8RiQ+CA7D5h2J9kmD4QA440aFrXDhWCGZUQcvMzGGX5znePjod\n G6tg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776452603; x=1777057403;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=0Wy7aEvsN/clgEXN9b33xr0KG5eaCEirucVfLQg6+E4=;\n b=faKHiAid3JWK36PUiyPq5Pqjjch/AHjEaPHHxPmYNyJFuhyy0eRoD6dr5Bn2wFT4GU\n mBi9O1D+odenT0YNwGlJqCiDl5fHDi4zWmRqNTEtKW7xzINK1ODKIqfM4JMhxEfhfpUo\n tIxHPLXAuiyTNe7UOWahCloCJtr5hGnbOWVCyAySlrdW4PLmMaC+1EYsiuVORNMU/vSZ\n PQXT4WYmyHWgNYvfHYlE2atGltFb6cgITVZddLjl0w6pFt2wWP6M74VhFe9kjv2tTOTV\n 62UukQy8YeZPvXzNvx2LjdVR/bfUTsZ/2dFLsOfVVWQLY3esRtgRbAjmyqbqytMZZM4p\n VeBw==","X-Gm-Message-State":"AOJu0YxM+6wRMjg41C4i767Xl6dsGA1nM1XYaOoBI1hXAdjcjxcXlnTz\n AUoWaXVh3Oj1sIuo/Hx5gPMtzLxZqciElYixSTHvb7Wscj7RdeuZkLZrlpMZlcRPDq+vl8Hj1Jy\n LrluwDRUJG5kKMHZjg8XJm/7vjwUhhrErFqaRBh1GKL/0+qX/0GZClQFVcazlkg8+dd2FQQ/A1C\n Pc3EKap/kkVphA5ImYIt8IogkdcafAxrGaqmg=","X-Gm-Gg":"AeBDies2ytvYfCUK7AvEENmCC20E3Ar7dLpSMRtifAxbpGqEf/D9vbyKDwmJ+D3U2Lu\n dKv6LgZDJ+85g3JmernYdxqx/sOJ0H9vcTrDwg5tnWHCMUbb9TGzvhO346BoCswDMHPx0KVrBU7\n izqbWXmyJx5xKMOC4GaWqDFLw/Y8850jI3KZNsicP7BWoi8BCEnpy3FIfU5FE0NIlW6soAdh79q\n PL9j3srOA2omTY=","X-Received":["by 2002:a05:7301:1007:b0:2c4:d01f:6ef7 with SMTP id\n 5a478bee46e88-2e47972308amr2167312eec.13.1776452602932;\n Fri, 17 Apr 2026 12:03:22 -0700 (PDT)","by 2002:a05:7301:1007:b0:2c4:d01f:6ef7 with SMTP id\n 5a478bee46e88-2e47972308amr2167282eec.13.1776452602307; Fri, 17 Apr 2026\n 12:03:22 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260417172506.1015169-2-torbjorn.svensson@foss.st.com>\n <20260417172834.1015281-2-torbjorn.svensson@foss.st.com>","In-Reply-To":"<20260417172834.1015281-2-torbjorn.svensson@foss.st.com>","From":"Andrew Pinski ","Date":"Fri, 17 Apr 2026 12:03:10 -0700","X-Gm-Features":"AQROBzB8sq8mEb-kD0t_F8wRJQkjqcWDN5AAlnGkYXfwN-7HKLp7l6ECrx7UhCc","Message-ID":"\n ","Subject":"Re: [PATCH 17/30] Change `class escape_summary` to `struct\n escape_summary` to align tags","To":"=?utf-8?q?Torbj=C3=B6rn_SVENSSON?= ","Cc":"gcc-patches@gcc.gnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Authority-Analysis":"v=2.4 cv=d6/FDxjE c=1 sm=1 tr=0 ts=69e283fd cx=c_pps\n a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10\n a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n a=Um2Pa8k9VHT-vaBCBUpS:22 a=8b9GpE9nAAAA:8 a=7JHi2Ta6WiMGHoLugPoA:9\n a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22 a=T3LWEMljR5ZiDmsYVIUa:22","X-Proofpoint-GUID":"tXw9xoI8jyIqKGTDpOdBMib-eWO8ANxI","X-Proofpoint-ORIG-GUID":"tXw9xoI8jyIqKGTDpOdBMib-eWO8ANxI","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE3MDE5MSBTYWx0ZWRfXxV87EciJqYoy\n jZezUoflaNyGHWuAKbwlkrpT/6RzVLHZhfUNOztPpbMcUOC9JO/rjKuOfjr0J9rJA+AQCNn/wUY\n tcIFIfleSQ5EkgkzqBnztd+fo3aWR1q4kmDlhx/IlX98T1WuTtjcJxc2bZiyBYh9f5nU7P5lClw\n WZQg0GksrbyZ4mlyXr8WF0A3GOyu4AjL86qqqDRBEbPENdohgrEdED3KIqNc8CqLdAk9UsdoAJ0\n W0gYozIlZ640aJHKXXBycgdIHNM6dwiL5fWY2aM2ayTYn02QFuNKWq7Dvj6wXO1gHzrmphG3X+v\n C+gjdJ7dhs+2KWsxLiF0s83Di9eVqYpytBE6cUyMxF9shX0oEyGa0h99Hi2HWaIaD98Rs0omKXg\n 6B0ACL3vXmCUclckgFvQWq9H7R3lxCU63R6UaCdcGaZSSsoJDb1p7N2dYgaUyRllLwFnIMP1Iss\n m8QetFl87Kj5/vURYTA==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-17_02,2026-04-17_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 malwarescore=0\n lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170191","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]